From: Marco Costalba <mcostalba@gmail.com>
Date: Fri, 6 Feb 2009 15:40:30 +0000 (+0100)
Subject: Simplify newly introduced castling_is_check()
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=1156eb865babe7b07443548aa5e81211205bc7b5

Simplify newly introduced castling_is_check()

Use bit_is_set() instead of open coding.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---

diff --git a/src/movegen.cpp b/src/movegen.cpp
index 9c405def..5917c9e4 100644
--- a/src/movegen.cpp
+++ b/src/movegen.cpp
@@ -945,11 +945,10 @@ namespace {
     File rookFile = (side == QUEEN_SIDE ? FILE_D : FILE_F);
     Color us = pos.side_to_move();
     Square ksq = pos.king_square(us);
-    Bitboard occ = pos.occupied_squares(), oppKingBB = EmptyBoardBB;
+    Bitboard occ = pos.occupied_squares();
 
-    set_bit(&oppKingBB, pos.king_square(opposite_color(us)));
     clear_bit(&occ, ksq); // Remove our king from the board
     Square rsq = make_square(rookFile, square_rank(ksq));
-    return (rook_attacks_bb(rsq, occ) & oppKingBB);
+    return bit_is_set(rook_attacks_bb(rsq, occ), pos.king_square(opposite_color(us)));
   }
 }