From: syzygy <syzygy@server.fake>
Date: Sun, 3 Sep 2017 20:02:49 +0000 (+0200)
Subject: Small simplication of see_ge()
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=741523eda8e0d1fb418d579c7cda9a73040b8914

Small simplication of see_ge()

Two simplifications:

- Remove the initialisation to 0 of occupied, which is now unnecessary.
- Remove the initial check for nextVictim == KING

If nextVictim == KING, then PieceValue[MG][nextVictim] will be 0, so that
balance >= threshold is true. So see_ge() returns true anyway.

No functional change.
---

diff --git a/src/position.cpp b/src/position.cpp
index bda83d7a..b6dc31b4 100644
--- a/src/position.cpp
+++ b/src/position.cpp
@@ -1004,21 +1004,17 @@ bool Position::see_ge(Move m, Value threshold) const {
   Bitboard occupied, stmAttackers;
 
   balance = PieceValue[MG][piece_on(to)];
-  occupied = 0;
 
   if (balance < threshold)
       return false;
 
-  if (nextVictim == KING)
-      return true;
-
   balance -= PieceValue[MG][nextVictim];
 
-  if (balance >= threshold)
+  if (balance >= threshold) // Always true if nextVictim == KING
       return true;
 
   bool relativeStm = true; // True if the opponent is to move
-  occupied ^= pieces() ^ from ^ to;
+  occupied = pieces() ^ from ^ to;
 
   // Find all attackers to the destination square, with the moving piece removed,
   // but possibly an X-ray attacker added behind it.