From: hxim <hxim.jo@gmail.com>
Date: Tue, 13 Jan 2015 21:07:18 +0000 (+0000)
Subject: Use VALUE_ZERO instead of 0 when comparing with Value
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=7b20bb6e1a98758e6afabe4e654761685c8dafa5

Use VALUE_ZERO instead of 0 when comparing with Value

This is the correct practice.

No functional change

Resolves #208
---

diff --git a/src/movepick.cpp b/src/movepick.cpp
index 7a7e13fc..edee8179 100644
--- a/src/movepick.cpp
+++ b/src/movepick.cpp
@@ -51,7 +51,7 @@ namespace {
 
   // Unary predicate used by std::partition to split positive values from remaining
   // ones so as to sort the two sets separately, with the second sort delayed.
-  inline bool has_positive_value(const ExtMove& move) { return move.value > 0; }
+  inline bool has_positive_value(const ExtMove& move) { return move.value > VALUE_ZERO; }
 
   // Picks the best move in the range (begin, end) and moves it to the front.
   // It's faster than sorting all the moves in advance when there are few
diff --git a/src/search.cpp b/src/search.cpp
index 1f77e0aa..092a4915 100644
--- a/src/search.cpp
+++ b/src/search.cpp
@@ -906,7 +906,7 @@ moves_loop: // When in check and at SpNode search starts from here
           ss->reduction = reduction<PvNode>(improving, depth, moveCount);
 
           if (   (!PvNode && cutNode)
-              ||  History[pos.piece_on(to_sq(move))][to_sq(move)] < 0)
+              ||  History[pos.piece_on(to_sq(move))][to_sq(move)] < VALUE_ZERO)
               ss->reduction += ONE_PLY;
 
           if (move == countermoves[0] || move == countermoves[1])
@@ -916,7 +916,7 @@ moves_loop: // When in check and at SpNode search starts from here
           if (   ss->reduction
               && type_of(move) == NORMAL
               && type_of(pos.piece_on(to_sq(move))) != PAWN
-              && pos.see(make_move(to_sq(move), from_sq(move))) < 0)
+              && pos.see(make_move(to_sq(move), from_sq(move))) < VALUE_ZERO)
               ss->reduction = std::max(DEPTH_ZERO, ss->reduction - ONE_PLY);
 
           Depth d = std::max(newDepth - ss->reduction, ONE_PLY);