From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 11 May 2013 09:32:34 +0000 (+0200)
Subject: Use Them instead of ~Us
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=818a3537a7fecf51f3d24d1c96d653ef29ad1d5a;hp=bcbc9bfd1f5efeaa3f1e0b020e405f11984e72ec

Use Them instead of ~Us

Unortunatly we have no guarantee that the call to
operator~(Color c) is resolved at compile time.

Perhaps the solution would be to use C++11 const_expr,
but for now simply use the good old-style ternary operator
that works as expected.

No functional change.
---

diff --git a/src/bitbase.cpp b/src/bitbase.cpp
index 425d0f14..b888d76c 100644
--- a/src/bitbase.cpp
+++ b/src/bitbase.cpp
@@ -148,12 +148,14 @@ namespace {
     // as WIN, the position is classified WIN otherwise the current position is
     // classified UNKNOWN.
 
+    const Color Them = (Us == WHITE ? BLACK : WHITE);
+
     Result r = INVALID;
     Bitboard b = StepAttacksBB[KING][Us == WHITE ? wksq : bksq];
 
     while (b)
-        r |= Us == WHITE ? db[index(~Us, bksq, pop_lsb(&b), psq)]
-                         : db[index(~Us, pop_lsb(&b), wksq, psq)];
+        r |= Us == WHITE ? db[index(Them, bksq, pop_lsb(&b), psq)]
+                         : db[index(Them, pop_lsb(&b), wksq, psq)];
 
     if (Us == WHITE && rank_of(psq) < RANK_7)
     {