From: cj5716 <125858804+cj5716@users.noreply.github.com>
Date: Sat, 2 Dec 2023 10:37:52 +0000 (+0100)
Subject: Simplify promotion move generation
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=883163395ed464d17c6732e227a2d2c3c0b26f1e

Simplify promotion move generation

closes https://github.com/official-stockfish/Stockfish/pull/4892

No functional change
---

diff --git a/src/movegen.cpp b/src/movegen.cpp
index 16da659d..7d6856bb 100644
--- a/src/movegen.cpp
+++ b/src/movegen.cpp
@@ -31,18 +31,12 @@ namespace {
 template<GenType Type, Direction D, bool Enemy>
 ExtMove* make_promotions(ExtMove* moveList, [[maybe_unused]] Square to) {
 
-    if constexpr (Type == CAPTURES || Type == EVASIONS || Type == NON_EVASIONS)
-    {
+    constexpr bool all = Type == EVASIONS || Type == NON_EVASIONS;
+
+    if constexpr (Type == CAPTURES || all)
         *moveList++ = make<PROMOTION>(to - D, to, QUEEN);
-        if constexpr (Enemy && Type == CAPTURES)
-        {
-            *moveList++ = make<PROMOTION>(to - D, to, ROOK);
-            *moveList++ = make<PROMOTION>(to - D, to, BISHOP);
-            *moveList++ = make<PROMOTION>(to - D, to, KNIGHT);
-        }
-    }
 
-    if constexpr ((Type == QUIETS && !Enemy) || Type == EVASIONS || Type == NON_EVASIONS)
+    if constexpr ((Type == CAPTURES && Enemy) || (Type == QUIETS && !Enemy) || all)
     {
         *moveList++ = make<PROMOTION>(to - D, to, ROOK);
         *moveList++ = make<PROMOTION>(to - D, to, BISHOP);