From: Alain SAVARD <support@multicim.com>
Date: Sun, 27 Oct 2019 20:16:26 +0000 (-0400)
Subject: Sequencing tweak in tbprobe()
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=9b8b259388f15d9f669cfc526a2bb7c5a5b1ee71;hp=5ae195ee7e3ccac01b8145f9b7022e352a288f07;ds=sidebyside

Sequencing tweak in tbprobe()

Followup of "issue" #2372, which was in fact a small speed-up
proposal by user @d3vv for the probing code of tablebases.

See comments on this issue where it was proven by Alin Savard that the
proposed change is more efficient on average than master on all type of
sequences it will usually be called.

Note that on gcc 4.3, this will produce a bogus warning which was solved
with ulterior gcc versions: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949

Closes https://github.com/official-stockfish/Stockfish/issues/2372
Closes https://github.com/official-stockfish/Stockfish/pull/2379

Non functional change
---

diff --git a/src/syzygy/tbprobe.cpp b/src/syzygy/tbprobe.cpp
index a9378b4b..c0453492 100644
--- a/src/syzygy/tbprobe.cpp
+++ b/src/syzygy/tbprobe.cpp
@@ -730,8 +730,8 @@ Ret do_probe_table(const Position& pos, T* entry, WDLScore wdl, ProbeState* resu
 
     // Then we reorder the pieces to have the same sequence as the one stored
     // in pieces[i]: the sequence that ensures the best compression.
-    for (int i = leadPawnsCnt; i < size; ++i)
-        for (int j = i; j < size; ++j)
+    for (int i = leadPawnsCnt; i < size - 1; ++i)
+        for (int j = i + 1; j < size; ++j)
             if (d->pieces[i] == pieces[j])
             {
                 std::swap(pieces[i], pieces[j]);