From: Marco Costalba <mcostalba@gmail.com>
Date: Sun, 9 Jan 2011 13:45:49 +0000 (+0100)
Subject: Simplify set_option()
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=a8741bd59fb928f7107ecc4717105070ff0ef311

Simplify set_option()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---

diff --git a/src/uci.cpp b/src/uci.cpp
index c6d090d2..826ecd12 100644
--- a/src/uci.cpp
+++ b/src/uci.cpp
@@ -142,21 +142,21 @@ namespace {
 
     string fen, token;
 
-    if (!(up >> token) || (token != "startpos" && token != "fen"))
-        return;
+    up >> token; // operator>>() skips any whitespace
 
     if (token == "startpos")
     {
         pos.from_fen(StartPositionFEN, false);
         up >> token; // Consume "moves" token
     }
-    else // fen
+    else if (token == "fen")
     {
         while (up >> token && token != "moves")
-            fen += token + string(" ");
+            fen += token + " ";
 
         pos.from_fen(fen, Options["UCI_Chess960"].value<bool>());
     }
+    else return;
 
     // Parse move list (if any)
     while (up >> token)
@@ -172,39 +172,26 @@ namespace {
 
   void set_option(UCIParser& up) {
 
-    string token, name, value;
-
-    if (!(up >> token) || token != "name") // operator>>() skips any whitespace
-        return;
+    string value = "true"; // UCI buttons don't have a "value" field
+    string token, name;
 
-    if (!(up >> name))
-        return;
+    up >> token; // Consume "name" token
+    up >> name;  // Read option name
 
     // Handle names with included spaces
     while (up >> token && token != "value")
-        name += (" " + token);
+        name += " " + token;
 
-    if (Options.find(name) == Options.end())
-    {
-        cout << "No such option: " << name << endl;
-        return;
-    }
-
-    // Is a button ?
-    if (token != "value")
-    {
-        Options[name].set_value("true");
-        return;
-    }
-
-    if (!(up >> value))
-        return;
+    up >> value; // Read option value
 
     // Handle values with included spaces
     while (up >> token)
-        value += (" " + token);
+        value += " " + token;
 
-    Options[name].set_value(value);
+    if (Options.find(name) != Options.end())
+        Options[name].set_value(value);
+    else
+        cout << "No such option: " << name << endl;
   }
 
 
diff --git a/src/ucioption.cpp b/src/ucioption.cpp
index c7883d4c..cd59c931 100644
--- a/src/ucioption.cpp
+++ b/src/ucioption.cpp
@@ -163,8 +163,11 @@ void Option::set_value(const string& value) {
 
   assert(!type.empty());
 
-  if (    (type == "check" || type == "button")
-      && !(value == "true" || value == "false"))
+  if (value.empty())
+      return;
+
+  if (   (type == "check" || type == "button")
+      != (value == "true" || value == "false"))
       return;
 
   if (type == "spin")