From: Matthew Sullivan Date: Fri, 25 Oct 2013 16:22:43 +0000 (-0500) Subject: Fix divide by zero bug in late game X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=d454cd42166d71789e8c5a4d099a0c3d96ab517e Fix divide by zero bug in late game If the game got late enough that move_importance(currentPly) * slowMover / 100 rounds to 0, then we ended up dividing 0 by 0 when only looking 1 move ahead. This apparently caused the search to almost immediately abort and Stockfish would blunder in long games. So convert thisMoveImportance to a double. No functional change. --- diff --git a/src/timeman.cpp b/src/timeman.cpp index 28505e4e..146818e6 100644 --- a/src/timeman.cpp +++ b/src/timeman.cpp @@ -147,14 +147,14 @@ namespace { const double TMaxRatio = (T == OptimumTime ? 1 : MaxRatio); const double TStealRatio = (T == OptimumTime ? 0 : StealRatio); - int thisMoveImportance = move_importance(currentPly) * slowMover / 100; + double thisMoveImportance = double(move_importance(currentPly) * slowMover) / 100; int otherMovesImportance = 0; for (int i = 1; i < movesToGo; ++i) otherMovesImportance += move_importance(currentPly + 2 * i); - double ratio1 = (TMaxRatio * thisMoveImportance) / double(TMaxRatio * thisMoveImportance + otherMovesImportance); - double ratio2 = (thisMoveImportance + TStealRatio * otherMovesImportance) / double(thisMoveImportance + otherMovesImportance); + double ratio1 = (TMaxRatio * thisMoveImportance) / (TMaxRatio * thisMoveImportance + otherMovesImportance); + double ratio2 = (thisMoveImportance + TStealRatio * otherMovesImportance) / (thisMoveImportance + otherMovesImportance); return int(floor(myTime * std::min(ratio1, ratio2))); }