From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 17 Mar 2012 09:29:33 +0000 (+0100)
Subject: Fix UCI 'button' options
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=ee838f56f7492f3a00927657e8dc3402c752cbd3;hp=ee838f56f7492f3a00927657e8dc3402c752cbd3

Fix UCI 'button' options

When a button fires UCIOption::operator=() is called and from
there the on_change() function. Now it happens that in case of
a button the on_change() function resets option's value to
"false" triggering again UCIOption::operator=() that calls again
on_change() and so on in an endless loop that is experienced
by the user as an application hang.

Rework the button logic to fix the issue and also be more clear
about how button works.

Reported by several people working with Scid and tracked down
to the "Clear Hash" UCI button by Steven Atkinson.

Bug recently introduced by 2ef5b4066e649.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---