stockfish
10 years agoTempletize xxx_time_for_MTG()
Marco Costalba [Mon, 2 Aug 2010 10:14:27 +0000 (12:14 +0200)]
Templetize xxx_time_for_MTG()

Also fixed some warnings under MSVC.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoLittle timeman.cpp massage
Marco Costalba [Mon, 2 Aug 2010 09:34:19 +0000 (11:34 +0200)]
Little timeman.cpp massage

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTweak default values for ucioptions
Joona Kiiski [Mon, 26 Jul 2010 13:39:10 +0000 (16:39 +0300)]
Tweak default values for ucioptions

I created three different systems, tested them all separately and
attached one did best:

1/40: Orig - Mod: 841 - 850 (+2 elo)
1+1 : Orig - Mod: 474 - 498 (+9 elo)
1+0 : Orig - Mod: 455 - 495 (+15 elo)

Because such testing system is not statistically reliable, I made a
confirmation test:

1/40: Orig - Mod: 502 - 543 (+14 elo)
1+1: Orig - Mod: 447 - 489 (+16 elo)
1+0: Orig - Mod: 641 - 656 (+4 elo)

All tests show positive score :-)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoNew Time management system
Joona Kiiski [Sun, 11 Jul 2010 16:23:50 +0000 (19:23 +0300)]
New Time management system

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAlways use ss->bestMove to store ply best move
Marco Costalba [Sat, 31 Jul 2010 06:29:29 +0000 (07:29 +0100)]
Always use ss->bestMove to store ply best move

Instead of ss->currentMove. It is more consistent and
clear to understand.

Remark by Ralph Stoesser.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoLower SingularExtensionDepth to 7 plies for non-pv
Marco Costalba [Wed, 28 Jul 2010 07:39:28 +0000 (09:39 +0200)]
Lower SingularExtensionDepth to 7 plies for non-pv

To compensate for the extra work skip singular
searches deemed to fail because excluded node
failed high already in the past.

After 1200 games at 1+0
Mod vs Orig +387 =1274 -339  (+8 ELO)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTwo small fixes in passed pawns evaluation
Marco Costalba [Mon, 26 Jul 2010 05:07:34 +0000 (06:07 +0100)]
Two small fixes in passed pawns evaluation

The one in evaluate_passed_pawns() is just a micro
optimization, the other in evaluate_unstoppable_pawns()
is indeed a fix, although almost unmeasurable in real
games.

Bugs report and fixes by Marek Kwiatkowski

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix KBNK endgame
Marco Costalba [Sun, 25 Jul 2010 20:47:54 +0000 (21:47 +0100)]
Fix KBNK endgame

Broken by recent patch. Also better document what's
happening there.

Verified to restore original behaviour.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRename EMPTY in NO_PIECE
Marco Costalba [Sun, 25 Jul 2010 11:10:22 +0000 (12:10 +0100)]
Rename EMPTY in NO_PIECE

It is more correct and more in line with enum PieceType

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoIntroduce enum SquareColor
Marco Costalba [Sun, 25 Jul 2010 10:44:03 +0000 (11:44 +0100)]
Introduce enum SquareColor

Square and piece colors are two different things,
so use different types to avoid misunderstandings.

Suggested by Tord.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoIntroduce and use same_color_squares()
Marco Costalba [Sun, 25 Jul 2010 10:05:01 +0000 (11:05 +0100)]
Introduce and use same_color_squares()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoCleanup Position::print()
Marco Costalba [Sun, 25 Jul 2010 08:52:06 +0000 (09:52 +0100)]
Cleanup Position::print()

And remove not used OUTSIDE enum Piece.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix build failure on GCC
Joona Kiiski [Sun, 25 Jul 2010 06:52:11 +0000 (09:52 +0300)]
Fix build failure on GCC

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoCleanup Position::to_fen()
Marco Costalba [Sat, 24 Jul 2010 16:59:18 +0000 (17:59 +0100)]
Cleanup Position::to_fen()

Less invasive then previous patches, but still a good
enhancement.

Also some indulge on STL algorithms :-)

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoLast touches to from_fen()
Marco Costalba [Sat, 24 Jul 2010 15:19:46 +0000 (16:19 +0100)]
Last touches to from_fen()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRewrite Position::from_fen()
Marco Costalba [Fri, 23 Jul 2010 08:38:19 +0000 (10:38 +0200)]
Rewrite Position::from_fen()

Complete rewrite the function and extend compatibility
also to X-FEN notation for Chess960.

We are now able to read standard FEN, Shredder-FEN and X-FEN.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoDon't initialize psqt-tables when 'ucinewgame' is received
Joona Kiiski [Fri, 23 Jul 2010 06:16:33 +0000 (09:16 +0300)]
Don't initialize psqt-tables when 'ucinewgame' is received

After 'Randomness' is retired, this is no longer necessary.

NOTE: Possibly some extra care is needed when tuning branch is synced

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire 'Randomness' ucioption
Joona Kiiski [Fri, 23 Jul 2010 06:08:31 +0000 (09:08 +0300)]
Retire 'Randomness' ucioption

Using multiple threads and good opening book is
much better and more reliable source of randomness than
spoiling psqt-tables

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAlways init pthread locks to NULL
Joona Kiiski [Fri, 23 Jul 2010 05:45:42 +0000 (08:45 +0300)]
Always init pthread locks to NULL

This is the only way to keep Windows and POSIX behaviour in sync,
so better hardcode it.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove other locking options
Joona Kiiski [Fri, 23 Jul 2010 05:26:54 +0000 (08:26 +0300)]
Remove other locking options

Currently broken and we use pthreads in search.cpp
anyway, so I see no reason to keep these around

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire SearchStack init() and initKillers()
Marco Costalba [Fri, 23 Jul 2010 01:42:27 +0000 (02:42 +0100)]
Retire SearchStack init() and initKillers()

Let be explicit about what this functions do, and
we save some code lines too.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix errouneus reset of ss->threatMove
Marco Costalba [Fri, 23 Jul 2010 01:26:10 +0000 (02:26 +0100)]
Fix errouneus reset of ss->threatMove

After we set ss->threatMove we could go under a IID step that
resets SearchStack ss and so also ss->threatMove.

When later we use that field in futility pruning we have this
set to MOVE_NONE !

The fix is to use a local variable and add threatMove to SplitPoint
to pass this move to slaves.

Spotted by Ralph Stoesser, fix suggested by Richard Vida.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRevert previous patch
Marco Costalba [Thu, 22 Jul 2010 17:29:36 +0000 (18:29 +0100)]
Revert previous patch

Improvement is easily in error bar and there is
some added complexity making future changes more
difficult.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoWeight backward-ness of a pawn
Marco Costalba [Mon, 19 Jul 2010 06:56:14 +0000 (08:56 +0200)]
Weight backward-ness of a pawn

Because not all backward pawns are the same ;-) if the
blocking enemy pawn is near then our pawn is more backward
than another whose enemy pawn is far away so that can advance
for some sqaures.

After 2925 games at 30"+0 on my QUAD
Mod vs Orig +602 =1745 -578 +3 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoValueType needs only 2 bits to be stored in TT
Joona Kiiski [Thu, 22 Jul 2010 13:11:08 +0000 (16:11 +0300)]
ValueType needs only 2 bits to be stored in TT

Also update some more TT documentation

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoUpdate TT documentation
Joona Kiiski [Thu, 22 Jul 2010 12:52:22 +0000 (15:52 +0300)]
Update TT documentation

Update outdated and even misleading documentation.

Also check #include-directives

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMove insert_pv() and extract_pv() out of TT class
Marco Costalba [Wed, 21 Jul 2010 06:31:11 +0000 (08:31 +0200)]
Move insert_pv() and extract_pv() out of TT class

These functions have little to do with TranspositionTable
class and more with the search and in particular with the PV
handling. So move them where they belong.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoStore position static score in TT as soon as possible
Marco Costalba [Tue, 20 Jul 2010 21:36:38 +0000 (22:36 +0100)]
Store position static score in TT as soon as possible

So to maximize the possibility to avoid to recalculate it
in the future. A small speed-up of 0.8%

Idea by Ralph Stoesser.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoIntroduce DEPTH_NONE and use it
Marco Costalba [Tue, 20 Jul 2010 07:16:16 +0000 (09:16 +0200)]
Introduce DEPTH_NONE and use it

Also better fix previous patch.

Suggestions by Joona and Ralph.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove pointless tte->static_value() != VALUE_NONE checks
Joona Kiiski [Mon, 19 Jul 2010 15:48:16 +0000 (18:48 +0300)]
Remove pointless tte->static_value() != VALUE_NONE checks

Now in non-check nodes we are guaranteed to always have static value
in TT Entry.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoStore static value and king danger in TT also in TT.insert_pv() method
Joona Kiiski [Sun, 18 Jul 2010 21:19:09 +0000 (00:19 +0300)]
Store static value and king danger in TT also in TT.insert_pv() method

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix "pass ss->eval to qsearch()" condition
Marco Costalba [Mon, 19 Jul 2010 11:28:33 +0000 (12:28 +0100)]
Fix "pass ss->eval to qsearch()" condition

The seocond check is no more needed now and
anyhow is wrong to overwrite a TT entry if
present.

Spotted by Ralph Stoesser.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTriviality in material.cpp
Marco Costalba [Mon, 19 Jul 2010 07:08:28 +0000 (09:08 +0200)]
Triviality in material.cpp

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoSmall rewrite of backward pawn test
Marco Costalba [Mon, 19 Jul 2010 06:13:50 +0000 (07:13 +0100)]
Small rewrite of backward pawn test

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoInitialize SearchStack only once at RootMoveList c'tor
Joona Kiiski [Sun, 18 Jul 2010 21:01:58 +0000 (00:01 +0300)]
Initialize SearchStack only once at RootMoveList c'tor

Just fix current ugly behaviour :-)

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoEvery node is responsible for initializing its own SearchStack entry
Joona Kiiski [Sun, 18 Jul 2010 20:54:40 +0000 (23:54 +0300)]
Every node is responsible for initializing its own SearchStack entry

More logical than doing partly initialization at init_ss_array()

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoDrop KILLER_MAX. Hardcode to 2 instead.
Joona Kiiski [Sun, 18 Jul 2010 20:52:03 +0000 (23:52 +0300)]
Drop KILLER_MAX. Hardcode to 2 instead.

KILLER_MAX in search.h is quite pointless, because
we already hardcode this to 2 in MovePicker anyway.

By hard-coding this to 2 we can keep code simpler.

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoDo not initialize ss->reduction to zero in the beginning of node
Joona Kiiski [Sun, 18 Jul 2010 20:35:57 +0000 (23:35 +0300)]
Do not initialize ss->reduction to zero in the beginning of node

It must already be zero because zeroed in SearchStack initialization

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoDo not reset ss->eval in the beginning of the node
Joona Kiiski [Sun, 18 Jul 2010 13:24:07 +0000 (16:24 +0300)]
Do not reset ss->eval in the beginning of the node

This avoids problems with IID clearing ss->eval and
eval not being available when we return

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix isolated and backward pawns scoring
Marco Costalba [Sat, 17 Jul 2010 16:32:54 +0000 (17:32 +0100)]
Fix isolated and backward pawns scoring

It is more clear and also more correct because we
consider enemy pawns only in fornt of us and not just
on our file.

Very small functional change, almost not measurable, but
keep the patch for documenting purposes.

Spotted by Marek Kwiatkowski.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTriviality in endgame.cpp
Marco Costalba [Sat, 17 Jul 2010 13:00:25 +0000 (14:00 +0100)]
Triviality in endgame.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoUpdate Makefile
Joona Kiiski [Fri, 16 Jul 2010 06:12:46 +0000 (09:12 +0300)]
Update Makefile

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFind balance between 1.7 and 1.8 reductions
Joona Kiiski [Sat, 3 Jul 2010 05:14:31 +0000 (08:14 +0300)]
Find balance between 1.7 and 1.8 reductions

Almost no change so commit because is a pruning
reduction patch.

After 1088 games at 1'+0 with QUAD
Mod vs Orig +178 =727 -183  (-2 ELO)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove redundant argument in think()
Marco Costalba [Thu, 15 Jul 2010 15:05:56 +0000 (17:05 +0200)]
Remove redundant argument in think()

We don't need to pass side_to_move because we can get
it directly from the position object.

Note that in benchmark we always used to pass '0' and
it was a bug, but with no effect because was used only
in time[] and increment[], set always to 0 for both
colors.

Also additional small cleanup while there.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire apply_scale_factor() and scale.h
Marco Costalba [Thu, 15 Jul 2010 13:45:27 +0000 (15:45 +0200)]
Retire apply_scale_factor() and scale.h

Directly inline in the only occurence.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoInline history and gain getters
Marco Costalba [Thu, 15 Jul 2010 13:31:12 +0000 (15:31 +0200)]
Inline history and gain getters

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire value.cpp
Marco Costalba [Thu, 15 Jul 2010 09:00:20 +0000 (11:00 +0200)]
Retire value.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire LSN machinery
Marco Costalba [Wed, 14 Jul 2010 12:21:28 +0000 (14:21 +0200)]
Retire LSN machinery

Now that we use cutechess-cli we can set the auto-resign
parameter that makes LSN less effective.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTriviality in ucioption.cpp
Marco Costalba [Wed, 14 Jul 2010 13:12:09 +0000 (15:12 +0200)]
Triviality in ucioption.cpp

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAdd moves from failed high nodes in PV
Marco Costalba [Sat, 10 Jul 2010 10:55:56 +0000 (11:55 +0100)]
Add moves from failed high nodes in PV

Considering only VALUE_TYPE_EXACT nodes is too
restrictive and has a number of side-effects, most
notably the truncation of PV line after a fail high
at root.

Note that in this way we are no more guaranteed that
PV line is built up with PV nodes only, because
it could happen that a side search overwrites with a
cut-off move a PV node and this cut-off move ends up
in PV.

Change should be almost not measurable, perhaps with
ponder on we could have some beneficial effect.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix (zugzwang) verification to be shallower then null search
Marco Costalba [Sun, 11 Jul 2010 06:52:05 +0000 (07:52 +0100)]
Fix (zugzwang) verification to be shallower then null search

Currently starting from depth 12*OnePly on we have a verification
search deeper then the null search.

Note that, although reduction is R we start from one ply less then
null search, so actually we reach a depth that is OnePly shallower
then null search.

After 1130 games at 1'+0 on QUAD
Mod vs Orig +202 =756 -172  +9 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove TranspositionTable::overwrites variable
Joona Kiiski [Sun, 11 Jul 2010 17:22:30 +0000 (20:22 +0300)]
Remove TranspositionTable::overwrites variable

Doesn't provide useful information and
can cause slowdown with many Threads.

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoSpace inflate bitbase.cpp
Marco Costalba [Sun, 11 Jul 2010 09:47:04 +0000 (10:47 +0100)]
Space inflate bitbase.cpp

Also heavy cleanup while there.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoThere is no need to clear TT at allocation time
Marco Costalba [Sun, 11 Jul 2010 08:42:04 +0000 (09:42 +0100)]
There is no need to clear TT at allocation time

Operator new() already returns a zeroed memory.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRevert previous patch
Marco Costalba [Sat, 10 Jul 2010 15:38:54 +0000 (16:38 +0100)]
Revert previous patch

After the previous patch, it's impossible to build
anything else than x86 32-bit binary!

So revert.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMakefile: default on gcc 32 bits when type 'make'
Marco Costalba [Sat, 10 Jul 2010 11:15:13 +0000 (12:15 +0100)]
Makefile: default on gcc 32 bits when type 'make'

From Vratko Polak

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoReword singular extension comments
Marco Costalba [Tue, 6 Jul 2010 08:08:35 +0000 (10:08 +0200)]
Reword singular extension comments

Should be more stick to original definition (Hsu, Campbell)

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTweak Makefile a bit
Joona Kiiski [Mon, 5 Jul 2010 04:56:24 +0000 (07:56 +0300)]
Tweak Makefile a bit

To fix some build problems on debian's
automatic building system.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMove SplitPoint array under its thread
Marco Costalba [Mon, 5 Jul 2010 12:22:53 +0000 (14:22 +0200)]
Move SplitPoint array under its thread

And cleanup / rename that part of code.

No functional change also with faked split.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTweak non-captures scoring
Marco Costalba [Sat, 3 Jul 2010 05:02:06 +0000 (06:02 +0100)]
Tweak non-captures scoring

Tested with Orig set at f5ef5632f so to evaluate
direct gain against 1.8

After 3239 games at 10"+0.1
Mod vs Orig +701 =1906 -632 +7 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix TT documentation
Joona Kiiski [Sun, 4 Jul 2010 19:09:40 +0000 (22:09 +0300)]
Fix TT documentation

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoReintroduce GCC/ICC rounding hack
Marco Costalba [Sat, 3 Jul 2010 18:04:05 +0000 (19:04 +0100)]
Reintroduce GCC/ICC rounding hack

Unfortunatly the source of this issue is not in the
different handling of log(0) illegal value.

No functional change on MSVC.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix Makefile for HPUX
Joona Kiiski [Sat, 3 Jul 2010 16:28:51 +0000 (19:28 +0300)]
Fix Makefile for HPUX

On hpux there is no prefetch.

Reported by Richard Lloyd

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix DIVIDE BY ZERO exception in init_search()
Marco Costalba [Sat, 3 Jul 2010 15:02:07 +0000 (16:02 +0100)]
Fix DIVIDE BY ZERO exception in init_search()

It happens that when d == 0 we calculate:

log(double(0 * 0) / 2)

Unfortunately, log(0) is "illegal" and can generate either a
floating point exception or return a nonsense "huge" value
depending on the platform.

This fixs in the proper way the GCC/ICC rounding difference,
bug was from our side, not in the intel compiler.

Also fixed some few other warnings.

Bug spotted by Richard Lloyd.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoPSQT access functions can be static
Marco Costalba [Sat, 3 Jul 2010 04:48:43 +0000 (05:48 +0100)]
PSQT access functions can be static

Also renamed history access value in something more
in line with the meaning.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoUse only history to score non-captures
Marco Costalba [Fri, 25 Jun 2010 21:55:52 +0000 (22:55 +0100)]
Use only history to score non-captures

It seems there is absolutely no difference in using gains.

After 7025 games at 5"+0
Mod vs Orig +1903 =3236 -1886 (+1 ELO)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRestore development version
Marco Costalba [Sat, 3 Jul 2010 04:34:57 +0000 (05:34 +0100)]
Restore development version

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRevert "Another PSQT tuning round"
Marco Costalba [Fri, 2 Jul 2010 05:53:04 +0000 (06:53 +0100)]
Revert "Another PSQT tuning round"

At longer TC of 1'+0" patch fails:
Orig - Mod: 841 - 819 (-6 elo!)

Just before the release ;-)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoStockfish 1.8
Marco Costalba [Fri, 2 Jul 2010 05:23:15 +0000 (06:23 +0100)]
Stockfish 1.8

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMark CheckInfo c'tor as explicit
Marco Costalba [Thu, 1 Jul 2010 21:21:09 +0000 (22:21 +0100)]
Mark CheckInfo c'tor as explicit

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMove singleEvasion assignment out of move's loop
Marco Costalba [Thu, 1 Jul 2010 21:18:53 +0000 (22:18 +0100)]
Move singleEvasion assignment out of move's loop

We don't need to recheck after every move.

Spotted by Ralph Stoesser.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAnother PSQT tuning round
Joona Kiiski [Wed, 17 Mar 2010 06:32:26 +0000 (08:32 +0200)]
Another PSQT tuning round

This time with a new algorithm by Joona.

It works basically like this:

repeat
{
   1) pick 8000 random positions from qsearch
   2) "go depth 8" to get the true evaluation.
   3) "eval" to get the stand pat score
   4) Adjusting parameters one by one to minimize deltasum between
true evaluation and stand  pat scores.
}

* Good news: method seems to converge
* Bad news: Point where it converges is not optimum.

So it's more or less trial and error... sometimes works, sometimes
doesn't. It can give you the right direction, but if you let it run
too long, it fails. Far from scientific ;)

After 14800 games with 5s/game
Orig - Mod: 3318 - 3570 - 7626 (+6 elo)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove a redundant check in passed pawn eval
Marco Costalba [Tue, 29 Jun 2010 11:05:19 +0000 (13:05 +0200)]
Remove a redundant check in passed pawn eval

When first condition is met then second one is
always true.

Spotted by Ralph Stoesser.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoCode style triviality in san.cpp
Marco Costalba [Tue, 29 Jun 2010 10:14:44 +0000 (12:14 +0200)]
Code style triviality in san.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRename TranspositionTable 'writes' in 'overwrites'
Marco Costalba [Mon, 28 Jun 2010 07:20:34 +0000 (08:20 +0100)]
Rename TranspositionTable 'writes' in 'overwrites'

Better documents what that variable means.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoExtract only exact scores to get the PV
Marco Costalba [Sun, 27 Jun 2010 14:13:22 +0000 (15:13 +0100)]
Extract only exact scores to get the PV

This should allow to skip overwritten nodes because
only in PV we store in TT with VALUE_TYPE_EXACT flag.

Test result for the whole series is:

After 3627 games at 5"
Mod vs Orig +1037 =1605 -985 +5 ELO

After 1311 games at 1'+0"
Mod vs Orig +234 =850 -227 +2 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire update_pv() and sp_update_pv()
Marco Costalba [Sat, 26 Jun 2010 14:22:13 +0000 (15:22 +0100)]
Retire update_pv() and sp_update_pv()

Expand inline instead.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRetire pv[] from SearchStack
Marco Costalba [Sat, 26 Jun 2010 14:05:38 +0000 (15:05 +0100)]
Retire pv[] from SearchStack

Extract PV info from TT instead of using
a set of arrays. This is almost equivalent
except for cases when TT is full and the PV entry
is overwritten, but this is very rare.

(Almost) No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoIntroduce bestMove to store PV move
Marco Costalba [Sat, 26 Jun 2010 13:42:44 +0000 (14:42 +0100)]
Introduce bestMove to store PV move

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoCleanup code that stores score in TT
Marco Costalba [Sat, 26 Jun 2010 09:43:59 +0000 (10:43 +0100)]
Cleanup code that stores score in TT

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoFix some wrong documentation
Joona Kiiski [Sat, 26 Jun 2010 08:12:32 +0000 (11:12 +0300)]
Fix some wrong documentation

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove unused constant
Joona Kiiski [Sat, 26 Jun 2010 08:09:06 +0000 (11:09 +0300)]
Remove unused constant

Fixes warning on ICC

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoStockfish 1.8 beta 2
Marco Costalba [Fri, 25 Jun 2010 17:56:42 +0000 (18:56 +0100)]
Stockfish 1.8 beta 2

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoHack to fix GCC/ICC rounding difference
Joona Kiiski [Fri, 25 Jun 2010 17:49:36 +0000 (20:49 +0300)]
Hack to fix GCC/ICC rounding difference

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoStockfish 1.8 beta 1
Marco Costalba [Thu, 24 Jun 2010 16:56:45 +0000 (17:56 +0100)]
Stockfish 1.8 beta 1

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRevert "Do IID also when we already have a ttMove"
Marco Costalba [Thu, 24 Jun 2010 17:00:03 +0000 (18:00 +0100)]
Revert "Do IID also when we already have a ttMove"

Joona's testing reports very bad results at 5s, 30s and
even 1 minute TC, so revert.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoCall apply_weight() for both colors in one go
Marco Costalba [Sat, 5 Jun 2010 17:05:29 +0000 (18:05 +0100)]
Call apply_weight() for both colors in one go

Due to rounding errors in apply_weight() where we divide
by 0x100 it is not possible to keep some functionality.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoTweak unstoppable pawns detection
Marco Costalba [Sun, 13 Jun 2010 10:05:04 +0000 (11:05 +0100)]
Tweak unstoppable pawns detection

A pawn is unstoppable also if enemy king can reach it
but path to queening is protected.

Original idea by Ralph Stoesser fixed by me.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMerge branch 'master' of free2.projectlocker.com:sf
Marco Costalba [Mon, 21 Jun 2010 19:50:20 +0000 (20:50 +0100)]
Merge branch 'master' of free2.projectlocker.com:sf

10 years agoMoved a misplaced #endif in misc.cpp, which broke compilation in
Tord Romstad [Mon, 21 Jun 2010 09:25:06 +0000 (11:25 +0200)]
Moved a misplaced #endif in misc.cpp, which broke compilation in
Mac OS X.

No functional change.

10 years agoTest killer for legality earlier
Marco Costalba [Sat, 19 Jun 2010 15:48:36 +0000 (16:48 +0100)]
Test killer for legality earlier

Many killers moves, around 40%, are not legal, so
skip earlier in this case.

Some Movepicker c'tor cleanup while there.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoOptimize for king moves in see_sign()
Marco Costalba [Sat, 19 Jun 2010 14:44:03 +0000 (15:44 +0100)]
Optimize for king moves in see_sign()

Because we only test legal moves, a king move
cannot have negative SEE.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoMove prefetch() out of TT
Marco Costalba [Sat, 19 Jun 2010 10:10:54 +0000 (11:10 +0100)]
Move prefetch() out of TT

This code is platform specific and has nothing to
do with TT class, so move to misc.cpp

This patch is a prerequisite to use extend prefetch use
also to other hash tables apart from Transposition Table.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoExtend checks only if SEE is non-negative
Marco Costalba [Sat, 12 Jun 2010 13:47:30 +0000 (14:47 +0100)]
Extend checks only if SEE is non-negative

Idea from Dr. Hyatt

After 10k games at 5"+0 on my QUAD
Mod vs Orig +2750 =4601 -2649 +4 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRevert "Use ply counter in Position object"
Marco Costalba [Sun, 13 Jun 2010 01:26:43 +0000 (02:26 +0100)]
Revert "Use ply counter in Position object"

Search ply and game ply are rwo different things !

Revert bogus commit.

No functional change on bench, but it changes in real games
when engine sends all the moves up to current one.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoSet LSNTime to 100 ms
Marco Costalba [Sat, 12 Jun 2010 09:29:50 +0000 (10:29 +0100)]
Set LSNTime to 100 ms

This is a timeout compatible with very short TC of 5 sec/game.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoRemove a wrong FIXME
Marco Costalba [Sat, 5 Jun 2010 17:04:58 +0000 (18:04 +0100)]
Remove a wrong FIXME

If we are there it means we already had that info stored in TT,
so we don't need to overwrite with the same content !

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAvoid a double copy when saving a TTEntry
Marco Costalba [Sat, 5 Jun 2010 09:50:24 +0000 (11:50 +0200)]
Avoid a double copy when saving a TTEntry

In statement:

*tte = TTEntry(posKey32, v, t, d, m, generation, statV, kingD);

We first create a TTEntry, then we copy the temporary entry to
its final destination in *tte then we discard the TTEntry.

Instead of this assign the fields directly to the destination TTEntry.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoAvoid calling evaluate() while razoring
Marco Costalba [Sat, 5 Jun 2010 07:40:47 +0000 (09:40 +0200)]
Avoid calling evaluate() while razoring

Micro optimization that gives a 0.5% speed improvment

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
10 years agoOffset pv[] always from 0
Marco Costalba [Fri, 4 Jun 2010 07:46:38 +0000 (09:46 +0200)]
Offset pv[] always from 0

We don't need to offset from current ply.

Also rewritten a bit update_pv()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>