From 27efc5ac996ffc679395317c8bbb16aca996296c Mon Sep 17 00:00:00 2001 From: Stefan Geschwentner Date: Fri, 10 Apr 2015 20:32:39 +0100 Subject: [PATCH] Update stats at pv nodes If a quiet best move is found at a pv node then always update stats. STC: LLR: 2.96 (-2.94,2.94) [-1.50,4.50] Total: 41485 W: 8047 L: 7830 D: 25608 LTC: LLR: 2.96 (-2.94,2.94) [0.00,6.00] Total: 14351 W: 2420 L: 2250 D: 9681 Bench: 6985247 Resolves #330 --- src/search.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/search.cpp b/src/search.cpp index 31462308..8f074ca6 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -945,8 +945,6 @@ moves_loop: // When in check and at SpNode search starts from here } ss->currentMove = move; - if (!SpNode && !captureOrPromotion && quietCount < 64) - quietsSearched[quietCount++] = move; // Step 14. Make the move pos.do_move(move, st, givesCheck); @@ -1070,6 +1068,7 @@ moves_loop: // When in check and at SpNode search starts from here rm.score = -VALUE_INFINITE; } + bool newBestMove = false; if (value > bestValue) { bestValue = SpNode ? splitPoint->bestValue = value : value; @@ -1082,6 +1081,7 @@ moves_loop: // When in check and at SpNode search starts from here && (move != EasyMove.get(pos.key()) || moveCount > 1)) EasyMove.clear(); + newBestMove = true; bestMove = SpNode ? splitPoint->bestMove = move : move; if (PvNode && !RootNode) // Update pv even in fail-high case @@ -1101,6 +1101,9 @@ moves_loop: // When in check and at SpNode search starts from here } } + if (!SpNode && !captureOrPromotion && !newBestMove && quietCount < 64) + quietsSearched[quietCount++] = move; + // Step 19. Check for splitting the search if ( !SpNode && Threads.size() >= 2 @@ -1144,8 +1147,8 @@ moves_loop: // When in check and at SpNode search starts from here : inCheck ? mated_in(ss->ply) : DrawValue[pos.side_to_move()]; // Quiet best move: update killers, history and countermoves - else if (bestValue >= beta && !pos.capture_or_promotion(bestMove)) - update_stats(pos, ss, bestMove, depth, quietsSearched, quietCount - 1); + else if (bestMove != MOVE_NONE && !pos.capture_or_promotion(bestMove)) + update_stats(pos, ss, bestMove, depth, quietsSearched, quietCount); tte->save(posKey, value_to_tt(bestValue, ss->ply), bestValue >= beta ? BOUND_LOWER : @@ -1402,8 +1405,7 @@ moves_loop: // When in check and at SpNode search starts from here *pv = MOVE_NONE; } - // update_stats() updates killers, history and countermoves stats after a fail-high - // of a quiet move. + // update_stats() updates killers, history, countermove history and countermoves stats for a quiet best move. void update_stats(const Position& pos, Stack* ss, Move move, Depth depth, Move* quiets, int quietsCnt) { -- 2.39.2