From 302e0f70c653bfcca4338d7be71dfdd1166da910 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Ste=CC=81phane=20Nicolet?= <cassio@free.fr>
Date: Mon, 23 Sep 2019 09:10:28 +0200
Subject: [PATCH] Revert "Clarify the mapping of files to queenside"

This reverts commit 7756344d5d2b93970e7cd423f8cbf6fb1da11b74.
---
 src/evaluate.cpp | 2 +-
 src/pawns.cpp    | 2 +-
 src/psqt.cpp     | 2 +-
 src/types.h      | 4 ----
 4 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/evaluate.cpp b/src/evaluate.cpp
index f37820af..9521cd10 100644
--- a/src/evaluate.cpp
+++ b/src/evaluate.cpp
@@ -662,7 +662,7 @@ namespace {
             || (pos.pieces(PAWN) & (s + Up)))
             bonus = bonus / 2;
 
-        score += bonus - PassedFile * map_to_queenside(f);
+        score += bonus - PassedFile * std::min(f, ~f);
     }
 
     if (T)
diff --git a/src/pawns.cpp b/src/pawns.cpp
index d822ef4e..f6041199 100644
--- a/src/pawns.cpp
+++ b/src/pawns.cpp
@@ -198,7 +198,7 @@ Score Entry::evaluate_shelter(const Position& pos, Square ksq) {
       b = theirPawns & file_bb(f);
       int theirRank = b ? relative_rank(Us, frontmost_sq(Them, b)) : 0;
 
-      int d = map_to_queenside(f);
+      int d = std::min(f, ~f);
       bonus += make_score(ShelterStrength[d][ourRank], 0);
 
       if (ourRank && (ourRank == theirRank - 1))
diff --git a/src/psqt.cpp b/src/psqt.cpp
index 13e69499..36d99feb 100644
--- a/src/psqt.cpp
+++ b/src/psqt.cpp
@@ -119,7 +119,7 @@ void init() {
 
       for (Square s = SQ_A1; s <= SQ_H8; ++s)
       {
-          File f = map_to_queenside(file_of(s));
+          File f = std::min(file_of(s), ~file_of(s));
           psq[ pc][ s] = score + (type_of(pc) == PAWN ? PBonus[rank_of(s)][file_of(s)]
                                                       : Bonus[pc][rank_of(s)][f]);
           psq[~pc][~s] = -psq[pc][s];
diff --git a/src/types.h b/src/types.h
index 6af03687..c77d8040 100644
--- a/src/types.h
+++ b/src/types.h
@@ -366,10 +366,6 @@ constexpr Piece operator~(Piece pc) {
   return Piece(pc ^ 8); // Swap color of piece B_KNIGHT -> W_KNIGHT
 }
 
-inline File map_to_queenside(File f) {
-  return std::min(f, File(FILE_H - f)); // Map files ABCDEFGH to files ABCDDCBA
-}
-
 constexpr CastlingRights operator&(Color c, CastlingRights cr) {
   return CastlingRights((c == WHITE ? WHITE_CASTLING : BLACK_CASTLING) & cr);
 }
-- 
2.39.2