From 6235904898c67e0609ba06dc9f92e1f7325dd176 Mon Sep 17 00:00:00 2001 From: Marco Costalba Date: Tue, 28 Dec 2010 11:45:57 +0100 Subject: [PATCH] Redefine MoveStack comparison as the natural one Define symbol '<' to mean 'minor of', as it should be. Its meaning was reversed to be used with std::sort() that sorts in ascending order while we want a descending order. But now that we use our own sorting code we don't need this trick anymore. No functional change. Signed-off-by: Marco Costalba --- src/move.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/move.h b/src/move.h index 06c9969f..a40c058e 100644 --- a/src/move.h +++ b/src/move.h @@ -64,8 +64,7 @@ struct MoveStack { int score; }; -// Note that operator< is set up such that sorting will be in descending order -inline bool operator<(const MoveStack& f, const MoveStack& s) { return s.score < f.score; } +inline bool operator<(const MoveStack& f, const MoveStack& s) { return f.score < s.score; } // An helper insertion sort implementation template @@ -79,10 +78,10 @@ inline void insertion_sort(T* firstMove, T* lastMove) { p = d = cur; value = *p--; - if (value < *p) + if (*p < value) { do *d = *p; - while (--d != firstMove && value < *--p); + while (--d != firstMove && *--p < value); *d = value; } } @@ -132,7 +131,7 @@ inline T pick_best(T* curMove, T* lastMove) bestMove = *curMove; while (++curMove != lastMove) { - if (*curMove < bestMove) + if (bestMove < *curMove) { tmp = *curMove; *curMove = bestMove; -- 2.39.2