From 6e00aa6bae8a9634b3aea4b7b0bde652a588e9de Mon Sep 17 00:00:00 2001 From: Marco Costalba Date: Sun, 1 Apr 2012 11:30:54 +0100 Subject: [PATCH] Better document square flipping helpers No functional change. Signed-off-by: Marco Costalba --- src/bitboard.cpp | 4 ++-- src/position.cpp | 4 ++-- src/types.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bitboard.cpp b/src/bitboard.cpp index 6a3c1820..41ce2955 100644 --- a/src/bitboard.cpp +++ b/src/bitboard.cpp @@ -236,7 +236,7 @@ void Bitboards::init() { { Square to = s + Square(c == WHITE ? steps[pt][k] : -steps[pt][k]); - if (square_is_ok(to) && square_distance(s, to) < 3) + if (is_ok(to) && square_distance(s, to) < 3) StepAttacksBB[make_piece(c, pt)][s] |= to; } @@ -273,7 +273,7 @@ namespace { for (int i = 0; i < 4; i++) for (Square s = sq + deltas[i]; - square_is_ok(s) && square_distance(s, s - deltas[i]) == 1; + is_ok(s) && square_distance(s, s - deltas[i]) == 1; s += deltas[i]) { attack |= s; diff --git a/src/position.cpp b/src/position.cpp index 879ac442..e3ee3d26 100644 --- a/src/position.cpp +++ b/src/position.cpp @@ -409,7 +409,7 @@ Bitboard Position::attackers_to(Square s, Bitboard occ) const { Bitboard Position::attacks_from(Piece p, Square s, Bitboard occ) { - assert(square_is_ok(s)); + assert(is_ok(s)); switch (type_of(p)) { @@ -427,7 +427,7 @@ Bitboard Position::attacks_from(Piece p, Square s, Bitboard occ) { bool Position::move_attacks_square(Move m, Square s) const { assert(is_ok(m)); - assert(square_is_ok(s)); + assert(is_ok(s)); Bitboard occ, xray; Square from = from_sq(m); diff --git a/src/types.h b/src/types.h index b9964971..031cb0ba 100644 --- a/src/types.h +++ b/src/types.h @@ -327,7 +327,7 @@ inline Color operator~(Color c) { } inline Square operator~(Square s) { - return Square(s ^ 56); + return Square(s ^ 56); // Vertical flip SQ_A1 -> SQ_A8 } inline Value mate_in(int ply) { @@ -354,7 +354,7 @@ inline Square make_square(File f, Rank r) { return Square((r << 3) | f); } -inline bool square_is_ok(Square s) { +inline bool is_ok(Square s) { return s >= SQ_A1 && s <= SQ_H8; } @@ -367,7 +367,7 @@ inline Rank rank_of(Square s) { } inline Square mirror(Square s) { - return Square(s ^ 7); + return Square(s ^ 7); // Horizontal flip SQ_A1 -> SQ_H1 } inline Square relative_square(Color c, Square s) { -- 2.39.2