From b5d10d17c225cccf0ed670b724a4cdcc4fc68018 Mon Sep 17 00:00:00 2001 From: Fabian Beuke Date: Sat, 19 Nov 2016 15:55:30 +0100 Subject: [PATCH] Reduce variable scope in swap_byte Added a specialization to remove the 'if' condition No functional change. --- src/syzygy/tbprobe.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/syzygy/tbprobe.cpp b/src/syzygy/tbprobe.cpp index b553ac9f..d13e9018 100644 --- a/src/syzygy/tbprobe.cpp +++ b/src/syzygy/tbprobe.cpp @@ -228,10 +228,10 @@ template inline void swap_byte(T& x) { char tmp, *c = (char*)&x; - if (Half) // Fix a MSVC 2015 warning - for (int i = 0; i < Half; ++i) - tmp = c[i], c[i] = c[End - i], c[End - i] = tmp; + for (int i = 0; i < Half; ++i) + tmp = c[i], c[i] = c[End - i], c[End - i] = tmp; } +template<> inline void swap_byte(uint8_t&) {} template T number(void* addr) { -- 2.39.2