From: RĂ©mi Duraffort Date: Thu, 31 Jul 2008 19:55:53 +0000 (+0200) Subject: Potential memleak. X-Git-Tag: 0.9.0-test3~89 X-Git-Url: https://git.sesse.net/?p=vlc;a=commitdiff_plain;h=be68773052b3b440f3274b1164fb07b22d147a59 Potential memleak. --- diff --git a/modules/codec/fake.c b/modules/codec/fake.c index 7696a76f49..bd4c1cddc8 100644 --- a/modules/codec/fake.c +++ b/modules/codec/fake.c @@ -154,6 +154,7 @@ static int OpenDecoder( vlc_object_t *p_this ) if( !psz_file ) { msg_Err( p_dec, "specify a file with --fake-file=..." ); + free( p_dec->p_sys ); return VLC_EGENERIC; } var_AddCallback( p_dec, "fake-file", FakeCallback, p_dec ); @@ -222,6 +223,8 @@ static int OpenDecoder( vlc_object_t *p_this ) if ( p_image == NULL ) { msg_Err( p_dec, "unable to read image file %s", psz_file ); + free( psz_file ); + free( p_dec->p_sys ); return VLC_EGENERIC; } msg_Dbg( p_dec, "file %s loaded successfully", psz_file ); diff --git a/modules/control/http/http.c b/modules/control/http/http.c index 54cce0bfa7..1b1796a1c6 100644 --- a/modules/control/http/http.c +++ b/modules/control/http/http.c @@ -142,6 +142,7 @@ static int Open( vlc_object_t *p_this ) p_intf->p_sys = p_sys = malloc( sizeof( intf_sys_t ) ); if( !p_intf->p_sys ) { + free( psz_address ); return( VLC_ENOMEM ); } diff --git a/modules/control/lirc.c b/modules/control/lirc.c index 1951c1751a..0ae6fbb1fa 100644 --- a/modules/control/lirc.c +++ b/modules/control/lirc.c @@ -98,6 +98,7 @@ static int Open( vlc_object_t *p_this ) if( i_fd == -1 ) { msg_Err( p_intf, "lirc initialisation failed" ); + free( p_intf->p_sys->psz_file ); free( p_intf->p_sys ); return 1; } @@ -109,6 +110,7 @@ static int Open( vlc_object_t *p_this ) { msg_Err( p_intf, "failure while reading lirc config" ); lirc_deinit(); + free( p_intf->p_sys->psz_file ); free( p_intf->p_sys ); return 1; }