From: RĂ©mi Duraffort Date: Sun, 4 Jul 2010 06:22:14 +0000 (+0200) Subject: rar: fix possible use of un undefined value (due to a goto on error). X-Git-Tag: 1.2.0-pre1~5950 X-Git-Url: https://git.sesse.net/?p=vlc;a=commitdiff_plain;h=c38d7ca2761d566e0c4e882f51aeb0cd2ac8d08f rar: fix possible use of un undefined value (due to a goto on error). --- diff --git a/modules/access/rar/rar.c b/modules/access/rar/rar.c index b028f0004d..4079d815b0 100644 --- a/modules/access/rar/rar.c +++ b/modules/access/rar/rar.c @@ -189,13 +189,16 @@ static int SkipFile(stream_t *s, int *count, rar_file_t ***file, const rar_block memcpy(name, &peek[name_offset], name_size); } + rar_file_t *current = NULL; if (method != 0x30) { msg_Warn(s, "Ignoring compressed file %s (method=0x%2.2x)", name, method); goto exit; } /* */ - rar_file_t *current = *count > 0 ? (*file)[*count - 1] : NULL; + if( *count > 0 ) + current = (*file)[*count - 1]; + if (current && (current->is_complete || current->size != file_size ||