From 2d4cdd7ab6ec8d58df38558f15d03b36d9c888ef Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Kempf Date: Mon, 10 Oct 2011 00:00:14 +0200 Subject: [PATCH] Freetype: fix double-free in error path --- modules/text_renderer/freetype.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/text_renderer/freetype.c b/modules/text_renderer/freetype.c index 069e01d2f6..fe14eda38a 100644 --- a/modules/text_renderer/freetype.c +++ b/modules/text_renderer/freetype.c @@ -2594,9 +2594,6 @@ static int Create( vlc_object_t *p_this ) psz_fontfile ? psz_fontfile : "(null)" ); goto error; } -#ifdef HAVE_STYLES - free( psz_fontfile ); -#endif i_error = FT_Select_Charmap( p_sys->p_face, ft_encoding_unicode ); if( i_error ) @@ -2627,6 +2624,10 @@ static int Create( vlc_object_t *p_this ) LoadFontsFromAttachments( p_filter ); +#ifdef HAVE_STYLES + free( psz_fontfile ); +#endif + return VLC_SUCCESS; error: -- 2.39.2