From 9f9f6d1153bb1954bed4ab7146a6a801dfe36fb0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?R=C3=A9mi=20Denis-Courmont?= Date: Sat, 1 May 2010 22:31:13 +0300 Subject: [PATCH] Remove the Xlib no-ARGB hack The XCB/XVideo (for a long time) and the XCB/X11 (since the commit before the previous one) video output plugins will fail safe in case the embedding window has an alpha channel. In VLC 1.0, the Xlib plugins needed this hack as the Xlib error handler would terminate VLC. If compositing is in use, VLC will now use GLX. This will require software chroma conversion from YUV to RGB. Also, unless the GLX output is explicitly selected, VLC will flash twice before it starts rendering. First, it tries (and fail) to use XVideo, then plain X11. To fix this cosmetic problem, we would need to keep the window across plugins. I assume this change is needed to fix #3581, but I have not tested, so it may or may not be sufficient. --- bin/vlc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/bin/vlc.c b/bin/vlc.c index e141b4b431..68cbfa07b2 100644 --- a/bin/vlc.c +++ b/bin/vlc.c @@ -70,10 +70,6 @@ int main( int i_argc, const char *ppsz_argv[] ) /* Disable the ugly Gnome crash dialog so that we properly segfault */ putenv( (char *)"GNOME_DISABLE_CRASH_DIALOG=1" ); # endif - - /* Make Xlib hide visuals with an alphachannel. Ensure that Qt4 will not - * use the alpha channel for the embedded video window. */ - putenv( (char *)"XLIB_SKIP_ARGB_VISUALS=1" ); #endif #ifdef HAVE_SETENV /* Clear the X.Org startup notification ID. Otherwise the UI might try to -- 2.39.2