X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;ds=inline;f=src%2Fmovepick.cpp;h=694b9222fe573945c826e627865e6b4d5565f58c;hb=HEAD;hp=6aa1954b5ae67ccee5108b8de2729f43dc46b03b;hpb=88ef68dde5882648b54cce2d1fb024c926596054;p=stockfish
diff --git a/src/movepick.cpp b/src/movepick.cpp
index 6aa1954b..bdc0e4af 100644
--- a/src/movepick.cpp
+++ b/src/movepick.cpp
@@ -1,6 +1,6 @@
/*
Stockfish, a UCI chess playing engine derived from Glaurung 2.1
- Copyright (C) 2004-2021 The Stockfish developers (see AUTHORS file)
+ Copyright (C) 2004-2024 The Stockfish developers (see AUTHORS file)
Stockfish is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -16,258 +16,303 @@
along with this program. If not, see .
*/
+#include "movepick.h"
+
+#include
#include
+#include
-#include "movepick.h"
+#include "bitboard.h"
+#include "position.h"
namespace Stockfish {
namespace {
- enum Stages {
- MAIN_TT, CAPTURE_INIT, GOOD_CAPTURE, REFUTATION, QUIET_INIT, QUIET, BAD_CAPTURE,
- EVASION_TT, EVASION_INIT, EVASION,
- PROBCUT_TT, PROBCUT_INIT, PROBCUT,
- QSEARCH_TT, QCAPTURE_INIT, QCAPTURE, QCHECK_INIT, QCHECK
- };
-
- // partial_insertion_sort() sorts moves in descending order up to and including
- // a given limit. The order of moves smaller than the limit is left unspecified.
- void partial_insertion_sort(ExtMove* begin, ExtMove* end, int limit) {
+enum Stages {
+ // generate main search moves
+ MAIN_TT,
+ CAPTURE_INIT,
+ GOOD_CAPTURE,
+ QUIET_INIT,
+ GOOD_QUIET,
+ BAD_CAPTURE,
+ BAD_QUIET,
+
+ // generate evasion moves
+ EVASION_TT,
+ EVASION_INIT,
+ EVASION,
+
+ // generate probcut moves
+ PROBCUT_TT,
+ PROBCUT_INIT,
+ PROBCUT,
+
+ // generate qsearch moves
+ QSEARCH_TT,
+ QCAPTURE_INIT,
+ QCAPTURE
+};
+
+// Sort moves in descending order up to and including a given limit.
+// The order of moves smaller than the limit is left unspecified.
+void partial_insertion_sort(ExtMove* begin, ExtMove* end, int limit) {
for (ExtMove *sortedEnd = begin, *p = begin + 1; p < end; ++p)
if (p->value >= limit)
{
ExtMove tmp = *p, *q;
- *p = *++sortedEnd;
+ *p = *++sortedEnd;
for (q = sortedEnd; q != begin && *(q - 1) < tmp; --q)
*q = *(q - 1);
*q = tmp;
}
- }
-
-} // namespace
-
-
-/// Constructors of the MovePicker class. As arguments we pass information
-/// to help it to return the (presumably) good moves first, to decide which
-/// moves to return (in the quiescence search, for instance, we only want to
-/// search captures, promotions, and some checks) and how important good move
-/// ordering is at the current node.
-
-/// MovePicker constructor for the main search
-MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const ButterflyHistory* mh,
- const CapturePieceToHistory* cph,
- const PieceToHistory** ch,
- Move cm,
- const Move* killers)
- : pos(p), mainHistory(mh), captureHistory(cph), continuationHistory(ch),
- ttMove(ttm), refutations{{killers[0], 0}, {killers[1], 0}, {cm, 0}}, depth(d)
-{
- assert(d > 0);
-
- stage = (pos.checkers() ? EVASION_TT : MAIN_TT) +
- !(ttm && pos.pseudo_legal(ttm));
}
-/// MovePicker constructor for quiescence search
-MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const ButterflyHistory* mh,
- const CapturePieceToHistory* cph,
- const PieceToHistory** ch,
- Square rs)
- : pos(p), mainHistory(mh), captureHistory(cph), continuationHistory(ch), ttMove(ttm), recaptureSquare(rs), depth(d)
-{
- assert(d <= 0);
-
- stage = (pos.checkers() ? EVASION_TT : QSEARCH_TT) +
- !( ttm
- && (pos.checkers() || depth > DEPTH_QS_RECAPTURES || to_sq(ttm) == recaptureSquare)
- && pos.pseudo_legal(ttm));
+} // namespace
+
+
+// Constructors of the MovePicker class. As arguments, we pass information
+// to decide which class of moves to emit, to help sorting the (presumably)
+// good moves first, and how important move ordering is at the current node.
+
+// MovePicker constructor for the main search and for the quiescence search
+MovePicker::MovePicker(const Position& p,
+ Move ttm,
+ Depth d,
+ const ButterflyHistory* mh,
+ const CapturePieceToHistory* cph,
+ const PieceToHistory** ch,
+ const PawnHistory* ph) :
+ pos(p),
+ mainHistory(mh),
+ captureHistory(cph),
+ continuationHistory(ch),
+ pawnHistory(ph),
+ ttMove(ttm),
+ depth(d) {
+
+ if (pos.checkers())
+ stage = EVASION_TT + !(ttm && pos.pseudo_legal(ttm));
+
+ else
+ stage = (depth > 0 ? MAIN_TT : QSEARCH_TT) + !(ttm && pos.pseudo_legal(ttm));
}
-/// MovePicker constructor for ProbCut: we generate captures with SEE greater
-/// than or equal to the given threshold.
-MovePicker::MovePicker(const Position& p, Move ttm, Value th, const CapturePieceToHistory* cph)
- : pos(p), captureHistory(cph), ttMove(ttm), threshold(th)
-{
- assert(!pos.checkers());
-
- stage = PROBCUT_TT + !(ttm && pos.capture(ttm)
- && pos.pseudo_legal(ttm)
- && pos.see_ge(ttm, threshold));
+// MovePicker constructor for ProbCut: we generate captures with Static Exchange
+// Evaluation (SEE) greater than or equal to the given threshold.
+MovePicker::MovePicker(const Position& p, Move ttm, int th, const CapturePieceToHistory* cph) :
+ pos(p),
+ captureHistory(cph),
+ ttMove(ttm),
+ threshold(th) {
+ assert(!pos.checkers());
+
+ stage = PROBCUT_TT
+ + !(ttm && pos.capture_stage(ttm) && pos.pseudo_legal(ttm) && pos.see_ge(ttm, threshold));
}
-/// MovePicker::score() assigns a numerical value to each move in a list, used
-/// for sorting. Captures are ordered by Most Valuable Victim (MVV), preferring
-/// captures with a good history. Quiets moves are ordered using the histories.
+// Assigns a numerical value to each move in a list, used for sorting.
+// Captures are ordered by Most Valuable Victim (MVV), preferring captures
+// with a good history. Quiets moves are ordered using the history tables.
template
void MovePicker::score() {
- static_assert(Type == CAPTURES || Type == QUIETS || Type == EVASIONS, "Wrong type");
-
- for (auto& m : *this)
- if constexpr (Type == CAPTURES)
- m.value = int(PieceValue[MG][pos.piece_on(to_sq(m))]) * 6
- + (*captureHistory)[pos.moved_piece(m)][to_sq(m)][type_of(pos.piece_on(to_sq(m)))];
-
- else if constexpr (Type == QUIETS)
- m.value = (*mainHistory)[pos.side_to_move()][from_to(m)]
- + 2 * (*continuationHistory[0])[pos.moved_piece(m)][to_sq(m)]
- + (*continuationHistory[1])[pos.moved_piece(m)][to_sq(m)]
- + (*continuationHistory[3])[pos.moved_piece(m)][to_sq(m)]
- + (*continuationHistory[5])[pos.moved_piece(m)][to_sq(m)];
-
- else // Type == EVASIONS
- {
- if (pos.capture(m))
- m.value = PieceValue[MG][pos.piece_on(to_sq(m))]
- - Value(type_of(pos.moved_piece(m)));
- else
- m.value = (*mainHistory)[pos.side_to_move()][from_to(m)]
- + 2 * (*continuationHistory[0])[pos.moved_piece(m)][to_sq(m)]
- - (1 << 28);
- }
+ static_assert(Type == CAPTURES || Type == QUIETS || Type == EVASIONS, "Wrong type");
+
+ [[maybe_unused]] Bitboard threatenedByPawn, threatenedByMinor, threatenedByRook,
+ threatenedPieces;
+ if constexpr (Type == QUIETS)
+ {
+ Color us = pos.side_to_move();
+
+ threatenedByPawn = pos.attacks_by(~us);
+ threatenedByMinor =
+ pos.attacks_by(~us) | pos.attacks_by(~us) | threatenedByPawn;
+ threatenedByRook = pos.attacks_by(~us) | threatenedByMinor;
+
+ // Pieces threatened by pieces of lesser material value
+ threatenedPieces = (pos.pieces(us, QUEEN) & threatenedByRook)
+ | (pos.pieces(us, ROOK) & threatenedByMinor)
+ | (pos.pieces(us, KNIGHT, BISHOP) & threatenedByPawn);
+ }
+
+ for (auto& m : *this)
+ if constexpr (Type == CAPTURES)
+ m.value =
+ 7 * int(PieceValue[pos.piece_on(m.to_sq())])
+ + (*captureHistory)[pos.moved_piece(m)][m.to_sq()][type_of(pos.piece_on(m.to_sq()))];
+
+ else if constexpr (Type == QUIETS)
+ {
+ Piece pc = pos.moved_piece(m);
+ PieceType pt = type_of(pc);
+ Square from = m.from_sq();
+ Square to = m.to_sq();
+
+ // histories
+ m.value = (*mainHistory)[pos.side_to_move()][m.from_to()];
+ m.value += 2 * (*pawnHistory)[pawn_structure_index(pos)][pc][to];
+ m.value += 2 * (*continuationHistory[0])[pc][to];
+ m.value += (*continuationHistory[1])[pc][to];
+ m.value += (*continuationHistory[2])[pc][to] / 3;
+ m.value += (*continuationHistory[3])[pc][to];
+ m.value += (*continuationHistory[5])[pc][to];
+
+ // bonus for checks
+ m.value += bool(pos.check_squares(pt) & to) * 16384;
+
+ // bonus for escaping from capture
+ m.value += threatenedPieces & from ? (pt == QUEEN && !(to & threatenedByRook) ? 51700
+ : pt == ROOK && !(to & threatenedByMinor) ? 25600
+ : !(to & threatenedByPawn) ? 14450
+ : 0)
+ : 0;
+
+ // malus for putting piece en prise
+ m.value -= (pt == QUEEN ? bool(to & threatenedByRook) * 49000
+ : pt == ROOK ? bool(to & threatenedByMinor) * 24335
+ : bool(to & threatenedByPawn) * 14900);
+ }
+
+ else // Type == EVASIONS
+ {
+ if (pos.capture_stage(m))
+ m.value =
+ PieceValue[pos.piece_on(m.to_sq())] - type_of(pos.moved_piece(m)) + (1 << 28);
+ else
+ m.value = (*mainHistory)[pos.side_to_move()][m.from_to()]
+ + (*continuationHistory[0])[pos.moved_piece(m)][m.to_sq()]
+ + (*pawnHistory)[pawn_structure_index(pos)][pos.moved_piece(m)][m.to_sq()];
+ }
}
-/// MovePicker::select() returns the next move satisfying a predicate function.
-/// It never returns the TT move.
+// Returns the next move satisfying a predicate function.
+// This never returns the TT move, as it was emitted before.
template
Move MovePicker::select(Pred filter) {
- while (cur < endMoves)
- {
- if (T == Best)
- std::swap(*cur, *std::max_element(cur, endMoves));
+ while (cur < endMoves)
+ {
+ if constexpr (T == Best)
+ std::swap(*cur, *std::max_element(cur, endMoves));
- if (*cur != ttMove && filter())
- return *cur++;
+ if (*cur != ttMove && filter())
+ return *cur++;
- cur++;
- }
- return MOVE_NONE;
+ cur++;
+ }
+ return Move::none();
}
-/// MovePicker::next_move() is the most important method of the MovePicker class. It
-/// returns a new pseudo-legal move every time it is called until there are no more
-/// moves left, picking the move with the highest score from a list of generated moves.
+// This is the most important method of the MovePicker class. We emit one
+// new pseudo-legal move on every call until there are no more moves left,
+// picking the move with the highest score from a list of generated moves.
Move MovePicker::next_move(bool skipQuiets) {
+ auto quiet_threshold = [](Depth d) { return -3560 * d; };
+
top:
- switch (stage) {
-
- case MAIN_TT:
- case EVASION_TT:
- case QSEARCH_TT:
- case PROBCUT_TT:
- ++stage;
- return ttMove;
-
- case CAPTURE_INIT:
- case PROBCUT_INIT:
- case QCAPTURE_INIT:
- cur = endBadCaptures = moves;
- endMoves = generate(pos, cur);
-
- score();
- ++stage;
- goto top;
-
- case GOOD_CAPTURE:
- if (select([&](){
- return pos.see_ge(*cur, Value(-69 * cur->value / 1024)) ?
- // Move losing capture to endBadCaptures to be tried later
- true : (*endBadCaptures++ = *cur, false); }))
- return *(cur - 1);
-
- // Prepare the pointers to loop over the refutations array
- cur = std::begin(refutations);
- endMoves = std::end(refutations);
-
- // If the countermove is the same as a killer, skip it
- if ( refutations[0].move == refutations[2].move
- || refutations[1].move == refutations[2].move)
- --endMoves;
-
- ++stage;
- [[fallthrough]];
-
- case REFUTATION:
- if (select([&](){ return *cur != MOVE_NONE
- && !pos.capture(*cur)
- && pos.pseudo_legal(*cur); }))
- return *(cur - 1);
- ++stage;
- [[fallthrough]];
-
- case QUIET_INIT:
- if (!skipQuiets)
- {
- cur = endBadCaptures;
- endMoves = generate(pos, cur);
-
- score();
- partial_insertion_sort(cur, endMoves, -3000 * depth);
- }
-
- ++stage;
- [[fallthrough]];
-
- case QUIET:
- if ( !skipQuiets
- && select([&](){return *cur != refutations[0].move
- && *cur != refutations[1].move
- && *cur != refutations[2].move;}))
- return *(cur - 1);
-
- // Prepare the pointers to loop over the bad captures
- cur = moves;
- endMoves = endBadCaptures;
-
- ++stage;
- [[fallthrough]];
-
- case BAD_CAPTURE:
- return select([](){ return true; });
-
- case EVASION_INIT:
- cur = moves;
- endMoves = generate(pos, cur);
-
- score();
- ++stage;
- [[fallthrough]];
-
- case EVASION:
- return select([](){ return true; });
-
- case PROBCUT:
- return select([&](){ return pos.see_ge(*cur, threshold); });
-
- case QCAPTURE:
- if (select([&](){ return depth > DEPTH_QS_RECAPTURES
- || to_sq(*cur) == recaptureSquare; }))
- return *(cur - 1);
-
- // If we did not find any move and we do not try checks, we have finished
- if (depth != DEPTH_QS_CHECKS)
- return MOVE_NONE;
-
- ++stage;
- [[fallthrough]];
-
- case QCHECK_INIT:
- cur = moves;
- endMoves = generate(pos, cur);
-
- ++stage;
- [[fallthrough]];
-
- case QCHECK:
- return select([](){ return true; });
- }
-
- assert(false);
- return MOVE_NONE; // Silence warning
+ switch (stage)
+ {
+
+ case MAIN_TT :
+ case EVASION_TT :
+ case QSEARCH_TT :
+ case PROBCUT_TT :
+ ++stage;
+ return ttMove;
+
+ case CAPTURE_INIT :
+ case PROBCUT_INIT :
+ case QCAPTURE_INIT :
+ cur = endBadCaptures = moves;
+ endMoves = generate(pos, cur);
+
+ score();
+ partial_insertion_sort(cur, endMoves, std::numeric_limits::min());
+ ++stage;
+ goto top;
+
+ case GOOD_CAPTURE :
+ if (select([&]() {
+ // Move losing capture to endBadCaptures to be tried later
+ return pos.see_ge(*cur, -cur->value / 18) ? true
+ : (*endBadCaptures++ = *cur, false);
+ }))
+ return *(cur - 1);
+
+ ++stage;
+ [[fallthrough]];
+
+ case QUIET_INIT :
+ if (!skipQuiets)
+ {
+ cur = endBadCaptures;
+ endMoves = beginBadQuiets = endBadQuiets = generate(pos, cur);
+
+ score();
+ partial_insertion_sort(cur, endMoves, quiet_threshold(depth));
+ }
+
+ ++stage;
+ [[fallthrough]];
+
+ case GOOD_QUIET :
+ if (!skipQuiets && select([]() { return true; }))
+ {
+ if ((cur - 1)->value > -7998 || (cur - 1)->value <= quiet_threshold(depth))
+ return *(cur - 1);
+
+ // Remaining quiets are bad
+ beginBadQuiets = cur - 1;
+ }
+
+ // Prepare the pointers to loop over the bad captures
+ cur = moves;
+ endMoves = endBadCaptures;
+
+ ++stage;
+ [[fallthrough]];
+
+ case BAD_CAPTURE :
+ if (select([]() { return true; }))
+ return *(cur - 1);
+
+ // Prepare the pointers to loop over the bad quiets
+ cur = beginBadQuiets;
+ endMoves = endBadQuiets;
+
+ ++stage;
+ [[fallthrough]];
+
+ case BAD_QUIET :
+ if (!skipQuiets)
+ return select([]() { return true; });
+
+ return Move::none();
+
+ case EVASION_INIT :
+ cur = moves;
+ endMoves = generate(pos, cur);
+
+ score();
+ ++stage;
+ [[fallthrough]];
+
+ case EVASION :
+ return select([]() { return true; });
+
+ case PROBCUT :
+ return select([&]() { return pos.see_ge(*cur, threshold); });
+
+ case QCAPTURE :
+ return select([]() { return true; });
+ }
+
+ assert(false);
+ return Move::none(); // Silence warning
}
-} // namespace Stockfish
+} // namespace Stockfish