X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;ds=sidebyside;f=modules%2Fvideo_filter%2Fremoteosd.c;h=1b564cbd27733e8c27cb9690585dcd0b6962cd61;hb=0597403277c49d3fc23da19fb6f6954e984bae86;hp=1bd84ca14e36a999ffe528bbedcdfbfc6a86653f;hpb=bd03c387b82dad16831e76091aae66b37080910b;p=vlc diff --git a/modules/video_filter/remoteosd.c b/modules/video_filter/remoteosd.c index 1bd84ca14e..1b564cbd27 100644 --- a/modules/video_filter/remoteosd.c +++ b/modules/video_filter/remoteosd.c @@ -115,14 +115,14 @@ static int CreateFilter ( vlc_object_t * ); static void DestroyFilter( vlc_object_t * ); -vlc_module_begin(); - set_description( N_("Remote-OSD over VNC") ); - set_capability( "sub filter", 100 ); - set_shortname( N_("Remote-OSD") ); - set_category( CAT_VIDEO ); - set_subcategory( SUBCAT_VIDEO_SUBPIC ); - add_shortcut( "rmtosd" ); - set_callbacks( CreateFilter, DestroyFilter ); +vlc_module_begin () + set_description( N_("Remote-OSD over VNC") ) + set_capability( "sub filter", 100 ) + set_shortname( N_("Remote-OSD") ) + set_category( CAT_VIDEO ) + set_subcategory( SUBCAT_VIDEO_SUBPIC ) + add_shortcut( "rmtosd" ) + set_callbacks( CreateFilter, DestroyFilter ) add_string( RMTOSD_CFG "host", "myvdr", NULL, RMTOSD_HOST_TEXT, RMTOSD_HOST_LONGTEXT, false ); @@ -142,7 +142,7 @@ vlc_module_begin(); add_integer_with_range( RMTOSD_CFG "alpha", 255, 0, 255, NULL, RMTOSD_ALPHA_TEXT, RMTOSD_ALPHA_LONGTEXT, true ); -vlc_module_end(); +vlc_module_end () /***************************************************************************** @@ -333,8 +333,7 @@ static int CreateFilter ( vlc_object_t *p_this ) sizeof( vlc_object_t ) ); vlc_object_attach( p_sys->p_worker_thread, p_this ); if( vlc_thread_create( p_sys->p_worker_thread, "vnc worker thread", - vnc_worker_thread, - VLC_THREAD_PRIORITY_LOW, false ) ) + vnc_worker_thread, VLC_THREAD_PRIORITY_LOW ) ) { vlc_object_detach( p_sys->p_worker_thread ); vlc_object_release( p_sys->p_worker_thread ); @@ -715,8 +714,7 @@ static void* vnc_worker_thread( vlc_object_t *p_thread_obj ) vlc_object_attach( p_update_request_thread, p_filter ); if( vlc_thread_create( p_update_request_thread, "vnc update request thread", - update_request_thread, - VLC_THREAD_PRIORITY_LOW, false ) ) + update_request_thread, VLC_THREAD_PRIORITY_LOW ) ) { vlc_object_detach( p_update_request_thread ); vlc_object_release( p_update_request_thread ); @@ -1162,7 +1160,7 @@ static subpicture_t *Filter( filter_t *p_filter, mtime_t date ) fmt.i_width = fmt.i_visible_width = p_pic->p[Y_PLANE].i_visible_pitch; fmt.i_height = fmt.i_visible_height = p_pic->p[Y_PLANE].i_visible_lines; fmt.i_x_offset = fmt.i_y_offset = 0; - p_region = p_spu->pf_create_region( VLC_OBJECT(p_filter), &fmt ); + p_region = subpicture_region_New( &fmt ); if( !p_region ) { msg_Err( p_filter, "cannot allocate SPU region" ); @@ -1171,7 +1169,8 @@ static subpicture_t *Filter( filter_t *p_filter, mtime_t date ) return NULL; } - vout_CopyPicture( p_filter, &p_region->picture, p_pic ); + /* FIXME the copy is probably not needed anymore */ + picture_Copy( p_region->p_picture, p_pic ); p_sys->b_need_update = false; @@ -1182,8 +1181,6 @@ static subpicture_t *Filter( filter_t *p_filter, mtime_t date ) p_spu->b_absolute = false; - p_spu->i_x = 0; - p_spu->i_y = 0; p_spu->i_original_picture_width = 0; /*Let vout core do the horizontal scaling */ p_spu->i_original_picture_height = fmt.i_height;