X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=backup.sh;h=71ebfe1084897fe525dd14091340d4c100a74ccb;hb=948635d7a45badaf24b8e66c54e92073234dab23;hp=c79432293d3aff1c8ff392bac8c2581d42193fae;hpb=1cf6fdfd22c1250045695f5723e84c0d7d0c84bd;p=backup.sh

diff --git a/backup.sh b/backup.sh
index c794322..71ebfe1 100755
--- a/backup.sh
+++ b/backup.sh
@@ -18,30 +18,35 @@
 # The script is halfway Norwegian and halfway English. Newer modifications are
 # in English, we should probably stick to that.
 
-# The computer to backup.
-computer=$1
-
-# Configuration
-LOCKFILE=/home/backup/backuprun.lockfile.$computer
-confdir=/home/backup/conf/              # Configuration files
-storagedir=/backup                      # Where we keep backups
-maxnumfull=3                            # Number of full backups
-daysbetweenfull=30                      # Days between full backups
-daysbetweenfullforfixed=32              # Days between full backups for machines with fixed
-                                        # full-backup date (in case the fixed day gets missed)
-DAY_OF_MONTH=`date "+%d" | sed s/^0//`  # from 1 to 31
-DATE=`date "+%Y%m%d%H%M"`               #format: touch
-DATEs=`date "+%Y-%m-%d %H:%M"`          #format: tar
-
-# Exclude-pattern
-exclude=$confdir/exclude
-[ ! -f $exclude ] && printf "tmp\ncore\n" > $exclude
+SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"  # Absolute directory the script lives in
+confdir=$SCRIPTPATH/conf/                        # Directory configuration files
+[ -r $confdir/env ] && . $confdir/env
+
+# Default configuration; used unless $confdir/env has set something different.
+storagedir=${storagedir:-/backup}                # Where we keep backups
+exclude=${exclude:-$confdir/exclude}             # List of exclude patterns
+maxnumfull=${maxnumfull:-3}                      # Number of full backups
+daysbetweenfull=${daysbetweenfull:-30}           # Days between full backups
+
+# Days between full backups for machines with fixed full-backup date
+# (in case the fixed day gets missed).
+daysbetweenfullforfixed=${daysbetweenfullforfixed:-32}
+
+# End of configuration.
+
+computer=$1                                      # The computer to backup.
+LOCKFILE=$SCRIPTPATH/backuprun.lockfile.$computer
+DAY_OF_MONTH=`date "+%d" | sed s/^0//`           # from 1 to 31
+DATE=`date "+%Y%m%d%H%M"`                        # format: touch
+DATEs=`date "+%Y-%m-%d %H:%M"`                   # format: tar
 
 if [ -z "$computer" ]; then
 	echo "Usage: $0 COMPUTER"
 	exit 1
 fi
 
+[ ! -f $exclude ] && printf "tmp\ncore\n" > $exclude
+
 # Die more or less gracefully (at least notify user)
 die() {
 	warnmsg "Aborting."
@@ -63,9 +68,10 @@ infomsg() {
 # Trap C-c and kill
 trap die SIGINT SIGTERM
 
-# Don't start if we're already running
+# Don't start if we're already running. Don't use diemsg, as that removes the lock file!
 if [ -e $LOCKFILE ]; then
-	diemsg "$LOCKFILE exists for pid `cat $LOCKFILE`."
+	warnmsg "$LOCKFILE exists for pid `cat $LOCKFILE`."
+	exit 1
 fi;
 touch $LOCKFILE
 echo $$ > $LOCKFILE
@@ -84,7 +90,7 @@ backup()
 		# If incremental backup, we need to copy the incremental status to $computer.
 		# If it does not exist, whine a bit and then run date-based instead.
 		if [ -s "$localsnar" ]; then
-			if ! scp $localsnar $username@$computer:$remotesnar; then
+			if ! scp $localsnar $username@$computer:$remotesnar >&2; then
 				diemsg "Could not copy .incremental.snar to $computer"
 			fi
 			lastcmd="--listed-incremental=$remotesnar --no-check-device"
@@ -101,6 +107,16 @@ backup()
 		lastcmd="--listed-incremental=$remotesnar"
 	fi
 
+	# The file is usually stored to disk with a simple cat > $TARFILE,
+	# but in some cases, like backing up to a remote and untrusted
+	# file system, it could be useful to replace it with e.g.
+	# a GPG command line.
+	if [ -f $confdir/storageprogram.$computer ]; then
+		storageprogram=`cat $confdir/storageprogram.$computer`
+	else
+		storageprogram=cat
+	fi
+
 	# We try to run tar on the remote computer
 	#    c create archive
 	#    C change to directory first
@@ -112,8 +128,8 @@ backup()
 	#    Pipe the stuff over ssh to ourselves, run pee to cat the contents to a
 	#    file and build a file list, respectivly.  
 	TARFILE=$DATE.tmp
-	TARCMD="ssh $username@$computer \"nice -n 19 ionice -c3 tar --one-file-system --use-compress-program $compressor -cf - -C $filesystem . $lastcmd \
-		--exclude-from=$remotehome/.backup/exclude\" | pee \"cat > $TARFILE\" \"tar tzvf -\""
+	TARCMD="ssh -n $username@$computer \"$nice tar --one-file-system --use-compress-program $compressor -cf - -C $filesystem . $lastcmd \
+		--exclude-from=$remotehome/.backup/exclude\" | pee \"$storageprogram > $TARFILE\" \"tar tzvf -\""
 	infomsg "Running $TARCMD"
 	eval $TARCMD > $DATE.idx
 
@@ -121,7 +137,7 @@ backup()
 		# File is >0 in size and neither cat or tar tzvf failed; we assume it worked.
  
 		if [ "$remotesnar" ]; then
-			if ! scp $username@$computer:$remotesnar $localsnar.tmp; then
+			if ! scp $username@$computer:$remotesnar $localsnar.tmp >&2; then
 				diemsg "Could not copy .incremental.snar from $computer"
 			fi
 		fi
@@ -140,7 +156,7 @@ backup()
 		chmod 644 *idx 2>/dev/null          #everyone can read
 
 		# Let the remote computer know that we ran a successful backup (for nagios)
-		ssh $username@$computer touch $filesystem/.lastbackup
+		ssh -n $username@$computer touch $filesystem/.lastbackup
 	else
 		# Something wrong happened.
 		rm $TARFILE
@@ -153,24 +169,28 @@ backup()
 #  - No .idx files.
 #  - No .snar-style incremental backups, only date-based.
 #  - No touching of .lastbackup for Nagios.
+#  - Failed tar operations may go undetected, since we only see the error code
+#    the last process in the pipe chain, which is gpg.
+#  - No storageprogram support (see above), because the file is typically already
+#    encrypted.
 nonprivbackup()
 {
 	infomsg "$computer:$filesystem $backuplevel non-privileged backup"
 
 	if [ "$backuplevel" = "daglig" ]; then
 		lastd=`cat ../.date`
-		lastcmd="\"$lastd\""
+		lastcmd="'$lastd'"
 	else
 		lastcmd=""
 	fi
 
 	TARFILE=$DATE.tmp
-	TARCMD="ssh $username@$computer \"sudo /usr/local/sbin/output-encrypted-backup $filesystem $lastcmd\""
+	TARCMD="ssh -n $username@$computer \"sudo /usr/local/sbin/output-encrypted-backup $filesystem $lastcmd\""
 	infomsg "Running $TARCMD"
 	eval $TARCMD > $TARFILE
 
-	if [ $? -lt 2 ] && [ -s $TARFILE ]; then
-		# File is >0 in size and the remote tar did not report any fatal errors; we assume it worked.
+	if [ $? -eq 0 ] && [ -s $TARFILE ]; then
+		# File is >0 in size and the remote side did not report any fatal errors; we assume it worked.
 
 		# Move tar file in place
 		mv $TARFILE $DATE.tgz.gpg
@@ -213,7 +233,7 @@ if ! ssh -n -o NumberOfPasswordPrompts=0 $username@$computer /bin/true; then
 fi
 
 # Find the home directory of the backup user
-remotehome=`ssh $username@$computer "echo ~"`
+remotehome=`ssh -n $username@$computer "echo ~"`
 if [ -z "$remotehome" ]; then
 	diemsg "Could not expand ~ for user $username"
 fi
@@ -226,6 +246,14 @@ else
 	compressor=gzip
 fi
 
+# Check if nice and ionice are available
+if ssh -n $username@$computer "nice -n 19 ionice -c3 /bin/true 2>/dev/null"; then
+	nice="nice -n 19 ionice -c3"
+else
+	infomsg "nice and/or ionice missing; will run at normal priority."
+	nice=""
+fi
+
 # Check dump bit in fstab
 filesystems=`ssh -n $username@$computer "cat /etc/fstab" \
 	| grep -v nfs \
@@ -234,12 +262,12 @@ filesystems=`ssh -n $username@$computer "cat /etc/fstab" \
 	| awk '{ if ( $(NF-1) != "0" ) print $2}' `
 
 # Clean up our dir at this client
-if ! ssh $username@$computer "rm -r $remotehome/.backup ; mkdir -m 700 $remotehome/.backup"; then
+if ! ssh -n $username@$computer "rm -r $remotehome/.backup ; mkdir -m 700 $remotehome/.backup"; then
 	diemsg "Could not create backup staging area at $computer:$remotehome/.backup"
 fi
 
 # Try to copy $exclude to $computer
-if ! scp $exclude $username@$computer:$remotehome/.backup/exclude > /dev/null; then
+if ! scp $exclude $username@$computer:$remotehome/.backup/exclude >&2; then
 	diemsg "Could not copy exclude.txt to $computer"
 fi
 
@@ -256,7 +284,7 @@ if [ -f $confdir/postexec.$computer ]; then
 fi
 
 # Try to run preexec if it exists
-if ! ssh $username@$computer "[ ! -f $remotehome/.backup/preexec ] || /bin/bash -x $remotehome/.backup/preexec" >&2; then
+if ! ssh -n $username@$computer "[ ! -f $remotehome/.backup/preexec ] || /bin/bash -x $remotehome/.backup/preexec" >&2; then
 	diemsg "Could not run $computer:$remotehome/.backup/preexec"
 fi
 
@@ -307,7 +335,7 @@ for filesystem in $filesystems; do
 
 	# Check if this box has a custom number of full backups
 	if [ -f $confdir/maksfulle.$computer.$sfilesystem ]; then
-		mf=$((`cat $confdir/maksfulle.$computer`+1))
+		mf=$((`cat $confdir/maksfulle.$computer.$sfilesystem`+1))
 	elif [ -f $confdir/maksfulle.$computer ] ; then
 		mf=$((`cat $confdir/maksfulle.$computer`+1))
 	else
@@ -332,7 +360,7 @@ for filesystem in $filesystems; do
 done
 
 # Try to run postexec if it exist
-if ! ssh $username@$computer "[ ! -f $remotehome/.backup/postexec ] || /bin/bash -x $remotehome/.backup/postexec" >&2; then
+if ! ssh -n $username@$computer "[ ! -f $remotehome/.backup/postexec ] || /bin/bash -x $remotehome/.backup/postexec" >&2; then
 	diemsg "Could not run $computer:$remotehome/.backup/postexec"
 fi