X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=bin%2Fvlc.c;h=d6fc5a820fa3f43ab0ea728f07d3e948f9de8bbc;hb=053f9d6ea00435633c3dcbf87041d868223c9ec7;hp=182a7edc6c3af332c45cc7a21330e3e2ca7e150a;hpb=3048882f57f5ec815fe21e1a803fddaff7a58f61;p=vlc diff --git a/bin/vlc.c b/bin/vlc.c index 182a7edc6c..d6fc5a820f 100644 --- a/bin/vlc.c +++ b/bin/vlc.c @@ -42,21 +42,44 @@ /* Explicit HACK */ extern void LocaleFree (const char *); extern char *FromLocale (const char *); +extern void vlc_enable_override (void); #include #include #include #include +#include /***************************************************************************** * main: parse command line, start interface and spawn threads. *****************************************************************************/ int main( int i_argc, const char *ppsz_argv[] ) { -#ifdef __APPLE__ - /* The so-called POSIX-compliant MacOS X is not. - * SIGPIPE fires even when it is blocked in all threads! */ + /* The so-called POSIX-compliant MacOS X reportedly processes SIGPIPE even + * if it is blocked in all thread. Also some libraries want SIGPIPE blocked + * as they have no clue about signal masks. + * Note: this is NOT an excuse for not protecting against SIGPIPE. If + * LibVLC runs outside of VLC, we cannot rely on this code snippet. */ signal (SIGPIPE, SIG_IGN); + +#ifdef HAVE_PUTENV +# ifndef NDEBUG + /* Activate malloc checking routines to detect heap corruptions. */ + putenv( (char*)"MALLOC_CHECK_=2" ); + + /* Disable the ugly Gnome crash dialog so that we properly segfault */ + putenv( (char *)"GNOME_DISABLE_CRASH_DIALOG=1" ); +# endif + + /* Make Xlib hide visuals with an alphachannel. Ensure that Qt4 will not + * use the alpha channel for the embedded video window. */ + putenv( (char *)"XLIB_SKIP_ARGB_VISUALS=1" ); +#endif +#ifdef HAVE_SETENV + /* Clear the X.Org startup notification ID. Otherwise the UI might try to + * change the environment while the process is multi-threaded. That could + * crash. Screw you X.Org. Next time write a thread-safe specification. */ + unsetenv ("DESKTOP_STARTUP_ID"); #endif #ifndef ALLOW_RUN_AS_ROOT @@ -78,16 +101,6 @@ int main( int i_argc, const char *ppsz_argv[] ) libvlc_get_version(), libvlc_get_changeset() ); #endif -#ifdef HAVE_PUTENV -# ifndef NDEBUG - /* Activate malloc checking routines to detect heap corruptions. */ - putenv( (char*)"MALLOC_CHECK_=2" ); - - /* Disable the ugly Gnome crash dialog so that we properly segfault */ - putenv( (char *)"GNOME_DISABLE_CRASH_DIALOG=1" ); -# endif -#endif - /* Synchronously intercepted POSIX signals. * * In a threaded program such as VLC, the only sane way to handle signals @@ -151,6 +164,8 @@ int main( int i_argc, const char *ppsz_argv[] ) return 1; // BOOM! argv[argc] = NULL; + vlc_enable_override (); + /* Initialize libvlc */ libvlc_instance_t *vlc = libvlc_new (argc, argv); @@ -172,5 +187,15 @@ int main( int i_argc, const char *ppsz_argv[] ) for (int i = 1; i < argc; i++) LocaleFree (argv[i]); +#ifdef RTLD_NOLOAD + /* Avoid crash in KIO scheduler cleanup. */ + /* This is ugly, but we get way too many crash reports due to this. */ + if (dlopen ("libkio.so.5", RTLD_LAZY|RTLD_LOCAL|RTLD_NOLOAD) != NULL) + { + fprintf (stderr, "KIO present. Unclean shutdown!\n" + " (see http://bugs.kde.org/show_bug.cgi?id=234484 for details)\n"); + _exit (0); + } +#endif return 0; }