X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=effects%2Ffrei0r_sopsat.xml;h=f4a9c1e3a5f00b391990192b0082bfdd370bb864;hb=4ae3260592acc87712db77b7d3fe0cc2be7d76bc;hp=130e66119e64016b8b38960d4d703aa348cb5a08;hpb=98ed961ae42ab3dc0676dc2b5a0da793207059b5;p=kdenlive

diff --git a/effects/frei0r_sopsat.xml b/effects/frei0r_sopsat.xml
index 130e6611..f4a9c1e3 100644
--- a/effects/frei0r_sopsat.xml
+++ b/effects/frei0r_sopsat.xml
@@ -1,49 +1,112 @@
 <!DOCTYPE kpartgui>
-<effect tag="frei0r.sopsat" id="frei0r.sopsat">
+<group>
+    <effect tag="frei0r.sopsat" id="frei0r.sopsat">
         <name>SOP/Sat</name>
         <description>Changes Slope, Offset, and Power of the color components, and the overall Saturation, according to the ASC CDL (Color Decision List).</description>
         <author>Simon A. Eugster (Granjow)</author>
-        <parameter type="constant" name="rSlope" default="100" min="0" max="1000" factor="100">
+        <parameter type="simplekeyframe" name="rSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Red</name>
+                <comment><![CDATA[Changing the slope means multiplying the pixel value with a constant value. Black pixels will remain black, whileas brighter ones will be changed.<br/>
+                All effects can be observed well when applied on a greyscale gradient and looking at the RGB Parade monitor.]]></comment>
         </parameter>
-        <parameter type="constant" name="gSlope" default="100" min="0" max="1000" factor="100">
+        <parameter type="simplekeyframe" name="gSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Green</name>
         </parameter>
-        <parameter type="constant" name="bSlope" default="100" min="0" max="1000" factor="100">
+        <parameter type="simplekeyframe" name="bSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Blue</name>
         </parameter>
-        <parameter type="constant" name="aSlope" default="100" min="0" max="1000" factor="100">
+        <parameter type="simplekeyframe" name="aSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Alpha</name>
         </parameter>
 
-        <parameter type="constant" name="rOffset" default="0" min="-1024" max="1024" factor="256">
+        <parameter type="simplekeyframe" name="rOffset" default="0" min="-1024" max="1024" factor="256">
                 <name>Offset Red</name>
+                <comment>Changing the offset lifts (or lowers) the brightness of each pixel by the given value.</comment>
         </parameter>
-        <parameter type="constant" name="gOffset" default="0" min="-1024" max="1024" factor="256">
+        <parameter type="simplekeyframe" name="gOffset" default="0" min="-1024" max="1024" factor="256">
                 <name>Offset Green</name>
         </parameter>
-        <parameter type="constant" name="bOffset" default="0" min="-1024" max="1024" factor="256">
+        <parameter type="simplekeyframe" name="bOffset" default="0" min="-1024" max="1024" factor="256">
                 <name>Offset Blue</name>
         </parameter>
-        <parameter type="constant" name="aOffset" default="0" min="-1024" max="1024" factor="256">
+        <parameter type="simplekeyframe" name="aOffset" default="0" min="-1024" max="1024" factor="256">
                 <name>Offset Alpha</name>
         </parameter>
 
-        <parameter type="constant" name="rPower" default="100" min="1" max="1000" factor="100">
-                <name>Power (Gamma) Red</name>
+        <parameter type="simplekeyframe" name="rPower" default="100" min="1" max="1000" factor="100">
+                <name>Power Red</name>
+                <comment><![CDATA[Changes the Gamma value for the selected channel. Black and white pixel values will not be affected, but everything between.<br/>
+                Mathematically, what happens is an exponentiation of the pixel brightness on <code>[0,1]</code> by the gamma value.]]></comment>
         </parameter>
-        <parameter type="constant" name="gPower" default="100" min="1" max="1000" factor="100">
-                <name>Power (Gamma) Green</name>
+        <parameter type="simplekeyframe" name="gPower" default="100" min="1" max="1000" factor="100">
+                <name>Power Green</name>
         </parameter>
-        <parameter type="constant" name="bPower" default="100" min="1" max="1000" factor="100">
-                <name>Power (Gamma) Blue</name>
+        <parameter type="simplekeyframe" name="bPower" default="100" min="1" max="1000" factor="100">
+                <name>Power Blue</name>
         </parameter>
-        <parameter type="constant" name="aPower" default="100" min="1" max="1000" factor="100">
-                <name>Power (Gamma) Alpha</name>
+        <parameter type="simplekeyframe" name="aPower" default="100" min="1" max="1000" factor="100">
+                <name>Power Alpha</name>
         </parameter>
 
-        <parameter type="constant" name="saturation" default="100" min="0" max="500" factor="100">
+        <parameter type="simplekeyframe" name="saturation" default="100" min="0" max="500" factor="100">
                 <name>Overall Saturation</name>
+                <comment>The overall saturation will be changed in the last step of this filter.</comment>
         </parameter>
 
-</effect>
+    </effect>
+
+    <effect LC_NUMERIC="C" tag="frei0r.sopsat" id="frei0r.sopsat" version="0.2">
+        <name>SOP/Sat</name>
+        <description>Changes Slope, Offset, and Power of the color components, and the overall Saturation, according to the ASC CDL (Color Decision List).</description>
+        <author>Simon A. Eugster (Granjow)</author>
+        <parameter type="simplekeyframe" name="rSlope" default="100" min="0" max="1000" factor="2000">
+                <name>Slope Red</name>
+                <comment><![CDATA[Changing the slope means multiplying the pixel value with a constant value. Black pixels will remain black, whileas brighter ones will be changed.<br/>
+                All effects can be observed well when applied on a greyscale gradient and looking at the RGB Parade monitor.]]></comment>
+        </parameter>
+        <parameter type="simplekeyframe" name="gSlope" default="100" min="0" max="1000" factor="2000">
+                <name>Slope Green</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="bSlope" default="100" min="0" max="1000" factor="2000">
+                <name>Slope Blue</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="aSlope" default="100" min="0" max="1000" factor="2000">
+                <name>Slope Alpha</name>
+        </parameter>
+
+        <parameter type="simplekeyframe" name="rOffset" default="0" min="-1024" max="1024" factor="2048" offset="-1024">
+                <name>Offset Red</name>
+                <comment>Changing the offset lifts (or lowers) the brightness of each pixel by the given value.</comment>
+        </parameter>
+        <parameter type="simplekeyframe" name="gOffset" default="0" min="-1024" max="1024" factor="2048" offset="-1024">
+                <name>Offset Green</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="bOffset" default="0" min="-1024" max="1024" factor="2048" offset="-1024">
+                <name>Offset Blue</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="aOffset" default="0" min="-1024" max="1024" factor="2048" offset="-1024">
+                <name>Offset Alpha</name>
+        </parameter>
+
+        <parameter type="simplekeyframe" name="rPower" default="100" min="1" max="1000" factor="2000">
+                <name>Power Red</name>
+                <comment><![CDATA[Changes the Gamma value for the selected channel. Black and white pixel values will not be affected, but everything between.<br/>
+                Mathematically, what happens is an exponentiation of the pixel brightness on <code>[0,1]</code> by the gamma value.]]></comment>
+        </parameter>
+        <parameter type="simplekeyframe" name="gPower" default="100" min="1" max="1000" factor="2000">
+                <name>Power Green</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="bPower" default="100" min="1" max="1000" factor="2000">
+                <name>Power Blue</name>
+        </parameter>
+        <parameter type="simplekeyframe" name="aPower" default="100" min="1" max="1000" factor="2000">
+                <name>Power Alpha</name>
+        </parameter>
+
+        <parameter type="simplekeyframe" name="saturation" default="100" min="0" max="500" factor="1000">
+                <name>Overall Saturation</name>
+                <comment>The overall saturation will be changed in the last step of this filter.</comment>
+        </parameter>
+
+    </effect>
+</group>