X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=encoder%2Fanalyse.c;h=e854da8c1f900f64392722f44f82dfe283a62ad7;hb=b9ce3a10bacb32af12756d4104d7d8ef255c140a;hp=424c5da11a190030620cc3505732834d5c6a890e;hpb=b8692db2efa98c719332979f6dc8fc39af8f1eff;p=x264 diff --git a/encoder/analyse.c b/encoder/analyse.c index 424c5da1..55dbfa02 100644 --- a/encoder/analyse.c +++ b/encoder/analyse.c @@ -1,11 +1,11 @@ /***************************************************************************** * analyse.c: h264 encoder library ***************************************************************************** - * Copyright (C) 2003 x264 project - * $Id: analyse.c,v 1.1 2004/06/03 19:27:08 fenrir Exp $ + * Copyright (C) 2003-2008 x264 project * * Authors: Laurent Aimar * Loren Merritt + * Fiona Glaser * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -19,15 +19,15 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111, USA. *****************************************************************************/ -#include -#include +#define _ISOC99_SOURCE #include -#include +#include #include "common/common.h" +#include "common/cpu.h" #include "macroblock.h" #include "me.h" #include "ratecontrol.h" @@ -43,8 +43,8 @@ typedef struct /* 8x8 */ int i_cost8x8; - int mvc[16][5][2]; /* [ref][0] is 16x16 mv, - [ref][1..4] are 8x8 mv from partition [0..3] */ + /* [ref][0] is 16x16 mv, [ref][1..4] are 8x8 mv from partition [0..3] */ + ALIGNED_4( int16_t mvc[32][5][2] ); x264_me_t me8x8[4]; /* Sub 4x4 */ @@ -57,7 +57,7 @@ typedef struct /* Sub 4x8 */ int i_cost4x8[4]; /* cost per 8x8 partition */ - x264_me_t me4x8[4][4]; + x264_me_t me4x8[4][2]; /* 16x8 */ int i_cost16x8; @@ -75,8 +75,10 @@ typedef struct int i_lambda; int i_lambda2; int i_qp; - int16_t *p_cost_mv; - int b_mbrd; + uint16_t *p_cost_mv; + uint16_t *p_cost_ref0; + uint16_t *p_cost_ref1; + int i_mbrd; /* I: Intra part */ @@ -90,14 +92,18 @@ typedef struct int i_predict16x16; int i_satd_i8x8; + int i_cbp_i8x8_luma; int i_satd_i8x8_dir[12][4]; int i_predict8x8[4]; int i_satd_i4x4; int i_predict4x4[16]; + int i_satd_pcm; + /* Chroma part */ int i_satd_i8x8chroma; + int i_satd_i8x8chroma_dir[4]; int i_predict8x8chroma; /* II: Inter part P/B frame */ @@ -126,7 +132,7 @@ typedef struct } x264_mb_analysis_t; /* lambda = pow(2,qp/6-2) */ -static const int i_qp0_cost_table[52] = { +const int x264_lambda_tab[52] = { 1, 1, 1, 1, 1, 1, 1, 1, /* 0-7 */ 1, 1, 1, 1, /* 8-11 */ 1, 1, 1, 1, 2, 2, 2, 2, /* 12-19 */ @@ -136,21 +142,85 @@ static const int i_qp0_cost_table[52] = { 40,45,51,57,64,72,81,91 /* 44-51 */ }; -/* pow(lambda,2) * .9 */ -static const int i_qp0_cost2_table[52] = { - 1, 1, 1, 1, 1, 1, /* 0-5 */ - 1, 1, 1, 1, 1, 1, /* 6-11 */ - 1, 1, 1, 2, 2, 3, /* 12-17 */ - 4, 5, 6, 7, 9, 11, /* 18-23 */ - 14, 18, 23, 29, 36, 46, /* 24-29 */ - 58, 73, 91, 115, 145, 183, /* 30-35 */ - 230, 290, 366, 461, 581, 731, /* 36-41 */ - 922,1161,1463,1843,2322,2926, /* 42-47 */ -3686,4645,5852,7373 +/* lambda2 = pow(lambda,2) * .9 * 256 */ +const int x264_lambda2_tab[52] = { + 14, 18, 22, 28, 36, 45, 57, 72, /* 0 - 7 */ + 91, 115, 145, 182, 230, 290, 365, 460, /* 8 - 15 */ + 580, 731, 921, 1161, 1462, 1843, 2322, 2925, /* 16 - 23 */ + 3686, 4644, 5851, 7372, 9289, 11703, 14745, 18578, /* 24 - 31 */ + 23407, 29491, 37156, 46814, 58982, 74313, 93628, 117964, /* 32 - 39 */ +148626, 187257, 235929, 297252, 374514, 471859, 594505, 749029, /* 40 - 47 */ +943718, 1189010, 1498059, 1887436 /* 48 - 51 */ +}; + +const uint8_t x264_exp2_lut[64] = { + 0, 3, 6, 8, 11, 14, 17, 20, 23, 26, 29, 32, 36, 39, 42, 45, + 48, 52, 55, 58, 62, 65, 69, 72, 76, 80, 83, 87, 91, 94, 98, 102, + 106, 110, 114, 118, 122, 126, 130, 135, 139, 143, 147, 152, 156, 161, 165, 170, + 175, 179, 184, 189, 194, 198, 203, 208, 214, 219, 224, 229, 234, 240, 245, 250 +}; + +const float x264_log2_lut[128] = { + 0.00000, 0.01123, 0.02237, 0.03342, 0.04439, 0.05528, 0.06609, 0.07682, + 0.08746, 0.09803, 0.10852, 0.11894, 0.12928, 0.13955, 0.14975, 0.15987, + 0.16993, 0.17991, 0.18982, 0.19967, 0.20945, 0.21917, 0.22882, 0.23840, + 0.24793, 0.25739, 0.26679, 0.27612, 0.28540, 0.29462, 0.30378, 0.31288, + 0.32193, 0.33092, 0.33985, 0.34873, 0.35755, 0.36632, 0.37504, 0.38370, + 0.39232, 0.40088, 0.40939, 0.41785, 0.42626, 0.43463, 0.44294, 0.45121, + 0.45943, 0.46761, 0.47573, 0.48382, 0.49185, 0.49985, 0.50779, 0.51570, + 0.52356, 0.53138, 0.53916, 0.54689, 0.55459, 0.56224, 0.56986, 0.57743, + 0.58496, 0.59246, 0.59991, 0.60733, 0.61471, 0.62205, 0.62936, 0.63662, + 0.64386, 0.65105, 0.65821, 0.66534, 0.67243, 0.67948, 0.68650, 0.69349, + 0.70044, 0.70736, 0.71425, 0.72110, 0.72792, 0.73471, 0.74147, 0.74819, + 0.75489, 0.76155, 0.76818, 0.77479, 0.78136, 0.78790, 0.79442, 0.80090, + 0.80735, 0.81378, 0.82018, 0.82655, 0.83289, 0.83920, 0.84549, 0.85175, + 0.85798, 0.86419, 0.87036, 0.87652, 0.88264, 0.88874, 0.89482, 0.90087, + 0.90689, 0.91289, 0.91886, 0.92481, 0.93074, 0.93664, 0.94251, 0.94837, + 0.95420, 0.96000, 0.96578, 0.97154, 0.97728, 0.98299, 0.98868, 0.99435, +}; + +/* Avoid an int/float conversion. */ +const float x264_log2_lz_lut[32] = { + 31,30,29,28,27,26,25,24,23,22,21,20,19,18,17,16,15,14,13,12,11,10,9,8,7,6,5,4,3,2,1,0 +}; + +// should the intra and inter lambdas be different? +// I'm just matching the behaviour of deadzone quant. +static const int x264_trellis_lambda2_tab[2][52] = { + // inter lambda = .85 * .85 * 2**(qp/3. + 10 - LAMBDA_BITS) + { 46, 58, 73, 92, 117, 147, + 185, 233, 294, 370, 466, 587, + 740, 932, 1174, 1480, 1864, 2349, + 2959, 3728, 4697, 5918, 7457, 9395, + 11837, 14914, 18790, 23674, 29828, 37581, + 47349, 59656, 75163, 94699, 119313, 150326, + 189399, 238627, 300652, 378798, 477255, 601304, + 757596, 954511, 1202608, 1515192, 1909022, 2405217, + 3030384, 3818045, 4810435, 6060769 }, + // intra lambda = .65 * .65 * 2**(qp/3. + 10 - LAMBDA_BITS) + { 27, 34, 43, 54, 68, 86, + 108, 136, 172, 216, 273, 343, + 433, 545, 687, 865, 1090, 1374, + 1731, 2180, 2747, 3461, 4361, 5494, + 6922, 8721, 10988, 13844, 17442, 21976, + 27688, 34885, 43953, 55377, 69771, 87906, + 110755, 139543, 175813, 221511, 279087, 351627, + 443023, 558174, 703255, 886046, 1116348, 1406511, + 1772093, 2232697, 2813022, 3544186 } +}; + +static const uint16_t x264_chroma_lambda2_offset_tab[] = { + 16, 20, 25, 32, 40, 50, + 64, 80, 101, 128, 161, 203, + 256, 322, 406, 512, 645, 812, + 1024, 1290, 1625, 2048, 2580, 3250, + 4096, 5160, 6501, 8192, 10321, 13003, + 16384, 20642, 26007, 32768, 41285, 52015, + 65535 }; /* TODO: calculate CABAC costs */ -static const int i_mb_b_cost_table[19] = { +static const int i_mb_b_cost_table[X264_MBTYPE_MAX] = { 9, 9, 9, 9, 0, 0, 0, 1, 3, 7, 7, 7, 3, 7, 7, 7, 5, 9, 0 }; static const int i_mb_b16x8_cost_table[17] = { @@ -165,44 +235,97 @@ static const int i_sub_mb_p_cost_table[4] = { static void x264_analyse_update_cache( x264_t *h, x264_mb_analysis_t *a ); -/* initialize an array of lambda*nbits for all possible mvs */ -static void x264_mb_analyse_load_costs( x264_t *h, x264_mb_analysis_t *a ) -{ - static int16_t *p_cost_mv[52]; +static uint16_t x264_cost_ref[92][3][33]; +static UNUSED x264_pthread_mutex_t cost_ref_mutex = X264_PTHREAD_MUTEX_INITIALIZER; - if( !p_cost_mv[a->i_qp] ) - { - /* could be faster, but isn't called many times */ - /* factor of 4 from qpel, 2 from sign, and 2 because mv can be opposite from mvp */ - int i; - p_cost_mv[a->i_qp] = x264_malloc( (4*4*2048 + 1) * sizeof(int16_t) ); - p_cost_mv[a->i_qp] += 2*4*2048; - for( i = 0; i <= 2*4*2048; i++ ) +int x264_analyse_init_costs( x264_t *h, int qp ) +{ + int i, j; + int lambda = x264_lambda_tab[qp]; + if( h->cost_mv[lambda] ) + return 0; + /* factor of 4 from qpel, 2 from sign, and 2 because mv can be opposite from mvp */ + CHECKED_MALLOC( h->cost_mv[lambda], (4*4*2048 + 1) * sizeof(uint16_t) ); + h->cost_mv[lambda] += 2*4*2048; + for( i = 0; i <= 2*4*2048; i++ ) + { + h->cost_mv[lambda][-i] = + h->cost_mv[lambda][i] = lambda * (log2f(i+1)*2 + 0.718f + !!i) + .5f; + } + x264_pthread_mutex_lock( &cost_ref_mutex ); + for( i = 0; i < 3; i++ ) + for( j = 0; j < 33; j++ ) + x264_cost_ref[lambda][i][j] = i ? lambda * bs_size_te( i, j ) : 0; + x264_pthread_mutex_unlock( &cost_ref_mutex ); + if( h->param.analyse.i_me_method >= X264_ME_ESA && !h->cost_mv_fpel[lambda][0] ) + { + for( j=0; j<4; j++ ) { - p_cost_mv[a->i_qp][-i] = - p_cost_mv[a->i_qp][i] = a->i_lambda * bs_size_se( i ); + CHECKED_MALLOC( h->cost_mv_fpel[lambda][j], (4*2048 + 1) * sizeof(uint16_t) ); + h->cost_mv_fpel[lambda][j] += 2*2048; + for( i = -2*2048; i < 2*2048; i++ ) + h->cost_mv_fpel[lambda][j][i] = h->cost_mv[lambda][i*4+j]; } } + return 0; +fail: + return -1; +} + +void x264_analyse_free_costs( x264_t *h ) +{ + int i, j; + for( i = 0; i < 92; i++ ) + { + if( h->cost_mv[i] ) + x264_free( h->cost_mv[i] - 2*4*2048 ); + if( h->cost_mv_fpel[i][0] ) + for( j = 0; j < 4; j++ ) + x264_free( h->cost_mv_fpel[i][j] - 2*2048 ); + } +} - a->p_cost_mv = p_cost_mv[a->i_qp]; +/* initialize an array of lambda*nbits for all possible mvs */ +static void x264_mb_analyse_load_costs( x264_t *h, x264_mb_analysis_t *a ) +{ + a->p_cost_mv = h->cost_mv[a->i_lambda]; + a->p_cost_ref0 = x264_cost_ref[a->i_lambda][x264_clip3(h->sh.i_num_ref_idx_l0_active-1,0,2)]; + a->p_cost_ref1 = x264_cost_ref[a->i_lambda][x264_clip3(h->sh.i_num_ref_idx_l1_active-1,0,2)]; } static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp ) { - memset( a, 0, sizeof( x264_mb_analysis_t ) ); + int i = h->param.analyse.i_subpel_refine - (h->sh.i_type == SLICE_TYPE_B); + + /* mbrd == 1 -> RD mode decision */ + /* mbrd == 2 -> RD refinement */ + /* mbrd == 3 -> QPRD */ + a->i_mbrd = (i>=6) + (i>=8) + (h->param.analyse.i_subpel_refine>=10); /* conduct the analysis using this lamda and QP */ a->i_qp = h->mb.i_qp = i_qp; - a->i_lambda = i_qp0_cost_table[i_qp]; - a->i_lambda2 = i_qp0_cost2_table[i_qp]; - a->b_mbrd = h->param.analyse.i_subpel_refine >= 6 && - ( h->sh.i_type != SLICE_TYPE_B || h->param.analyse.b_bframe_rdo ); + h->mb.i_chroma_qp = h->chroma_qp_table[i_qp]; + + a->i_lambda = x264_lambda_tab[i_qp]; + a->i_lambda2 = x264_lambda2_tab[i_qp]; + + h->mb.b_trellis = h->param.analyse.i_trellis > 1 && a->i_mbrd; + if( h->param.analyse.i_trellis ) + { + h->mb.i_trellis_lambda2[0][0] = x264_trellis_lambda2_tab[0][h->mb.i_qp]; + h->mb.i_trellis_lambda2[0][1] = x264_trellis_lambda2_tab[1][h->mb.i_qp]; + h->mb.i_trellis_lambda2[1][0] = x264_trellis_lambda2_tab[0][h->mb.i_chroma_qp]; + h->mb.i_trellis_lambda2[1][1] = x264_trellis_lambda2_tab[1][h->mb.i_chroma_qp]; + } + h->mb.i_psy_rd_lambda = a->i_lambda; + /* Adjusting chroma lambda based on QP offset hurts PSNR but improves visual quality. */ + h->mb.i_chroma_lambda2_offset = h->param.analyse.b_psy ? x264_chroma_lambda2_offset_tab[h->mb.i_qp-h->mb.i_chroma_qp+12] : 256; h->mb.i_me_method = h->param.analyse.i_me_method; h->mb.i_subpel_refine = h->param.analyse.i_subpel_refine; h->mb.b_chroma_me = h->param.analyse.b_chroma_me && h->sh.i_type == SLICE_TYPE_P && h->mb.i_subpel_refine >= 5; - h->mb.b_trellis = h->param.analyse.i_trellis > 1 && a->b_mbrd; + h->mb.b_transform_8x8 = 0; h->mb.b_noise_reduction = 0; @@ -212,30 +335,94 @@ static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp ) a->i_satd_i4x4 = a->i_satd_i8x8chroma = COST_MAX; + /* non-RD PCM decision is inaccurate (as is psy-rd), so don't do it */ + a->i_satd_pcm = !h->mb.i_psy_rd && a->i_mbrd ? ((uint64_t)X264_PCM_COST*a->i_lambda2 + 128) >> 8 : COST_MAX; + a->b_fast_intra = 0; + h->mb.i_skip_intra = + h->mb.b_lossless ? 0 : + a->i_mbrd ? 2 : + !h->param.analyse.i_trellis && !h->param.analyse.i_noise_reduction; /* II: Inter part P/B frame */ if( h->sh.i_type != SLICE_TYPE_I ) { - int i; - int i_fmv_range = h->param.analyse.i_mv_range - 16; + int i, j; + int i_fmv_range = 4 * h->param.analyse.i_mv_range; + // limit motion search to a slightly smaller range than the theoretical limit, + // since the search may go a few iterations past its given range + int i_fpel_border = 6; // umh: 1 for diamond, 2 for octagon, 2 for hpel /* Calculate max allowed MV range */ -#define CLIP_FMV(mv) x264_clip3( mv, -i_fmv_range, i_fmv_range ) +#define CLIP_FMV(mv) x264_clip3( mv, -i_fmv_range, i_fmv_range-1 ) h->mb.mv_min[0] = 4*( -16*h->mb.i_mb_x - 24 ); h->mb.mv_max[0] = 4*( 16*( h->sps->i_mb_width - h->mb.i_mb_x - 1 ) + 24 ); - h->mb.mv_min_fpel[0] = CLIP_FMV( -16*h->mb.i_mb_x - 8 ); - h->mb.mv_max_fpel[0] = CLIP_FMV( 16*( h->sps->i_mb_width - h->mb.i_mb_x - 1 ) + 8 ); - h->mb.mv_min_spel[0] = 4*( h->mb.mv_min_fpel[0] - 16 ); - h->mb.mv_max_spel[0] = 4*( h->mb.mv_max_fpel[0] + 16 ); + h->mb.mv_min_spel[0] = CLIP_FMV( h->mb.mv_min[0] ); + h->mb.mv_max_spel[0] = CLIP_FMV( h->mb.mv_max[0] ); + h->mb.mv_min_fpel[0] = (h->mb.mv_min_spel[0]>>2) + i_fpel_border; + h->mb.mv_max_fpel[0] = (h->mb.mv_max_spel[0]>>2) - i_fpel_border; if( h->mb.i_mb_x == 0) { - h->mb.mv_min[1] = 4*( -16*h->mb.i_mb_y - 24 ); - h->mb.mv_max[1] = 4*( 16*( h->sps->i_mb_height - h->mb.i_mb_y - 1 ) + 24 ); - h->mb.mv_min_fpel[1] = CLIP_FMV( -16*h->mb.i_mb_y - 8 ); - h->mb.mv_max_fpel[1] = CLIP_FMV( 16*( h->sps->i_mb_height - h->mb.i_mb_y - 1 ) + 8 ); - h->mb.mv_min_spel[1] = 4*( h->mb.mv_min_fpel[1] - 16 ); - h->mb.mv_max_spel[1] = 4*( h->mb.mv_max_fpel[1] + 16 ); + int mb_y = h->mb.i_mb_y >> h->sh.b_mbaff; + int mb_height = h->sps->i_mb_height >> h->sh.b_mbaff; + int thread_mvy_range = i_fmv_range; + + if( h->param.i_threads > 1 ) + { + int pix_y = (h->mb.i_mb_y | h->mb.b_interlaced) * 16; + int thresh = pix_y + h->param.analyse.i_mv_range_thread; + for( i = (h->sh.i_type == SLICE_TYPE_B); i >= 0; i-- ) + { + x264_frame_t **fref = i ? h->fref1 : h->fref0; + int i_ref = i ? h->i_ref1 : h->i_ref0; + for( j=0; jorig, thresh ); + thread_mvy_range = X264_MIN( thread_mvy_range, fref[j]->orig->i_lines_completed - pix_y ); + } + } + + if( h->param.b_deterministic ) + thread_mvy_range = h->param.analyse.i_mv_range_thread; + if( h->mb.b_interlaced ) + thread_mvy_range >>= 1; + + for( j=0; ji_ref0; j++ ) + { + if( h->sh.weight[j][0].weightfn ) + { + x264_frame_t *frame = h->fref0[j]; + int width = frame->i_width[0] + 2*PADH; + int i_padv = PADV << h->param.b_interlaced; + int offset, height; + uint8_t *src = frame->filtered[0] - frame->i_stride[0]*i_padv - PADH; + int k; + height = X264_MIN( 16 + thread_mvy_range + pix_y + i_padv, h->fref0[j]->i_lines[0] + i_padv*2 ) - h->fenc->i_lines_weighted; + offset = h->fenc->i_lines_weighted*frame->i_stride[0]; + h->fenc->i_lines_weighted += height; + if( height ) + { + for( k = j; k < h->i_ref0; k++ ) + if( h->sh.weight[k][0].weightfn ) + { + uint8_t *dst = h->fenc->weighted[k] - h->fenc->i_stride[0]*i_padv - PADH; + x264_weight_scale_plane( h, dst + offset, frame->i_stride[0], + src + offset, frame->i_stride[0], + width, height, &h->sh.weight[k][0] ); + } + } + break; + } + } + } + + h->mb.mv_min[1] = 4*( -16*mb_y - 24 ); + h->mb.mv_max[1] = 4*( 16*( mb_height - mb_y - 1 ) + 24 ); + h->mb.mv_min_spel[1] = x264_clip3( h->mb.mv_min[1], -i_fmv_range, i_fmv_range ); + h->mb.mv_max_spel[1] = CLIP_FMV( h->mb.mv_max[1] ); + h->mb.mv_max_spel[1] = X264_MIN( h->mb.mv_max_spel[1], thread_mvy_range*4 ); + h->mb.mv_min_fpel[1] = (h->mb.mv_min_spel[1]>>2) + i_fpel_border; + h->mb.mv_max_fpel[1] = (h->mb.mv_max_spel[1]>>2) - i_fpel_border; } #undef CLIP_FMV @@ -295,6 +482,7 @@ static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp ) a->b_fast_intra = 1; } } + h->mb.b_skip_mc = 0; } } @@ -306,23 +494,30 @@ static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp ) /* Max = 4 */ static void predict_16x16_mode_available( unsigned int i_neighbour, int *mode, int *pi_count ) { - if( i_neighbour & MB_TOPLEFT ) + int b_top = i_neighbour & MB_TOP; + int b_left = i_neighbour & MB_LEFT; + if( b_top && b_left ) { - /* top and left avaible */ + /* top and left available */ *mode++ = I_PRED_16x16_V; *mode++ = I_PRED_16x16_H; *mode++ = I_PRED_16x16_DC; - *mode++ = I_PRED_16x16_P; - *pi_count = 4; + *pi_count = 3; + if( i_neighbour & MB_TOPLEFT ) + { + /* top left available*/ + *mode++ = I_PRED_16x16_P; + *pi_count = 4; + } } - else if( i_neighbour & MB_LEFT ) + else if( b_left ) { /* left available*/ *mode++ = I_PRED_16x16_DC_LEFT; *mode++ = I_PRED_16x16_H; *pi_count = 2; } - else if( i_neighbour & MB_TOP ) + else if( b_top ) { /* top available*/ *mode++ = I_PRED_16x16_DC_TOP; @@ -331,7 +526,7 @@ static void predict_16x16_mode_available( unsigned int i_neighbour, int *mode, i } else { - /* none avaible */ + /* none available */ *mode = I_PRED_16x16_DC_128; *pi_count = 1; } @@ -340,23 +535,30 @@ static void predict_16x16_mode_available( unsigned int i_neighbour, int *mode, i /* Max = 4 */ static void predict_8x8chroma_mode_available( unsigned int i_neighbour, int *mode, int *pi_count ) { - if( i_neighbour & MB_TOPLEFT ) + int b_top = i_neighbour & MB_TOP; + int b_left = i_neighbour & MB_LEFT; + if( b_top && b_left ) { - /* top and left avaible */ + /* top and left available */ *mode++ = I_PRED_CHROMA_V; *mode++ = I_PRED_CHROMA_H; *mode++ = I_PRED_CHROMA_DC; - *mode++ = I_PRED_CHROMA_P; - *pi_count = 4; + *pi_count = 3; + if( i_neighbour & MB_TOPLEFT ) + { + /* top left available */ + *mode++ = I_PRED_CHROMA_P; + *pi_count = 4; + } } - else if( i_neighbour & MB_LEFT ) + else if( b_left ) { /* left available*/ *mode++ = I_PRED_CHROMA_DC_LEFT; *mode++ = I_PRED_CHROMA_H; *pi_count = 2; } - else if( i_neighbour & MB_TOP ) + else if( b_top ) { /* top available*/ *mode++ = I_PRED_CHROMA_DC_TOP; @@ -365,7 +567,7 @@ static void predict_8x8chroma_mode_available( unsigned int i_neighbour, int *mod } else { - /* none avaible */ + /* none available */ *mode = I_PRED_CHROMA_DC_128; *pi_count = 1; } @@ -375,10 +577,9 @@ static void predict_8x8chroma_mode_available( unsigned int i_neighbour, int *mod static void predict_4x4_mode_available( unsigned int i_neighbour, int *mode, int *pi_count ) { - int b_l = i_neighbour & MB_LEFT; - int b_t = i_neighbour & MB_TOP; - - if( b_l && b_t ) + int b_top = i_neighbour & MB_TOP; + int b_left = i_neighbour & MB_LEFT; + if( b_top && b_left ) { *pi_count = 6; *mode++ = I_PRED_4x4_DC; @@ -395,14 +596,14 @@ static void predict_4x4_mode_available( unsigned int i_neighbour, *mode++ = I_PRED_4x4_VL; *mode++ = I_PRED_4x4_HU; } - else if( b_l ) + else if( b_left ) { *mode++ = I_PRED_4x4_DC_LEFT; *mode++ = I_PRED_4x4_H; *mode++ = I_PRED_4x4_HU; *pi_count = 3; } - else if( b_t ) + else if( b_top ) { *mode++ = I_PRED_4x4_DC_TOP; *mode++ = I_PRED_4x4_V; @@ -417,12 +618,65 @@ static void predict_4x4_mode_available( unsigned int i_neighbour, } } +/* For trellis=2, we need to do this for both sizes of DCT, for trellis=1 we only need to use it on the chosen mode. */ +static void inline x264_psy_trellis_init( x264_t *h, int do_both_dct ) +{ + ALIGNED_ARRAY_16( int16_t, dct8x8,[4],[64] ); + ALIGNED_ARRAY_16( int16_t, dct4x4,[16],[16] ); + ALIGNED_16( static uint8_t zero[16*FDEC_STRIDE] ) = {0}; + int i; + + if( do_both_dct || h->mb.b_transform_8x8 ) + { + h->dctf.sub16x16_dct8( dct8x8, h->mb.pic.p_fenc[0], zero ); + for( i = 0; i < 4; i++ ) + h->zigzagf.scan_8x8( h->mb.pic.fenc_dct8[i], dct8x8[i] ); + } + if( do_both_dct || !h->mb.b_transform_8x8 ) + { + h->dctf.sub16x16_dct( dct4x4, h->mb.pic.p_fenc[0], zero ); + for( i = 0; i < 16; i++ ) + h->zigzagf.scan_4x4( h->mb.pic.fenc_dct4[i], dct4x4[i] ); + } +} + +/* Pre-calculate fenc satd scores for psy RD, minus DC coefficients */ +static inline void x264_mb_cache_fenc_satd( x264_t *h ) +{ + ALIGNED_16( static uint8_t zero[16] ) = {0}; + uint8_t *fenc; + int x, y, satd_sum = 0, sa8d_sum = 0; + if( h->param.analyse.i_trellis == 2 && h->mb.i_psy_trellis ) + x264_psy_trellis_init( h, h->param.analyse.b_transform_8x8 ); + if( !h->mb.i_psy_rd ) + return; + for( y = 0; y < 4; y++ ) + for( x = 0; x < 4; x++ ) + { + fenc = h->mb.pic.p_fenc[0]+x*4+y*4*FENC_STRIDE; + h->mb.pic.fenc_satd[y][x] = h->pixf.satd[PIXEL_4x4]( zero, 0, fenc, FENC_STRIDE ) + - (h->pixf.sad[PIXEL_4x4]( zero, 0, fenc, FENC_STRIDE )>>1); + satd_sum += h->mb.pic.fenc_satd[y][x]; + } + for( y = 0; y < 2; y++ ) + for( x = 0; x < 2; x++ ) + { + fenc = h->mb.pic.p_fenc[0]+x*8+y*8*FENC_STRIDE; + h->mb.pic.fenc_sa8d[y][x] = h->pixf.sa8d[PIXEL_8x8]( zero, 0, fenc, FENC_STRIDE ) + - (h->pixf.sad[PIXEL_8x8]( zero, 0, fenc, FENC_STRIDE )>>2); + sa8d_sum += h->mb.pic.fenc_sa8d[y][x]; + } + h->mb.pic.fenc_satd_sum = satd_sum; + h->mb.pic.fenc_sa8d_sum = sa8d_sum; +} + static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *a ) { int i; int i_max; int predict_mode[4]; + int b_merged_satd = !!h->pixf.intra_mbcmp_x3_8x8c && !h->mb.b_lossless; uint8_t *p_dstc[2], *p_srcc[2]; @@ -435,25 +689,27 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *a ) p_srcc[0] = h->mb.pic.p_fenc[1]; p_srcc[1] = h->mb.pic.p_fenc[2]; - predict_8x8chroma_mode_available( h->mb.i_neighbour, predict_mode, &i_max ); + predict_8x8chroma_mode_available( h->mb.i_neighbour_intra, predict_mode, &i_max ); a->i_satd_i8x8chroma = COST_MAX; - if( i_max == 4 && h->pixf.intra_satd_x3_8x8c && h->pixf.mbcmp[0] == h->pixf.satd[0] ) + if( i_max == 4 && b_merged_satd ) { int satdu[4], satdv[4]; - h->pixf.intra_satd_x3_8x8c( p_srcc[0], p_dstc[0], satdu ); - h->pixf.intra_satd_x3_8x8c( p_srcc[1], p_dstc[1], satdv ); + h->pixf.intra_mbcmp_x3_8x8c( p_srcc[0], p_dstc[0], satdu ); + h->pixf.intra_mbcmp_x3_8x8c( p_srcc[1], p_dstc[1], satdv ); h->predict_8x8c[I_PRED_CHROMA_P]( p_dstc[0] ); h->predict_8x8c[I_PRED_CHROMA_P]( p_dstc[1] ); satdu[I_PRED_CHROMA_P] = h->pixf.mbcmp[PIXEL_8x8]( p_dstc[0], FDEC_STRIDE, p_srcc[0], FENC_STRIDE ); satdv[I_PRED_CHROMA_P] = h->pixf.mbcmp[PIXEL_8x8]( p_dstc[1], FDEC_STRIDE, p_srcc[1], FENC_STRIDE ); - + for( i=0; ii_lambda * bs_size_ue(i_mode); + + a->i_satd_i8x8chroma_dir[i] = i_satd; COPY2_IF_LT( a->i_satd_i8x8chroma, i_satd, a->i_predict8x8chroma, i_mode ); } } @@ -465,8 +721,13 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *a ) int i_mode = predict_mode[i]; /* we do the prediction */ - h->predict_8x8c[i_mode]( p_dstc[0] ); - h->predict_8x8c[i_mode]( p_dstc[1] ); + if( h->mb.b_lossless ) + x264_predict_lossless_8x8_chroma( h, i_mode ); + else + { + h->predict_8x8c[i_mode]( p_dstc[0] ); + h->predict_8x8c[i_mode]( p_dstc[1] ); + } /* we calculate the cost */ i_satd = h->pixf.mbcmp[PIXEL_8x8]( p_dstc[0], FDEC_STRIDE, @@ -475,6 +736,7 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *a ) p_srcc[1], FENC_STRIDE ) + a->i_lambda * bs_size_ue( x264_mb_pred_mode8x8c_fix[i_mode] ); + a->i_satd_i8x8chroma_dir[i] = i_satd; COPY2_IF_LT( a->i_satd_i8x8chroma, i_satd, a->i_predict8x8chroma, i_mode ); } } @@ -491,16 +753,16 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ int i, idx; int i_max; int predict_mode[9]; - int b_merged_satd = h->pixf.intra_satd_x3_16x16 && h->pixf.mbcmp[0] == h->pixf.satd[0]; + int b_merged_satd = !!h->pixf.intra_mbcmp_x3_16x16 && !h->mb.b_lossless; /*---------------- Try all mode and calculate their score ---------------*/ /* 16x16 prediction selection */ - predict_16x16_mode_available( h->mb.i_neighbour, predict_mode, &i_max ); + predict_16x16_mode_available( h->mb.i_neighbour_intra, predict_mode, &i_max ); if( b_merged_satd && i_max == 4 ) { - h->pixf.intra_satd_x3_16x16( p_src, p_dst, a->i_satd_i16x16_dir ); + h->pixf.intra_mbcmp_x3_16x16( p_src, p_dst, a->i_satd_i16x16_dir ); h->predict_16x16[I_PRED_16x16_P]( p_dst ); a->i_satd_i16x16_dir[I_PRED_16x16_P] = h->pixf.mbcmp[PIXEL_16x16]( p_dst, FDEC_STRIDE, p_src, FENC_STRIDE ); @@ -516,7 +778,11 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ { int i_satd; int i_mode = predict_mode[i]; - h->predict_16x16[i_mode]( p_dst ); + + if( h->mb.b_lossless ) + x264_predict_lossless_16x16( h, i_mode ); + else + h->predict_16x16[i_mode]( p_dst ); i_satd = h->pixf.mbcmp[PIXEL_16x16]( p_dst, FDEC_STRIDE, p_src, FENC_STRIDE ) + a->i_lambda * bs_size_ue( x264_mb_pred_mode16x16_fix[i_mode] ); @@ -534,11 +800,12 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ /* 8x8 prediction selection */ if( flags & X264_ANALYSE_I8x8 ) { - DECLARE_ALIGNED( uint8_t, edge[33], 8 ); - x264_pixel_cmp_t sa8d = (*h->pixf.mbcmp == *h->pixf.sad) ? h->pixf.sad[PIXEL_8x8] : h->pixf.sa8d[PIXEL_8x8]; - int i_satd_thresh = a->b_mbrd ? COST_MAX : X264_MIN( i_satd_inter, a->i_satd_i16x16 ); + ALIGNED_ARRAY_16( uint8_t, edge,[33] ); + x264_pixel_cmp_t sa8d = (h->pixf.mbcmp[0] == h->pixf.satd[0]) ? h->pixf.sa8d[PIXEL_8x8] : h->pixf.mbcmp[PIXEL_8x8]; + int i_satd_thresh = a->i_mbrd ? COST_MAX : X264_MIN( i_satd_inter, a->i_satd_i16x16 ); int i_cost = 0; - b_merged_satd = h->pixf.intra_sa8d_x3_8x8 && h->pixf.mbcmp[0] == h->pixf.satd[0]; + h->mb.i_cbp_luma = 0; + b_merged_satd = h->pixf.intra_mbcmp_x3_8x8 && !h->mb.b_lossless; // FIXME some bias like in i4x4? if( h->sh.i_type == SLICE_TYPE_B ) @@ -554,14 +821,13 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ int i_pred_mode = x264_mb_predict_intra4x4_mode( h, 4*idx ); predict_4x4_mode_available( h->mb.i_neighbour8[idx], predict_mode, &i_max ); - x264_predict_8x8_filter( p_dst_by, edge, h->mb.i_neighbour8[idx], ALL_NEIGHBORS ); + h->predict_8x8_filter( p_dst_by, edge, h->mb.i_neighbour8[idx], ALL_NEIGHBORS ); if( b_merged_satd && i_max == 9 ) { - int satd[3]; - h->pixf.intra_sa8d_x3_8x8( p_src_by, edge, satd ); - if( i_pred_mode < 3 ) - satd[i_pred_mode] -= 3 * a->i_lambda; + int satd[9]; + h->pixf.intra_mbcmp_x3_8x8( p_src_by, edge, satd ); + satd[i_pred_mode] -= 3 * a->i_lambda; for( i=2; i>=0; i-- ) { int cost = a->i_satd_i8x8_dir[i][idx] = satd[i] + 4 * a->i_lambda; @@ -577,10 +843,14 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ int i_satd; int i_mode = predict_mode[i]; - h->predict_8x8[i_mode]( p_dst_by, edge ); + if( h->mb.b_lossless ) + x264_predict_lossless_8x8( h, p_dst_by, idx, i_mode, edge ); + else + h->predict_8x8[i_mode]( p_dst_by, edge ); - i_satd = sa8d( p_dst_by, FDEC_STRIDE, p_src_by, FENC_STRIDE ) - + a->i_lambda * (i_pred_mode == x264_mb_pred_mode4x4_fix(i_mode) ? 1 : 4); + i_satd = sa8d( p_dst_by, FDEC_STRIDE, p_src_by, FENC_STRIDE ) + a->i_lambda * 4; + if( i_pred_mode == x264_mb_pred_mode4x4_fix(i_mode) ) + i_satd -= a->i_lambda * 3; COPY2_IF_LT( i_best, i_satd, a->i_predict8x8[idx], i_mode ); a->i_satd_i8x8_dir[i_mode][idx] = i_satd; @@ -598,13 +868,27 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ } if( idx == 3 ) + { a->i_satd_i8x8 = i_cost; + if( h->mb.i_skip_intra ) + { + h->mc.copy[PIXEL_16x16]( h->mb.pic.i8x8_fdec_buf, 16, p_dst, FDEC_STRIDE, 16 ); + h->mb.pic.i8x8_nnz_buf[0] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 0]] ); + h->mb.pic.i8x8_nnz_buf[1] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 2]] ); + h->mb.pic.i8x8_nnz_buf[2] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 8]] ); + h->mb.pic.i8x8_nnz_buf[3] = M32( &h->mb.cache.non_zero_count[x264_scan8[10]] ); + h->mb.pic.i8x8_cbp = h->mb.i_cbp_luma; + if( h->mb.i_skip_intra == 2 ) + h->mc.memcpy_aligned( h->mb.pic.i8x8_dct_buf, h->dct.luma8x8, sizeof(h->mb.pic.i8x8_dct_buf) ); + } + } else { + static const uint16_t cost_div_fix8[3] = {1024,512,341}; a->i_satd_i8x8 = COST_MAX; - i_cost = i_cost * 4/(idx+1); + i_cost = (i_cost * cost_div_fix8[idx]) >> 8; } - if( X264_MIN(i_cost, a->i_satd_i16x16) > i_satd_inter*(5+a->b_mbrd)/4 ) + if( X264_MIN(i_cost, a->i_satd_i16x16) > i_satd_inter*(5+!!a->i_mbrd)/4 ) return; } @@ -613,8 +897,9 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ { int i_cost; int i_satd_thresh = X264_MIN3( i_satd_inter, a->i_satd_i16x16, a->i_satd_i8x8 ); - b_merged_satd = h->pixf.intra_satd_x3_4x4 && h->pixf.mbcmp[0] == h->pixf.satd[0]; - if( a->b_mbrd ) + h->mb.i_cbp_luma = 0; + b_merged_satd = h->pixf.intra_mbcmp_x3_4x4 && !h->mb.b_lossless; + if( a->i_mbrd ) i_satd_thresh = i_satd_thresh * (10-a->b_fast_intra)/8; i_cost = a->i_lambda * 24; /* from JVT (SATD0) */ @@ -623,10 +908,8 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ for( idx = 0;; idx++ ) { - int x = block_idx_x[idx]; - int y = block_idx_y[idx]; - uint8_t *p_src_by = p_src + 4*x + 4*y*FENC_STRIDE; - uint8_t *p_dst_by = p_dst + 4*x + 4*y*FDEC_STRIDE; + uint8_t *p_src_by = p_src + block_idx_xy_fenc[idx]; + uint8_t *p_dst_by = p_dst + block_idx_xy_fdec[idx]; int i_best = COST_MAX; int i_pred_mode = x264_mb_predict_intra4x4_mode( h, idx ); @@ -634,17 +917,15 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ if( (h->mb.i_neighbour4[idx] & (MB_TOPRIGHT|MB_TOP)) == MB_TOP ) /* emulate missing topright samples */ - *(uint32_t*) &p_dst_by[4 - FDEC_STRIDE] = p_dst_by[3 - FDEC_STRIDE] * 0x01010101U; + M32( &p_dst_by[4 - FDEC_STRIDE] ) = p_dst_by[3 - FDEC_STRIDE] * 0x01010101U; if( b_merged_satd && i_max >= 6 ) { - int satd[3]; - h->pixf.intra_satd_x3_4x4( p_src_by, p_dst_by, satd ); - if( i_pred_mode < 3 ) - satd[i_pred_mode] -= 3 * a->i_lambda; + int satd[9]; + h->pixf.intra_mbcmp_x3_4x4( p_src_by, p_dst_by, satd ); + satd[i_pred_mode] -= 3 * a->i_lambda; for( i=2; i>=0; i-- ) - COPY2_IF_LT( i_best, satd[i] + 4 * a->i_lambda, - a->i_predict4x4[idx], i ); + COPY2_IF_LT( i_best, satd[i], a->i_predict4x4[idx], i ); i = 3; } else @@ -654,16 +935,18 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ { int i_satd; int i_mode = predict_mode[i]; + if( h->mb.b_lossless ) + x264_predict_lossless_4x4( h, p_dst_by, idx, i_mode ); + else + h->predict_4x4[i_mode]( p_dst_by ); - h->predict_4x4[i_mode]( p_dst_by ); - - i_satd = h->pixf.mbcmp[PIXEL_4x4]( p_dst_by, FDEC_STRIDE, - p_src_by, FENC_STRIDE ) - + a->i_lambda * (i_pred_mode == x264_mb_pred_mode4x4_fix(i_mode) ? 1 : 4); + i_satd = h->pixf.mbcmp[PIXEL_4x4]( p_dst_by, FDEC_STRIDE, p_src_by, FENC_STRIDE ); + if( i_pred_mode == x264_mb_pred_mode4x4_fix(i_mode) ) + i_satd -= a->i_lambda * 3; COPY2_IF_LT( i_best, i_satd, a->i_predict4x4[idx], i_mode ); } - i_cost += i_best; + i_cost += i_best + 4 * a->i_lambda; if( i_cost > i_satd_thresh || idx == 15 ) break; @@ -675,7 +958,20 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *a, int i_satd_ h->mb.cache.intra4x4_pred_mode[x264_scan8[idx]] = a->i_predict4x4[idx]; } if( idx == 15 ) + { a->i_satd_i4x4 = i_cost; + if( h->mb.i_skip_intra ) + { + h->mc.copy[PIXEL_16x16]( h->mb.pic.i4x4_fdec_buf, 16, p_dst, FDEC_STRIDE, 16 ); + h->mb.pic.i4x4_nnz_buf[0] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 0]] ); + h->mb.pic.i4x4_nnz_buf[1] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 2]] ); + h->mb.pic.i4x4_nnz_buf[2] = M32( &h->mb.cache.non_zero_count[x264_scan8[ 8]] ); + h->mb.pic.i4x4_nnz_buf[3] = M32( &h->mb.cache.non_zero_count[x264_scan8[10]] ); + h->mb.pic.i4x4_cbp = h->mb.i_cbp_luma; + if( h->mb.i_skip_intra == 2 ) + h->mc.memcpy_aligned( h->mb.pic.i4x4_dct_buf, h->dct.luma4x4, sizeof(h->mb.pic.i4x4_dct_buf) ); + } + } else a->i_satd_i4x4 = COST_MAX; } @@ -706,6 +1002,7 @@ static void x264_intra_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd_thresh ) h->mb.i_type = I_8x8; x264_analyse_update_cache( h, a ); a->i_satd_i8x8 = x264_rd_cost_mb( h, a->i_lambda2 ); + a->i_cbp_i8x8_luma = h->mb.i_cbp_luma; } else a->i_satd_i8x8 = COST_MAX; @@ -713,20 +1010,20 @@ static void x264_intra_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd_thresh ) static void x264_intra_rd_refine( x264_t *h, x264_mb_analysis_t *a ) { - uint8_t *p_src = h->mb.pic.p_fenc[0]; uint8_t *p_dst = h->mb.pic.p_fdec[0]; - int i, idx, x, y; - int i_max, i_satd, i_best, i_mode; - int i_pred_mode; + int i, j, idx, x, y; + int i_max, i_mode, i_thresh; + uint64_t i_satd, i_best; int predict_mode[9]; + h->mb.i_skip_intra = 0; if( h->mb.i_type == I_16x16 ) { int old_pred_mode = a->i_predict16x16; - int i_thresh = a->i_satd_i16x16_dir[old_pred_mode] * 9/8; + i_thresh = a->i_satd_i16x16_dir[old_pred_mode] * 9/8; i_best = a->i_satd_i16x16; - predict_16x16_mode_available( h->mb.i_neighbour, predict_mode, &i_max ); + predict_16x16_mode_available( h->mb.i_neighbour_intra, predict_mode, &i_max ); for( i = 0; i < i_max; i++ ) { int i_mode = predict_mode[i]; @@ -737,50 +1034,90 @@ static void x264_intra_rd_refine( x264_t *h, x264_mb_analysis_t *a ) COPY2_IF_LT( i_best, i_satd, a->i_predict16x16, i_mode ); } } - else if( h->mb.i_type == I_4x4 ) + + /* RD selection for chroma prediction */ + predict_8x8chroma_mode_available( h->mb.i_neighbour_intra, predict_mode, &i_max ); + if( i_max > 1 ) + { + i_thresh = a->i_satd_i8x8chroma * 5/4; + + for( i = j = 0; i < i_max; i++ ) + if( a->i_satd_i8x8chroma_dir[i] < i_thresh && + predict_mode[i] != a->i_predict8x8chroma ) + { + predict_mode[j++] = predict_mode[i]; + } + i_max = j; + + if( i_max > 0 ) + { + int i_cbp_chroma_best = h->mb.i_cbp_chroma; + int i_chroma_lambda = x264_lambda2_tab[h->mb.i_chroma_qp]; + /* the previous thing encoded was x264_intra_rd(), so the pixels and + * coefs for the current chroma mode are still around, so we only + * have to recount the bits. */ + i_best = x264_rd_cost_i8x8_chroma( h, i_chroma_lambda, a->i_predict8x8chroma, 0 ); + for( i = 0; i < i_max; i++ ) + { + i_mode = predict_mode[i]; + if( h->mb.b_lossless ) + x264_predict_lossless_8x8_chroma( h, i_mode ); + else + { + h->predict_8x8c[i_mode]( h->mb.pic.p_fdec[1] ); + h->predict_8x8c[i_mode]( h->mb.pic.p_fdec[2] ); + } + /* if we've already found a mode that needs no residual, then + * probably any mode with a residual will be worse. + * so avoid dct on the remaining modes to improve speed. */ + i_satd = x264_rd_cost_i8x8_chroma( h, i_chroma_lambda, i_mode, h->mb.i_cbp_chroma != 0x00 ); + COPY3_IF_LT( i_best, i_satd, a->i_predict8x8chroma, i_mode, i_cbp_chroma_best, h->mb.i_cbp_chroma ); + } + h->mb.i_chroma_pred_mode = a->i_predict8x8chroma; + h->mb.i_cbp_chroma = i_cbp_chroma_best; + } + } + + if( h->mb.i_type == I_4x4 ) { uint32_t pels[4] = {0}; // doesn't need initting, just shuts up a gcc warning int i_nnz = 0; for( idx = 0; idx < 16; idx++ ) { - uint8_t *p_src_by; - uint8_t *p_dst_by; - i_best = COST_MAX; + uint8_t *p_dst_by = p_dst + block_idx_xy_fdec[idx]; + i_best = COST_MAX64; - i_pred_mode = x264_mb_predict_intra4x4_mode( h, idx ); - x = block_idx_x[idx]; - y = block_idx_y[idx]; - - p_src_by = p_src + 4*x + 4*y*FENC_STRIDE; - p_dst_by = p_dst + 4*x + 4*y*FDEC_STRIDE; predict_4x4_mode_available( h->mb.i_neighbour4[idx], predict_mode, &i_max ); if( (h->mb.i_neighbour4[idx] & (MB_TOPRIGHT|MB_TOP)) == MB_TOP ) /* emulate missing topright samples */ - *(uint32_t*) &p_dst_by[4 - FDEC_STRIDE] = p_dst_by[3 - FDEC_STRIDE] * 0x01010101U; + M32( &p_dst_by[4 - FDEC_STRIDE] ) = p_dst_by[3 - FDEC_STRIDE] * 0x01010101U; for( i = 0; i < i_max; i++ ) { i_mode = predict_mode[i]; - h->predict_4x4[i_mode]( p_dst_by ); + if( h->mb.b_lossless ) + x264_predict_lossless_4x4( h, p_dst_by, idx, i_mode ); + else + h->predict_4x4[i_mode]( p_dst_by ); i_satd = x264_rd_cost_i4x4( h, a->i_lambda2, idx, i_mode ); if( i_best > i_satd ) { a->i_predict4x4[idx] = i_mode; i_best = i_satd; - pels[0] = *(uint32_t*)(p_dst_by+0*FDEC_STRIDE); - pels[1] = *(uint32_t*)(p_dst_by+1*FDEC_STRIDE); - pels[2] = *(uint32_t*)(p_dst_by+2*FDEC_STRIDE); - pels[3] = *(uint32_t*)(p_dst_by+3*FDEC_STRIDE); + pels[0] = M32( p_dst_by+0*FDEC_STRIDE ); + pels[1] = M32( p_dst_by+1*FDEC_STRIDE ); + pels[2] = M32( p_dst_by+2*FDEC_STRIDE ); + pels[3] = M32( p_dst_by+3*FDEC_STRIDE ); i_nnz = h->mb.cache.non_zero_count[x264_scan8[idx]]; } } - *(uint32_t*)(p_dst_by+0*FDEC_STRIDE) = pels[0]; - *(uint32_t*)(p_dst_by+1*FDEC_STRIDE) = pels[1]; - *(uint32_t*)(p_dst_by+2*FDEC_STRIDE) = pels[2]; - *(uint32_t*)(p_dst_by+3*FDEC_STRIDE) = pels[3]; + M32( p_dst_by+0*FDEC_STRIDE ) = pels[0]; + M32( p_dst_by+1*FDEC_STRIDE ) = pels[1]; + M32( p_dst_by+2*FDEC_STRIDE ) = pels[2]; + M32( p_dst_by+3*FDEC_STRIDE ) = pels[3]; h->mb.cache.non_zero_count[x264_scan8[idx]] = i_nnz; h->mb.cache.intra4x4_pred_mode[x264_scan8[idx]] = a->i_predict4x4[idx]; @@ -788,55 +1125,58 @@ static void x264_intra_rd_refine( x264_t *h, x264_mb_analysis_t *a ) } else if( h->mb.i_type == I_8x8 ) { - DECLARE_ALIGNED( uint8_t, edge[33], 8 ); + ALIGNED_ARRAY_16( uint8_t, edge,[33] ); for( idx = 0; idx < 4; idx++ ) { uint64_t pels_h = 0; uint8_t pels_v[7]; - int i_nnz[3]; - uint8_t *p_src_by; + uint16_t i_nnz[2] = {0}; //shut up gcc uint8_t *p_dst_by; int j; - int i_thresh = a->i_satd_i8x8_dir[a->i_predict8x8[idx]][idx] * 11/8; + int cbp_luma_new = 0; + i_thresh = a->i_satd_i8x8_dir[a->i_predict8x8[idx]][idx] * 11/8; - i_best = COST_MAX; - i_pred_mode = x264_mb_predict_intra4x4_mode( h, 4*idx ); + i_best = COST_MAX64; x = idx&1; y = idx>>1; - p_src_by = p_src + 8*x + 8*y*FENC_STRIDE; p_dst_by = p_dst + 8*x + 8*y*FDEC_STRIDE; predict_4x4_mode_available( h->mb.i_neighbour8[idx], predict_mode, &i_max ); - x264_predict_8x8_filter( p_dst_by, edge, h->mb.i_neighbour8[idx], ALL_NEIGHBORS ); + h->predict_8x8_filter( p_dst_by, edge, h->mb.i_neighbour8[idx], ALL_NEIGHBORS ); for( i = 0; i < i_max; i++ ) { i_mode = predict_mode[i]; if( a->i_satd_i8x8_dir[i_mode][idx] > i_thresh ) continue; - h->predict_8x8[i_mode]( p_dst_by, edge ); + if( h->mb.b_lossless ) + x264_predict_lossless_8x8( h, p_dst_by, idx, i_mode, edge ); + else + h->predict_8x8[i_mode]( p_dst_by, edge ); + h->mb.i_cbp_luma = a->i_cbp_i8x8_luma; i_satd = x264_rd_cost_i8x8( h, a->i_lambda2, idx, i_mode ); if( i_best > i_satd ) { a->i_predict8x8[idx] = i_mode; + cbp_luma_new = h->mb.i_cbp_luma; i_best = i_satd; - pels_h = *(uint64_t*)(p_dst_by+7*FDEC_STRIDE); + pels_h = M64( p_dst_by+7*FDEC_STRIDE ); if( !(idx&1) ) for( j=0; j<7; j++ ) pels_v[j] = p_dst_by[7+j*FDEC_STRIDE]; - for( j=0; j<3; j++ ) - i_nnz[j] = h->mb.cache.non_zero_count[x264_scan8[4*idx+j+1]]; + i_nnz[0] = M16( &h->mb.cache.non_zero_count[x264_scan8[4*idx+0]] ); + i_nnz[1] = M16( &h->mb.cache.non_zero_count[x264_scan8[4*idx+2]] ); } } - - *(uint64_t*)(p_dst_by+7*FDEC_STRIDE) = pels_h; + a->i_cbp_i8x8_luma = cbp_luma_new; + M64( p_dst_by+7*FDEC_STRIDE ) = pels_h; if( !(idx&1) ) for( j=0; j<7; j++ ) p_dst_by[7+j*FDEC_STRIDE] = pels_v[j]; - for( j=0; j<3; j++ ) - h->mb.cache.non_zero_count[x264_scan8[4*idx+j+1]] = i_nnz[j]; + M16( &h->mb.cache.non_zero_count[x264_scan8[4*idx+0]] ) = i_nnz[0]; + M16( &h->mb.cache.non_zero_count[x264_scan8[4*idx+2]] ) = i_nnz[1]; x264_macroblock_cache_intra8x8_pred( h, 2*x, 2*y, a->i_predict8x8[idx] ); } @@ -844,6 +1184,7 @@ static void x264_intra_rd_refine( x264_t *h, x264_mb_analysis_t *a ) } #define LOAD_FENC( m, src, xoff, yoff) \ + (m)->p_cost_mv = a->p_cost_mv; \ (m)->i_stride[0] = h->mb.pic.i_stride[0]; \ (m)->i_stride[1] = h->mb.pic.i_stride[1]; \ (m)->p_fenc[0] = &(src)[0][(xoff)+(yoff)*FENC_STRIDE]; \ @@ -851,84 +1192,90 @@ static void x264_intra_rd_refine( x264_t *h, x264_mb_analysis_t *a ) (m)->p_fenc[2] = &(src)[2][((xoff)>>1)+((yoff)>>1)*FENC_STRIDE]; #define LOAD_HPELS(m, src, list, ref, xoff, yoff) \ - (m)->p_fref[0] = &(src)[0][(xoff)+(yoff)*(m)->i_stride[0]]; \ + (m)->p_fref_w = (m)->p_fref[0] = &(src)[0][(xoff)+(yoff)*(m)->i_stride[0]]; \ (m)->p_fref[1] = &(src)[1][(xoff)+(yoff)*(m)->i_stride[0]]; \ (m)->p_fref[2] = &(src)[2][(xoff)+(yoff)*(m)->i_stride[0]]; \ (m)->p_fref[3] = &(src)[3][(xoff)+(yoff)*(m)->i_stride[0]]; \ (m)->p_fref[4] = &(src)[4][((xoff)>>1)+((yoff)>>1)*(m)->i_stride[1]]; \ (m)->p_fref[5] = &(src)[5][((xoff)>>1)+((yoff)>>1)*(m)->i_stride[1]]; \ - (m)->integral = &h->mb.pic.p_integral[list][ref][(xoff)+(yoff)*(m)->i_stride[0]]; + (m)->integral = &h->mb.pic.p_integral[list][ref][(xoff)+(yoff)*(m)->i_stride[0]]; \ + (m)->weight = weight_none; \ + (m)->i_ref = ref; + +#define LOAD_WPELS(m, src, list, ref, xoff, yoff) \ + (m)->p_fref_w = &(src)[(xoff)+(yoff)*(m)->i_stride[0]]; \ + (m)->weight = h->sh.weight[i_ref]; #define REF_COST(list, ref) \ - (a->i_lambda * bs_size_te( h->sh.i_num_ref_idx_l##list##_active - 1, ref )) + (a->p_cost_ref##list[ref]) static void x264_mb_analyse_inter_p16x16( x264_t *h, x264_mb_analysis_t *a ) { x264_me_t m; - int i_ref; - int mvc[7][2], i_mvc; + int i_ref, i_mvc; + ALIGNED_4( int16_t mvc[8][2] ); int i_halfpel_thresh = INT_MAX; - int *p_halfpel_thresh = h->i_ref0>1 ? &i_halfpel_thresh : NULL; + int *p_halfpel_thresh = h->mb.pic.i_fref[0]>1 ? &i_halfpel_thresh : NULL; /* 16x16 Search on all ref frame */ m.i_pixel = PIXEL_16x16; - m.p_cost_mv = a->p_cost_mv; LOAD_FENC( &m, h->mb.pic.p_fenc, 0, 0 ); a->l0.me16x16.cost = INT_MAX; - for( i_ref = 0; i_ref < h->i_ref0; i_ref++ ) + for( i_ref = 0; i_ref < h->mb.pic.i_fref[0]; i_ref++ ) { const int i_ref_cost = REF_COST( 0, i_ref ); i_halfpel_thresh -= i_ref_cost; m.i_ref_cost = i_ref_cost; - m.i_ref = i_ref; /* search with ref */ LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 0, 0 ); + LOAD_WPELS( &m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 0, 0 ); + x264_mb_predict_mv_16x16( h, 0, i_ref, m.mvp ); x264_mb_predict_mv_ref16x16( h, 0, i_ref, mvc, &i_mvc ); x264_me_search_ref( h, &m, mvc, i_mvc, p_halfpel_thresh ); /* early termination * SSD threshold would probably be better than SATD */ - if( i_ref == 0 && a->b_try_pskip && m.cost-m.cost_mv < 300*a->i_lambda ) + if( i_ref == 0 + && a->b_try_pskip + && m.cost-m.cost_mv < 300*a->i_lambda + && abs(m.mv[0]-h->mb.cache.pskip_mv[0]) + + abs(m.mv[1]-h->mb.cache.pskip_mv[1]) <= 1 + && x264_macroblock_probe_pskip( h ) ) { - int mvskip[2]; - x264_mb_predict_mv_pskip( h, mvskip ); - if( abs(m.mv[0]-mvskip[0]) + abs(m.mv[1]-mvskip[1]) <= 1 - && x264_macroblock_probe_pskip( h ) ) - { - h->mb.i_type = P_SKIP; - x264_analyse_update_cache( h, a ); - return; - } + h->mb.i_type = P_SKIP; + x264_analyse_update_cache( h, a ); + assert( h->mb.cache.pskip_mv[1] <= h->mb.mv_max_spel[1] || h->param.i_threads == 1 ); + return; } m.cost += i_ref_cost; i_halfpel_thresh += i_ref_cost; if( m.cost < a->l0.me16x16.cost ) - a->l0.me16x16 = m; + h->mc.memcpy_aligned( &a->l0.me16x16, &m, sizeof(x264_me_t) ); /* save mv for predicting neighbors */ - a->l0.mvc[i_ref][0][0] = - h->mb.mvr[0][i_ref][h->mb.i_mb_xy][0] = m.mv[0]; - a->l0.mvc[i_ref][0][1] = - h->mb.mvr[0][i_ref][h->mb.i_mb_xy][1] = m.mv[1]; + CP32( a->l0.mvc[i_ref][0], m.mv ); + CP32( h->mb.mvr[0][i_ref][h->mb.i_mb_xy], m.mv ); } x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, a->l0.me16x16.i_ref ); + assert( a->l0.me16x16.mv[1] <= h->mb.mv_max_spel[1] || h->param.i_threads == 1 ); h->mb.i_type = P_L0; - if( a->b_mbrd && a->l0.i_ref == 0 ) + if( a->i_mbrd ) { - int mvskip[2]; - x264_mb_predict_mv_pskip( h, mvskip ); - if( a->l0.me16x16.mv[0] == mvskip[0] && a->l0.me16x16.mv[1] == mvskip[1] ) + x264_mb_cache_fenc_satd( h ); + if( a->l0.me16x16.i_ref == 0 && M32( a->l0.me16x16.mv ) == M32( h->mb.cache.pskip_mv ) ) { h->mb.i_partition = D_16x16; - x264_macroblock_cache_mv( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv[0], a->l0.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv ); a->l0.i_rd16x16 = x264_rd_cost_mb( h, a->i_lambda2 ); + if( !(h->mb.i_cbp_luma|h->mb.i_cbp_chroma) ) + h->mb.i_type = P_SKIP; } } } @@ -939,9 +1286,9 @@ static void x264_mb_analyse_inter_p8x8_mixed_ref( x264_t *h, x264_mb_analysis_t int i_ref; uint8_t **p_fenc = h->mb.pic.p_fenc; int i_halfpel_thresh = INT_MAX; - int *p_halfpel_thresh = /*h->i_ref0>1 ? &i_halfpel_thresh : */NULL; + int *p_halfpel_thresh = /*h->mb.pic.i_fref[0]>1 ? &i_halfpel_thresh : */NULL; int i; - int i_maxref = h->i_ref0-1; + int i_maxref = h->mb.pic.i_fref[0]-1; h->mb.i_partition = D_8x8; @@ -960,10 +1307,7 @@ static void x264_mb_analyse_inter_p8x8_mixed_ref( x264_t *h, x264_mb_analysis_t } for( i_ref = 0; i_ref <= i_maxref; i_ref++ ) - { - a->l0.mvc[i_ref][0][0] = h->mb.mvr[0][i_ref][h->mb.i_mb_xy][0]; - a->l0.mvc[i_ref][0][1] = h->mb.mvr[0][i_ref][h->mb.i_mb_xy][1]; - } + CP32( a->l0.mvc[i_ref][0], h->mb.mvr[0][i_ref][h->mb.i_mb_xy] ); for( i = 0; i < 4; i++ ) { @@ -972,38 +1316,44 @@ static void x264_mb_analyse_inter_p8x8_mixed_ref( x264_t *h, x264_mb_analysis_t const int y8 = i/2; m.i_pixel = PIXEL_8x8; - m.p_cost_mv = a->p_cost_mv; LOAD_FENC( &m, p_fenc, 8*x8, 8*y8 ); l0m->cost = INT_MAX; for( i_ref = 0; i_ref <= i_maxref; i_ref++ ) { - const int i_ref_cost = REF_COST( 0, i_ref ); - i_halfpel_thresh -= i_ref_cost; - m.i_ref_cost = i_ref_cost; - m.i_ref = i_ref; - - LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 8*x8, 8*y8 ); - x264_macroblock_cache_ref( h, 2*x8, 2*y8, 2, 2, 0, i_ref ); - x264_mb_predict_mv( h, 0, 4*i, 2, m.mvp ); - x264_me_search_ref( h, &m, a->l0.mvc[i_ref], i+1, p_halfpel_thresh ); - - m.cost += i_ref_cost; - i_halfpel_thresh += i_ref_cost; - *(uint64_t*)a->l0.mvc[i_ref][i+1] = *(uint64_t*)m.mv; - - if( m.cost < l0m->cost ) - *l0m = m; + const int i_ref_cost = REF_COST( 0, i_ref ); + i_halfpel_thresh -= i_ref_cost; + m.i_ref_cost = i_ref_cost; + + LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 8*x8, 8*y8 ); + LOAD_WPELS( &m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 8*x8, 8*y8 ); + + x264_macroblock_cache_ref( h, 2*x8, 2*y8, 2, 2, 0, i_ref ); + x264_mb_predict_mv( h, 0, 4*i, 2, m.mvp ); + x264_me_search_ref( h, &m, a->l0.mvc[i_ref], i+1, p_halfpel_thresh ); + + m.cost += i_ref_cost; + i_halfpel_thresh += i_ref_cost; + CP32( a->l0.mvc[i_ref][i+1], m.mv ); + + if( m.cost < l0m->cost ) + h->mc.memcpy_aligned( l0m, &m, sizeof(x264_me_t) ); } - x264_macroblock_cache_mv( h, 2*x8, 2*y8, 2, 2, 0, l0m->mv[0], l0m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, 2*x8, 2*y8, 2, 2, 0, l0m->mv ); x264_macroblock_cache_ref( h, 2*x8, 2*y8, 2, 2, 0, l0m->i_ref ); - /* mb type cost */ - l0m->cost += a->i_lambda * i_sub_mb_p_cost_table[D_L0_8x8]; + /* If CABAC is on and we're not doing sub-8x8 analysis, the costs + are effectively zero. */ + if( !h->param.b_cabac || (h->param.analyse.inter & X264_ANALYSE_PSUB8x8) ) + l0m->cost += a->i_lambda * i_sub_mb_p_cost_table[D_L0_8x8]; } a->l0.i_cost8x8 = a->l0.me8x8[0].cost + a->l0.me8x8[1].cost + a->l0.me8x8[2].cost + a->l0.me8x8[3].cost; + /* P_8x8 ref0 has no ref cost */ + if( !h->param.b_cabac && !(a->l0.me8x8[0].i_ref | a->l0.me8x8[1].i_ref | + a->l0.me8x8[2].i_ref | a->l0.me8x8[3].i_ref) ) + a->l0.i_cost8x8 -= REF_COST( 0, 0 ) * 4; h->mb.i_sub_partition[0] = h->mb.i_sub_partition[1] = h->mb.i_sub_partition[2] = h->mb.i_sub_partition[3] = D_L0_8x8; } @@ -1011,18 +1361,17 @@ static void x264_mb_analyse_inter_p8x8_mixed_ref( x264_t *h, x264_mb_analysis_t static void x264_mb_analyse_inter_p8x8( x264_t *h, x264_mb_analysis_t *a ) { const int i_ref = a->l0.me16x16.i_ref; - const int i_ref_cost = REF_COST( 0, i_ref ); - uint8_t **p_fref = h->mb.pic.p_fref[0][i_ref]; + const int i_ref_cost = h->param.b_cabac || i_ref ? REF_COST( 0, i_ref ) : 0; uint8_t **p_fenc = h->mb.pic.p_fenc; int i_mvc; - int (*mvc)[2] = a->l0.mvc[i_ref]; + int16_t (*mvc)[2] = a->l0.mvc[i_ref]; int i; /* XXX Needed for x264_mb_predict_mv */ h->mb.i_partition = D_8x8; i_mvc = 1; - *(uint64_t*)mvc[0] = *(uint64_t*)a->l0.me16x16.mv; + CP32( mvc[0], a->l0.me16x16.mv ); for( i = 0; i < 4; i++ ) { @@ -1031,30 +1380,32 @@ static void x264_mb_analyse_inter_p8x8( x264_t *h, x264_mb_analysis_t *a ) const int y8 = i/2; m->i_pixel = PIXEL_8x8; - m->p_cost_mv = a->p_cost_mv; m->i_ref_cost = i_ref_cost; - m->i_ref = i_ref; LOAD_FENC( m, p_fenc, 8*x8, 8*y8 ); - LOAD_HPELS( m, p_fref, 0, i_ref, 8*x8, 8*y8 ); + LOAD_HPELS( m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 8*x8, 8*y8 ); + LOAD_WPELS( m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 8*x8, 8*y8 ); + x264_mb_predict_mv( h, 0, 4*i, 2, m->mvp ); x264_me_search( h, m, mvc, i_mvc ); - x264_macroblock_cache_mv( h, 2*x8, 2*y8, 2, 2, 0, m->mv[0], m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, 2*x8, 2*y8, 2, 2, 0, m->mv ); - *(uint64_t*)mvc[i_mvc] = *(uint64_t*)m->mv; + CP32( mvc[i_mvc], m->mv ); i_mvc++; /* mb type cost */ m->cost += i_ref_cost; - m->cost += a->i_lambda * i_sub_mb_p_cost_table[D_L0_8x8]; + if( !h->param.b_cabac || (h->param.analyse.inter & X264_ANALYSE_PSUB8x8) ) + m->cost += a->i_lambda * i_sub_mb_p_cost_table[D_L0_8x8]; } + a->l0.i_cost8x8 = a->l0.me8x8[0].cost + a->l0.me8x8[1].cost + + a->l0.me8x8[2].cost + a->l0.me8x8[3].cost; /* theoretically this should include 4*ref_cost, * but 3 seems a better approximation of cabac. */ - a->l0.i_cost8x8 = a->l0.me8x8[0].cost + a->l0.me8x8[1].cost + - a->l0.me8x8[2].cost + a->l0.me8x8[3].cost - - REF_COST( 0, a->l0.me16x16.i_ref ); + if( h->param.b_cabac ) + a->l0.i_cost8x8 -= i_ref_cost; h->mb.i_sub_partition[0] = h->mb.i_sub_partition[1] = h->mb.i_sub_partition[2] = h->mb.i_sub_partition[3] = D_L0_8x8; } @@ -1063,7 +1414,7 @@ static void x264_mb_analyse_inter_p16x8( x264_t *h, x264_mb_analysis_t *a ) { x264_me_t m; uint8_t **p_fenc = h->mb.pic.p_fenc; - int mvc[3][2]; + ALIGNED_4( int16_t mvc[3][2] ); int i, j; /* XXX Needed for x264_mb_predict_mv */ @@ -1076,33 +1427,33 @@ static void x264_mb_analyse_inter_p16x8( x264_t *h, x264_mb_analysis_t *a ) const int i_ref8s = ( ref8[0] == ref8[1] ) ? 1 : 2; m.i_pixel = PIXEL_16x8; - m.p_cost_mv = a->p_cost_mv; LOAD_FENC( &m, p_fenc, 0, 8*i ); l0m->cost = INT_MAX; for( j = 0; j < i_ref8s; j++ ) { - const int i_ref = ref8[j]; - const int i_ref_cost = REF_COST( 0, i_ref ); - m.i_ref_cost = i_ref_cost; - m.i_ref = i_ref; + const int i_ref = ref8[j]; + const int i_ref_cost = REF_COST( 0, i_ref ); + m.i_ref_cost = i_ref_cost; + + /* if we skipped the 16x16 predictor, we wouldn't have to copy anything... */ + CP32( mvc[0], a->l0.mvc[i_ref][0] ); + CP32( mvc[1], a->l0.mvc[i_ref][2*i+1] ); + CP32( mvc[2], a->l0.mvc[i_ref][2*i+2] ); - /* if we skipped the 16x16 predictor, we wouldn't have to copy anything... */ - *(uint64_t*)mvc[0] = *(uint64_t*)a->l0.mvc[i_ref][0]; - *(uint64_t*)mvc[1] = *(uint64_t*)a->l0.mvc[i_ref][2*i+1]; - *(uint64_t*)mvc[2] = *(uint64_t*)a->l0.mvc[i_ref][2*i+2]; + LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 0, 8*i ); + LOAD_WPELS( &m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 0, 8*i ); - LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 0, 8*i ); - x264_macroblock_cache_ref( h, 0, 2*i, 4, 2, 0, i_ref ); - x264_mb_predict_mv( h, 0, 8*i, 4, m.mvp ); - x264_me_search( h, &m, mvc, 3 ); + x264_macroblock_cache_ref( h, 0, 2*i, 4, 2, 0, i_ref ); + x264_mb_predict_mv( h, 0, 8*i, 4, m.mvp ); + x264_me_search( h, &m, mvc, 3 ); - m.cost += i_ref_cost; + m.cost += i_ref_cost; - if( m.cost < l0m->cost ) - *l0m = m; + if( m.cost < l0m->cost ) + h->mc.memcpy_aligned( l0m, &m, sizeof(x264_me_t) ); } - x264_macroblock_cache_mv( h, 0, 2*i, 4, 2, 0, l0m->mv[0], l0m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 2*i, 4, 2, 0, l0m->mv ); x264_macroblock_cache_ref( h, 0, 2*i, 4, 2, 0, l0m->i_ref ); } @@ -1113,7 +1464,7 @@ static void x264_mb_analyse_inter_p8x16( x264_t *h, x264_mb_analysis_t *a ) { x264_me_t m; uint8_t **p_fenc = h->mb.pic.p_fenc; - int mvc[3][2]; + ALIGNED_4( int16_t mvc[3][2] ); int i, j; /* XXX Needed for x264_mb_predict_mv */ @@ -1126,32 +1477,32 @@ static void x264_mb_analyse_inter_p8x16( x264_t *h, x264_mb_analysis_t *a ) const int i_ref8s = ( ref8[0] == ref8[1] ) ? 1 : 2; m.i_pixel = PIXEL_8x16; - m.p_cost_mv = a->p_cost_mv; LOAD_FENC( &m, p_fenc, 8*i, 0 ); l0m->cost = INT_MAX; for( j = 0; j < i_ref8s; j++ ) { - const int i_ref = ref8[j]; - const int i_ref_cost = REF_COST( 0, i_ref ); - m.i_ref_cost = i_ref_cost; - m.i_ref = i_ref; + const int i_ref = ref8[j]; + const int i_ref_cost = REF_COST( 0, i_ref ); + m.i_ref_cost = i_ref_cost; - *(uint64_t*)mvc[0] = *(uint64_t*)a->l0.mvc[i_ref][0]; - *(uint64_t*)mvc[1] = *(uint64_t*)a->l0.mvc[i_ref][i+1]; - *(uint64_t*)mvc[2] = *(uint64_t*)a->l0.mvc[i_ref][i+3]; + CP32( mvc[0], a->l0.mvc[i_ref][0] ); + CP32( mvc[1], a->l0.mvc[i_ref][i+1] ); + CP32( mvc[2], a->l0.mvc[i_ref][i+3] ); - LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 8*i, 0 ); - x264_macroblock_cache_ref( h, 2*i, 0, 2, 4, 0, i_ref ); - x264_mb_predict_mv( h, 0, 4*i, 2, m.mvp ); - x264_me_search( h, &m, mvc, 3 ); + LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 8*i, 0 ); + LOAD_WPELS( &m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 8*i, 0 ); - m.cost += i_ref_cost; + x264_macroblock_cache_ref( h, 2*i, 0, 2, 4, 0, i_ref ); + x264_mb_predict_mv( h, 0, 4*i, 2, m.mvp ); + x264_me_search( h, &m, mvc, 3 ); - if( m.cost < l0m->cost ) - *l0m = m; + m.cost += i_ref_cost; + + if( m.cost < l0m->cost ) + h->mc.memcpy_aligned( l0m, &m, sizeof(x264_me_t) ); } - x264_macroblock_cache_mv( h, 2*i, 0, 2, 4, 0, l0m->mv[0], l0m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, 2*i, 0, 2, 4, 0, l0m->mv ); x264_macroblock_cache_ref( h, 2*i, 0, 2, 4, 0, l0m->i_ref ); } @@ -1160,36 +1511,47 @@ static void x264_mb_analyse_inter_p8x16( x264_t *h, x264_mb_analysis_t *a ) static int x264_mb_analyse_inter_p4x4_chroma( x264_t *h, x264_mb_analysis_t *a, uint8_t **p_fref, int i8x8, int pixel ) { - DECLARE_ALIGNED( uint8_t, pix1[8*8], 8 ); - DECLARE_ALIGNED( uint8_t, pix2[8*8], 8 ); + ALIGNED_8( uint8_t pix1[16*8] ); + uint8_t *pix2 = pix1+8; const int i_stride = h->mb.pic.i_stride[1]; const int or = 4*(i8x8&1) + 2*(i8x8&2)*i_stride; const int oe = 4*(i8x8&1) + 2*(i8x8&2)*FENC_STRIDE; + const int i_ref = a->l0.me8x8[i8x8].i_ref; + const int mvy_offset = h->mb.b_interlaced & i_ref ? (h->mb.i_mb_y & 1)*4 - 2 : 0; + x264_weight_t *weight = h->sh.weight[i_ref]; #define CHROMA4x4MC( width, height, me, x, y ) \ - h->mc.mc_chroma( &p_fref[4][or+x+y*i_stride], i_stride, &pix1[x+y*8], 8, (me).mv[0], (me).mv[1], width, height ); \ - h->mc.mc_chroma( &p_fref[5][or+x+y*i_stride], i_stride, &pix2[x+y*8], 8, (me).mv[0], (me).mv[1], width, height ); + h->mc.mc_chroma( &pix1[x+y*16], 16, &p_fref[4][or+x+y*i_stride], i_stride, (me).mv[0], (me).mv[1]+mvy_offset, width, height ); \ + if( weight[1].weightfn ) \ + weight[1].weightfn[width>>2]( &pix1[x+y*16], 16, &pix1[x+y*16], 16, &weight[1], height ); \ + h->mc.mc_chroma( &pix2[x+y*16], 16, &p_fref[5][or+x+y*i_stride], i_stride, (me).mv[0], (me).mv[1]+mvy_offset, width, height ); \ + if( weight[2].weightfn ) \ + weight[1].weightfn[width>>2]( &pix2[x+y*16], 16, &pix2[x+y*16], 16, &weight[2], height ); + if( pixel == PIXEL_4x4 ) { - CHROMA4x4MC( 2,2, a->l0.me4x4[i8x8][0], 0,0 ); - CHROMA4x4MC( 2,2, a->l0.me4x4[i8x8][1], 0,2 ); - CHROMA4x4MC( 2,2, a->l0.me4x4[i8x8][2], 2,0 ); - CHROMA4x4MC( 2,2, a->l0.me4x4[i8x8][3], 2,2 ); + x264_me_t *m = a->l0.me4x4[i8x8]; + CHROMA4x4MC( 2,2, m[0], 0,0 ); + CHROMA4x4MC( 2,2, m[1], 2,0 ); + CHROMA4x4MC( 2,2, m[2], 0,2 ); + CHROMA4x4MC( 2,2, m[3], 2,2 ); } else if( pixel == PIXEL_8x4 ) { - CHROMA4x4MC( 4,2, a->l0.me8x4[i8x8][0], 0,0 ); - CHROMA4x4MC( 4,2, a->l0.me8x4[i8x8][1], 0,2 ); + x264_me_t *m = a->l0.me8x4[i8x8]; + CHROMA4x4MC( 4,2, m[0], 0,0 ); + CHROMA4x4MC( 4,2, m[1], 0,2 ); } else { - CHROMA4x4MC( 2,4, a->l0.me4x8[i8x8][0], 0,0 ); - CHROMA4x4MC( 2,4, a->l0.me4x8[i8x8][1], 2,0 ); + x264_me_t *m = a->l0.me4x8[i8x8]; + CHROMA4x4MC( 2,4, m[0], 0,0 ); + CHROMA4x4MC( 2,4, m[1], 2,0 ); } - return h->pixf.mbcmp[PIXEL_4x4]( &h->mb.pic.p_fenc[1][oe], FENC_STRIDE, pix1, 8 ) - + h->pixf.mbcmp[PIXEL_4x4]( &h->mb.pic.p_fenc[2][oe], FENC_STRIDE, pix2, 8 ); + return h->pixf.mbcmp[PIXEL_4x4]( &h->mb.pic.p_fenc[1][oe], FENC_STRIDE, pix1, 16 ) + + h->pixf.mbcmp[PIXEL_4x4]( &h->mb.pic.p_fenc[2][oe], FENC_STRIDE, pix2, 16 ); } static void x264_mb_analyse_inter_p4x4( x264_t *h, x264_mb_analysis_t *a, int i8x8 ) @@ -1212,15 +1574,15 @@ static void x264_mb_analyse_inter_p4x4( x264_t *h, x264_mb_analysis_t *a, int i8 x264_me_t *m = &a->l0.me4x4[i8x8][i4x4]; m->i_pixel = PIXEL_4x4; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, p_fenc, 4*x4, 4*y4 ); LOAD_HPELS( m, p_fref, 0, i_ref, 4*x4, 4*y4 ); + LOAD_WPELS( m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 4*x4, 4*y4 ); x264_mb_predict_mv( h, 0, idx, 1, m->mvp ); x264_me_search( h, m, &a->l0.me8x8[i8x8].mv, i_mvc ); - x264_macroblock_cache_mv( h, x4, y4, 1, 1, 0, m->mv[0], m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, x4, y4, 1, 1, 0, m->mv ); } a->l0.i_cost4x4[i8x8] = a->l0.me4x4[i8x8][0].cost + a->l0.me4x4[i8x8][1].cost + @@ -1252,15 +1614,15 @@ static void x264_mb_analyse_inter_p8x4( x264_t *h, x264_mb_analysis_t *a, int i8 x264_me_t *m = &a->l0.me8x4[i8x8][i8x4]; m->i_pixel = PIXEL_8x4; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, p_fenc, 4*x4, 4*y4 ); LOAD_HPELS( m, p_fref, 0, i_ref, 4*x4, 4*y4 ); + LOAD_WPELS( m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 4*x4, 4*y4 ); x264_mb_predict_mv( h, 0, idx, 2, m->mvp ); x264_me_search( h, m, &a->l0.me4x4[i8x8][0].mv, i_mvc ); - x264_macroblock_cache_mv( h, x4, y4, 2, 1, 0, m->mv[0], m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, x4, y4, 2, 1, 0, m->mv ); } a->l0.i_cost8x4[i8x8] = a->l0.me8x4[i8x8][0].cost + a->l0.me8x4[i8x8][1].cost + REF_COST( 0, i_ref ) + @@ -1289,15 +1651,15 @@ static void x264_mb_analyse_inter_p4x8( x264_t *h, x264_mb_analysis_t *a, int i8 x264_me_t *m = &a->l0.me4x8[i8x8][i4x8]; m->i_pixel = PIXEL_4x8; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, p_fenc, 4*x4, 4*y4 ); LOAD_HPELS( m, p_fref, 0, i_ref, 4*x4, 4*y4 ); + LOAD_WPELS( m, h->mb.pic.p_fref_w[i_ref], 0, i_ref, 4*x4, 4*y4 ); x264_mb_predict_mv( h, 0, idx, 1, m->mvp ); x264_me_search( h, m, &a->l0.me4x4[i8x8][0].mv, i_mvc ); - x264_macroblock_cache_mv( h, x4, y4, 1, 2, 0, m->mv[0], m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, x4, y4, 1, 2, 0, m->mv ); } a->l0.i_cost4x8[i8x8] = a->l0.me4x8[i8x8][0].cost + a->l0.me4x8[i8x8][1].cost + REF_COST( 0, i_ref ) + @@ -1329,36 +1691,28 @@ static void x264_mb_analyse_inter_direct( x264_t *h, x264_mb_analysis_t *a ) } } -#define WEIGHTED_AVG( size, pix1, stride1, src2, stride2 ) \ - { \ - if( h->param.analyse.b_weighted_bipred ) \ - h->mc.avg_weight[size]( pix1, stride1, src2, stride2, \ - h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref] ); \ - else \ - h->mc.avg[size]( pix1, stride1, src2, stride2 ); \ - } - static void x264_mb_analyse_inter_b16x16( x264_t *h, x264_mb_analysis_t *a ) { - uint8_t pix1[16*16], pix2[16*16]; - uint8_t *src2; - int stride2 = 16; - int weight; + ALIGNED_ARRAY_16( uint8_t, pix0,[16*16] ); + ALIGNED_ARRAY_16( uint8_t, pix1,[16*16] ); + uint8_t *src0, *src1; + int stride0 = 16, stride1 = 16; x264_me_t m; - int i_ref; - int mvc[8][2], i_mvc; + int i_ref, i_mvc; + ALIGNED_4( int16_t mvc[9][2] ); int i_halfpel_thresh = INT_MAX; - int *p_halfpel_thresh = h->i_ref0>1 ? &i_halfpel_thresh : NULL; + int *p_halfpel_thresh = h->mb.pic.i_fref[0]>1 ? &i_halfpel_thresh : NULL; /* 16x16 Search on all ref frame */ m.i_pixel = PIXEL_16x16; - m.p_cost_mv = a->p_cost_mv; + m.weight = weight_none; + LOAD_FENC( &m, h->mb.pic.p_fenc, 0, 0 ); /* ME for List 0 */ a->l0.me16x16.cost = INT_MAX; - for( i_ref = 0; i_ref < h->i_ref0; i_ref++ ) + for( i_ref = 0; i_ref < h->mb.pic.i_fref[0]; i_ref++ ) { /* search with ref */ LOAD_HPELS( &m, h->mb.pic.p_fref[0][i_ref], 0, i_ref, 0, 0 ); @@ -1372,21 +1726,22 @@ static void x264_mb_analyse_inter_b16x16( x264_t *h, x264_mb_analysis_t *a ) if( m.cost < a->l0.me16x16.cost ) { a->l0.i_ref = i_ref; - a->l0.me16x16 = m; + h->mc.memcpy_aligned( &a->l0.me16x16, &m, sizeof(x264_me_t) ); } /* save mv for predicting neighbors */ - h->mb.mvr[0][i_ref][h->mb.i_mb_xy][0] = m.mv[0]; - h->mb.mvr[0][i_ref][h->mb.i_mb_xy][1] = m.mv[1]; + CP32( h->mb.mvr[0][i_ref][h->mb.i_mb_xy], m.mv ); } + a->l0.me16x16.i_ref = a->l0.i_ref; + /* subtract ref cost, so we don't have to add it for the other MB types */ a->l0.me16x16.cost -= REF_COST( 0, a->l0.i_ref ); /* ME for list 1 */ i_halfpel_thresh = INT_MAX; - p_halfpel_thresh = h->i_ref1>1 ? &i_halfpel_thresh : NULL; + p_halfpel_thresh = h->mb.pic.i_fref[1]>1 ? &i_halfpel_thresh : NULL; a->l1.me16x16.cost = INT_MAX; - for( i_ref = 0; i_ref < h->i_ref1; i_ref++ ) + for( i_ref = 0; i_ref < h->mb.pic.i_fref[1]; i_ref++ ) { /* search with ref */ LOAD_HPELS( &m, h->mb.pic.p_fref[1][i_ref], 1, i_ref, 0, 0 ); @@ -1400,13 +1755,14 @@ static void x264_mb_analyse_inter_b16x16( x264_t *h, x264_mb_analysis_t *a ) if( m.cost < a->l1.me16x16.cost ) { a->l1.i_ref = i_ref; - a->l1.me16x16 = m; + h->mc.memcpy_aligned( &a->l1.me16x16, &m, sizeof(x264_me_t) ); } /* save mv for predicting neighbors */ - h->mb.mvr[1][i_ref][h->mb.i_mb_xy][0] = m.mv[0]; - h->mb.mvr[1][i_ref][h->mb.i_mb_xy][1] = m.mv[1]; + CP32( h->mb.mvr[1][i_ref][h->mb.i_mb_xy], m.mv ); } + a->l1.me16x16.i_ref = a->l1.i_ref; + /* subtract ref cost, so we don't have to add it for the other MB types */ a->l1.me16x16.cost -= REF_COST( 1, a->l1.i_ref ); @@ -1415,39 +1771,16 @@ static void x264_mb_analyse_inter_b16x16( x264_t *h, x264_mb_analysis_t *a ) x264_macroblock_cache_ref( h, 0, 0, 4, 4, 1, a->l1.i_ref ); /* get cost of BI mode */ - weight = h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref]; - if ( ((a->l0.me16x16.mv[0] | a->l0.me16x16.mv[1]) & 1) == 0 ) - { - /* l0 reference is halfpel, so get_ref on it will make it faster */ - src2 = h->mc.get_ref( h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.i_stride[0], - pix2, &stride2, - a->l0.me16x16.mv[0], a->l0.me16x16.mv[1], - 16, 16 ); - h->mc.mc_luma( h->mb.pic.p_fref[1][a->l1.i_ref], h->mb.pic.i_stride[0], - pix1, 16, - a->l1.me16x16.mv[0], a->l1.me16x16.mv[1], - 16, 16 ); - weight = 64 - weight; - } - else - { - /* if l0 was qpel, we'll use get_ref on l1 instead */ - h->mc.mc_luma( h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.i_stride[0], - pix1, 16, - a->l0.me16x16.mv[0], a->l0.me16x16.mv[1], - 16, 16 ); - src2 = h->mc.get_ref( h->mb.pic.p_fref[1][a->l1.i_ref], h->mb.pic.i_stride[0], - pix2, &stride2, - a->l1.me16x16.mv[0], a->l1.me16x16.mv[1], - 16, 16 ); - } + src0 = h->mc.get_ref( pix0, &stride0, + h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.i_stride[0], + a->l0.me16x16.mv[0], a->l0.me16x16.mv[1], 16, 16, weight_none ); + src1 = h->mc.get_ref( pix1, &stride1, + h->mb.pic.p_fref[1][a->l1.i_ref], h->mb.pic.i_stride[0], + a->l1.me16x16.mv[0], a->l1.me16x16.mv[1], 16, 16, weight_none ); - if( h->param.analyse.b_weighted_bipred ) - h->mc.avg_weight[PIXEL_16x16]( pix1, 16, src2, stride2, weight ); - else - h->mc.avg[PIXEL_16x16]( pix1, 16, src2, stride2 ); + h->mc.avg[PIXEL_16x16]( pix0, 16, src0, stride0, src1, stride1, h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref] ); - a->i_cost16x16bi = h->pixf.mbcmp[PIXEL_16x16]( h->mb.pic.p_fenc[0], FENC_STRIDE, pix1, 16 ) + a->i_cost16x16bi = h->pixf.mbcmp[PIXEL_16x16]( h->mb.pic.p_fenc[0], FENC_STRIDE, pix0, 16 ) + REF_COST( 0, a->l0.i_ref ) + REF_COST( 1, a->l1.i_ref ) + a->l0.me16x16.cost_mv @@ -1467,21 +1800,21 @@ static inline void x264_mb_cache_mv_p8x8( x264_t *h, x264_mb_analysis_t *a, int switch( h->mb.i_sub_partition[i] ) { case D_L0_8x8: - x264_macroblock_cache_mv( h, x, y, 2, 2, 0, a->l0.me8x8[i].mv[0], a->l0.me8x8[i].mv[1] ); + x264_macroblock_cache_mv_ptr( h, x, y, 2, 2, 0, a->l0.me8x8[i].mv ); break; case D_L0_8x4: - x264_macroblock_cache_mv( h, x, y+0, 2, 1, 0, a->l0.me8x4[i][0].mv[0], a->l0.me8x4[i][0].mv[1] ); - x264_macroblock_cache_mv( h, x, y+1, 2, 1, 0, a->l0.me8x4[i][1].mv[0], a->l0.me8x4[i][1].mv[1] ); + x264_macroblock_cache_mv_ptr( h, x, y+0, 2, 1, 0, a->l0.me8x4[i][0].mv ); + x264_macroblock_cache_mv_ptr( h, x, y+1, 2, 1, 0, a->l0.me8x4[i][1].mv ); break; case D_L0_4x8: - x264_macroblock_cache_mv( h, x+0, y, 1, 2, 0, a->l0.me4x8[i][0].mv[0], a->l0.me4x8[i][0].mv[1] ); - x264_macroblock_cache_mv( h, x+1, y, 1, 2, 0, a->l0.me4x8[i][1].mv[0], a->l0.me4x8[i][1].mv[1] ); + x264_macroblock_cache_mv_ptr( h, x+0, y, 1, 2, 0, a->l0.me4x8[i][0].mv ); + x264_macroblock_cache_mv_ptr( h, x+1, y, 1, 2, 0, a->l0.me4x8[i][1].mv ); break; case D_L0_4x4: - x264_macroblock_cache_mv( h, x+0, y+0, 1, 1, 0, a->l0.me4x4[i][0].mv[0], a->l0.me4x4[i][0].mv[1] ); - x264_macroblock_cache_mv( h, x+1, y+0, 1, 1, 0, a->l0.me4x4[i][1].mv[0], a->l0.me4x4[i][1].mv[1] ); - x264_macroblock_cache_mv( h, x+0, y+1, 1, 1, 0, a->l0.me4x4[i][2].mv[0], a->l0.me4x4[i][2].mv[1] ); - x264_macroblock_cache_mv( h, x+1, y+1, 1, 1, 0, a->l0.me4x4[i][3].mv[0], a->l0.me4x4[i][3].mv[1] ); + x264_macroblock_cache_mv_ptr( h, x+0, y+0, 1, 1, 0, a->l0.me4x4[i][0].mv ); + x264_macroblock_cache_mv_ptr( h, x+1, y+0, 1, 1, 0, a->l0.me4x4[i][1].mv ); + x264_macroblock_cache_mv_ptr( h, x+0, y+1, 1, 1, 0, a->l0.me4x4[i][2].mv ); + x264_macroblock_cache_mv_ptr( h, x+1, y+1, 1, 1, 0, a->l0.me4x4[i][3].mv ); break; default: x264_log( h, X264_LOG_ERROR, "internal error\n" ); @@ -1493,26 +1826,26 @@ static inline void x264_mb_cache_mv_p8x8( x264_t *h, x264_mb_analysis_t *a, int if( x264_mb_partition_listX_table[0][part] ) \ { \ x264_macroblock_cache_ref( h, x,y,dx,dy, 0, a->l0.i_ref ); \ - x264_macroblock_cache_mv( h, x,y,dx,dy, 0, me0.mv[0], me0.mv[1] ); \ + x264_macroblock_cache_mv_ptr( h, x,y,dx,dy, 0, me0.mv ); \ } \ else \ { \ x264_macroblock_cache_ref( h, x,y,dx,dy, 0, -1 ); \ - x264_macroblock_cache_mv( h, x,y,dx,dy, 0, 0, 0 ); \ + x264_macroblock_cache_mv( h, x,y,dx,dy, 0, 0 ); \ if( b_mvd ) \ - x264_macroblock_cache_mvd( h, x,y,dx,dy, 0, 0, 0 ); \ + x264_macroblock_cache_mvd( h, x,y,dx,dy, 0, 0 ); \ } \ if( x264_mb_partition_listX_table[1][part] ) \ { \ x264_macroblock_cache_ref( h, x,y,dx,dy, 1, a->l1.i_ref ); \ - x264_macroblock_cache_mv( h, x,y,dx,dy, 1, me1.mv[0], me1.mv[1] ); \ + x264_macroblock_cache_mv_ptr( h, x,y,dx,dy, 1, me1.mv ); \ } \ else \ { \ x264_macroblock_cache_ref( h, x,y,dx,dy, 1, -1 ); \ - x264_macroblock_cache_mv( h, x,y,dx,dy, 1, 0, 0 ); \ + x264_macroblock_cache_mv( h, x,y,dx,dy, 1, 0 ); \ if( b_mvd ) \ - x264_macroblock_cache_mvd( h, x,y,dx,dy, 1, 0, 0 ); \ + x264_macroblock_cache_mvd( h, x,y,dx,dy, 1, 0 ); \ } static inline void x264_mb_cache_mv_b8x8( x264_t *h, x264_mb_analysis_t *a, int i, int b_mvd ) @@ -1524,8 +1857,8 @@ static inline void x264_mb_cache_mv_b8x8( x264_t *h, x264_mb_analysis_t *a, int x264_mb_load_mv_direct8x8( h, i ); if( b_mvd ) { - x264_macroblock_cache_mvd( h, x, y, 2, 2, 0, 0, 0 ); - x264_macroblock_cache_mvd( h, x, y, 2, 2, 1, 0, 0 ); + x264_macroblock_cache_mvd( h, x, y, 2, 2, 0, 0 ); + x264_macroblock_cache_mvd( h, x, y, 2, 2, 1, 0 ); x264_macroblock_cache_skip( h, x, y, 2, 2, 1 ); } } @@ -1549,7 +1882,7 @@ static void x264_mb_analyse_inter_b8x8( x264_t *h, x264_mb_analysis_t *a ) uint8_t **p_fref[2] = { h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.p_fref[1][a->l1.i_ref] }; - uint8_t pix[2][8*8]; + ALIGNED_8( uint8_t pix[2][8*8] ); int i, l; /* XXX Needed for x264_mb_predict_mv */ @@ -1563,6 +1896,8 @@ static void x264_mb_analyse_inter_b8x8( x264_t *h, x264_mb_analysis_t *a ) const int y8 = i/2; int i_part_cost; int i_part_cost_bi = 0; + int stride[2] = {8,8}; + uint8_t *src[2]; for( l = 0; l < 2; l++ ) { @@ -1570,7 +1905,6 @@ static void x264_mb_analyse_inter_b8x8( x264_t *h, x264_mb_analysis_t *a ) x264_me_t *m = &lX->me8x8[i]; m->i_pixel = PIXEL_8x8; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, h->mb.pic.p_fenc, 8*x8, 8*y8 ); LOAD_HPELS( m, p_fref[l], l, lX->i_ref, 8*x8, 8*y8 ); @@ -1578,16 +1912,15 @@ static void x264_mb_analyse_inter_b8x8( x264_t *h, x264_mb_analysis_t *a ) x264_mb_predict_mv( h, l, 4*i, 2, m->mvp ); x264_me_search( h, m, &lX->me16x16.mv, 1 ); - x264_macroblock_cache_mv( h, 2*x8, 2*y8, 2, 2, l, m->mv[0], m->mv[1] ); + x264_macroblock_cache_mv_ptr( h, 2*x8, 2*y8, 2, 2, l, m->mv ); /* BI mode */ - h->mc.mc_luma( m->p_fref, m->i_stride[0], pix[l], 8, - m->mv[0], m->mv[1], 8, 8 ); + src[l] = h->mc.get_ref( pix[l], &stride[l], m->p_fref, m->i_stride[0], + m->mv[0], m->mv[1], 8, 8, weight_none ); i_part_cost_bi += m->cost_mv; /* FIXME: ref cost */ } - - WEIGHTED_AVG( PIXEL_8x8, pix[0], 8, pix[1], 8 ); + h->mc.avg[PIXEL_8x8]( pix[0], 8, src[0], stride[0], src[1], stride[1], h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref] ); i_part_cost_bi += h->pixf.mbcmp[PIXEL_8x8]( a->l0.me8x8[i].p_fenc[0], FENC_STRIDE, pix[0], 8 ) + a->i_lambda * i_sub_mb_b_cost_table[D_BI_8x8]; a->l0.me8x8[i].cost += a->i_lambda * i_sub_mb_b_cost_table[D_L0_8x8]; @@ -1613,8 +1946,8 @@ static void x264_mb_analyse_inter_b16x8( x264_t *h, x264_mb_analysis_t *a ) uint8_t **p_fref[2] = { h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.p_fref[1][a->l1.i_ref] }; - DECLARE_ALIGNED( uint8_t, pix[2][16*8], 16 ); - int mvc[2][2]; + ALIGNED_ARRAY_16( uint8_t, pix,[2],[16*8] ); + ALIGNED_4( int16_t mvc[2][2] ); int i, l; h->mb.i_partition = D_16x8; @@ -1624,6 +1957,8 @@ static void x264_mb_analyse_inter_b16x8( x264_t *h, x264_mb_analysis_t *a ) { int i_part_cost; int i_part_cost_bi = 0; + int stride[2] = {16,16}; + uint8_t *src[2]; /* TODO: check only the list(s) that were used in b8x8? */ for( l = 0; l < 2; l++ ) @@ -1632,27 +1967,23 @@ static void x264_mb_analyse_inter_b16x8( x264_t *h, x264_mb_analysis_t *a ) x264_me_t *m = &lX->me16x8[i]; m->i_pixel = PIXEL_16x8; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, h->mb.pic.p_fenc, 0, 8*i ); LOAD_HPELS( m, p_fref[l], l, lX->i_ref, 0, 8*i ); - mvc[0][0] = lX->me8x8[2*i].mv[0]; - mvc[0][1] = lX->me8x8[2*i].mv[1]; - mvc[1][0] = lX->me8x8[2*i+1].mv[0]; - mvc[1][1] = lX->me8x8[2*i+1].mv[1]; + CP32( mvc[0], lX->me8x8[2*i].mv ); + CP32( mvc[1], lX->me8x8[2*i+1].mv ); - x264_mb_predict_mv( h, 0, 8*i, 2, m->mvp ); + x264_mb_predict_mv( h, l, 8*i, 2, m->mvp ); x264_me_search( h, m, mvc, 2 ); /* BI mode */ - h->mc.mc_luma( m->p_fref, m->i_stride[0], pix[l], 16, - m->mv[0], m->mv[1], 16, 8 ); + src[l] = h->mc.get_ref( pix[l], &stride[l], m->p_fref, m->i_stride[0], + m->mv[0], m->mv[1], 16, 8, weight_none ); /* FIXME: ref cost */ i_part_cost_bi += m->cost_mv; } - - WEIGHTED_AVG( PIXEL_16x8, pix[0], 16, pix[1], 16 ); + h->mc.avg[PIXEL_16x8]( pix[0], 16, src[0], stride[0], src[1], stride[1], h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref] ); i_part_cost_bi += h->pixf.mbcmp[PIXEL_16x8]( a->l0.me16x8[i].p_fenc[0], FENC_STRIDE, pix[0], 16 ); i_part_cost = a->l0.me16x8[i].cost; @@ -1684,8 +2015,8 @@ static void x264_mb_analyse_inter_b8x16( x264_t *h, x264_mb_analysis_t *a ) uint8_t **p_fref[2] = { h->mb.pic.p_fref[0][a->l0.i_ref], h->mb.pic.p_fref[1][a->l1.i_ref] }; - uint8_t pix[2][8*16]; - int mvc[2][2]; + ALIGNED_8( uint8_t pix[2][8*16] ); + ALIGNED_4( int16_t mvc[2][2] ); int i, l; h->mb.i_partition = D_8x16; @@ -1695,6 +2026,8 @@ static void x264_mb_analyse_inter_b8x16( x264_t *h, x264_mb_analysis_t *a ) { int i_part_cost; int i_part_cost_bi = 0; + int stride[2] = {8,8}; + uint8_t *src[2]; for( l = 0; l < 2; l++ ) { @@ -1702,27 +2035,24 @@ static void x264_mb_analyse_inter_b8x16( x264_t *h, x264_mb_analysis_t *a ) x264_me_t *m = &lX->me8x16[i]; m->i_pixel = PIXEL_8x16; - m->p_cost_mv = a->p_cost_mv; LOAD_FENC( m, h->mb.pic.p_fenc, 8*i, 0 ); LOAD_HPELS( m, p_fref[l], l, lX->i_ref, 8*i, 0 ); - mvc[0][0] = lX->me8x8[i].mv[0]; - mvc[0][1] = lX->me8x8[i].mv[1]; - mvc[1][0] = lX->me8x8[i+2].mv[0]; - mvc[1][1] = lX->me8x8[i+2].mv[1]; + CP32( mvc[0], lX->me8x8[i].mv ); + CP32( mvc[1], lX->me8x8[i+2].mv ); - x264_mb_predict_mv( h, 0, 4*i, 2, m->mvp ); + x264_mb_predict_mv( h, l, 4*i, 2, m->mvp ); x264_me_search( h, m, mvc, 2 ); /* BI mode */ - h->mc.mc_luma( m->p_fref, m->i_stride[0], pix[l], 8, - m->mv[0], m->mv[1], 8, 16 ); + src[l] = h->mc.get_ref( pix[l], &stride[l], m->p_fref, m->i_stride[0], + m->mv[0], m->mv[1], 8, 16, weight_none ); /* FIXME: ref cost */ i_part_cost_bi += m->cost_mv; } - WEIGHTED_AVG( PIXEL_8x16, pix[0], 8, pix[1], 8 ); + h->mc.avg[PIXEL_8x16]( pix[0], 8, src[0], stride[0], src[1], stride[1], h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref] ); i_part_cost_bi += h->pixf.mbcmp[PIXEL_8x16]( a->l0.me8x16[i].p_fenc[0], FENC_STRIDE, pix[0], 8 ); i_part_cost = a->l0.me8x16[i].cost; @@ -1760,7 +2090,6 @@ static void x264_mb_analyse_p_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd ) x264_analyse_update_cache( h, a ); a->l0.i_rd16x16 = x264_rd_cost_mb( h, a->i_lambda2 ); } - a->l0.me16x16.cost = a->l0.i_rd16x16; if( a->l0.i_cost16x8 <= thresh ) { @@ -1783,34 +2112,39 @@ static void x264_mb_analyse_p_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd ) if( a->l0.i_cost8x8 <= thresh ) { h->mb.i_type = P_8x8; - x264_analyse_update_cache( h, a ); - a->l0.i_cost8x8 = x264_rd_cost_mb( h, a->i_lambda2 ); - + h->mb.i_partition = D_8x8; if( h->param.analyse.inter & X264_ANALYSE_PSUB8x8 ) { - /* FIXME: RD per subpartition */ - int part_bak[4]; - int i, i_cost; - int b_sub8x8 = 0; - for( i=0; i<4; i++ ) - { - part_bak[i] = h->mb.i_sub_partition[i]; - b_sub8x8 |= (part_bak[i] != D_L0_8x8); - } - if( b_sub8x8 ) + int i; + x264_macroblock_cache_ref( h, 0, 0, 2, 2, 0, a->l0.me8x8[0].i_ref ); + x264_macroblock_cache_ref( h, 2, 0, 2, 2, 0, a->l0.me8x8[1].i_ref ); + x264_macroblock_cache_ref( h, 0, 2, 2, 2, 0, a->l0.me8x8[2].i_ref ); + x264_macroblock_cache_ref( h, 2, 2, 2, 2, 0, a->l0.me8x8[3].i_ref ); + /* FIXME: In the 8x8 blocks where RDO isn't run, the NNZ values used for context selection + * for future blocks are those left over from previous RDO calls. */ + for( i = 0; i < 4; i++ ) { - h->mb.i_sub_partition[0] = h->mb.i_sub_partition[1] = - h->mb.i_sub_partition[2] = h->mb.i_sub_partition[3] = D_L0_8x8; - i_cost = x264_rd_cost_mb( h, a->i_lambda2 ); - if( a->l0.i_cost8x8 < i_cost ) + int costs[4] = {a->l0.i_cost4x4[i], a->l0.i_cost8x4[i], a->l0.i_cost4x8[i], a->l0.me8x8[i].cost}; + int thresh = X264_MIN4( costs[0], costs[1], costs[2], costs[3] ) * 5 / 4; + int subtype, btype = D_L0_8x8; + uint64_t bcost = COST_MAX64; + for( subtype = D_L0_4x4; subtype <= D_L0_8x8; subtype++ ) { - for( i=0; i<4; i++ ) - h->mb.i_sub_partition[i] = part_bak[i]; + uint64_t cost; + if( costs[subtype] > thresh || (subtype == D_L0_8x8 && bcost == COST_MAX64) ) + continue; + h->mb.i_sub_partition[i] = subtype; + x264_mb_cache_mv_p8x8( h, a, i ); + cost = x264_rd_cost_part( h, a->i_lambda2, i<<2, PIXEL_8x8 ); + COPY2_IF_LT( bcost, cost, btype, subtype ); } - else - a->l0.i_cost8x8 = i_cost; + h->mb.i_sub_partition[i] = btype; + x264_mb_cache_mv_p8x8( h, a, i ); } } + else + x264_analyse_update_cache( h, a ); + a->l0.i_cost8x8 = x264_rd_cost_mb( h, a->i_lambda2 ); } else a->l0.i_cost8x8 = COST_MAX; @@ -1818,13 +2152,17 @@ static void x264_mb_analyse_p_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd ) static void x264_mb_analyse_b_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd_inter ) { - int thresh = i_satd_inter * 17/16; + int thresh = i_satd_inter * (17 + (!!h->mb.i_psy_rd))/16; if( a->b_direct_available && a->i_rd16x16direct == COST_MAX ) { h->mb.i_type = B_DIRECT; + /* Assumes direct/skip MC is still in fdec */ + /* Requires b-rdo to be done before intra analysis */ + h->mb.b_skip_mc = 1; x264_analyse_update_cache( h, a ); a->i_rd16x16direct = x264_rd_cost_mb( h, a->i_lambda2 ); + h->mb.b_skip_mc = 0; } //FIXME not all the update_cache calls are needed @@ -1882,45 +2220,44 @@ static void x264_mb_analyse_b_rd( x264_t *h, x264_mb_analysis_t *a, int i_satd_i } } -static void refine_bidir( x264_t *h, x264_mb_analysis_t *a ) +static void x264_refine_bidir( x264_t *h, x264_mb_analysis_t *a ) { const int i_biweight = h->mb.bipred_weight[a->l0.i_ref][a->l1.i_ref]; int i; + if( IS_INTRA(h->mb.i_type) ) + return; + switch( h->mb.i_partition ) { - case D_16x16: - if( h->mb.i_type == B_BI_BI ) - x264_me_refine_bidir( h, &a->l0.me16x16, &a->l1.me16x16, i_biweight ); - break; - case D_16x8: - for( i=0; i<2; i++ ) - if( a->i_mb_partition16x8[i] == D_BI_8x8 ) - x264_me_refine_bidir( h, &a->l0.me16x8[i], &a->l1.me16x8[i], i_biweight ); - break; - case D_8x16: - for( i=0; i<2; i++ ) - if( a->i_mb_partition8x16[i] == D_BI_8x8 ) - x264_me_refine_bidir( h, &a->l0.me8x16[i], &a->l1.me8x16[i], i_biweight ); - break; - case D_8x8: - for( i=0; i<4; i++ ) - if( h->mb.i_sub_partition[i] == D_BI_8x8 ) - x264_me_refine_bidir( h, &a->l0.me8x8[i], &a->l1.me8x8[i], i_biweight ); - break; + case D_16x16: + if( h->mb.i_type == B_BI_BI ) + x264_me_refine_bidir_satd( h, &a->l0.me16x16, &a->l1.me16x16, i_biweight ); + break; + case D_16x8: + for( i=0; i<2; i++ ) + if( a->i_mb_partition16x8[i] == D_BI_8x8 ) + x264_me_refine_bidir_satd( h, &a->l0.me16x8[i], &a->l1.me16x8[i], i_biweight ); + break; + case D_8x16: + for( i=0; i<2; i++ ) + if( a->i_mb_partition8x16[i] == D_BI_8x8 ) + x264_me_refine_bidir_satd( h, &a->l0.me8x16[i], &a->l1.me8x16[i], i_biweight ); + break; + case D_8x8: + for( i=0; i<4; i++ ) + if( h->mb.i_sub_partition[i] == D_BI_8x8 ) + x264_me_refine_bidir_satd( h, &a->l0.me8x8[i], &a->l1.me8x8[i], i_biweight ); + break; } } static inline void x264_mb_analyse_transform( x264_t *h ) { - h->mb.cache.b_transform_8x8_allowed = - h->param.analyse.b_transform_8x8 - && !IS_INTRA( h->mb.i_type ) && x264_mb_transform_8x8_allowed( h ); - - if( h->mb.cache.b_transform_8x8_allowed ) + if( x264_mb_transform_8x8_allowed( h ) && h->param.analyse.b_transform_8x8 && !h->mb.b_lossless ) { int i_cost4, i_cost8; - /* FIXME only luma mc is needed */ + /* Only luma MC is really needed, but the full MC is re-used in macroblock_encode. */ x264_mb_mc( h ); i_cost8 = h->pixf.sa8d[PIXEL_16x16]( h->mb.pic.p_fenc[0], FENC_STRIDE, @@ -1929,19 +2266,17 @@ static inline void x264_mb_analyse_transform( x264_t *h ) h->mb.pic.p_fdec[0], FDEC_STRIDE ); h->mb.b_transform_8x8 = i_cost8 < i_cost4; + h->mb.b_skip_mc = 1; } } static inline void x264_mb_analyse_transform_rd( x264_t *h, x264_mb_analysis_t *a, int *i_satd, int *i_rd ) { - h->mb.cache.b_transform_8x8_allowed = - h->param.analyse.b_transform_8x8 && x264_mb_transform_8x8_allowed( h ); - - if( h->mb.cache.b_transform_8x8_allowed ) + if( x264_mb_transform_8x8_allowed( h ) && h->param.analyse.b_transform_8x8 ) { int i_rd8; x264_analyse_update_cache( h, a ); - h->mb.b_transform_8x8 = !h->mb.b_transform_8x8; + h->mb.b_transform_8x8 ^= 1; /* FIXME only luma is needed, but the score for comparison already includes chroma */ i_rd8 = x264_rd_cost_mb( h, a->i_lambda2 ); @@ -1949,17 +2284,90 @@ static inline void x264_mb_analyse_transform_rd( x264_t *h, x264_mb_analysis_t * { if( *i_rd > 0 ) *i_satd = (int64_t)(*i_satd) * i_rd8 / *i_rd; - /* prevent a rare division by zero in estimated intra cost */ - if( *i_satd == 0 ) - *i_satd = 1; - *i_rd = i_rd8; } else - h->mb.b_transform_8x8 = !h->mb.b_transform_8x8; + h->mb.b_transform_8x8 ^= 1; } } +/* Rate-distortion optimal QP selection. + * FIXME: More than half of the benefit of this function seems to be + * in the way it improves the coding of chroma DC (by decimating or + * finding a better way to code a single DC coefficient.) + * There must be a more efficient way to get that portion of the benefit + * without doing full QP-RD, but RD-decimation doesn't seem to do the + * trick. */ +static inline void x264_mb_analyse_qp_rd( x264_t *h, x264_mb_analysis_t *a ) +{ + int bcost, cost, direction, failures, prevcost, origcost; + int orig_qp = h->mb.i_qp, bqp = h->mb.i_qp; + int last_qp_tried = 0; + origcost = bcost = x264_rd_cost_mb( h, a->i_lambda2 ); + + /* If CBP is already zero, don't raise the quantizer any higher. */ + for( direction = h->mb.cbp[h->mb.i_mb_xy] ? 1 : -1; direction >= -1; direction-=2 ) + { + /* Without psy-RD, require monotonicity when moving quant away from previous + * macroblock's quant; allow 1 failure when moving quant towards previous quant. + * With psy-RD, allow 1 failure when moving quant away from previous quant, + * allow 2 failures when moving quant towards previous quant. + * Psy-RD generally seems to result in more chaotic RD score-vs-quantizer curves. */ + int threshold = (!!h->mb.i_psy_rd); + /* Raise the threshold for failures if we're moving towards the last QP. */ + if( ( h->mb.i_last_qp < orig_qp && direction == -1 ) || + ( h->mb.i_last_qp > orig_qp && direction == 1 ) ) + threshold++; + h->mb.i_qp = orig_qp; + failures = 0; + prevcost = origcost; + h->mb.i_qp += direction; + while( h->mb.i_qp >= h->param.rc.i_qp_min && h->mb.i_qp <= h->param.rc.i_qp_max ) + { + if( h->mb.i_last_qp == h->mb.i_qp ) + last_qp_tried = 1; + h->mb.i_chroma_qp = h->chroma_qp_table[h->mb.i_qp]; + cost = x264_rd_cost_mb( h, a->i_lambda2 ); + COPY2_IF_LT( bcost, cost, bqp, h->mb.i_qp ); + + /* We can't assume that the costs are monotonic over QPs. + * Tie case-as-failure seems to give better results. */ + if( cost < prevcost ) + failures = 0; + else + failures++; + prevcost = cost; + + if( failures > threshold ) + break; + if( direction == 1 && !h->mb.cbp[h->mb.i_mb_xy] ) + break; + h->mb.i_qp += direction; + } + } + + /* Always try the last block's QP. */ + if( !last_qp_tried ) + { + h->mb.i_qp = h->mb.i_last_qp; + h->mb.i_chroma_qp = h->chroma_qp_table[h->mb.i_qp]; + cost = x264_rd_cost_mb( h, a->i_lambda2 ); + COPY2_IF_LT( bcost, cost, bqp, h->mb.i_qp ); + } + + h->mb.i_qp = bqp; + h->mb.i_chroma_qp = h->chroma_qp_table[h->mb.i_qp]; + + /* Check transform again; decision from before may no longer be optimal. */ + if( h->mb.i_qp != orig_qp && h->param.analyse.b_transform_8x8 && + x264_mb_transform_8x8_allowed( h ) ) + { + h->mb.b_transform_8x8 ^= 1; + cost = x264_rd_cost_mb( h, a->i_lambda2 ); + if( cost > bcost ) + h->mb.b_transform_8x8 ^= 1; + } +} /***************************************************************************** * x264_macroblock_analyse: @@ -1970,39 +2378,51 @@ void x264_macroblock_analyse( x264_t *h ) int i_cost = COST_MAX; int i; - /* init analysis */ - x264_mb_analyse_init( h, &analysis, x264_ratecontrol_qp( h ) ); + h->mb.i_qp = x264_ratecontrol_qp( h ); + if( h->param.rc.i_aq_mode ) + { + x264_adaptive_quant( h ); + /* If the QP of this MB is within 1 of the previous MB, code the same QP as the previous MB, + * to lower the bit cost of the qp_delta. Don't do this if QPRD is enabled. */ + if( h->param.analyse.i_subpel_refine < 10 && abs(h->mb.i_qp - h->mb.i_last_qp) == 1 ) + h->mb.i_qp = h->mb.i_last_qp; + } + + x264_mb_analyse_init( h, &analysis, h->mb.i_qp ); /*--------------------------- Do the analysis ---------------------------*/ if( h->sh.i_type == SLICE_TYPE_I ) { + if( analysis.i_mbrd ) + x264_mb_cache_fenc_satd( h ); x264_mb_analyse_intra( h, &analysis, COST_MAX ); - if( analysis.b_mbrd ) + if( analysis.i_mbrd ) x264_intra_rd( h, &analysis, COST_MAX ); i_cost = analysis.i_satd_i16x16; h->mb.i_type = I_16x16; - if( analysis.i_satd_i4x4 < i_cost ) - { - i_cost = analysis.i_satd_i4x4; - h->mb.i_type = I_4x4; - } - if( analysis.i_satd_i8x8 < i_cost ) - h->mb.i_type = I_8x8; + COPY2_IF_LT( i_cost, analysis.i_satd_i4x4, h->mb.i_type, I_4x4 ); + COPY2_IF_LT( i_cost, analysis.i_satd_i8x8, h->mb.i_type, I_8x8 ); + if( analysis.i_satd_pcm < i_cost ) + h->mb.i_type = I_PCM; - if( h->mb.i_subpel_refine >= 7 ) + else if( analysis.i_mbrd >= 2 ) x264_intra_rd_refine( h, &analysis ); } else if( h->sh.i_type == SLICE_TYPE_P ) { int b_skip = 0; - int i_intra_cost, i_intra_type; + + h->mc.prefetch_ref( h->mb.pic.p_fref[0][0][h->mb.i_mb_x&3], h->mb.pic.i_stride[0], 0 ); /* Fast P_SKIP detection */ analysis.b_try_pskip = 0; if( h->param.analyse.b_fast_pskip ) { - if( h->param.analyse.i_subpel_refine >= 3 ) + if( h->param.i_threads > 1 && h->mb.cache.pskip_mv[1] > h->mb.mv_max_spel[1] ) + // FIXME don't need to check this if the reference frame is done + {} + else if( h->param.analyse.i_subpel_refine >= 3 ) analysis.b_try_pskip = 1; else if( h->mb.i_mb_type_left == P_SKIP || h->mb.i_mb_type_top == P_SKIP || @@ -2011,10 +2431,13 @@ void x264_macroblock_analyse( x264_t *h ) b_skip = x264_macroblock_probe_pskip( h ); } + h->mc.prefetch_ref( h->mb.pic.p_fref[0][0][h->mb.i_mb_x&3], h->mb.pic.i_stride[0], 1 ); + if( b_skip ) { h->mb.i_type = P_SKIP; h->mb.i_partition = D_16x16; + assert( h->mb.cache.pskip_mv[1] <= h->mb.mv_max_spel[1] || h->param.i_threads == 1 ); } else { @@ -2094,7 +2517,7 @@ void x264_macroblock_analyse( x264_t *h ) /* refine qpel */ //FIXME mb_type costs? - if( analysis.b_mbrd ) + if( analysis.i_mbrd ) { /* refine later */ } @@ -2173,12 +2596,12 @@ void x264_macroblock_analyse( x264_t *h ) analysis.i_satd_i8x8, analysis.i_satd_i4x4 ); - if( analysis.b_mbrd ) + if( analysis.i_mbrd ) { x264_mb_analyse_p_rd( h, &analysis, X264_MIN(i_satd_inter, i_satd_intra) ); i_type = P_L0; i_partition = D_16x16; - i_cost = analysis.l0.me16x16.cost; + i_cost = analysis.l0.i_rd16x16; COPY2_IF_LT( i_cost, analysis.l0.i_cost16x8, i_partition, D_16x8 ); COPY2_IF_LT( i_cost, analysis.l0.i_cost8x16, i_partition, D_8x16 ); COPY3_IF_LT( i_cost, analysis.l0.i_cost8x8, i_partition, D_8x8, i_type, P_8x8 ); @@ -2189,20 +2612,14 @@ void x264_macroblock_analyse( x264_t *h ) x264_intra_rd( h, &analysis, i_satd_inter * 5/4 ); } - i_intra_type = I_16x16; - i_intra_cost = analysis.i_satd_i16x16; - COPY2_IF_LT( i_intra_cost, analysis.i_satd_i8x8, i_intra_type, I_8x8 ); - COPY2_IF_LT( i_intra_cost, analysis.i_satd_i4x4, i_intra_type, I_4x4 ); - COPY2_IF_LT( i_cost, i_intra_cost, i_type, i_intra_type ); - - if( i_intra_cost == COST_MAX ) - i_intra_cost = i_cost * i_satd_intra / i_satd_inter + 1; + COPY2_IF_LT( i_cost, analysis.i_satd_i16x16, i_type, I_16x16 ); + COPY2_IF_LT( i_cost, analysis.i_satd_i8x8, i_type, I_8x8 ); + COPY2_IF_LT( i_cost, analysis.i_satd_i4x4, i_type, I_4x4 ); + COPY2_IF_LT( i_cost, analysis.i_satd_pcm, i_type, I_PCM ); h->mb.i_type = i_type; - h->stat.frame.i_intra_cost += i_intra_cost; - h->stat.frame.i_inter_cost += i_cost; - if( h->mb.i_subpel_refine >= 7 ) + if( analysis.i_mbrd >= 2 && h->mb.i_type != I_PCM ) { if( IS_INTRA( h->mb.i_type ) ) { @@ -2211,29 +2628,55 @@ void x264_macroblock_analyse( x264_t *h ) else if( i_partition == D_16x16 ) { x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, analysis.l0.me16x16.i_ref ); - x264_me_refine_qpel_rd( h, &analysis.l0.me16x16, analysis.i_lambda2, 0 ); + analysis.l0.me16x16.cost = i_cost; + x264_me_refine_qpel_rd( h, &analysis.l0.me16x16, analysis.i_lambda2, 0, 0 ); } else if( i_partition == D_16x8 ) { + h->mb.i_sub_partition[0] = h->mb.i_sub_partition[1] = + h->mb.i_sub_partition[2] = h->mb.i_sub_partition[3] = D_L0_8x8; x264_macroblock_cache_ref( h, 0, 0, 4, 2, 0, analysis.l0.me16x8[0].i_ref ); x264_macroblock_cache_ref( h, 0, 2, 4, 2, 0, analysis.l0.me16x8[1].i_ref ); - x264_me_refine_qpel_rd( h, &analysis.l0.me16x8[0], analysis.i_lambda2, 0 ); - x264_me_refine_qpel_rd( h, &analysis.l0.me16x8[1], analysis.i_lambda2, 2 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me16x8[0], analysis.i_lambda2, 0, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me16x8[1], analysis.i_lambda2, 8, 0 ); } else if( i_partition == D_8x16 ) { + h->mb.i_sub_partition[0] = h->mb.i_sub_partition[1] = + h->mb.i_sub_partition[2] = h->mb.i_sub_partition[3] = D_L0_8x8; x264_macroblock_cache_ref( h, 0, 0, 2, 4, 0, analysis.l0.me8x16[0].i_ref ); x264_macroblock_cache_ref( h, 2, 0, 2, 4, 0, analysis.l0.me8x16[1].i_ref ); - x264_me_refine_qpel_rd( h, &analysis.l0.me8x16[0], analysis.i_lambda2, 0 ); - x264_me_refine_qpel_rd( h, &analysis.l0.me8x16[1], analysis.i_lambda2, 1 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me8x16[0], analysis.i_lambda2, 0, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me8x16[1], analysis.i_lambda2, 4, 0 ); } else if( i_partition == D_8x8 ) { int i8x8; x264_analyse_update_cache( h, &analysis ); for( i8x8 = 0; i8x8 < 4; i8x8++ ) - if( h->mb.i_sub_partition[i8x8] == D_L0_8x8 ) - x264_me_refine_qpel_rd( h, &analysis.l0.me8x8[i8x8], analysis.i_lambda2, i8x8 ); + { + if( h->mb.i_sub_partition[i8x8] == D_L0_8x8 ) + { + x264_me_refine_qpel_rd( h, &analysis.l0.me8x8[i8x8], analysis.i_lambda2, i8x8*4, 0 ); + } + else if( h->mb.i_sub_partition[i8x8] == D_L0_8x4 ) + { + x264_me_refine_qpel_rd( h, &analysis.l0.me8x4[i8x8][0], analysis.i_lambda2, i8x8*4+0, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me8x4[i8x8][1], analysis.i_lambda2, i8x8*4+2, 0 ); + } + else if( h->mb.i_sub_partition[i8x8] == D_L0_4x8 ) + { + x264_me_refine_qpel_rd( h, &analysis.l0.me4x8[i8x8][0], analysis.i_lambda2, i8x8*4+0, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me4x8[i8x8][1], analysis.i_lambda2, i8x8*4+1, 0 ); + } + else if( h->mb.i_sub_partition[i8x8] == D_L0_4x4 ) + { + x264_me_refine_qpel_rd( h, &analysis.l0.me4x4[i8x8][0], analysis.i_lambda2, i8x8*4+0, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me4x4[i8x8][1], analysis.i_lambda2, i8x8*4+1, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me4x4[i8x8][2], analysis.i_lambda2, i8x8*4+2, 0 ); + x264_me_refine_qpel_rd( h, &analysis.l0.me4x4[i8x8][3], analysis.i_lambda2, i8x8*4+3, 0 ); + } + } } } } @@ -2243,6 +2686,9 @@ void x264_macroblock_analyse( x264_t *h ) int i_bskip_cost = COST_MAX; int b_skip = 0; + if( analysis.i_mbrd ) + x264_mb_cache_fenc_satd( h ); + h->mb.i_type = B_SKIP; if( h->mb.b_direct_auto_write ) { @@ -2272,21 +2718,11 @@ void x264_macroblock_analyse( x264_t *h ) { if( !h->mb.b_direct_auto_write ) x264_mb_mc( h ); - if( h->mb.b_lossless ) - { - /* chance of skip is too small to bother */ - } - else if( analysis.b_mbrd ) + if( analysis.i_mbrd ) { i_bskip_cost = ssd_mb( h ); - /* 6 = minimum cavlc cost of a non-skipped MB */ - if( i_bskip_cost <= 6 * analysis.i_lambda2 ) - { - h->mb.i_type = B_SKIP; - x264_analyse_update_cache( h, &analysis ); - return; - } + b_skip = h->mb.b_skip_mc = i_bskip_cost <= ((6 * analysis.i_lambda2 + 128) >> 8); } else if( !h->mb.b_direct_auto_write ) { @@ -2301,6 +2737,8 @@ void x264_macroblock_analyse( x264_t *h ) const unsigned int flags = h->param.analyse.inter; int i_type; int i_partition; + int i_satd_inter; + h->mb.b_skip_mc = 0; x264_mb_analyse_load_costs( h, &analysis ); @@ -2318,7 +2756,7 @@ void x264_macroblock_analyse( x264_t *h ) COPY2_IF_LT( i_cost, analysis.i_cost16x16bi, i_type, B_BI_BI ); COPY2_IF_LT( i_cost, analysis.i_cost16x16direct, i_type, B_DIRECT ); - if( analysis.b_mbrd && analysis.i_cost16x16direct <= i_cost * 33/32 ) + if( analysis.i_mbrd && analysis.i_cost16x16direct <= i_cost * 33/32 ) { x264_mb_analyse_b_rd( h, &analysis, i_cost ); if( i_bskip_cost < analysis.i_rd16x16direct && @@ -2360,7 +2798,7 @@ void x264_macroblock_analyse( x264_t *h ) } } - if( analysis.b_mbrd ) + if( analysis.i_mbrd ) { /* refine later */ } @@ -2443,11 +2881,10 @@ void x264_macroblock_analyse( x264_t *h ) } } - x264_mb_analyse_intra( h, &analysis, i_cost ); + i_satd_inter = i_cost; - if( analysis.b_mbrd ) + if( analysis.i_mbrd ) { - int i_satd_inter = i_cost; x264_mb_analyse_b_rd( h, &analysis, i_satd_inter ); i_type = B_SKIP; i_cost = i_bskip_cost; @@ -2462,6 +2899,12 @@ void x264_macroblock_analyse( x264_t *h ) h->mb.i_type = i_type; h->mb.i_partition = i_partition; + } + + x264_mb_analyse_intra( h, &analysis, i_satd_inter ); + + if( analysis.i_mbrd ) + { x264_mb_analyse_transform_rd( h, &analysis, &i_satd_inter, &i_cost ); x264_intra_rd( h, &analysis, i_satd_inter * 17/16 ); } @@ -2469,22 +2912,105 @@ void x264_macroblock_analyse( x264_t *h ) COPY2_IF_LT( i_cost, analysis.i_satd_i16x16, i_type, I_16x16 ); COPY2_IF_LT( i_cost, analysis.i_satd_i8x8, i_type, I_8x8 ); COPY2_IF_LT( i_cost, analysis.i_satd_i4x4, i_type, I_4x4 ); + COPY2_IF_LT( i_cost, analysis.i_satd_pcm, i_type, I_PCM ); h->mb.i_type = i_type; h->mb.i_partition = i_partition; - if( h->param.analyse.b_bidir_me ) - refine_bidir( h, &analysis ); + if( analysis.i_mbrd >= 2 && IS_INTRA( i_type ) && i_type != I_PCM ) + x264_intra_rd_refine( h, &analysis ); + if( h->mb.i_subpel_refine >= 5 ) + x264_refine_bidir( h, &analysis ); + + if( analysis.i_mbrd >= 2 && i_type > B_DIRECT && i_type < B_SKIP ) + { + const int i_biweight = h->mb.bipred_weight[analysis.l0.i_ref][analysis.l1.i_ref]; + x264_analyse_update_cache( h, &analysis ); + + if( i_partition == D_16x16 ) + { + if( i_type == B_L0_L0 ) + { + analysis.l0.me16x16.cost = i_cost; + x264_me_refine_qpel_rd( h, &analysis.l0.me16x16, analysis.i_lambda2, 0, 0 ); + } + else if( i_type == B_L1_L1 ) + { + analysis.l1.me16x16.cost = i_cost; + x264_me_refine_qpel_rd( h, &analysis.l1.me16x16, analysis.i_lambda2, 0, 1 ); + } + else if( i_type == B_BI_BI ) + x264_me_refine_bidir_rd( h, &analysis.l0.me16x16, &analysis.l1.me16x16, i_biweight, 0, analysis.i_lambda2 ); + } + else if( i_partition == D_16x8 ) + { + for( i = 0; i < 2; i++ ) + { + h->mb.i_sub_partition[i*2] = h->mb.i_sub_partition[i*2+1] = analysis.i_mb_partition16x8[i]; + if( analysis.i_mb_partition16x8[i] == D_L0_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l0.me16x8[i], analysis.i_lambda2, i*8, 0 ); + else if( analysis.i_mb_partition16x8[i] == D_L1_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l1.me16x8[i], analysis.i_lambda2, i*8, 1 ); + else if( analysis.i_mb_partition16x8[i] == D_BI_8x8 ) + x264_me_refine_bidir_rd( h, &analysis.l0.me16x8[i], &analysis.l1.me16x8[i], i_biweight, i*2, analysis.i_lambda2 ); + } + } + else if( i_partition == D_8x16 ) + { + for( i = 0; i < 2; i++ ) + { + h->mb.i_sub_partition[i] = h->mb.i_sub_partition[i+2] = analysis.i_mb_partition8x16[i]; + if( analysis.i_mb_partition8x16[i] == D_L0_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l0.me8x16[i], analysis.i_lambda2, i*4, 0 ); + else if( analysis.i_mb_partition8x16[i] == D_L1_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l1.me8x16[i], analysis.i_lambda2, i*4, 1 ); + else if( analysis.i_mb_partition8x16[i] == D_BI_8x8 ) + x264_me_refine_bidir_rd( h, &analysis.l0.me8x16[i], &analysis.l1.me8x16[i], i_biweight, i, analysis.i_lambda2 ); + } + } + else if( i_partition == D_8x8 ) + { + for( i = 0; i < 4; i++ ) + { + if( h->mb.i_sub_partition[i] == D_L0_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l0.me8x8[i], analysis.i_lambda2, i*4, 0 ); + else if( h->mb.i_sub_partition[i] == D_L1_8x8 ) + x264_me_refine_qpel_rd( h, &analysis.l1.me8x8[i], analysis.i_lambda2, i*4, 1 ); + else if( h->mb.i_sub_partition[i] == D_BI_8x8 ) + x264_me_refine_bidir_rd( h, &analysis.l0.me8x8[i], &analysis.l1.me8x8[i], i_biweight, i, analysis.i_lambda2 ); + } + } + } } } x264_analyse_update_cache( h, &analysis ); - if( !analysis.b_mbrd ) + /* In rare cases we can end up qpel-RDing our way back to a larger partition size + * without realizing it. Check for this and account for it if necessary. */ + if( analysis.i_mbrd >= 2 ) + { + /* Don't bother with bipred or 8x8-and-below, the odds are incredibly low. */ + static const uint8_t check_mv_lists[X264_MBTYPE_MAX] = {[P_L0]=1, [B_L0_L0]=1, [B_L1_L1]=2}; + int list = check_mv_lists[h->mb.i_type] - 1; + if( list >= 0 && h->mb.i_partition != D_16x16 && + M32( &h->mb.cache.mv[list][x264_scan8[0]] ) == M32( &h->mb.cache.mv[list][x264_scan8[12]] ) && + h->mb.cache.ref[list][x264_scan8[0]] == h->mb.cache.ref[list][x264_scan8[12]] ) + h->mb.i_partition = D_16x16; + } + + if( !analysis.i_mbrd ) x264_mb_analyse_transform( h ); + if( analysis.i_mbrd == 3 && !IS_SKIP(h->mb.i_type) ) + x264_mb_analyse_qp_rd( h, &analysis ); + h->mb.b_trellis = h->param.analyse.i_trellis; - h->mb.b_noise_reduction = h->param.analyse.i_noise_reduction; + h->mb.b_noise_reduction = !!h->param.analyse.i_noise_reduction; + if( !IS_SKIP(h->mb.i_type) && h->mb.i_psy_trellis && h->param.analyse.i_trellis == 1 ) + x264_psy_trellis_init( h, 0 ); + if( h->mb.b_trellis == 1 || h->mb.b_noise_reduction ) + h->mb.i_skip_intra = 0; } /*-------------------- Update MB from the analysis ----------------------*/ @@ -2511,26 +3037,29 @@ static void x264_analyse_update_cache( x264_t *h, x264_mb_analysis_t *a ) x264_mb_analyse_intra_chroma( h, a ); break; + case I_PCM: + break; + case P_L0: switch( h->mb.i_partition ) { case D_16x16: x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, a->l0.me16x16.i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv[0], a->l0.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv ); break; case D_16x8: x264_macroblock_cache_ref( h, 0, 0, 4, 2, 0, a->l0.me16x8[0].i_ref ); x264_macroblock_cache_ref( h, 0, 2, 4, 2, 0, a->l0.me16x8[1].i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 2, 0, a->l0.me16x8[0].mv[0], a->l0.me16x8[0].mv[1] ); - x264_macroblock_cache_mv ( h, 0, 2, 4, 2, 0, a->l0.me16x8[1].mv[0], a->l0.me16x8[1].mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 2, 0, a->l0.me16x8[0].mv ); + x264_macroblock_cache_mv_ptr( h, 0, 2, 4, 2, 0, a->l0.me16x8[1].mv ); break; case D_8x16: x264_macroblock_cache_ref( h, 0, 0, 2, 4, 0, a->l0.me8x16[0].i_ref ); x264_macroblock_cache_ref( h, 2, 0, 2, 4, 0, a->l0.me8x16[1].i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 2, 4, 0, a->l0.me8x16[0].mv[0], a->l0.me8x16[0].mv[1] ); - x264_macroblock_cache_mv ( h, 2, 0, 2, 4, 0, a->l0.me8x16[1].mv[0], a->l0.me8x16[1].mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 2, 4, 0, a->l0.me8x16[0].mv ); + x264_macroblock_cache_mv_ptr( h, 2, 0, 2, 4, 0, a->l0.me8x16[1].mv ); break; default: @@ -2550,12 +3079,9 @@ static void x264_analyse_update_cache( x264_t *h, x264_mb_analysis_t *a ) case P_SKIP: { - int mvp[2]; - x264_mb_predict_mv_pskip( h, mvp ); - /* */ h->mb.i_partition = D_16x16; x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, 0 ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, mvp[0], mvp[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 0, h->mb.cache.pskip_mv ); break; } @@ -2581,26 +3107,26 @@ static void x264_analyse_update_cache( x264_t *h, x264_mb_analysis_t *a ) { case B_L0_L0: x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, a->l0.i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv[0], a->l0.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv ); x264_macroblock_cache_ref( h, 0, 0, 4, 4, 1, -1 ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 1, 0, 0 ); - x264_macroblock_cache_mvd( h, 0, 0, 4, 4, 1, 0, 0 ); + x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 1, 0 ); + x264_macroblock_cache_mvd( h, 0, 0, 4, 4, 1, 0 ); break; case B_L1_L1: x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, -1 ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, 0, 0 ); - x264_macroblock_cache_mvd( h, 0, 0, 4, 4, 0, 0, 0 ); + x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, 0 ); + x264_macroblock_cache_mvd( h, 0, 0, 4, 4, 0, 0 ); x264_macroblock_cache_ref( h, 0, 0, 4, 4, 1, a->l1.i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 1, a->l1.me16x16.mv[0], a->l1.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 1, a->l1.me16x16.mv ); break; case B_BI_BI: x264_macroblock_cache_ref( h, 0, 0, 4, 4, 0, a->l0.i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv[0], a->l0.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 0, a->l0.me16x16.mv ); x264_macroblock_cache_ref( h, 0, 0, 4, 4, 1, a->l1.i_ref ); - x264_macroblock_cache_mv ( h, 0, 0, 4, 4, 1, a->l1.me16x16.mv[0], a->l1.me16x16.mv[1] ); + x264_macroblock_cache_mv_ptr( h, 0, 0, 4, 4, 1, a->l1.me16x16.mv ); break; } break; @@ -2617,7 +3143,38 @@ static void x264_analyse_update_cache( x264_t *h, x264_mb_analysis_t *a ) break; } } + +#ifndef NDEBUG + if( h->param.i_threads > 1 && !IS_INTRA(h->mb.i_type) ) + { + int l; + for( l=0; l <= (h->sh.i_type == SLICE_TYPE_B); l++ ) + { + int completed; + int ref = h->mb.cache.ref[l][x264_scan8[0]]; + if( ref < 0 ) + continue; + completed = (l ? h->fref1 : h->fref0)[ ref >> h->mb.b_interlaced ]->i_lines_completed; + if( (h->mb.cache.mv[l][x264_scan8[15]][1] >> (2 - h->mb.b_interlaced)) + h->mb.i_mb_y*16 > completed ) + { + x264_log( h, X264_LOG_WARNING, "internal error (MV out of thread range)\n"); + fprintf(stderr, "mb type: %d \n", h->mb.i_type); + fprintf(stderr, "mv: l%dr%d (%d,%d) \n", l, ref, + h->mb.cache.mv[l][x264_scan8[15]][0], + h->mb.cache.mv[l][x264_scan8[15]][1] ); + fprintf(stderr, "limit: %d \n", h->mb.mv_max_spel[1]); + fprintf(stderr, "mb_xy: %d,%d \n", h->mb.i_mb_x, h->mb.i_mb_y); + fprintf(stderr, "completed: %d \n", completed ); + x264_log( h, X264_LOG_WARNING, "recovering by using intra mode\n"); + x264_mb_analyse_intra( h, a, COST_MAX ); + h->mb.i_type = I_16x16; + h->mb.i_intra16x16_pred_mode = a->i_predict16x16; + x264_mb_analyse_intra_chroma( h, a ); + } + } + } +#endif } -#include "slicetype_decision.c" +#include "slicetype.c"