X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=include%2Fvlc_arrays.h;h=0670ef79efd7e4638d850a1d542c5fbe881e8b96;hb=3def7a126ba8568ee7dcc8f9d2f1ce01f2603935;hp=f446ef1ab590e3d9dcf9cfaa7366c398589a95cc;hpb=9d6bf51a76aa5877fbdce794b0a7ffd267ef1e5a;p=vlc diff --git a/include/vlc_arrays.h b/include/vlc_arrays.h index f446ef1ab5..0670ef79ef 100644 --- a/include/vlc_arrays.h +++ b/include/vlc_arrays.h @@ -2,7 +2,7 @@ * vlc_arrays.h : Arrays and data structures handling ***************************************************************************** * Copyright (C) 1999-2004 the VideoLAN team - * $Id: vlc_playlist.h 17108 2006-10-15 15:28:34Z zorglub $ + * $Id$ * * Authors: Samuel Hocevar * Clément Stenac @@ -301,6 +301,22 @@ static inline void vlc_array_clear( vlc_array_t * p_array ) memset( p_array, 0, sizeof(vlc_array_t) ); } +static inline vlc_array_t * vlc_array_new( void ) +{ + vlc_array_t * ret = (vlc_array_t *)malloc( sizeof(vlc_array_t) ); + if( ret ) vlc_array_init( ret ); + return ret; +} + +static inline void vlc_array_destroy( vlc_array_t * p_array ) +{ + if( !p_array ) + return; + vlc_array_clear( p_array ); + free( p_array ); +} + + /* Read */ static inline int vlc_array_count( vlc_array_t * p_array ) @@ -314,6 +330,18 @@ vlc_array_item_at_index( vlc_array_t * p_array, int i_index ) return p_array->pp_elems[i_index]; } +static inline int +vlc_array_index_of_item( vlc_array_t * p_array, void * item ) +{ + int i; + for( i = 0; i < p_array->i_count; i++) + { + if( p_array->pp_elems[i] == item ) + return i; + } + return -1; +} + /* Write */ static inline void vlc_array_insert( vlc_array_t * p_array, void * p_elem, int i_index ) @@ -403,18 +431,21 @@ static inline void vlc_dictionary_clear( vlc_dictionary_t * p_dict ) { int i; struct vlc_dictionary_entry_t * p_current, * p_next; - for( i = 0; i < p_dict->i_size; i++ ) + if( p_dict->p_entries ) { - p_current = p_dict->p_entries[i]; - while( p_current ) + for( i = 0; i < p_dict->i_size; i++ ) { - p_next = p_dict->p_entries[i]->p_next; - free( p_dict->p_entries[i]->psz_key ); - free( p_current ); - p_current = p_next; + p_current = p_dict->p_entries[i]; + while( p_current ) + { + p_next = p_current->p_next; + free( p_current->psz_key ); + free( p_current ); + p_current = p_next; + } } + free( p_dict->p_entries ); } - free( p_dict->p_entries ); p_dict->i_size = 0; } @@ -429,13 +460,10 @@ vlc_dictionary_value_for_key( const vlc_dictionary_t * p_dict, const char * psz_ int i_pos = DictHash( psz_key, p_dict->i_size ); struct vlc_dictionary_entry_t * p_entry = p_dict->p_entries[i_pos]; - if( p_entry && !p_entry->p_next ) - return p_entry->p_value; - if( !p_entry ) return kVLCDictionaryNotFound; - /* Hash collision */ + /* Make sure we return the right item. (Hash collision) */ do { if( !strcmp( psz_key, p_entry->psz_key ) ) return p_entry->p_value; @@ -450,6 +478,10 @@ vlc_dictionary_keys_count( const vlc_dictionary_t * p_dict ) { struct vlc_dictionary_entry_t * p_entry; int i, count = 0; + + if( !p_dict->p_entries ) + return 0; + for( i = 0; i < p_dict->i_size; i++ ) { for( p_entry = p_dict->p_entries[i]; p_entry; p_entry = p_entry->p_next ) count++; @@ -466,7 +498,7 @@ vlc_dictionary_all_keys( const vlc_dictionary_t * p_dict ) ppsz_ret = (char**)malloc(sizeof(char *) * (count + 1)); assert( ppsz_ret ); - + count = 0; for( i = 0; i < p_dict->i_size; i++ ) { @@ -488,36 +520,14 @@ __vlc_dictionary_insert( vlc_dictionary_t * p_dict, const char * psz_key, vlc_dictionary_init( p_dict, 1 ); int i_pos = DictHash( psz_key, p_dict->i_size ); - struct vlc_dictionary_entry_t * p_entry = p_dict->p_entries[i_pos]; - - if( !p_entry ) - { - p_entry = p_dict->p_entries[i_pos] = (struct vlc_dictionary_entry_t *)malloc( - sizeof(struct vlc_dictionary_entry_t)); - assert( p_entry ); - - p_entry->psz_key = strdup( psz_key ); - assert( p_entry->psz_key ); - p_entry->p_value = p_value; - p_dict->p_entries[i_pos]->p_next = NULL; - return; - } - if( p_entry->p_value == kVLCDictionaryNotFound ) - { - /* This one is fine, just high jack */ - p_entry->psz_key = strdup( psz_key ); - p_entry->p_value = p_value; - return; - } + struct vlc_dictionary_entry_t * p_entry; - /* Hash collision here */ p_entry = (struct vlc_dictionary_entry_t *)malloc(sizeof(struct vlc_dictionary_entry_t)); assert( p_entry ); p_entry->psz_key = strdup( psz_key ); p_entry->p_value = p_value; p_entry->p_next = p_dict->p_entries[i_pos]; p_dict->p_entries[i_pos] = p_entry; - if( rebuild ) { /* Count how many items there was */ @@ -529,12 +539,11 @@ __vlc_dictionary_insert( vlc_dictionary_t * p_dict, const char * psz_key, struct vlc_dictionary_t new_dict; int i_new_size = ( (p_dict->i_size+2) * 3) / 2; /* XXX: this need tuning */ int i; - vlc_dictionary_init( &new_dict, i_new_size ); for( i = 0; i < p_dict->i_size; i++ ) { p_entry = p_dict->p_entries[i]; - while( p_entry ); + while( p_entry ) { __vlc_dictionary_insert( &new_dict, p_entry->psz_key, p_entry->p_value, @@ -542,9 +551,10 @@ __vlc_dictionary_insert( vlc_dictionary_t * p_dict, const char * psz_key, p_entry = p_entry->p_next; } } + vlc_dictionary_clear( p_dict ); p_dict->i_size = new_dict.i_size; - p_dict->p_entries= new_dict.p_entries; + p_dict->p_entries = new_dict.p_entries; } } } @@ -568,14 +578,6 @@ vlc_dictionary_remove_value_for_key( const vlc_dictionary_t * p_dict, const char if( !p_entry ) return; /* Not found, nothing to do */ - if( !p_entry->p_next ) - { - free( p_entry->psz_key ); - free( p_entry ); - p_dict->p_entries[i_pos] = NULL; - return; - } - /* Hash collision */ p_prev = NULL; do {