X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=libavcodec%2Fclearvideo.c;h=a9fa0228bd92f02cd5fa150c1ae365a09178273e;hb=c996374d4d86e0efbef71812448b4c65656bc667;hp=437c459aa55b1dd397fe461236a67e9472c60711;hpb=2ea6310f4ae7509d7711fdb7cf86e80c189afa8b;p=ffmpeg diff --git a/libavcodec/clearvideo.c b/libavcodec/clearvideo.c index 437c459aa55..a9fa0228bd9 100644 --- a/libavcodec/clearvideo.c +++ b/libavcodec/clearvideo.c @@ -185,12 +185,12 @@ static inline int decode_block(CLVContext *ctx, int16_t *blk, int has_ac, const int t3 = OP( 2408 * blk[5 * step] - 1609 * blk[3 * step]); \ const int t4 = OP( 1108 * blk[2 * step] - 2676 * blk[6 * step]); \ const int t5 = OP( 2676 * blk[2 * step] + 1108 * blk[6 * step]); \ - const int t6 = ((blk[0 * step] + blk[4 * step]) << dshift) + bias; \ - const int t7 = ((blk[0 * step] - blk[4 * step]) << dshift) + bias; \ + const int t6 = ((blk[0 * step] + blk[4 * step]) * (1 << dshift)) + bias; \ + const int t7 = ((blk[0 * step] - blk[4 * step]) * (1 << dshift)) + bias; \ const int t8 = t0 + t2; \ const int t9 = t0 - t2; \ - const int tA = 181 * (t9 + (t1 - t3)) + 0x80 >> 8; \ - const int tB = 181 * (t9 - (t1 - t3)) + 0x80 >> 8; \ + const int tA = (int)(181U * (t9 + (t1 - t3)) + 0x80) >> 8; \ + const int tB = (int)(181U * (t9 - (t1 - t3)) + 0x80) >> 8; \ const int tC = t1 + t3; \ \ blk[0 * step] = (t6 + t5 + t8) >> shift; \ @@ -297,6 +297,11 @@ static int clv_decode_frame(AVCodecContext *avctx, void *data, c->pic->pict_type = frame_type & 0x20 ? AV_PICTURE_TYPE_I : AV_PICTURE_TYPE_P; if (frame_type & 0x2) { + if (buf_size < c->mb_width * c->mb_height) { + av_log(avctx, AV_LOG_ERROR, "Packet too small\n"); + return AVERROR_INVALIDDATA; + } + bytestream2_get_be32(&gb); // frame size; c->ac_quant = bytestream2_get_byte(&gb); c->luma_dc_quant = 32;