X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=libavcodec%2Fdirac.c;h=5faf0a384d95e3f3b7ce2ee816a635015e4ca129;hb=dcc39ee10e82833ce24aa57926c00ffeb1948198;hp=543a3425255842619a7ada9032ef9855e5f8b832;hpb=2361e59b98f1c78d9720e72aabfb847dd9906f12;p=ffmpeg diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index 543a3425255..5faf0a384d9 100644 --- a/libavcodec/dirac.c +++ b/libavcodec/dirac.c @@ -26,60 +26,91 @@ */ #include "libavutil/imgutils.h" -#include "dirac.h" + #include "avcodec.h" +#include "bitstream.h" +#include "dirac.h" #include "golomb.h" +#include "internal.h" #include "mpeg12data.h" +#if CONFIG_DIRAC_PARSE + +typedef struct dirac_source_params { + unsigned width; + unsigned height; + uint8_t chroma_format; ///< 0: 444 1: 422 2: 420 + + uint8_t interlaced; + uint8_t top_field_first; + + uint8_t frame_rate_index; ///< index into dirac_frame_rate[] + uint8_t aspect_ratio_index; ///< index into dirac_aspect_ratio[] + + uint16_t clean_width; + uint16_t clean_height; + uint16_t clean_left_offset; + uint16_t clean_right_offset; + + uint8_t pixel_range_index; ///< index into dirac_pixel_range_presets[] + uint8_t color_spec_index; ///< index into dirac_color_spec_presets[] +} dirac_source_params; + // defaults for source parameters static const dirac_source_params dirac_source_parameters_defaults[] = { - { 640, 480, 2, 0, 0, 1, 1, 640, 480, 0, 0, 1, 0 }, - { 176, 120, 2, 0, 0, 9, 2, 176, 120, 0, 0, 1, 1 }, - { 176, 144, 2, 0, 1, 10, 3, 176, 144, 0, 0, 1, 2 }, - { 352, 240, 2, 0, 0, 9, 2, 352, 240, 0, 0, 1, 1 }, - { 352, 288, 2, 0, 1, 10, 3, 352, 288, 0, 0, 1, 2 }, - { 704, 480, 2, 0, 0, 9, 2, 704, 480, 0, 0, 1, 1 }, - { 704, 576, 2, 0, 1, 10, 3, 704, 576, 0, 0, 1, 2 }, - { 720, 480, 1, 1, 0, 4, 2, 704, 480, 8, 0, 3, 1 }, - { 720, 576, 1, 1, 1, 3, 3, 704, 576, 8, 0, 3, 2 }, - - { 1280, 720, 1, 0, 1, 7, 1, 1280, 720, 0, 0, 3, 3 }, - { 1280, 720, 1, 0, 1, 6, 1, 1280, 720, 0, 0, 3, 3 }, - { 1920, 1080, 1, 1, 1, 4, 1, 1920, 1080, 0, 0, 3, 3 }, - { 1920, 1080, 1, 1, 1, 3, 1, 1920, 1080, 0, 0, 3, 3 }, - { 1920, 1080, 1, 0, 1, 7, 1, 1920, 1080, 0, 0, 3, 3 }, - { 1920, 1080, 1, 0, 1, 6, 1, 1920, 1080, 0, 0, 3, 3 }, - { 2048, 1080, 0, 0, 1, 2, 1, 2048, 1080, 0, 0, 4, 4 }, - { 4096, 2160, 0, 0, 1, 2, 1, 4096, 2160, 0, 0, 4, 4 }, - - { 3840, 2160, 1, 0, 1, 7, 1, 3840, 2160, 0, 0, 3, 3 }, - { 3840, 2160, 1, 0, 1, 6, 1, 3840, 2160, 0, 0, 3, 3 }, - { 7680, 4320, 1, 0, 1, 7, 1, 3840, 2160, 0, 0, 3, 3 }, - { 7680, 4320, 1, 0, 1, 6, 1, 3840, 2160, 0, 0, 3, 3 }, + { 640, 480, 2, 0, 0, 1, 1, 640, 480, 0, 0, 1, 0 }, + { 176, 120, 2, 0, 0, 9, 2, 176, 120, 0, 0, 1, 1 }, + { 176, 144, 2, 0, 1, 10, 3, 176, 144, 0, 0, 1, 2 }, + { 352, 240, 2, 0, 0, 9, 2, 352, 240, 0, 0, 1, 1 }, + { 352, 288, 2, 0, 1, 10, 3, 352, 288, 0, 0, 1, 2 }, + { 704, 480, 2, 0, 0, 9, 2, 704, 480, 0, 0, 1, 1 }, + { 704, 576, 2, 0, 1, 10, 3, 704, 576, 0, 0, 1, 2 }, + { 720, 480, 1, 1, 0, 4, 2, 704, 480, 8, 0, 3, 1 }, + { 720, 576, 1, 1, 1, 3, 3, 704, 576, 8, 0, 3, 2 }, + + { 1280, 720, 1, 0, 1, 7, 1, 1280, 720, 0, 0, 3, 3 }, + { 1280, 720, 1, 0, 1, 6, 1, 1280, 720, 0, 0, 3, 3 }, + { 1920, 1080, 1, 1, 1, 4, 1, 1920, 1080, 0, 0, 3, 3 }, + { 1920, 1080, 1, 1, 1, 3, 1, 1920, 1080, 0, 0, 3, 3 }, + { 1920, 1080, 1, 0, 1, 7, 1, 1920, 1080, 0, 0, 3, 3 }, + { 1920, 1080, 1, 0, 1, 6, 1, 1920, 1080, 0, 0, 3, 3 }, + { 2048, 1080, 0, 0, 1, 2, 1, 2048, 1080, 0, 0, 4, 4 }, + { 4096, 2160, 0, 0, 1, 2, 1, 4096, 2160, 0, 0, 4, 4 }, + + { 3840, 2160, 1, 0, 1, 7, 1, 3840, 2160, 0, 0, 3, 3 }, + { 3840, 2160, 1, 0, 1, 6, 1, 3840, 2160, 0, 0, 3, 3 }, + { 7680, 4320, 1, 0, 1, 7, 1, 3840, 2160, 0, 0, 3, 3 }, + { 7680, 4320, 1, 0, 1, 6, 1, 3840, 2160, 0, 0, 3, 3 }, }; +/* [DIRAC_STD] Table 10.4 - Available preset pixel aspect ratio values */ static const AVRational dirac_preset_aspect_ratios[] = { - {1, 1}, - {10, 11}, - {12, 11}, - {40, 33}, - {16, 11}, - {4, 3}, + { 1, 1 }, + { 10, 11 }, + { 12, 11 }, + { 40, 33 }, + { 16, 11 }, + { 4, 3 }, }; +/* [DIRAC_STD] Values 9,10 of 10.3.5 Frame Rate. + * Table 10.3 Available preset frame rate values + */ static const AVRational dirac_frame_rate[] = { - {15000, 1001}, - {25, 2}, + { 15000, 1001 }, + { 25, 2 }, }; +/* [DIRAC_STD] This should be equivalent to Table 10.5 Available signal + * range presets */ static const struct { uint8_t bitdepth; enum AVColorRange color_range; } pixel_range_presets[] = { - {8, AVCOL_RANGE_JPEG}, - {8, AVCOL_RANGE_MPEG}, - {10, AVCOL_RANGE_MPEG}, - {12, AVCOL_RANGE_MPEG}, + { 8, AVCOL_RANGE_JPEG }, + { 8, AVCOL_RANGE_MPEG }, + { 10, AVCOL_RANGE_MPEG }, + { 12, AVCOL_RANGE_MPEG }, }; static const enum AVColorPrimaries dirac_primaries[] = { @@ -100,186 +131,264 @@ static const struct { { AVCOL_PRI_BT709, AVCOL_SPC_BT709, AVCOL_TRC_UNSPECIFIED /* DCinema */ }, }; -static const enum PixelFormat dirac_pix_fmt[2][3] = { - { PIX_FMT_YUV444P, PIX_FMT_YUV422P, PIX_FMT_YUV420P }, - { PIX_FMT_YUVJ444P, PIX_FMT_YUVJ422P, PIX_FMT_YUVJ420P }, +/* [DIRAC_STD] Table 10.2 Supported chroma sampling formats + luma Offset */ +static const enum AVPixelFormat dirac_pix_fmt[2][3] = { + { AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV420P }, + { AV_PIX_FMT_YUVJ444P, AV_PIX_FMT_YUVJ422P, AV_PIX_FMT_YUVJ420P }, }; -static int parse_source_parameters(AVCodecContext *avctx, GetBitContext *gb, - dirac_source_params *source) +/* [DIRAC_STD] 10.3 Parse Source Parameters. + * source_parameters(base_video_format) */ +static int parse_source_parameters(AVDiracSeqHeader *dsh, BitstreamContext *bc, + void *log_ctx) { - AVRational frame_rate = (AVRational){0,0}; + AVRational frame_rate = { 0, 0 }; unsigned luma_depth = 8, luma_offset = 16; int idx; - if (get_bits1(gb)) { - source->width = svq3_get_ue_golomb(gb); - source->height = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.2 Frame size. frame_size(video_params) */ + /* [DIRAC_STD] custom_dimensions_flag */ + if (bitstream_read_bit(bc)) { + dsh->width = get_interleaved_ue_golomb(bc); /* [DIRAC_STD] FRAME_WIDTH */ + dsh->height = get_interleaved_ue_golomb(bc); /* [DIRAC_STD] FRAME_HEIGHT */ } - // chroma subsampling - if (get_bits1(gb)) - source->chroma_format = svq3_get_ue_golomb(gb); - if (source->chroma_format > 2) { - av_log(avctx, AV_LOG_ERROR, "Unknown chroma format %d\n", - source->chroma_format); - return -1; + /* [DIRAC_STD] 10.3.3 Chroma Sampling Format. + * chroma_sampling_format(video_params) */ + /* [DIRAC_STD] custom_chroma_format_flag */ + if (bitstream_read_bit(bc)) + /* [DIRAC_STD] CHROMA_FORMAT_INDEX */ + dsh->chroma_format = get_interleaved_ue_golomb(bc); + if (dsh->chroma_format > 2) { + if (log_ctx) + av_log(log_ctx, AV_LOG_ERROR, "Unknown chroma format %d\n", + dsh->chroma_format); + return AVERROR_INVALIDDATA; } - if (get_bits1(gb)) - source->interlaced = svq3_get_ue_golomb(gb); - if (source->interlaced > 1) - return -1; - - // frame rate - if (get_bits1(gb)) { - source->frame_rate_index = svq3_get_ue_golomb(gb); - - if (source->frame_rate_index > 10) - return -1; - - if (!source->frame_rate_index) { - frame_rate.num = svq3_get_ue_golomb(gb); - frame_rate.den = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.4 Scan Format. scan_format(video_params) */ + /* [DIRAC_STD] custom_scan_format_flag */ + if (bitstream_read_bit(bc)) + /* [DIRAC_STD] SOURCE_SAMPLING */ + dsh->interlaced = get_interleaved_ue_golomb(bc); + if (dsh->interlaced > 1) + return AVERROR_INVALIDDATA; + + /* [DIRAC_STD] 10.3.5 Frame Rate. frame_rate(video_params) */ + if (bitstream_read_bit(bc)) { /* [DIRAC_STD] custom_frame_rate_flag */ + dsh->frame_rate_index = get_interleaved_ue_golomb(bc); + + if (dsh->frame_rate_index > 10) + return AVERROR_INVALIDDATA; + + if (!dsh->frame_rate_index) { + /* [DIRAC_STD] FRAME_RATE_NUMER */ + frame_rate.num = get_interleaved_ue_golomb(bc); + /* [DIRAC_STD] FRAME_RATE_DENOM */ + frame_rate.den = get_interleaved_ue_golomb(bc); } } - if (source->frame_rate_index > 0) { - if (source->frame_rate_index <= 8) - frame_rate = ff_frame_rate_tab[source->frame_rate_index]; + /* [DIRAC_STD] preset_frame_rate(video_params, index) */ + if (dsh->frame_rate_index > 0) { + if (dsh->frame_rate_index <= 8) + frame_rate = ff_mpeg12_frame_rate_tab[dsh->frame_rate_index]; else - frame_rate = dirac_frame_rate[source->frame_rate_index-9]; + /* [DIRAC_STD] Table 10.3 values 9-10 */ + frame_rate = dirac_frame_rate[dsh->frame_rate_index - 9]; } - av_reduce(&avctx->time_base.num, &avctx->time_base.den, - frame_rate.den, frame_rate.num, 1<<30); + dsh->framerate = frame_rate; - // aspect ratio - if (get_bits1(gb)) { - source->aspect_ratio_index = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.6 Pixel Aspect Ratio. + * pixel_aspect_ratio(video_params) */ + if (bitstream_read_bit(bc)) { /* [DIRAC_STD] custom_pixel_aspect_ratio_flag */ + /* [DIRAC_STD] index */ + dsh->aspect_ratio_index = get_interleaved_ue_golomb(bc); - if (source->aspect_ratio_index > 6) - return -1; + if (dsh->aspect_ratio_index > 6) + return AVERROR_INVALIDDATA; - if (!source->aspect_ratio_index) { - avctx->sample_aspect_ratio.num = svq3_get_ue_golomb(gb); - avctx->sample_aspect_ratio.den = svq3_get_ue_golomb(gb); + if (!dsh->aspect_ratio_index) { + dsh->sample_aspect_ratio.num = get_interleaved_ue_golomb(bc); + dsh->sample_aspect_ratio.den = get_interleaved_ue_golomb(bc); } } - if (source->aspect_ratio_index > 0) - avctx->sample_aspect_ratio = - dirac_preset_aspect_ratios[source->aspect_ratio_index-1]; - - if (get_bits1(gb)) { - source->clean_width = svq3_get_ue_golomb(gb); - source->clean_height = svq3_get_ue_golomb(gb); - source->clean_left_offset = svq3_get_ue_golomb(gb); - source->clean_right_offset = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] Take value from Table 10.4 Available preset pixel + * aspect ratio values */ + if (dsh->aspect_ratio_index > 0) + dsh->sample_aspect_ratio = + dirac_preset_aspect_ratios[dsh->aspect_ratio_index - 1]; + + /* [DIRAC_STD] 10.3.7 Clean area. clean_area(video_params) */ + if (bitstream_read_bit(bc)) { /* [DIRAC_STD] custom_clean_area_flag */ + /* [DIRAC_STD] CLEAN_WIDTH */ + dsh->clean_width = get_interleaved_ue_golomb(bc); + /* [DIRAC_STD] CLEAN_HEIGHT */ + dsh->clean_height = get_interleaved_ue_golomb(bc); + /* [DIRAC_STD] CLEAN_LEFT_OFFSET */ + dsh->clean_left_offset = get_interleaved_ue_golomb(bc); + /* [DIRAC_STD] CLEAN_RIGHT_OFFSET */ + dsh->clean_right_offset = get_interleaved_ue_golomb(bc); } - // Override signal range. - if (get_bits1(gb)) { - source->pixel_range_index = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.8 Signal range. signal_range(video_params) + * WARNING: Some adaptation seems to be done using the + * AVCOL_RANGE_MPEG/JPEG values */ + if (bitstream_read_bit(bc)) { /* [DIRAC_STD] custom_signal_range_flag */ + /* [DIRAC_STD] index */ + dsh->pixel_range_index = get_interleaved_ue_golomb(bc); - if (source->pixel_range_index > 4) - return -1; + if (dsh->pixel_range_index > 4) + return AVERROR_INVALIDDATA; // This assumes either fullrange or MPEG levels only - if (!source->pixel_range_index) { - luma_offset = svq3_get_ue_golomb(gb); - luma_depth = av_log2(svq3_get_ue_golomb(gb))+1; - svq3_get_ue_golomb(gb); // chroma offset - svq3_get_ue_golomb(gb); // chroma excursion - - avctx->color_range = luma_offset ? AVCOL_RANGE_MPEG : AVCOL_RANGE_JPEG; + if (!dsh->pixel_range_index) { + luma_offset = get_interleaved_ue_golomb(bc); + luma_depth = av_log2(get_interleaved_ue_golomb(bc)) + 1; + get_interleaved_ue_golomb(bc); /* chroma offset */ + get_interleaved_ue_golomb(bc); /* chroma excursion */ + dsh->color_range = luma_offset ? AVCOL_RANGE_MPEG + : AVCOL_RANGE_JPEG; } } - if (source->pixel_range_index > 0) { - idx = source->pixel_range_index-1; + /* [DIRAC_STD] Table 10.5 + * Available signal range presets <--> pixel_range_presets */ + if (dsh->pixel_range_index > 0) { + idx = dsh->pixel_range_index - 1; luma_depth = pixel_range_presets[idx].bitdepth; - avctx->color_range = pixel_range_presets[idx].color_range; + dsh->color_range = pixel_range_presets[idx].color_range; } - if (luma_depth > 8) - av_log(avctx, AV_LOG_WARNING, "Bitdepth greater than 8"); + if (luma_depth > 8 && log_ctx) + av_log(log_ctx, AV_LOG_WARNING, "Bitdepth greater than 8"); - avctx->pix_fmt = dirac_pix_fmt[!luma_offset][source->chroma_format]; + dsh->pix_fmt = dirac_pix_fmt[!luma_offset][dsh->chroma_format]; - // color spec - if (get_bits1(gb)) { - idx = source->color_spec_index = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.9 Colour specification. colour_spec(video_params) */ + if (bitstream_read_bit(bc)) { /* [DIRAC_STD] custom_colour_spec_flag */ + /* [DIRAC_STD] index */ + idx = dsh->color_spec_index = get_interleaved_ue_golomb(bc); - if (source->color_spec_index > 4) - return -1; + if (dsh->color_spec_index > 4) + return AVERROR_INVALIDDATA; - avctx->color_primaries = dirac_color_presets[idx].color_primaries; - avctx->colorspace = dirac_color_presets[idx].colorspace; - avctx->color_trc = dirac_color_presets[idx].color_trc; + dsh->color_primaries = dirac_color_presets[idx].color_primaries; + dsh->colorspace = dirac_color_presets[idx].colorspace; + dsh->color_trc = dirac_color_presets[idx].color_trc; - if (!source->color_spec_index) { - if (get_bits1(gb)) { - idx = svq3_get_ue_golomb(gb); + if (!dsh->color_spec_index) { + /* [DIRAC_STD] 10.3.9.1 Colour primaries */ + if (bitstream_read_bit(bc)) { + idx = get_interleaved_ue_golomb(bc); if (idx < 3) - avctx->color_primaries = dirac_primaries[idx]; + dsh->color_primaries = dirac_primaries[idx]; } - - if (get_bits1(gb)) { - idx = svq3_get_ue_golomb(gb); + /* [DIRAC_STD] 10.3.9.2 Colour matrix */ + if (bitstream_read_bit(bc)) { + idx = get_interleaved_ue_golomb(bc); if (!idx) - avctx->colorspace = AVCOL_SPC_BT709; + dsh->colorspace = AVCOL_SPC_BT709; else if (idx == 1) - avctx->colorspace = AVCOL_SPC_BT470BG; + dsh->colorspace = AVCOL_SPC_BT470BG; } - - if (get_bits1(gb) && !svq3_get_ue_golomb(gb)) - avctx->color_trc = AVCOL_TRC_BT709; + /* [DIRAC_STD] 10.3.9.3 Transfer function */ + if (bitstream_read_bit(bc) && !get_interleaved_ue_golomb(bc)) + dsh->color_trc = AVCOL_TRC_BT709; } } else { - idx = source->color_spec_index; - avctx->color_primaries = dirac_color_presets[idx].color_primaries; - avctx->colorspace = dirac_color_presets[idx].colorspace; - avctx->color_trc = dirac_color_presets[idx].color_trc; + idx = dsh->color_spec_index; + dsh->color_primaries = dirac_color_presets[idx].color_primaries; + dsh->colorspace = dirac_color_presets[idx].colorspace; + dsh->color_trc = dirac_color_presets[idx].color_trc; } return 0; } -int avpriv_dirac_parse_sequence_header(AVCodecContext *avctx, GetBitContext *gb, - dirac_source_params *source) +/* [DIRAC_STD] 10. Sequence Header. sequence_header() */ +int av_dirac_parse_sequence_header(AVDiracSeqHeader **pdsh, + const uint8_t *buf, size_t buf_size, + void *log_ctx) { + AVDiracSeqHeader *dsh; + BitstreamContext bc; unsigned version_major; unsigned video_format, picture_coding_mode; + int ret; + + dsh = av_mallocz(sizeof(*dsh)); + if (!dsh) + return AVERROR(ENOMEM); + + ret = bitstream_init8(&bc, buf, buf_size); + if (ret < 0) + goto fail; + + /* [DIRAC_SPEC] 10.1 Parse Parameters. parse_parameters() */ + version_major = get_interleaved_ue_golomb(&bc); + get_interleaved_ue_golomb(&bc); /* version_minor */ + dsh->profile = get_interleaved_ue_golomb(&bc); + dsh->level = get_interleaved_ue_golomb(&bc); + /* [DIRAC_SPEC] sequence_header() -> base_video_format as defined in + * 10.2 Base Video Format, table 10.1 Dirac predefined video formats */ + video_format = get_interleaved_ue_golomb(&bc); + + if (log_ctx) { + if (version_major < 2) + av_log(log_ctx, AV_LOG_WARNING, "Stream is old and may not work\n"); + else if (version_major > 2) + av_log(log_ctx, AV_LOG_WARNING, "Stream may have unhandled features\n"); + } - version_major = svq3_get_ue_golomb(gb); - svq3_get_ue_golomb(gb); /* version_minor */ - avctx->profile = svq3_get_ue_golomb(gb); - avctx->level = svq3_get_ue_golomb(gb); - video_format = svq3_get_ue_golomb(gb); - - if (version_major < 2) - av_log(avctx, AV_LOG_WARNING, "Stream is old and may not work\n"); - else if (version_major > 2) - av_log(avctx, AV_LOG_WARNING, "Stream may have unhandled features\n"); - - if (video_format > 20) - return -1; + if (video_format > 20) { + ret = AVERROR_INVALIDDATA; + goto fail; + } // Fill in defaults for the source parameters. - *source = dirac_source_parameters_defaults[video_format]; - - // Override the defaults. - if (parse_source_parameters(avctx, gb, source)) - return -1; - - if (av_image_check_size(source->width, source->height, 0, avctx)) - return -1; - - avcodec_set_dimensions(avctx, source->width, source->height); - - // currently only used to signal field coding - picture_coding_mode = svq3_get_ue_golomb(gb); + dsh->width = dirac_source_parameters_defaults[video_format].width; + dsh->height = dirac_source_parameters_defaults[video_format].height; + dsh->chroma_format = dirac_source_parameters_defaults[video_format].chroma_format; + dsh->interlaced = dirac_source_parameters_defaults[video_format].interlaced; + dsh->top_field_first = dirac_source_parameters_defaults[video_format].top_field_first; + dsh->frame_rate_index = dirac_source_parameters_defaults[video_format].frame_rate_index; + dsh->aspect_ratio_index = dirac_source_parameters_defaults[video_format].aspect_ratio_index; + dsh->clean_width = dirac_source_parameters_defaults[video_format].clean_width; + dsh->clean_height = dirac_source_parameters_defaults[video_format].clean_height; + dsh->clean_left_offset = dirac_source_parameters_defaults[video_format].clean_left_offset; + dsh->clean_right_offset = dirac_source_parameters_defaults[video_format].clean_right_offset; + dsh->pixel_range_index = dirac_source_parameters_defaults[video_format].pixel_range_index; + dsh->color_spec_index = dirac_source_parameters_defaults[video_format].color_spec_index; + + /* [DIRAC_STD] 10.3 Source Parameters + * Override the defaults. */ + ret = parse_source_parameters(dsh, &bc, log_ctx); + if (ret < 0) + goto fail; + + /* [DIRAC_STD] picture_coding_mode shall be 0 for fields and 1 for frames + * currently only used to signal field coding */ + picture_coding_mode = get_interleaved_ue_golomb(&bc); if (picture_coding_mode != 0) { - av_log(avctx, AV_LOG_ERROR, "Unsupported picture coding mode %d", - picture_coding_mode); - return -1; + if (log_ctx) { + av_log(log_ctx, AV_LOG_ERROR, "Unsupported picture coding mode %d", + picture_coding_mode); + } + ret = AVERROR_INVALIDDATA; + goto fail; } + + *pdsh = dsh; return 0; +fail: + av_freep(&dsh); + *pdsh = NULL; + return ret; +} +#else +int av_dirac_parse_sequence_header(AVDiracSeqHeader **pdsh, + const uint8_t *buf, size_t buf_size, + void *log_ctx) +{ + return AVERROR(ENOSYS); } +#endif