X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=libavcodec%2Fvb.c;h=e7002a1def5562557d824fc3659c4aacbe5d85d7;hb=5e239c7f9e57d09c6a4c1d5762f441950f8d979c;hp=4c927888975558f242e9d38da5adcd84dec2b227;hpb=bad5537e2c2caeb5deb1ff9d771ea01058b8010c;p=ffmpeg diff --git a/libavcodec/vb.c b/libavcodec/vb.c index 4c927888975..e7002a1def5 100644 --- a/libavcodec/vb.c +++ b/libavcodec/vb.c @@ -2,25 +2,25 @@ * Beam Software VB decoder * Copyright (c) 2007 Konstantin Shishkov * - * This file is part of FFmpeg. + * This file is part of Libav. * - * FFmpeg is free software; you can redistribute it and/or + * Libav is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * - * FFmpeg is distributed in the hope that it will be useful, + * Libav is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with FFmpeg; if not, write to the Free Software + * License along with Libav; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ /** - * @file libavcodec/vb.c + * @file * VB Video decoder */ @@ -43,8 +43,8 @@ typedef struct VBDecContext { AVFrame pic; uint8_t *frame, *prev_frame; - uint32_t pal[256]; - const uint8_t *stream; + uint32_t pal[AVPALETTE_COUNT]; + GetByteContext stream; } VBDecContext; static const uint16_t vb_patterns[64] = { @@ -58,18 +58,22 @@ static const uint16_t vb_patterns[64] = { 0xC631, 0x6310, 0xC060, 0x0136, 0x136C, 0x36C8, 0x6C80, 0x324C }; -static void vb_decode_palette(VBDecContext *c) +static void vb_decode_palette(VBDecContext *c, int data_size) { int start, size, i; - start = bytestream_get_byte(&c->stream); - size = (bytestream_get_byte(&c->stream) - 1) & 0xFF; + start = bytestream2_get_byte(&c->stream); + size = (bytestream2_get_byte(&c->stream) - 1) & 0xFF; if(start + size > 255){ av_log(c->avctx, AV_LOG_ERROR, "Palette change runs beyond entry 256\n"); return; } + if(size*3+2 > data_size){ + av_log(c->avctx, AV_LOG_ERROR, "Palette data runs beyond chunk size\n"); + return; + } for(i = start; i <= start + size; i++) - c->pal[i] = bytestream_get_be24(&c->stream); + c->pal[i] = bytestream2_get_be24(&c->stream); } static inline int check_pixel(uint8_t *buf, uint8_t *start, uint8_t *end) @@ -82,8 +86,9 @@ static inline int check_line(uint8_t *buf, uint8_t *start, uint8_t *end) return buf >= start && (buf + 4) <= end; } -static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) +static int vb_decode_framedata(VBDecContext *c, int offset) { + GetByteContext g; uint8_t *prev, *cur; int blk, blocks, t, blk2; int blocktypes = 0; @@ -93,14 +98,17 @@ static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) uint8_t *pstart = c->prev_frame; uint8_t *pend = c->prev_frame + width*c->avctx->height; + g = c->stream; + prev = c->prev_frame + offset; cur = c->frame; blocks = (c->avctx->width >> 2) * (c->avctx->height >> 2); blk2 = 0; for(blk = 0; blk < blocks; blk++){ - if(!(blk & 3)) - blocktypes = bytestream_get_byte(&buf); + if(!(blk & 3)) { + blocktypes = bytestream2_get_byte(&g); + } switch(blocktypes & 0xC0){ case 0x00: //skip for(y = 0; y < 4; y++) @@ -110,11 +118,14 @@ static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) memset(cur + y*width, 0, 4); break; case 0x40: - t = bytestream_get_byte(&buf); + t = bytestream2_get_byte(&g); if(!t){ //raw block + if (bytestream2_get_bytes_left(&g) < 16) { + av_log(c->avctx, AV_LOG_ERROR, "Insufficient data\n"); + return -1; + } for(y = 0; y < 4; y++) - memcpy(cur + y*width, buf + y*4, 4); - buf += 16; + bytestream2_get_buffer(&g, cur + y * width, 4); }else{ // motion compensation x = ((t & 0xF)^8) - 8; y = ((t >> 4) ^8) - 8; @@ -127,18 +138,18 @@ static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) } break; case 0x80: // fill - t = bytestream_get_byte(&buf); + t = bytestream2_get_byte(&g); for(y = 0; y < 4; y++) memset(cur + y*width, t, 4); break; case 0xC0: // pattern fill - t = bytestream_get_byte(&buf); + t = bytestream2_get_byte(&g); pattype = t >> 6; pattern = vb_patterns[t & 0x3F]; switch(pattype){ case 0: - a = bytestream_get_byte(&buf); - b = bytestream_get_byte(&buf); + a = bytestream2_get_byte(&g); + b = bytestream2_get_byte(&g); for(y = 0; y < 4; y++) for(x = 0; x < 4; x++, pattern >>= 1) cur[x + y*width] = (pattern & 1) ? b : a; @@ -146,7 +157,7 @@ static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) case 1: pattern = ~pattern; case 2: - a = bytestream_get_byte(&buf); + a = bytestream2_get_byte(&g); for(y = 0; y < 4; y++) for(x = 0; x < 4; x++, pattern >>= 1) if(pattern & 1 && check_pixel(prev + x + y*width, pstart, pend)) @@ -173,44 +184,40 @@ static int vb_decode_framedata(VBDecContext *c, const uint8_t *buf, int offset) return 0; } -static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, const uint8_t *buf, int buf_size) +static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, AVPacket *avpkt) { VBDecContext * const c = avctx->priv_data; uint8_t *outptr, *srcptr; int i, j; int flags; uint32_t size; - int rest = buf_size; int offset = 0; - c->stream = buf; - flags = bytestream_get_le16(&c->stream); - rest -= 2; + bytestream2_init(&c->stream, avpkt->data, avpkt->size); + + if(c->pic.data[0]) + avctx->release_buffer(avctx, &c->pic); + c->pic.reference = 1; + if(avctx->get_buffer(avctx, &c->pic) < 0){ + av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n"); + return -1; + } + + flags = bytestream2_get_le16(&c->stream); if(flags & VB_HAS_GMC){ - i = (int16_t)bytestream_get_le16(&c->stream); - j = (int16_t)bytestream_get_le16(&c->stream); + i = (int16_t)bytestream2_get_le16(&c->stream); + j = (int16_t)bytestream2_get_le16(&c->stream); offset = i + j * avctx->width; - rest -= 4; } if(flags & VB_HAS_VIDEO){ - size = bytestream_get_le32(&c->stream); - if(size > rest){ - av_log(avctx, AV_LOG_ERROR, "Frame size is too big\n"); - return -1; - } - vb_decode_framedata(c, c->stream, offset); - c->stream += size - 4; - rest -= size; + size = bytestream2_get_le32(&c->stream); + vb_decode_framedata(c, offset); + bytestream2_skip(&c->stream, size - 4); } if(flags & VB_HAS_PALETTE){ - size = bytestream_get_le32(&c->stream); - if(size > rest){ - av_log(avctx, AV_LOG_ERROR, "Palette size is too big\n"); - return -1; - } - vb_decode_palette(c); - rest -= size; + size = bytestream2_get_le32(&c->stream); + vb_decode_palette(c, size); } memcpy(c->pic.data[1], c->pal, AVPALETTE_SIZE); @@ -231,7 +238,7 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, const *(AVFrame*)data = c->pic; /* always report that the buffer was completely consumed */ - return buf_size; + return avpkt->size; } static av_cold int decode_init(AVCodecContext *avctx) @@ -241,18 +248,8 @@ static av_cold int decode_init(AVCodecContext *avctx) c->avctx = avctx; avctx->pix_fmt = PIX_FMT_PAL8; - if (avcodec_check_dimensions(avctx, avctx->width, avctx->height) < 0) { - return -1; - } - - c->pic.reference = 1; - if(avctx->get_buffer(avctx, &c->pic) < 0){ - av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n"); - return -1; - } - - c->frame = av_malloc( avctx->width * avctx->height); - c->prev_frame = av_malloc( avctx->width * avctx->height); + c->frame = av_mallocz(avctx->width * avctx->height); + c->prev_frame = av_mallocz(avctx->width * avctx->height); return 0; } @@ -269,15 +266,13 @@ static av_cold int decode_end(AVCodecContext *avctx) return 0; } -AVCodec vb_decoder = { - "vb", - CODEC_TYPE_VIDEO, - CODEC_ID_VB, - sizeof(VBDecContext), - decode_init, - NULL, - decode_end, - decode_frame, +AVCodec ff_vb_decoder = { + .name = "vb", + .type = AVMEDIA_TYPE_VIDEO, + .id = CODEC_ID_VB, + .priv_data_size = sizeof(VBDecContext), + .init = decode_init, + .close = decode_end, + .decode = decode_frame, .long_name = NULL_IF_CONFIG_SMALL("Beam Software VB"), }; -