X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=libavcodec%2Fzmbv.c;h=d17f37a59f13c8a24d1db898acc6e63ec50a7e53;hb=b2bed9325dbd6be0da1d91ffed3f513c40274fd2;hp=6943ff3568470f05cc1d4e8764e1db053997e5c5;hpb=6a5d31ac25f55248af5725287833d007ff78b188;p=ffmpeg

diff --git a/libavcodec/zmbv.c b/libavcodec/zmbv.c
index 6943ff35684..d17f37a59f1 100644
--- a/libavcodec/zmbv.c
+++ b/libavcodec/zmbv.c
@@ -2,33 +2,35 @@
  * Zip Motion Blocks Video (ZMBV) decoder
  * Copyright (c) 2006 Konstantin Shishkov
  *
- * This file is part of FFmpeg.
+ * This file is part of Libav.
  *
- * FFmpeg is free software; you can redistribute it and/or
+ * Libav is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2.1 of the License, or (at your option) any later version.
  *
- * FFmpeg is distributed in the hope that it will be useful,
+ * Libav is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with FFmpeg; if not, write to the Free Software
+ * License along with Libav; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 /**
- * @file zmbv.c
+ * @file
  * Zip Motion Blocks Video decoder
  */
 
 #include <stdio.h>
 #include <stdlib.h>
 
+#include "libavutil/common.h"
 #include "libavutil/intreadwrite.h"
 #include "avcodec.h"
+#include "internal.h"
 
 #include <zlib.h>
 
@@ -52,7 +54,6 @@ enum ZmbvFormat {
  */
 typedef struct ZmbvContext {
     AVCodecContext *avctx;
-    AVFrame pic;
 
     int bpp;
     unsigned int decomp_size;
@@ -88,8 +89,8 @@ static int zmbv_decode_xor_8(ZmbvContext *c)
     output = c->cur;
     prev = c->prev;
 
-    if(c->flags & ZMBV_DELTAPAL){
-        for(i = 0; i < 768; i++)
+    if (c->flags & ZMBV_DELTAPAL) {
+        for (i = 0; i < 768; i++)
             c->pal[i] ^= *src++;
     }
 
@@ -97,9 +98,9 @@ static int zmbv_decode_xor_8(ZmbvContext *c)
     src += ((c->bx * c->by * 2 + 3) & ~3);
 
     block = 0;
-    for(y = 0; y < c->height; y += c->bh) {
+    for (y = 0; y < c->height; y += c->bh) {
         bh2 = ((c->height - y) > c->bh) ? c->bh : (c->height - y);
-        for(x = 0; x < c->width; x += c->bw) {
+        for (x = 0; x < c->width; x += c->bw) {
             uint8_t *out, *tprev;
 
             d = mvec[block] & 1;
@@ -114,12 +115,12 @@ static int zmbv_decode_xor_8(ZmbvContext *c)
             tprev = prev + x + dx + dy * c->width;
             mx = x + dx;
             my = y + dy;
-            for(j = 0; j < bh2; j++){
-                if((my + j < 0) || (my + j >= c->height)) {
+            for (j = 0; j < bh2; j++) {
+                if (my + j < 0 || my + j >= c->height) {
                     memset(out, 0, bw2);
                 } else {
-                    for(i = 0; i < bw2; i++){
-                        if((mx + i < 0) || (mx + i >= c->width))
+                    for (i = 0; i < bw2; i++) {
+                        if (mx + i < 0 || mx + i >= c->width)
                             out[i] = 0;
                         else
                             out[i] = tprev[i];
@@ -129,10 +130,10 @@ static int zmbv_decode_xor_8(ZmbvContext *c)
                 tprev += c->width;
             }
 
-            if(d) { /* apply XOR'ed difference */
+            if (d) { /* apply XOR'ed difference */
                 out = output + x;
-                for(j = 0; j < bh2; j++){
-                    for(i = 0; i < bw2; i++)
+                for (j = 0; j < bh2; j++) {
+                    for (i = 0; i < bw2; i++)
                         out[i] ^= *src++;
                     out += c->width;
                 }
@@ -141,8 +142,9 @@ static int zmbv_decode_xor_8(ZmbvContext *c)
         output += c->width * c->bh;
         prev += c->width * c->bh;
     }
-    if(src - c->decomp_buf != c->decomp_len)
-        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n", src-c->decomp_buf, c->decomp_len);
+    if (src - c->decomp_buf != c->decomp_len)
+        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n",
+               src-c->decomp_buf, c->decomp_len);
     return 0;
 }
 
@@ -168,9 +170,9 @@ static int zmbv_decode_xor_16(ZmbvContext *c)
     src += ((c->bx * c->by * 2 + 3) & ~3);
 
     block = 0;
-    for(y = 0; y < c->height; y += c->bh) {
+    for (y = 0; y < c->height; y += c->bh) {
         bh2 = ((c->height - y) > c->bh) ? c->bh : (c->height - y);
-        for(x = 0; x < c->width; x += c->bw) {
+        for (x = 0; x < c->width; x += c->bw) {
             uint16_t *out, *tprev;
 
             d = mvec[block] & 1;
@@ -185,12 +187,12 @@ static int zmbv_decode_xor_16(ZmbvContext *c)
             tprev = prev + x + dx + dy * c->width;
             mx = x + dx;
             my = y + dy;
-            for(j = 0; j < bh2; j++){
-                if((my + j < 0) || (my + j >= c->height)) {
+            for (j = 0; j < bh2; j++) {
+                if (my + j < 0 || my + j >= c->height) {
                     memset(out, 0, bw2 * 2);
                 } else {
-                    for(i = 0; i < bw2; i++){
-                        if((mx + i < 0) || (mx + i >= c->width))
+                    for (i = 0; i < bw2; i++) {
+                        if (mx + i < 0 || mx + i >= c->width)
                             out[i] = 0;
                         else
                             out[i] = tprev[i];
@@ -200,10 +202,10 @@ static int zmbv_decode_xor_16(ZmbvContext *c)
                 tprev += c->width;
             }
 
-            if(d) { /* apply XOR'ed difference */
+            if (d) { /* apply XOR'ed difference */
                 out = output + x;
-                for(j = 0; j < bh2; j++){
-                    for(i = 0; i < bw2; i++) {
+                for (j = 0; j < bh2; j++){
+                    for (i = 0; i < bw2; i++) {
                         out[i] ^= *((uint16_t*)src);
                         src += 2;
                     }
@@ -214,8 +216,9 @@ static int zmbv_decode_xor_16(ZmbvContext *c)
         output += c->width * c->bh;
         prev += c->width * c->bh;
     }
-    if(src - c->decomp_buf != c->decomp_len)
-        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n", src-c->decomp_buf, c->decomp_len);
+    if (src - c->decomp_buf != c->decomp_len)
+        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n",
+               src-c->decomp_buf, c->decomp_len);
     return 0;
 }
 
@@ -244,9 +247,9 @@ static int zmbv_decode_xor_24(ZmbvContext *c)
     src += ((c->bx * c->by * 2 + 3) & ~3);
 
     block = 0;
-    for(y = 0; y < c->height; y += c->bh) {
+    for (y = 0; y < c->height; y += c->bh) {
         bh2 = ((c->height - y) > c->bh) ? c->bh : (c->height - y);
-        for(x = 0; x < c->width; x += c->bw) {
+        for (x = 0; x < c->width; x += c->bw) {
             uint8_t *out, *tprev;
 
             d = mvec[block] & 1;
@@ -261,12 +264,12 @@ static int zmbv_decode_xor_24(ZmbvContext *c)
             tprev = prev + (x + dx) * 3 + dy * stride;
             mx = x + dx;
             my = y + dy;
-            for(j = 0; j < bh2; j++){
-                if((my + j < 0) || (my + j >= c->height)) {
+            for (j = 0; j < bh2; j++) {
+                if (my + j < 0 || my + j >= c->height) {
                     memset(out, 0, bw2 * 3);
                 } else {
-                    for(i = 0; i < bw2; i++){
-                        if((mx + i < 0) || (mx + i >= c->width)) {
+                    for (i = 0; i < bw2; i++){
+                        if (mx + i < 0 || mx + i >= c->width) {
                             out[i * 3 + 0] = 0;
                             out[i * 3 + 1] = 0;
                             out[i * 3 + 2] = 0;
@@ -281,10 +284,10 @@ static int zmbv_decode_xor_24(ZmbvContext *c)
                 tprev += stride;
             }
 
-            if(d) { /* apply XOR'ed difference */
+            if (d) { /* apply XOR'ed difference */
                 out = output + x * 3;
-                for(j = 0; j < bh2; j++){
-                    for(i = 0; i < bw2; i++) {
+                for (j = 0; j < bh2; j++) {
+                    for (i = 0; i < bw2; i++) {
                         out[i * 3 + 0] ^= *src++;
                         out[i * 3 + 1] ^= *src++;
                         out[i * 3 + 2] ^= *src++;
@@ -296,8 +299,9 @@ static int zmbv_decode_xor_24(ZmbvContext *c)
         output += stride * c->bh;
         prev += stride * c->bh;
     }
-    if(src - c->decomp_buf != c->decomp_len)
-        av_log(c->avctx, AV_LOG_ERROR, "Used %i of %i bytes\n", src-c->decomp_buf, c->decomp_len);
+    if (src - c->decomp_buf != c->decomp_len)
+        av_log(c->avctx, AV_LOG_ERROR, "Used %i of %i bytes\n",
+               src-c->decomp_buf, c->decomp_len);
     return 0;
 }
 #endif //ZMBV_ENABLE_24BPP
@@ -324,9 +328,9 @@ static int zmbv_decode_xor_32(ZmbvContext *c)
     src += ((c->bx * c->by * 2 + 3) & ~3);
 
     block = 0;
-    for(y = 0; y < c->height; y += c->bh) {
+    for (y = 0; y < c->height; y += c->bh) {
         bh2 = ((c->height - y) > c->bh) ? c->bh : (c->height - y);
-        for(x = 0; x < c->width; x += c->bw) {
+        for (x = 0; x < c->width; x += c->bw) {
             uint32_t *out, *tprev;
 
             d = mvec[block] & 1;
@@ -341,12 +345,12 @@ static int zmbv_decode_xor_32(ZmbvContext *c)
             tprev = prev + x + dx + dy * c->width;
             mx = x + dx;
             my = y + dy;
-            for(j = 0; j < bh2; j++){
-                if((my + j < 0) || (my + j >= c->height)) {
+            for (j = 0; j < bh2; j++) {
+                if (my + j < 0 || my + j >= c->height) {
                     memset(out, 0, bw2 * 4);
                 } else {
-                    for(i = 0; i < bw2; i++){
-                        if((mx + i < 0) || (mx + i >= c->width))
+                    for (i = 0; i < bw2; i++){
+                        if (mx + i < 0 || mx + i >= c->width)
                             out[i] = 0;
                         else
                             out[i] = tprev[i];
@@ -356,11 +360,11 @@ static int zmbv_decode_xor_32(ZmbvContext *c)
                 tprev += c->width;
             }
 
-            if(d) { /* apply XOR'ed difference */
+            if (d) { /* apply XOR'ed difference */
                 out = output + x;
-                for(j = 0; j < bh2; j++){
-                    for(i = 0; i < bw2; i++) {
-                        out[i] ^= *((uint32_t*)src);
+                for (j = 0; j < bh2; j++){
+                    for (i = 0; i < bw2; i++) {
+                        out[i] ^= *((uint32_t *) src);
                         src += 4;
                     }
                     out += c->width;
@@ -368,10 +372,11 @@ static int zmbv_decode_xor_32(ZmbvContext *c)
             }
         }
         output += c->width * c->bh;
-        prev += c->width * c->bh;
+        prev   += c->width * c->bh;
     }
-    if(src - c->decomp_buf != c->decomp_len)
-        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n", src-c->decomp_buf, c->decomp_len);
+    if (src - c->decomp_buf != c->decomp_len)
+        av_log(c->avctx, AV_LOG_ERROR, "Used %ti of %i bytes\n",
+               src-c->decomp_buf, c->decomp_len);
     return 0;
 }
 
@@ -392,53 +397,54 @@ static int zmbv_decode_intra(ZmbvContext *c)
     return 0;
 }
 
-static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, const uint8_t *buf, int buf_size)
+static int decode_frame(AVCodecContext *avctx, void *data, int *got_frame, AVPacket *avpkt)
 {
+    AVFrame *frame = data;
+    const uint8_t *buf = avpkt->data;
+    int buf_size = avpkt->size;
     ZmbvContext * const c = avctx->priv_data;
-    uint8_t *outptr;
     int zret = Z_OK; // Zlib return code
     int len = buf_size;
-    int hi_ver, lo_ver;
-
-    if(c->pic.data[0])
-            avctx->release_buffer(avctx, &c->pic);
+    int hi_ver, lo_ver, ret;
+    uint8_t *tmp;
 
-    c->pic.reference = 1;
-    c->pic.buffer_hints = FF_BUFFER_HINTS_VALID;
-    if(avctx->get_buffer(avctx, &c->pic) < 0){
+    if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) {
         av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
-        return -1;
+        return ret;
     }
 
-    outptr = c->pic.data[0]; // Output image pointer
-
     /* parse header */
     c->flags = buf[0];
     buf++; len--;
-    if(c->flags & ZMBV_KEYFRAME) {
+    if (c->flags & ZMBV_KEYFRAME) {
         hi_ver = buf[0];
         lo_ver = buf[1];
         c->comp = buf[2];
         c->fmt = buf[3];
         c->bw = buf[4];
         c->bh = buf[5];
+        c->decode_intra = NULL;
+        c->decode_xor = NULL;
 
         buf += 6;
         len -= 6;
-        av_log(avctx, AV_LOG_DEBUG, "Flags=%X ver=%i.%i comp=%i fmt=%i blk=%ix%i\n",c->flags,hi_ver,lo_ver,c->comp,c->fmt,c->bw,c->bh);
-        if(hi_ver != 0 || lo_ver != 1) {
-            av_log(avctx, AV_LOG_ERROR, "Unsupported version %i.%i\n", hi_ver, lo_ver);
-            return -1;
+        av_log(avctx, AV_LOG_DEBUG,
+               "Flags=%X ver=%i.%i comp=%i fmt=%i blk=%ix%i\n",
+               c->flags,hi_ver,lo_ver,c->comp,c->fmt,c->bw,c->bh);
+        if (hi_ver != 0 || lo_ver != 1) {
+            avpriv_request_sample(avctx, "Version %i.%i", hi_ver, lo_ver);
+            return AVERROR_PATCHWELCOME;
         }
-        if(c->bw == 0 || c->bh == 0) {
-            av_log(avctx, AV_LOG_ERROR, "Unsupported block size %ix%i\n", c->bw, c->bh);
+        if (c->bw == 0 || c->bh == 0) {
+            avpriv_request_sample(avctx, "Block size %ix%i", c->bw, c->bh);
+            return AVERROR_PATCHWELCOME;
         }
-        if(c->comp != 0 && c->comp != 1) {
-            av_log(avctx, AV_LOG_ERROR, "Unsupported compression type %i\n", c->comp);
-            return -1;
+        if (c->comp != 0 && c->comp != 1) {
+            avpriv_request_sample(avctx, "Compression type %i", c->comp);
+            return AVERROR_PATCHWELCOME;
         }
 
-        switch(c->fmt) {
+        switch (c->fmt) {
         case ZMBV_FMT_8BPP:
             c->bpp = 8;
             c->decode_intra = zmbv_decode_intra;
@@ -465,47 +471,60 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, const
         default:
             c->decode_intra = NULL;
             c->decode_xor = NULL;
-            av_log(avctx, AV_LOG_ERROR, "Unsupported (for now) format %i\n", c->fmt);
-            return -1;
+            avpriv_request_sample(avctx, "Format %i", c->fmt);
+            return AVERROR_PATCHWELCOME;
         }
 
         zret = inflateReset(&c->zstream);
         if (zret != Z_OK) {
             av_log(avctx, AV_LOG_ERROR, "Inflate reset error: %d\n", zret);
-            return -1;
+            return AVERROR_UNKNOWN;
         }
 
-        c->cur = av_realloc(c->cur, avctx->width * avctx->height * (c->bpp / 8));
-        c->prev = av_realloc(c->prev, avctx->width * avctx->height * (c->bpp / 8));
-        c->bx = (c->width + c->bw - 1) / c->bw;
-        c->by = (c->height+ c->bh - 1) / c->bh;
+        tmp = av_realloc(c->cur,  avctx->width * avctx->height * (c->bpp / 8));
+        if (!tmp)
+            return AVERROR(ENOMEM);
+        c->cur = tmp;
+        tmp = av_realloc(c->prev, avctx->width * avctx->height * (c->bpp / 8));
+        if (!tmp)
+            return AVERROR(ENOMEM);
+        c->prev = tmp;
+        c->bx   = (c->width  + c->bw - 1) / c->bw;
+        c->by   = (c->height + c->bh - 1) / c->bh;
     }
 
-    if(c->decode_intra == NULL) {
+    if (c->decode_intra == NULL) {
         av_log(avctx, AV_LOG_ERROR, "Error! Got no format or no keyframe!\n");
-        return -1;
+        return AVERROR_INVALIDDATA;
     }
 
-    if(c->comp == 0) { //Uncompressed data
+    if (c->comp == 0) { //Uncompressed data
+        if (c->decomp_size < len) {
+            av_log(avctx, AV_LOG_ERROR, "Buffer too small\n");
+            return AVERROR_INVALIDDATA;
+        }
         memcpy(c->decomp_buf, buf, len);
-        c->decomp_size = 1;
     } else { // ZLIB-compressed data
         c->zstream.total_in = c->zstream.total_out = 0;
         c->zstream.next_in = buf;
         c->zstream.avail_in = len;
         c->zstream.next_out = c->decomp_buf;
         c->zstream.avail_out = c->decomp_size;
-        inflate(&c->zstream, Z_FINISH);
+        zret = inflate(&c->zstream, Z_SYNC_FLUSH);
+        if (zret != Z_OK && zret != Z_STREAM_END) {
+            av_log(avctx, AV_LOG_ERROR, "inflate error %d\n", zret);
+            return AVERROR_INVALIDDATA;
+        }
         c->decomp_len = c->zstream.total_out;
     }
-    if(c->flags & ZMBV_KEYFRAME) {
-        c->pic.key_frame = 1;
-        c->pic.pict_type = FF_I_TYPE;
+    if (c->flags & ZMBV_KEYFRAME) {
+        frame->key_frame = 1;
+        frame->pict_type = AV_PICTURE_TYPE_I;
         c->decode_intra(c);
     } else {
-        c->pic.key_frame = 0;
-        c->pic.pict_type = FF_P_TYPE;
-        if(c->decomp_len)
+        frame->key_frame = 0;
+        frame->pict_type = AV_PICTURE_TYPE_P;
+        if (c->decomp_len)
             c->decode_xor(c);
     }
 
@@ -514,82 +533,74 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *data_size, const
         uint8_t *out, *src;
         int i, j;
 
-        out = c->pic.data[0];
+        out = frame->data[0];
         src = c->cur;
-        switch(c->fmt) {
+        switch (c->fmt) {
         case ZMBV_FMT_8BPP:
-            for(j = 0; j < c->height; j++) {
-                for(i = 0; i < c->width; i++) {
+            for (j = 0; j < c->height; j++) {
+                for (i = 0; i < c->width; i++) {
                     out[i * 3 + 0] = c->pal[(*src) * 3 + 0];
                     out[i * 3 + 1] = c->pal[(*src) * 3 + 1];
                     out[i * 3 + 2] = c->pal[(*src) * 3 + 2];
                     src++;
                 }
-                out += c->pic.linesize[0];
+                out += frame->linesize[0];
             }
             break;
         case ZMBV_FMT_15BPP:
-            for(j = 0; j < c->height; j++) {
-                for(i = 0; i < c->width; i++) {
+            for (j = 0; j < c->height; j++) {
+                for (i = 0; i < c->width; i++) {
                     uint16_t tmp = AV_RL16(src);
                     src += 2;
                     out[i * 3 + 0] = (tmp & 0x7C00) >> 7;
                     out[i * 3 + 1] = (tmp & 0x03E0) >> 2;
                     out[i * 3 + 2] = (tmp & 0x001F) << 3;
                 }
-                out += c->pic.linesize[0];
+                out += frame->linesize[0];
             }
             break;
         case ZMBV_FMT_16BPP:
-            for(j = 0; j < c->height; j++) {
-                for(i = 0; i < c->width; i++) {
+            for (j = 0; j < c->height; j++) {
+                for (i = 0; i < c->width; i++) {
                     uint16_t tmp = AV_RL16(src);
                     src += 2;
                     out[i * 3 + 0] = (tmp & 0xF800) >> 8;
                     out[i * 3 + 1] = (tmp & 0x07E0) >> 3;
                     out[i * 3 + 2] = (tmp & 0x001F) << 3;
                 }
-                out += c->pic.linesize[0];
+                out += frame->linesize[0];
             }
             break;
 #ifdef ZMBV_ENABLE_24BPP
         case ZMBV_FMT_24BPP:
-            for(j = 0; j < c->height; j++) {
+            for (j = 0; j < c->height; j++) {
                 memcpy(out, src, c->width * 3);
                 src += c->width * 3;
-                out += c->pic.linesize[0];
+                out += frame->linesize[0];
             }
             break;
 #endif //ZMBV_ENABLE_24BPP
         case ZMBV_FMT_32BPP:
-            for(j = 0; j < c->height; j++) {
-                for(i = 0; i < c->width; i++) {
+            for (j = 0; j < c->height; j++) {
+                for (i = 0; i < c->width; i++) {
                     uint32_t tmp = AV_RL32(src);
                     src += 4;
                     AV_WB24(out+(i*3), tmp);
                 }
-                out += c->pic.linesize[0];
+                out += frame->linesize[0];
             }
             break;
         default:
             av_log(avctx, AV_LOG_ERROR, "Cannot handle format %i\n", c->fmt);
         }
-        memcpy(c->prev, c->cur, c->width * c->height * (c->bpp / 8));
+        FFSWAP(uint8_t *, c->cur, c->prev);
     }
-    *data_size = sizeof(AVFrame);
-    *(AVFrame*)data = c->pic;
+    *got_frame = 1;
 
     /* always report that the buffer was completely consumed */
     return buf_size;
 }
 
-
-
-/*
- *
- * Init zmbv decoder
- *
- */
 static av_cold int decode_init(AVCodecContext *avctx)
 {
     ZmbvContext * const c = avctx->priv_data;
@@ -597,72 +608,59 @@ static av_cold int decode_init(AVCodecContext *avctx)
 
     c->avctx = avctx;
 
-    c->pic.data[0] = NULL;
     c->width = avctx->width;
     c->height = avctx->height;
 
-    if (avcodec_check_dimensions(avctx, avctx->width, avctx->height) < 0) {
-        return 1;
-    }
     c->bpp = avctx->bits_per_coded_sample;
 
     // Needed if zlib unused or init aborted before inflateInit
-    memset(&(c->zstream), 0, sizeof(z_stream));
+    memset(&c->zstream, 0, sizeof(z_stream));
 
-    avctx->pix_fmt = PIX_FMT_RGB24;
+    avctx->pix_fmt = AV_PIX_FMT_RGB24;
     c->decomp_size = (avctx->width + 255) * 4 * (avctx->height + 64);
 
     /* Allocate decompression buffer */
     if (c->decomp_size) {
         if ((c->decomp_buf = av_malloc(c->decomp_size)) == NULL) {
-            av_log(avctx, AV_LOG_ERROR, "Can't allocate decompression buffer.\n");
-            return 1;
+            av_log(avctx, AV_LOG_ERROR,
+                   "Can't allocate decompression buffer.\n");
+            return AVERROR(ENOMEM);
         }
     }
 
     c->zstream.zalloc = Z_NULL;
     c->zstream.zfree = Z_NULL;
     c->zstream.opaque = Z_NULL;
-    zret = inflateInit(&(c->zstream));
+    zret = inflateInit(&c->zstream);
     if (zret != Z_OK) {
         av_log(avctx, AV_LOG_ERROR, "Inflate init error: %d\n", zret);
-        return 1;
+        return AVERROR_UNKNOWN;
     }
 
     return 0;
 }
 
-
-
-/*
- *
- * Uninit zmbv decoder
- *
- */
 static av_cold int decode_end(AVCodecContext *avctx)
 {
     ZmbvContext * const c = avctx->priv_data;
 
     av_freep(&c->decomp_buf);
 
-    if (c->pic.data[0])
-        avctx->release_buffer(avctx, &c->pic);
-    inflateEnd(&(c->zstream));
+    inflateEnd(&c->zstream);
     av_freep(&c->cur);
     av_freep(&c->prev);
 
     return 0;
 }
 
-AVCodec zmbv_decoder = {
-    "zmbv",
-    CODEC_TYPE_VIDEO,
-    CODEC_ID_ZMBV,
-    sizeof(ZmbvContext),
-    decode_init,
-    NULL,
-    decode_end,
-    decode_frame,
-    .long_name = NULL_IF_CONFIG_SMALL("Zip Motion Blocks Video"),
+AVCodec ff_zmbv_decoder = {
+    .name           = "zmbv",
+    .long_name      = NULL_IF_CONFIG_SMALL("Zip Motion Blocks Video"),
+    .type           = AVMEDIA_TYPE_VIDEO,
+    .id             = AV_CODEC_ID_ZMBV,
+    .priv_data_size = sizeof(ZmbvContext),
+    .init           = decode_init,
+    .close          = decode_end,
+    .decode         = decode_frame,
+    .capabilities   = CODEC_CAP_DR1,
 };
-