X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Faccess%2Fdirectory.c;h=f2b8aec07913e54c84e2e9ad9c31e0273c07d651;hb=2c54f289115bc8c0b48bfd5f08b405b778a518ae;hp=feb655e259f4dc83ff095599922f6c6c52ab8856;hpb=300579565c3afadb7bb090335b97583d33501d9b;p=vlc diff --git a/modules/access/directory.c b/modules/access/directory.c index feb655e259..f2b8aec079 100644 --- a/modules/access/directory.c +++ b/modules/access/directory.c @@ -34,15 +34,14 @@ #include "fs.h" #include -#ifdef HAVE_SYS_TYPES_H -# include -#endif +#include #ifdef HAVE_SYS_STAT_H # include #endif #ifdef HAVE_UNISTD_H # include +# include #elif defined( WIN32 ) && !defined( UNDER_CE ) # include #endif @@ -57,7 +56,7 @@ static inline int dirfd (DIR *dir) } #endif -#include +#include #include #include @@ -77,13 +76,16 @@ struct directory_t #ifndef WIN32 struct stat st; #endif - char path[1]; +#ifndef HAVE_OPENAT + char *path; +#endif }; struct access_sys_t { directory_t *current; DIR *handle; + char *uri; char *ignored_exts; int mode; int i_item_count; @@ -100,7 +102,7 @@ int DirOpen( vlc_object_t *p_this ) if( !p_access->psz_path ) return VLC_EGENERIC; - DIR *handle = utf8_opendir (p_access->psz_path); + DIR *handle = vlc_opendir (p_access->psz_path); if (handle == NULL) return VLC_EGENERIC; @@ -110,22 +112,31 @@ int DirOpen( vlc_object_t *p_this ) int DirInit (access_t *p_access, DIR *handle) { access_sys_t *p_sys = malloc (sizeof (*p_sys)); - if (!p_sys) + if (unlikely(p_sys == NULL)) + goto error; + + char *uri; + if (!strcmp (p_access->psz_access, "fd")) { - closedir( handle ); - return VLC_ENOMEM; + if (asprintf (&uri, "fd://%s", p_access->psz_path) == -1) + uri = NULL; } + else + uri = make_URI (p_access->psz_path); + if (unlikely(uri == NULL)) + goto error; p_access->p_sys = p_sys; p_sys->current = NULL; p_sys->handle = handle; - p_sys->ignored_exts = var_CreateGetString (p_access, "ignore-filetypes"); + p_sys->uri = uri; + p_sys->ignored_exts = var_InheritString (p_access, "ignore-filetypes"); p_sys->i_item_count = 0; p_sys->psz_xspf_extension = strdup( "" ); /* Handle mode */ - char *psz = var_CreateGetString( p_access, "recursive" ); - if( *psz == '\0' || !strcasecmp( psz, "none" ) ) + char *psz = var_InheritString (p_access, "recursive"); + if (psz == NULL || !strcasecmp (psz, "none")) p_sys->mode = MODE_NONE; else if( !strcasecmp( psz, "collapse" ) ) p_sys->mode = MODE_COLLAPSE; @@ -142,6 +153,11 @@ int DirInit (access_t *p_access, DIR *handle) p_access->psz_demux = strdup ("xspf-open"); return VLC_SUCCESS; + +error: + closedir (handle); + free (p_sys); + return VLC_EGENERIC; } /***************************************************************************** @@ -159,10 +175,17 @@ void DirClose( vlc_object_t * p_this ) p_sys->current = current->parent; closedir (current->handle); free (current->uri); +#ifndef HAVE_OPENAT + free (current->path); +#endif free (current); } + + /* corner case: Block() not called ever */ if (p_sys->handle != NULL) - closedir (p_sys->handle); /* corner case,:Block() not called ever */ + closedir (p_sys->handle); + free (p_sys->uri); + free (p_sys->psz_xspf_extension); free (p_sys->ignored_exts); free (p_sys); @@ -206,7 +229,7 @@ block_t *DirBlock (access_t *p_access) memcpy (block->p_buffer, header, sizeof (header) - 1); /* "Open" the base directory */ - current = malloc (sizeof (*current) + strlen (p_access->psz_path)); + current = malloc (sizeof (*current)); if (current == NULL) { block_Release (block); @@ -214,28 +237,32 @@ block_t *DirBlock (access_t *p_access) } current->parent = NULL; current->handle = p_sys->handle; - strcpy (current->path, p_access->psz_path); - current->uri = make_URI (current->path); - if ((current->uri == NULL) - || fstat (dirfd (current->handle), ¤t->st)) +#ifndef HAVE_OPENAT + current->path = strdup (p_access->psz_path); +#endif + current->uri = p_sys->uri; + if (fstat (dirfd (current->handle), ¤t->st)) { - free (current->uri); free (current); block_Release (block); goto fatal; } p_sys->handle = NULL; + p_sys->uri = NULL; p_sys->current = current; return block; } - char *entry = utf8_readdir (current->handle); + char *entry = vlc_readdir (current->handle); if (entry == NULL) { /* End of directory, go back to parent */ closedir (current->handle); p_sys->current = current->parent; free (current->uri); +#ifndef HAVE_OPENAT + free (current->path); +#endif free (current); if (p_sys->current == NULL) @@ -246,14 +273,12 @@ block_t *DirBlock (access_t *p_access) "%s" \ " \n" \ "\n", p_sys->psz_xspf_extension ); - if( len < 0 ) + if (unlikely(len == -1)) goto fatal; - block_t *block = block_Alloc ( len ); - if (!block) - goto fatal; - memcpy (block->p_buffer, footer, len); - free( footer ); + block_t *block = block_heap_Alloc (footer, footer, len); + if (unlikely(block == NULL)) + free (footer); p_access->info.b_eof = true; return block; } @@ -282,16 +307,30 @@ block_t *DirBlock (access_t *p_access) /* Handle recursion */ if (p_sys->mode != MODE_COLLAPSE) { - directory_t *sub = malloc (sizeof (*sub) + strlen (current->path) + 1 - + strlen (entry)); + directory_t *sub = malloc (sizeof (*sub)); if (sub == NULL) { free (entry); return NULL; } - sprintf (sub->path, "%s/%s", current->path, entry); - DIR *handle = utf8_opendir (sub->path); + DIR *handle; +#ifdef HAVE_OPENAT + int fd = vlc_openat (dirfd (current->handle), entry, O_RDONLY); + if (fd != -1) + { + handle = fdopendir (fd); + if (handle == NULL) + close (fd); + } + else + handle = NULL; +#else + if (asprintf (&sub->path, "%s/%s", current->path, entry) != -1) + handle = vlc_opendir (sub->path); + else + handle = NULL; +#endif if (handle != NULL) { sub->parent = current; @@ -395,15 +434,12 @@ block_t *DirBlock (access_t *p_access) goto fatal; free( old_xspf_extension ); - /* TODO: new block allocator for malloc()ated data */ - block_t *block = block_Alloc (len); - if (!block) + block_t *block = block_heap_Alloc (entry, entry, len); + if (unlikely(block == NULL)) { free (entry); goto fatal; } - memcpy (block->p_buffer, entry, len); - free (entry); return block; fatal: