X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Faccess%2Fdvdnav.c;h=8bf9f14390d88d14382917505f7b75610f1ef4ca;hb=bc09c365ab435fda0185e60a423f69d6dfa348c8;hp=8aa8353747627091aaf94e5abf4029507d0ca5b0;hpb=f36e9bec13243624905f286aeade229aa21a732e;p=vlc diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c index 8aa8353747..8bf9f14390 100644 --- a/modules/access/dvdnav.c +++ b/modules/access/dvdnav.c @@ -16,9 +16,9 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ /***************************************************************************** @@ -36,15 +36,15 @@ #include #include #include +#include +#include #include #ifdef HAVE_UNISTD_H # include #endif -#ifdef HAVE_SYS_TYPES_H -# include -#endif +#include #ifdef HAVE_SYS_STAT_H # include #endif @@ -52,8 +52,8 @@ # include #endif -#include "vlc_keys.h" -#include "vlc_iso_lang.h" +#include +#include /* FIXME we should find a better way than including that */ #include "../../src/text/iso-639_def.h" @@ -96,9 +96,7 @@ vlc_module_begin () add_bool( "dvdnav-menu", true, NULL, MENU_TEXT, MENU_LONGTEXT, false ) set_capability( "access_demux", 5 ) - add_shortcut( "dvd" ) - add_shortcut( "dvdnav" ) - add_shortcut( "file" ) + add_shortcut( "dvd", "dvdnav", "file" ) set_callbacks( Open, Close ) vlc_module_end () @@ -138,19 +136,26 @@ struct demux_sys_t uint8_t palette[4][4]; bool b_spu_change; - /* */ - int i_aspect; + /* Aspect ration */ + struct { + unsigned i_num; + unsigned i_den; + } sar; + /* */ int i_title; input_title_t **title; /* lenght of program group chain */ mtime_t i_pgc_length; + int i_vobu_index; + int i_vobu_flush; }; static int Control( demux_t *, int, va_list ); static int Demux( demux_t * ); static int DemuxBlock( demux_t *, const uint8_t *, int ); +static void DemuxForceStill( demux_t * ); static void DemuxTitles( demux_t * ); static void ESSubtitleUpdate( demux_t * ); @@ -183,12 +188,12 @@ static int Open( vlc_object_t *p_this ) int i_angle; char *psz_name; char *psz_code; - vlc_value_t val; - if( !p_demux->psz_path || !*p_demux->psz_path ) + if( !p_demux->psz_file || !*p_demux->psz_file ) { /* Only when selected */ - if( !p_this->b_force ) return VLC_EGENERIC; + if( !p_demux->psz_access || !*p_demux->psz_access ) + return VLC_EGENERIC; psz_name = var_CreateGetString( p_this, "dvd" ); if( !psz_name ) @@ -197,11 +202,14 @@ static int Open( vlc_object_t *p_this ) } } else - psz_name = ToLocaleDup( p_demux->psz_path ); + psz_name = ToLocaleDup( p_demux->psz_file ); #ifdef WIN32 - if( psz_name[0] && psz_name[1] == ':' && - psz_name[2] == '\\' && psz_name[3] == '\0' ) psz_name[2] = '\0'; + /* Remove trailing backslash, otherwise dvdnav_open will fail */ + if( *psz_name && *(psz_name + strlen(psz_name) - 1) == '\\' ) + { + *(psz_name + strlen(psz_name) - 1) = '\0'; + } #endif /* Try some simple probing to avoid going through dvdnav_open too often */ @@ -226,10 +234,13 @@ static int Open( vlc_object_t *p_this ) p_sys->b_reset_pcr = false; ps_track_init( p_sys->tk ); - p_sys->i_aspect = -1; + p_sys->sar.i_num = 0; + p_sys->sar.i_den = 0; p_sys->i_mux_rate = 0; p_sys->i_pgc_length = 0; p_sys->b_spu_change = false; + p_sys->i_vobu_index = 0; + p_sys->i_vobu_flush = 0; if( 1 ) { @@ -303,9 +314,7 @@ static int Open( vlc_object_t *p_this ) DemuxTitles( p_demux ); - var_Create( p_demux, "dvdnav-menu", VLC_VAR_BOOL|VLC_VAR_DOINHERIT ); - var_Get( p_demux, "dvdnav-menu", &val ); - if( val.b_bool ) + if( var_CreateGetBool( p_demux, "dvdnav-menu" ) ) { msg_Dbg( p_demux, "trying to go to dvd menu" ); @@ -330,16 +339,15 @@ static int Open( vlc_object_t *p_this ) } } - var_Create( p_demux, "dvdnav-angle", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); - var_Get( p_demux, "dvdnav-angle", &val ); - i_angle = val.i_int > 0 ? val.i_int : 1; + i_angle = var_CreateGetInteger( p_demux, "dvdnav-angle" ); + if( i_angle <= 0 ) i_angle = 1; /* Update default_pts to a suitable value for dvdnav access */ var_Create( p_demux, "dvdnav-caching", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); /* FIXME hack hack hack hack FIXME */ /* Get p_input and create variable */ - p_sys->p_input = vlc_object_find( p_demux, VLC_OBJECT_INPUT, FIND_PARENT ); + p_sys->p_input = demux_GetParentInput( p_demux ); var_Create( p_sys->p_input, "x-start", VLC_VAR_INTEGER ); var_Create( p_sys->p_input, "y-start", VLC_VAR_INTEGER ); var_Create( p_sys->p_input, "x-end", VLC_VAR_INTEGER ); @@ -385,7 +393,7 @@ static void Close( vlc_object_t *p_this ) /* Stop still image handler */ if( p_sys->still.b_created ) - vlc_timer_destroy( &p_sys->still.timer ); + vlc_timer_destroy( p_sys->still.timer ); vlc_mutex_destroy( &p_sys->still.lock ); var_Destroy( p_sys->p_input, "highlight-mutex" ); @@ -409,6 +417,11 @@ static void Close( vlc_object_t *p_this ) } } + /* Free the array of titles */ + for( int i = 0; i < p_sys->i_title; i++ ) + vlc_input_title_Delete( p_sys->title[i] ); + TAB_CLEAN( p_sys->i_title, p_sys->title ); + dvdnav_close( p_sys->dvdnav ); free( p_sys ); } @@ -419,11 +432,7 @@ static void Close( vlc_object_t *p_this ) static int Control( demux_t *p_demux, int i_query, va_list args ) { demux_sys_t *p_sys = p_demux->p_sys; - double f, *pf; - bool *pb; - int64_t *pi64; input_title_t ***ppp_title; - int *pi_int; int i; switch( i_query ) @@ -440,41 +449,37 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) return VLC_EGENERIC; } - if( i_query == DEMUX_GET_POSITION ) + switch( i_query ) { - pf = (double*)va_arg( args, double* ); - *pf = (double)pos / (double)len; + case DEMUX_GET_POSITION: + *va_arg( args, double* ) = (double)pos / (double)len; return VLC_SUCCESS; - } - else if( i_query == DEMUX_SET_POSITION ) - { - f = (double)va_arg( args, double ); - pos = f * len; + + case DEMUX_SET_POSITION: + pos = va_arg( args, double ) * len; if( dvdnav_sector_search( p_sys->dvdnav, pos, SEEK_SET ) == DVDNAV_STATUS_OK ) { return VLC_SUCCESS; } - } - else if( i_query == DEMUX_GET_TIME ) - { - pi64 = (int64_t*)va_arg( args, int64_t * ); + break; + + case DEMUX_GET_TIME: if( p_sys->i_pgc_length > 0 ) { - *pi64 = p_sys->i_pgc_length * pos / len; + *va_arg( args, int64_t * ) = p_sys->i_pgc_length*pos/len; return VLC_SUCCESS; } - } - else if( i_query == DEMUX_GET_LENGTH ) - { - pi64 = (int64_t*)va_arg( args, int64_t * ); + break; + + case DEMUX_GET_LENGTH: if( p_sys->i_pgc_length > 0 ) { - *pi64 = (int64_t)p_sys->i_pgc_length; + *va_arg( args, int64_t * ) = (int64_t)p_sys->i_pgc_length; return VLC_SUCCESS; } + break; } - return VLC_EGENERIC; } @@ -483,21 +488,19 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) case DEMUX_CAN_SEEK: case DEMUX_CAN_CONTROL_PACE: /* TODO */ - pb = (bool*)va_arg( args, bool * ); - *pb = true; + *va_arg( args, bool * ) = true; return VLC_SUCCESS; case DEMUX_SET_PAUSE_STATE: return VLC_SUCCESS; case DEMUX_GET_TITLE_INFO: - ppp_title = (input_title_t***)va_arg( args, input_title_t*** ); - pi_int = (int*)va_arg( args, int* ); - *((int*)va_arg( args, int* )) = 0; /* Title offset */ - *((int*)va_arg( args, int* )) = 1; /* Chapter offset */ + ppp_title = va_arg( args, input_title_t*** ); + *va_arg( args, int* ) = p_sys->i_title; + *va_arg( args, int* ) = 0; /* Title offset */ + *va_arg( args, int* ) = 1; /* Chapter offset */ /* Duplicate title infos */ - *pi_int = p_sys->i_title; *ppp_title = malloc( sizeof( input_title_t ** ) * p_sys->i_title ); for( i = 0; i < p_sys->i_title; i++ ) { @@ -522,40 +525,21 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) return VLC_SUCCESS; case DEMUX_SET_SEEKPOINT: - i = (int)va_arg( args, int ); + i = va_arg( args, int ); if( p_demux->info.i_title == 0 ) { - int i_ret; - /* Special case */ - switch( i ) - { - case 0: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Escape ); - break; - case 1: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Root ); - break; - case 2: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Title ); - break; - case 3: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Part ); - break; - case 4: - i_ret = dvdnav_menu_call( p_sys->dvdnav, - DVD_MENU_Subpicture ); - break; - case 5: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Audio ); - break; - case 6: - i_ret = dvdnav_menu_call( p_sys->dvdnav, DVD_MENU_Angle ); - break; - default: - return VLC_EGENERIC; - } - - if( i_ret != DVDNAV_STATUS_OK ) + static const int argtab[] = { + DVD_MENU_Escape, + DVD_MENU_Root, + DVD_MENU_Title, + DVD_MENU_Part, + DVD_MENU_Subpicture, + DVD_MENU_Audio, + DVD_MENU_Angle + }; + enum { numargs = sizeof(argtab)/sizeof(int) }; + if( (unsigned)i >= numargs || DVDNAV_STATUS_OK != + dvdnav_menu_call(p_sys->dvdnav,argtab[i]) ) return VLC_EGENERIC; } else if( dvdnav_part_play( p_sys->dvdnav, p_demux->info.i_title, @@ -569,8 +553,8 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) return VLC_SUCCESS; case DEMUX_GET_PTS_DELAY: - pi64 = (int64_t*)va_arg( args, int64_t * ); - *pi64 = (int64_t)var_GetInteger( p_demux, "dvdnav-caching" ) *1000; + *va_arg( args, int64_t * ) + = (int64_t)var_GetInteger( p_demux, "dvdnav-caching" ) *1000; return VLC_SUCCESS; case DEMUX_GET_META: @@ -638,6 +622,7 @@ static int Demux( demux_t *p_demux ) { case DVDNAV_BLOCK_OK: /* mpeg block */ vlc_mutex_lock( &p_sys->still.lock ); + vlc_timer_schedule( p_sys->still.timer, false, 0, 0 ); p_sys->still.b_enabled = false; vlc_mutex_unlock( &p_sys->still.lock ); if( p_sys->b_reset_pcr ) @@ -646,6 +631,12 @@ static int Demux( demux_t *p_demux ) p_sys->b_reset_pcr = false; } DemuxBlock( p_demux, packet, i_len ); + if( p_sys->i_vobu_index > 0 ) + { + if( p_sys->i_vobu_flush == p_sys->i_vobu_index ) + DemuxForceStill( p_demux ); + p_sys->i_vobu_index++; + } break; case DVDNAV_NOP: /* Nothing */ @@ -667,7 +658,7 @@ static int Demux( demux_t *p_demux ) if( event->length != 0xff && p_sys->still.b_created ) { mtime_t delay = event->length * CLOCK_FREQ; - vlc_timer_schedule( &p_sys->still.timer, false, delay, 0 ); + vlc_timer_schedule( p_sys->still.timer, false, delay, 0 ); } b_still_init = true; @@ -676,16 +667,7 @@ static int Demux( demux_t *p_demux ) if( b_still_init ) { - /* We send a dummy mpeg2 end of sequence to force still frame display */ - static const uint8_t buffer[] = { - 0x00, 0x00, 0x01, 0xe0, 0x00, 0x07, - 0x80, 0x00, 0x00, - 0x00, 0x00, 0x01, 0xB7, - }; - DemuxBlock( p_demux, buffer, sizeof(buffer) ); - - bool b_empty; - es_out_Control( p_demux->out, ES_OUT_GET_EMPTY, &b_empty ); + DemuxForceStill( p_demux ); p_sys->b_reset_pcr = true; } msleep( 40000 ); @@ -758,10 +740,6 @@ static int Demux( demux_t *p_demux ) msg_Dbg( p_demux, " - vtsN=%d", event->new_vtsN ); msg_Dbg( p_demux, " - domain=%d", event->new_domain ); - /* dvdnav_get_video_aspect / dvdnav_get_video_scale_permission */ - /* TODO check if we always have VTS and CELL */ - p_sys->i_aspect = dvdnav_get_video_aspect( p_sys->dvdnav ); - /* reset PCR */ es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); @@ -776,6 +754,28 @@ static int Demux( demux_t *p_demux ) tk->b_seen = false; } +#if defined(HAVE_DVDNAV_GET_VIDEO_RESOLUTION) + uint32_t i_width, i_height; + if( dvdnav_get_video_resolution( p_sys->dvdnav, + &i_width, &i_height ) ) + i_width = i_height = 0; + switch( dvdnav_get_video_aspect( p_sys->dvdnav ) ) + { + case 0: + p_sys->sar.i_num = 4 * i_height; + p_sys->sar.i_den = 3 * i_width; + break; + case 3: + p_sys->sar.i_num = 16 * i_height; + p_sys->sar.i_den = 9 * i_width; + break; + default: + p_sys->sar.i_num = 0; + p_sys->sar.i_den = 0; + break; + } +#endif + if( dvdnav_current_title_info( p_sys->dvdnav, &i_title, &i_part ) == DVDNAV_STATUS_OK ) { @@ -807,6 +807,8 @@ static int Demux( demux_t *p_demux ) /* Store the lenght in time of the current PGC */ p_sys->i_pgc_length = event->pgc_length / 90 * 1000; + p_sys->i_vobu_index = 0; + p_sys->i_vobu_flush = 0; /* FIXME is it correct or there is better way to know chapter change */ if( dvdnav_current_title_info( p_sys->dvdnav, &i_title, @@ -825,6 +827,22 @@ static int Demux( demux_t *p_demux ) case DVDNAV_NAV_PACKET: { + p_sys->i_vobu_index = 1; + p_sys->i_vobu_flush = 0; + + /* Look if we have need to force a flush (and when) */ + const pci_gi_t *p_pci_gi = &dvdnav_get_current_nav_pci( p_sys->dvdnav )->pci_gi; + if( p_pci_gi->vobu_se_e_ptm != 0 && p_pci_gi->vobu_se_e_ptm < p_pci_gi->vobu_e_ptm ) + { + const dsi_gi_t *p_dsi_gi = &dvdnav_get_current_nav_dsi( p_sys->dvdnav )->dsi_gi; + if( p_dsi_gi->vobu_3rdref_ea != 0 ) + p_sys->i_vobu_flush = p_dsi_gi->vobu_3rdref_ea; + else if( p_dsi_gi->vobu_2ndref_ea != 0 ) + p_sys->i_vobu_flush = p_dsi_gi->vobu_2ndref_ea; + else if( p_dsi_gi->vobu_1stref_ea != 0 ) + p_sys->i_vobu_flush = p_dsi_gi->vobu_1stref_ea; + } + #ifdef DVDNAV_DEBUG msg_Dbg( p_demux, "DVDNAV_NAV_PACKET" ); #endif @@ -862,6 +880,8 @@ static int Demux( demux_t *p_demux ) case DVDNAV_HOP_CHANNEL: msg_Dbg( p_demux, "DVDNAV_HOP_CHANNEL" ); + p_sys->i_vobu_index = 0; + p_sys->i_vobu_flush = 0; es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); break; @@ -926,7 +946,7 @@ static char *DemuxGetLanguageCode( demux_t *p_demux, const char *psz_var ) free( psz_lang ); if( pl->psz_eng_name != NULL ) - return strdup( pl->psz_eng_name ); + return strdup( pl->psz_iso639_1 ); return strdup(LANGUAGE_DEFAULT); } @@ -978,13 +998,26 @@ static void DemuxTitles( demux_t *p_demux ) dvdnav_get_number_of_titles( p_sys->dvdnav, &i_titles ); for( i = 1; i <= i_titles; i++ ) { - int32_t i_chapters = 0; - int j; - - dvdnav_get_number_of_parts( p_sys->dvdnav, i, &i_chapters ); - + int32_t i_chapters; + uint64_t i_title_length; + +#if defined(HAVE_DVDNAV_DESCRIBE_TITLE_CHAPTERS) + uint64_t *p_chapters_time; + i_chapters = dvdnav_describe_title_chapters( p_sys->dvdnav, i, + &p_chapters_time, + &i_title_length ); + if( i_chapters > 0 ) + free( p_chapters_time ); + else + i_title_length = 0; +#else + if( dvdnav_get_number_of_parts( p_sys->dvdnav, i, &i_chapters ) != DVDNAV_STATUS_OK ) + i_chapters = 0; + i_title_length = 0; +#endif t = vlc_input_title_New(); - for( j = 0; j < __MAX( i_chapters, 1 ); j++ ) + t->i_length = i_title_length * 1000 / 90; + for( int j = 0; j < __MAX( i_chapters, 1 ); j++ ) { s = vlc_seekpoint_New(); TAB_APPEND( t->i_seekpoint, t->seekpoint, s ); @@ -1024,8 +1057,10 @@ static void ButtonUpdate( demux_t *p_demux, bool b_mode ) { pci_t *pci = dvdnav_get_current_nav_pci( p_sys->dvdnav ); - b_button_ok = dvdnav_get_highlight_area( pci, i_button, b_mode, &hl ) == DVDNAV_STATUS_OK; + b_button_ok = DVDNAV_STATUS_OK == + dvdnav_get_highlight_area( pci, i_button, b_mode, &hl ); } + if( b_button_ok ) { int i; @@ -1112,17 +1147,17 @@ static int DemuxBlock( demux_t *p_demux, const uint8_t *pkt, int i_pkt ) demux_sys_t *p_sys = p_demux->p_sys; const uint8_t *p = pkt; - while( p < &pkt[i_pkt] ) + while( (p - pkt) <= (i_pkt - 6) ) { + /* ps_pkt_size() needs at least 6 bytes */ int i_size = ps_pkt_size( p, &pkt[i_pkt] - p ); - block_t *p_pkt; if( i_size <= 0 ) { break; } /* Create a block */ - p_pkt = block_New( p_demux, i_size ); + block_t *p_pkt = block_New( p_demux, i_size ); memcpy( p_pkt->p_buffer, p, i_size); /* Parse it and send it */ @@ -1191,6 +1226,22 @@ static int DemuxBlock( demux_t *p_demux, const uint8_t *pkt, int i_pkt ) return VLC_SUCCESS; } +/***************************************************************************** + * Force still images to be displayed by sending EOS and stopping buffering. + *****************************************************************************/ +static void DemuxForceStill( demux_t *p_demux ) +{ + static const uint8_t buffer[] = { + 0x00, 0x00, 0x01, 0xe0, 0x00, 0x07, + 0x80, 0x00, 0x00, + 0x00, 0x00, 0x01, 0xB7, + }; + DemuxBlock( p_demux, buffer, sizeof(buffer) ); + + bool b_empty; + es_out_Control( p_demux->out, ES_OUT_GET_EMPTY, &b_empty ); +} + /***************************************************************************** * ESNew: register a new elementary stream *****************************************************************************/ @@ -1211,16 +1262,8 @@ static void ESNew( demux_t *p_demux, int i_id ) /* Add a new ES */ if( tk->fmt.i_cat == VIDEO_ES ) { - switch( p_sys->i_aspect ) - { - case 1: tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR; break; - case 2: tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * 4 / 3; break; - case 3: tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * 16 / 9; break; - case 4: tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * 221 / 10; break; - default: - tk->fmt.video.i_aspect = 0; - break; - } + tk->fmt.video.i_sar_num = p_sys->sar.i_num; + tk->fmt.video.i_sar_den = p_sys->sar.i_den; b_select = true; } else if( tk->fmt.i_cat == AUDIO_ES ) @@ -1303,9 +1346,11 @@ static void StillTimer( void *p_data ) demux_sys_t *p_sys = p_data; vlc_mutex_lock( &p_sys->still.lock ); - assert( p_sys->still.b_enabled ); - p_sys->still.b_enabled = false; - dvdnav_still_skip( p_sys->dvdnav ); + if( likely(p_sys->still.b_enabled) ) + { + p_sys->still.b_enabled = false; + dvdnav_still_skip( p_sys->dvdnav ); + } vlc_mutex_unlock( &p_sys->still.lock ); } @@ -1317,8 +1362,8 @@ static int EventMouse( vlc_object_t *p_vout, char const *psz_var, /* FIXME? PCI usage thread safe? */ pci_t *pci = dvdnav_get_current_nav_pci( p_sys->dvdnav ); - int x = var_GetInteger( p_vout, "mouse-x" ); - int y = var_GetInteger( p_vout, "mouse-y" ); + int x = val.coords.x; + int y = val.coords.y; if( psz_var[6] == 'm' ) /* mouse-moved */ dvdnav_mouse_select( p_sys->dvdnav, pci, x, y ); @@ -1329,8 +1374,8 @@ static int EventMouse( vlc_object_t *p_vout, char const *psz_var, ButtonUpdate( p_demux, true ); dvdnav_mouse_activate( p_sys->dvdnav, pci, x, y ); } - - (void)oldval; (void)val; + (void)p_vout; + (void)oldval; return VLC_SUCCESS; } @@ -1414,30 +1459,27 @@ static int ProbeDVD( demux_t *p_demux, char *psz_name ) return VLC_SUCCESS; } - if( !strcmp( psz_name, "-" ) ) /* stdin -> file access */ - return VLC_EGENERIC; - - if( (i_fd = utf8_open( psz_name, O_RDONLY |O_NONBLOCK, 0666 )) == -1 ) + if( (i_fd = vlc_open( psz_name, O_RDONLY |O_NONBLOCK )) == -1 ) { return VLC_SUCCESS; /* Let dvdnav_open() do the probing */ } + i_ret = VLC_EGENERIC; + if( fstat( i_fd, &stat_info ) || !S_ISREG( stat_info.st_mode ) ) { - close( i_fd ); - - if( S_ISFIFO( stat_info.st_mode ) ) - return VLC_EGENERIC; - return VLC_SUCCESS; /* Let dvdnav_open() do the probing */ + if( !S_ISFIFO( stat_info.st_mode ) ) + i_ret = VLC_SUCCESS; /* Let dvdnav_open() do the probing */ + goto bailout; } /* Try to find the anchor (2 bytes at LBA 256) */ - i_ret = VLC_EGENERIC; if( lseek( i_fd, 256 * DVD_VIDEO_LB_LEN, SEEK_SET ) != -1 && read( i_fd, pi_anchor, 2 ) == 2 && GetWLE( pi_anchor ) == 2 ) i_ret = VLC_SUCCESS; /* Found a potential anchor */ +bailout: close( i_fd ); return i_ret;