X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fcodec%2Fcvdsub.c;h=6e4955739adf874e75c6e68bf1251de9ec01c865;hb=5f584e4c451865ea350cd54e28a4d1417d50e9c6;hp=84b42748f8e64850bb27a53101faa17a7c284051;hpb=d3fe7f28797d4dba65ffcdd60bf932e758a48a9e;p=vlc diff --git a/modules/codec/cvdsub.c b/modules/codec/cvdsub.c index 84b42748f8..6e4955739a 100644 --- a/modules/codec/cvdsub.c +++ b/modules/codec/cvdsub.c @@ -27,6 +27,10 @@ /***************************************************************************** * Preamble *****************************************************************************/ +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + #include #include #include @@ -76,16 +80,16 @@ struct decoder_sys_t block_t *p_spu; /* Bytes of the packet. */ - int i_spu_size; /* goal for subtitle_data_pos while gathering, + size_t i_spu_size; /* goal for subtitle_data_pos while gathering, size of used subtitle_data later */ uint16_t i_image_offset; /* offset from subtitle_data to compressed image data */ - int i_image_length; /* size of the compressed image data */ - int first_field_offset; /* offset of even raster lines */ - int second_field_offset; /* offset of odd raster lines */ - int metadata_offset; /* offset to data describing the image */ - int metadata_length; /* length of metadata */ + size_t i_image_length; /* size of the compressed image data */ + size_t first_field_offset; /* offset of even raster lines */ + size_t second_field_offset; /* offset of odd raster lines */ + size_t metadata_offset; /* offset to data describing the image */ + size_t metadata_length; /* length of metadata */ mtime_t i_duration; /* how long to display the image, 0 stands for "until next subtitle" */ @@ -272,14 +276,14 @@ static block_t *Reassemble( decoder_t *p_dec, block_t *p_block ) except the submux sample code and a couple of samples of dubious origin. Thus, this is the result of reading some code whose correctness is not known and some experimentation. - + CVD subtitles are different in several ways from SVCD OGT subtitles. Image comes first and metadata is at the end. So that the metadata can be found easily, the subtitle packet starts with two bytes (everything is big-endian again) that give the total size of the subtitle data and the offset to the metadata - i.e. size of the image data plus the four bytes at the beginning. - + Image data comes interlaced is run-length encoded. Each field is a four-bit nibble. Each nibble contains a two-bit repeat count and a two-bit color number so that up to three pixels can be described in @@ -306,16 +310,15 @@ static void ParseHeader( decoder_t *p_dec, block_t *p_block ) p_sys->i_image_offset = 4; p_sys->i_image_length = p_sys->metadata_offset - p_sys->i_image_offset; - + #ifdef DEBUG_CVDSUB msg_Dbg( p_dec, "total size: %d image size: %d", p_sys->i_spu_size, p_sys->i_image_length ); #endif - } -/* - We parse the metadata information here. +/* + We parse the metadata information here. Although metadata information does not have to come in a fixed field order, every metadata field consists of a tag byte followed by @@ -333,7 +336,7 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) decoder_sys_t *p_sys = p_dec->p_sys; uint8_t *p = p_spu->p_buffer + p_sys->metadata_offset; uint8_t *p_end = p + p_sys->metadata_length; - + for( ; p < p_end; p += 4 ) { switch( p[0] ) @@ -347,14 +350,14 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) #endif p_sys->i_duration *= 100 / 9; break; - + case 0x0c: /* unknown */ #ifdef DEBUG_CVDSUB msg_Dbg( p_dec, "subtitle command unknown 0x%0x 0x%0x 0x%0x 0x%0x", (int)p[0], (int)p[1], (int)p[2], (int)p[3] ); #endif break; - + case 0x17: /* coordinates of subtitle upper left x, y position */ ExtractXY(p_sys->i_x_start, p_sys->i_y_start); @@ -363,7 +366,7 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) p_sys->i_x_start, p_sys->i_y_start ); #endif break; - + case 0x1f: /* coordinates of subtitle bottom right x, y position */ { int lastx; @@ -378,11 +381,11 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) #endif break; } - + case 0x24: case 0x25: case 0x26: - case 0x27: + case 0x27: { uint8_t v = p[0] - 0x24; @@ -431,7 +434,7 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) (int)p_sys->p_palette[2][3], (int)p_sys->p_palette[3][3]); #endif break; - + case 0x3f: /* transparency for highlight palette */ p_sys->p_palette_highlight[0][3] = (p[2] & 0x0f) << 4; @@ -471,7 +474,7 @@ static void ParseMetaInfo( decoder_t *p_dec, block_t *p_spu ) default: #ifdef DEBUG_CVDSUB - msg_Warn( p_dec, "unknown sequence in control header " + msg_Warn( p_dec, "unknown sequence in control header " "0x%0x 0x%0x 0x%0x 0x%0x", p[0], p[1], p[2], p[3]); #endif } @@ -540,7 +543,7 @@ static subpicture_t *DecodePacket( decoder_t *p_dec, block_t *p_data ) /***************************************************************************** * ParseImage: parse and render the image part of the subtitle ***************************************************************************** - This part parses the subtitle graphical data and renders it. + This part parses the subtitle graphical data and renders it. Image data comes interlaced and is run-length encoded (RLE). Each field is a four-bit nibbles that is further subdivided in a two-bit @@ -556,7 +559,7 @@ static subpicture_t *DecodePacket( decoder_t *p_dec, block_t *p_data ) may be untested. However we'll transform this so that that the RLE is expanded and - interlacing will also be removed. On output each pixel entry will by + interlacing will also be removed. On output each pixel entry will by a 4-bit alpha (filling 8 bits), and 8-bit y, u, and v entry. *****************************************************************************/