X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fcodec%2Ffaad.c;h=7af61bc7f092c271e143a51843a31c37f69a72ce;hb=b751665aa8f78719eb3e4fe30545fffd5c423948;hp=db8c8c64ca040d999fd97864cdac9fca730eece0;hpb=99fab9089e9e1709d9c3a4bc5ced0c137ac59134;p=vlc diff --git a/modules/codec/faad.c b/modules/codec/faad.c index db8c8c64ca..7af61bc7f0 100644 --- a/modules/codec/faad.c +++ b/modules/codec/faad.c @@ -26,7 +26,8 @@ # include "config.h" #endif -#include +#include +#include #include #include #include @@ -40,7 +41,7 @@ static int Open( vlc_object_t * ); static void Close( vlc_object_t * ); vlc_module_begin(); - set_description( _("AAC audio decoder (using libfaad2)") ); + set_description( N_("AAC audio decoder (using libfaad2)") ); set_capability( "decoder", 100 ); set_category( CAT_INPUT ); set_subcategory( SUBCAT_INPUT_ACODEC ); @@ -51,8 +52,7 @@ vlc_module_end(); * Local prototypes ****************************************************************************/ static aout_buffer_t *DecodeBlock( decoder_t *, block_t ** ); -static void DoReordering( decoder_t *, uint32_t *, uint32_t *, int, int, - uint32_t * ); +static void DoReordering( uint32_t *, uint32_t *, int, int, uint32_t * ); #define MAX_CHANNEL_POSITIONS 9 @@ -67,12 +67,12 @@ struct decoder_sys_t /* temporary buffer */ uint8_t *p_buffer; int i_buffer; - int i_buffer_size; + size_t i_buffer_size; /* Channel positions of the current stream (for re-ordering) */ uint32_t pi_channel_positions[MAX_CHANNEL_POSITIONS]; - vlc_bool_t b_sbr, b_ps; + bool b_sbr, b_ps; int i_input_rate; }; @@ -127,10 +127,7 @@ static int Open( vlc_object_t *p_this ) /* Allocate the memory needed to store the decoder's structure */ if( ( p_dec->p_sys = p_sys = (decoder_sys_t *)malloc(sizeof(decoder_sys_t)) ) == NULL ) - { - msg_Err( p_dec, "out of memory" ); - return VLC_EGENERIC; - } + return VLC_ENOMEM; /* Open a faad context */ if( ( p_sys->hfaad = faacDecOpen() ) == NULL ) @@ -189,14 +186,14 @@ static int Open( vlc_object_t *p_this ) /* buffer */ p_sys->i_buffer = p_sys->i_buffer_size = 0; - p_sys->p_buffer = 0; + p_sys->p_buffer = NULL; p_sys->i_input_rate = INPUT_RATE_DEFAULT; /* Faad2 can't deal with truncated data (eg. from MPEG TS) */ - p_dec->b_need_packetized = VLC_TRUE; + p_dec->b_need_packetized = true; - p_sys->b_sbr = p_sys->b_ps = VLC_FALSE; + p_sys->b_sbr = p_sys->b_ps = false; return VLC_SUCCESS; } @@ -221,6 +218,25 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) if( p_block->i_rate > 0 ) p_sys->i_input_rate = p_block->i_rate; + /* Remove ADTS header if we have decoder specific config */ + if( p_dec->fmt_in.i_extra && p_block->i_buffer > 7 ) + { + if( p_block->p_buffer[0] == 0xff && + ( p_block->p_buffer[1] & 0xf0 ) == 0xf0 ) /* syncword */ + { /* ADTS header present */ + size_t i_header_size; /* 7 bytes (+ 2 bytes for crc) */ + i_header_size = 7 + ( ( p_block->p_buffer[1] & 0x01 ) ? 0 : 2 ); + /* FIXME: multiple blocks per frame */ + if( p_block->i_buffer > i_header_size ) + { + vlc_memcpy( p_block->p_buffer, + p_block->p_buffer + i_header_size, + p_block->i_buffer - i_header_size ); + p_block->i_buffer -= i_header_size; + } + } + } + /* Append the block to the temporary buffer */ if( p_sys->i_buffer_size < p_sys->i_buffer + p_block->i_buffer ) { @@ -228,10 +244,10 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) p_sys->p_buffer = realloc( p_sys->p_buffer, p_sys->i_buffer_size ); } - if( p_block->i_buffer ) + if( p_block->i_buffer > 0 ) { - memcpy( &p_sys->p_buffer[p_sys->i_buffer], - p_block->p_buffer, p_block->i_buffer ); + vlc_memcpy( &p_sys->p_buffer[p_sys->i_buffer], + p_block->p_buffer, p_block->i_buffer ); p_sys->i_buffer += p_block->i_buffer; p_block->i_buffer = 0; } @@ -248,6 +264,10 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) { p_dec->fmt_out.audio.i_rate = i_rate; p_dec->fmt_out.audio.i_channels = i_channels; + p_dec->fmt_out.audio.i_physical_channels + = p_dec->fmt_out.audio.i_original_channels + = pi_channels_guessed[i_channels]; + aout_DateInit( &p_sys->date, i_rate ); } } @@ -268,6 +288,9 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) p_dec->fmt_out.audio.i_rate = i_rate; p_dec->fmt_out.audio.i_channels = i_channels; + p_dec->fmt_out.audio.i_physical_channels + = p_dec->fmt_out.audio.i_original_channels + = pi_channels_guessed[i_channels]; aout_DateInit( &p_sys->date, i_rate ); } @@ -344,28 +367,33 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) p_dec->fmt_out.audio.i_rate = frame.samplerate; p_dec->fmt_out.audio.i_channels = frame.channels; + p_dec->fmt_out.audio.i_physical_channels + = p_dec->fmt_out.audio.i_original_channels + = pi_channels_guessed[frame.channels]; /* Adjust stream info when dealing with SBR/PS */ if( (p_sys->b_sbr != frame.sbr || p_sys->b_ps != frame.ps) && p_dec->p_parent->i_object_type == VLC_OBJECT_INPUT ) { - input_thread_t *p_input = (input_thread_t *)p_dec->p_parent; - char *psz_cat; - const char *psz_ext = (frame.sbr && frame.ps) ? "SBR+PS" : + input_thread_t *p_input = (input_thread_t *)p_dec->p_parent; + char *psz_cat; + const char *psz_ext = (frame.sbr && frame.ps) ? "SBR+PS" : frame.sbr ? "SBR" : "PS"; - msg_Dbg( p_dec, "AAC %s (channels: %u, samplerate: %lu)", - psz_ext, frame.channels, frame.samplerate ); - - asprintf( &psz_cat, _("Stream %d"), p_dec->fmt_in.i_id ); - input_Control( p_input, INPUT_ADD_INFO, psz_cat, - _("AAC extension"), "%s", psz_ext ); - input_Control( p_input, INPUT_ADD_INFO, psz_cat, - _("Channels"), "%d", frame.channels ); - input_Control( p_input, INPUT_ADD_INFO, psz_cat, - _("Sample rate"), _("%d Hz"), frame.samplerate ); - free( psz_cat ); - p_sys->b_sbr = frame.sbr; p_sys->b_ps = frame.ps; + msg_Dbg( p_dec, "AAC %s (channels: %u, samplerate: %lu)", + psz_ext, frame.channels, frame.samplerate ); + + if( asprintf( &psz_cat, _("Stream %d"), p_dec->fmt_in.i_id ) != -1 ) + { + input_Control( p_input, INPUT_ADD_INFO, psz_cat, + _("AAC extension"), "%s", psz_ext ); + input_Control( p_input, INPUT_ADD_INFO, psz_cat, + _("Channels"), "%d", frame.channels ); + input_Control( p_input, INPUT_ADD_INFO, psz_cat, + _("Sample rate"), _("%d Hz"), frame.samplerate ); + free( psz_cat ); + } + p_sys->b_sbr = frame.sbr; p_sys->b_ps = frame.ps; } /* Convert frame.channel_position to our own channel values */ @@ -406,7 +434,7 @@ static aout_buffer_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) p_out->end_date = aout_DateIncrement( &p_sys->date, (frame.samples / frame.channels) * p_sys->i_input_rate / INPUT_RATE_DEFAULT ); - DoReordering( p_dec, (uint32_t *)p_out->p_buffer, samples, + DoReordering( (uint32_t *)p_out->p_buffer, samples, frame.samples / frame.channels, frame.channels, p_sys->pi_channel_positions ); @@ -433,7 +461,7 @@ static void Close( vlc_object_t *p_this ) decoder_sys_t *p_sys = p_dec->p_sys; faacDecClose( p_sys->hfaad ); - if( p_sys->p_buffer ) free( p_sys->p_buffer ); + free( p_sys->p_buffer ); free( p_sys ); } @@ -441,17 +469,16 @@ static void Close( vlc_object_t *p_this ) * DoReordering: do some channel re-ordering (the ac3 channel order is * different from the aac one). *****************************************************************************/ -static void DoReordering( decoder_t *p_dec, - uint32_t *p_out, uint32_t *p_in, int i_samples, +static void DoReordering( uint32_t *p_out, uint32_t *p_in, int i_samples, int i_nb_channels, uint32_t *pi_chan_positions ) { int pi_chan_table[MAX_CHANNEL_POSITIONS]; int i, j, k; /* Find the channels mapping */ - for( k = 0, j = 0; k < i_nb_channels; k++ ) + for( i = 0, j = 0; i < MAX_CHANNEL_POSITIONS; i++ ) { - for( i = 0; i < MAX_CHANNEL_POSITIONS; i++ ) + for( k = 0; k < i_nb_channels; k++ ) { if( pi_channels_ordered[i] == pi_chan_positions[k] ) { @@ -473,3 +500,4 @@ static void DoReordering( decoder_t *p_dec, ((uint16_t *)p_out)[i * i_nb_channels + pi_chan_table[j]] = ((uint16_t *)p_in)[i * i_nb_channels + j]; } +