X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fcodec%2Fvorbis.c;h=2c8cbcaa3452330979a3ea51033e32e9d8add901;hb=61d5259ed0c32905e058927c2b7aeb3c594761b5;hp=d3fa8a03dc16ab45100518ab98168f7052e51116;hpb=f2c554795a02ff8acdc070bc10a00f4640fdb8ab;p=vlc diff --git a/modules/codec/vorbis.c b/modules/codec/vorbis.c index d3fa8a03dc..2c8cbcaa34 100644 --- a/modules/codec/vorbis.c +++ b/modules/codec/vorbis.c @@ -1,7 +1,7 @@ /***************************************************************************** * vorbis.c: vorbis decoder/encoder/packetizer module making use of libvorbis. ***************************************************************************** - * Copyright (C) 2001-2003 VideoLAN + * Copyright (C) 2001-2003 the VideoLAN team * $Id$ * * Authors: Gildas Bazin @@ -18,16 +18,17 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ /***************************************************************************** * Preamble *****************************************************************************/ #include -#include -#include -#include +#include +#include +#include +#include #include @@ -77,6 +78,10 @@ struct decoder_sys_t audio_date_t end_date; int i_last_block_size; + /* + ** Channel reordering + */ + int pi_chan_table[AOUT_CHAN_MAX]; }; static int pi_channels_maps[7] = @@ -93,6 +98,28 @@ static int pi_channels_maps[7] = | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE }; +/* +** channel order as defined in http://www.ogghelp.com/ogg/glossary.cfm#Audio_Channels +*/ + +/* recommended vorbis channel order for 6 channels */ +static const uint32_t pi_6channels_in[] = +{ AOUT_CHAN_LEFT, AOUT_CHAN_CENTER, AOUT_CHAN_RIGHT, + AOUT_CHAN_REARLEFT, AOUT_CHAN_REARRIGHT,AOUT_CHAN_LFE,0 }; + +/* recommended vorbis channel order for 4 channels */ +static const uint32_t pi_4channels_in[] = +{ AOUT_CHAN_LEFT, AOUT_CHAN_RIGHT, AOUT_CHAN_CENTER, AOUT_CHAN_LFE, 0 }; + +/* recommended vorbis channel order for 3 channels */ +static const uint32_t pi_3channels_in[] = +{ AOUT_CHAN_LEFT, AOUT_CHAN_CENTER, AOUT_CHAN_RIGHT, 0 }; + +/* our internal channel order (WG-4 order) */ +static const uint32_t pi_channels_out[] = +{ AOUT_CHAN_LEFT, AOUT_CHAN_RIGHT, AOUT_CHAN_REARLEFT, AOUT_CHAN_REARRIGHT, + AOUT_CHAN_CENTER, AOUT_CHAN_LFE, 0 }; + /**************************************************************************** * Local prototypes ****************************************************************************/ @@ -101,6 +128,7 @@ static int OpenPacketizer( vlc_object_t * ); static void CloseDecoder ( vlc_object_t * ); static void *DecodeBlock ( decoder_t *, block_t ** ); +static int ProcessHeaders( decoder_t * ); static void *ProcessPacket ( decoder_t *, ogg_packet *, block_t ** ); static aout_buffer_t *DecodePacket ( decoder_t *, ogg_packet * ); @@ -108,10 +136,12 @@ static block_t *SendPacket( decoder_t *, ogg_packet *, block_t * ); static void ParseVorbisComments( decoder_t * ); +static void ConfigureChannelOrder(int *, int, uint32_t, vlc_bool_t ); + #ifdef MODULE_NAME_IS_tremor -static void Interleave ( int32_t *, const int32_t **, int, int ); +static void Interleave ( int32_t *, const int32_t **, int, int, int * ); #else -static void Interleave ( float *, const float **, int, int ); +static void Interleave ( float *, const float **, int, int, int * ); #endif #ifndef MODULE_NAME_IS_tremor @@ -125,25 +155,28 @@ static block_t *Encode ( encoder_t *, aout_buffer_t * ); *****************************************************************************/ #define ENC_QUALITY_TEXT N_("Encoding quality") #define ENC_QUALITY_LONGTEXT N_( \ - "Allows you to specify a quality between 1 (low) and 10 (high), instead " \ + "Enforce a quality between 1 (low) and 10 (high), instead " \ "of specifying a particular bitrate. This will produce a VBR stream." ) #define ENC_MAXBR_TEXT N_("Maximum encoding bitrate") #define ENC_MAXBR_LONGTEXT N_( \ - "Allows you to specify a maximum bitrate in kbps. " \ - "Useful for streaming applications." ) + "Maximum bitrate in kbps. This is useful for streaming applications." ) #define ENC_MINBR_TEXT N_("Minimum encoding bitrate") #define ENC_MINBR_LONGTEXT N_( \ - "Allows you to specify a minimum bitrate in kbps. " \ - "Useful for encoding for a fixed-size channel." ) + "Minimum bitrate in kbps. This is useful for encoding for a fixed-size channel." ) +#define ENC_CBR_TEXT N_("CBR encoding") +#define ENC_CBR_LONGTEXT N_( \ + "Force a constant bitrate encoding (CBR)." ) vlc_module_begin(); - + set_shortname( "Vorbis" ); set_description( _("Vorbis audio decoder") ); #ifdef MODULE_NAME_IS_tremor set_capability( "decoder", 90 ); #else set_capability( "decoder", 100 ); #endif + set_category( CAT_INPUT ); + set_subcategory( SUBCAT_INPUT_ACODEC ); set_callbacks( OpenDecoder, CloseDecoder ); add_submodule(); @@ -156,7 +189,9 @@ vlc_module_begin(); add_submodule(); set_description( _("Vorbis audio encoder") ); set_capability( "encoder", 100 ); - set_callbacks( OpenEncoder, CloseEncoder ); +#if defined(HAVE_VORBIS_VORBISENC_H) + set_callbacks( OpenEncoder, CloseEncoder ); +#endif add_integer( ENC_CFG_PREFIX "quality", 0, NULL, ENC_QUALITY_TEXT, ENC_QUALITY_LONGTEXT, VLC_FALSE ); @@ -164,13 +199,15 @@ vlc_module_begin(); ENC_MAXBR_LONGTEXT, VLC_FALSE ); add_integer( ENC_CFG_PREFIX "min-bitrate", 0, NULL, ENC_MINBR_TEXT, ENC_MINBR_LONGTEXT, VLC_FALSE ); + add_bool( ENC_CFG_PREFIX "cbr", 0, NULL, ENC_CBR_TEXT, + ENC_CBR_LONGTEXT, VLC_FALSE ); #endif vlc_module_end(); #ifndef MODULE_NAME_IS_tremor static const char *ppsz_enc_options[] = { - "quality", "max-bitrate", "min-bitrate", NULL + "quality", "max-bitrate", "min-bitrate", "cbr", NULL }; #endif @@ -197,6 +234,7 @@ static int OpenDecoder( vlc_object_t *p_this ) /* Misc init */ aout_DateSet( &p_sys->end_date, 0 ); + p_sys->i_last_block_size = 0; p_sys->b_packetizer = VLC_FALSE; p_sys->i_headers = 0; @@ -268,80 +306,166 @@ static void *DecodeBlock( decoder_t *p_dec, block_t **pp_block ) oggpacket.e_o_s = 0; oggpacket.packetno = 0; - if( p_sys->i_headers == 0 ) + /* Check for headers */ + if( p_sys->i_headers == 0 && p_dec->fmt_in.i_extra ) + { + /* Headers already available as extra data */ + msg_Dbg( p_dec, "headers already available as extra data" ); + p_sys->i_headers = 3; + } + else if( oggpacket.bytes && p_sys->i_headers < 3 ) { - /* Take care of the initial Vorbis header */ + /* Backup headers as extra data */ + uint8_t *p_extra; - oggpacket.b_o_s = 1; /* yes this actually is a b_o_s packet :) */ - if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, - &oggpacket ) < 0 ) + p_dec->fmt_in.p_extra = + realloc( p_dec->fmt_in.p_extra, p_dec->fmt_in.i_extra + + oggpacket.bytes + 2 ); + p_extra = (uint8_t *)p_dec->fmt_in.p_extra + p_dec->fmt_in.i_extra; + *(p_extra++) = oggpacket.bytes >> 8; + *(p_extra++) = oggpacket.bytes & 0xFF; + + memcpy( p_extra, oggpacket.packet, oggpacket.bytes ); + p_dec->fmt_in.i_extra += oggpacket.bytes + 2; + + block_Release( *pp_block ); + p_sys->i_headers++; + return NULL; + } + + if( p_sys->i_headers == 3 ) + { + if( ProcessHeaders( p_dec ) != VLC_SUCCESS ) { - msg_Err( p_dec, "this bitstream does not contain Vorbis " - "audio data."); + p_sys->i_headers = 0; + p_dec->fmt_in.i_extra = 0; block_Release( *pp_block ); return NULL; } - p_sys->i_headers++; + else p_sys->i_headers++; + } - /* Setup the format */ - p_dec->fmt_out.audio.i_rate = p_sys->vi.rate; - p_dec->fmt_out.audio.i_channels = p_sys->vi.channels; - p_dec->fmt_out.audio.i_physical_channels = - p_dec->fmt_out.audio.i_original_channels = - pi_channels_maps[p_sys->vi.channels]; - p_dec->fmt_out.i_bitrate = p_sys->vi.bitrate_nominal; + return ProcessPacket( p_dec, &oggpacket, pp_block ); +} - aout_DateInit( &p_sys->end_date, p_sys->vi.rate ); +/***************************************************************************** + * ProcessHeaders: process Vorbis headers. + *****************************************************************************/ +static int ProcessHeaders( decoder_t *p_dec ) +{ + decoder_sys_t *p_sys = p_dec->p_sys; + ogg_packet oggpacket; + uint8_t *p_extra; + int i_extra; - msg_Dbg( p_dec, "channels:%d samplerate:%ld bitrate:%ld", - p_sys->vi.channels, p_sys->vi.rate, - p_sys->vi.bitrate_nominal ); + if( !p_dec->fmt_in.i_extra ) return VLC_EGENERIC; - return ProcessPacket( p_dec, &oggpacket, pp_block ); + oggpacket.granulepos = -1; + oggpacket.b_o_s = 1; /* yes this actually is a b_o_s packet :) */ + oggpacket.e_o_s = 0; + oggpacket.packetno = 0; + p_extra = p_dec->fmt_in.p_extra; + i_extra = p_dec->fmt_in.i_extra; + + /* Take care of the initial Vorbis header */ + oggpacket.bytes = *(p_extra++) << 8; + oggpacket.bytes |= (*(p_extra++) & 0xFF); + oggpacket.packet = p_extra; + p_extra += oggpacket.bytes; + i_extra -= (oggpacket.bytes + 2); + if( i_extra < 0 ) + { + msg_Err( p_dec, "header data corrupted"); + return VLC_EGENERIC; } - if( p_sys->i_headers == 1 ) + if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, &oggpacket ) < 0 ) { - /* The next packet in order is the comments header */ - if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, &oggpacket ) - < 0 ) - { - msg_Err( p_dec, "2nd Vorbis header is corrupted" ); - block_Release( *pp_block ); - return NULL; - } - p_sys->i_headers++; + msg_Err( p_dec, "this bitstream does not contain Vorbis audio data"); + return VLC_EGENERIC; + } - ParseVorbisComments( p_dec ); + /* Setup the format */ + p_dec->fmt_out.audio.i_rate = p_sys->vi.rate; + p_dec->fmt_out.audio.i_channels = p_sys->vi.channels; - return ProcessPacket( p_dec, &oggpacket, pp_block ); + if( p_dec->fmt_out.audio.i_channels < 0 || + p_dec->fmt_out.audio.i_channels > 6 ) + { + msg_Err( p_dec, "invalid number of channels (not between 1 and 6): %i", + p_dec->fmt_out.audio.i_channels ); + return VLC_EGENERIC; } - if( p_sys->i_headers == 2 ) + p_dec->fmt_out.audio.i_physical_channels = + p_dec->fmt_out.audio.i_original_channels = + pi_channels_maps[p_sys->vi.channels]; + p_dec->fmt_out.i_bitrate = p_sys->vi.bitrate_nominal; + + aout_DateInit( &p_sys->end_date, p_sys->vi.rate ); + aout_DateSet( &p_sys->end_date, 0 ); + + msg_Dbg( p_dec, "channels:%d samplerate:%ld bitrate:%ld", + p_sys->vi.channels, p_sys->vi.rate, p_sys->vi.bitrate_nominal ); + + /* The next packet in order is the comments header */ + oggpacket.b_o_s = 0; + oggpacket.bytes = *(p_extra++) << 8; + oggpacket.bytes |= (*(p_extra++) & 0xFF); + oggpacket.packet = p_extra; + p_extra += oggpacket.bytes; + i_extra -= (oggpacket.bytes + 2); + if( i_extra < 0 ) { - /* The next packet in order is the codebooks header - We need to watch out that this packet is not missing as a - missing or corrupted header is fatal. */ - if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, &oggpacket ) - < 0 ) - { - msg_Err( p_dec, "3rd Vorbis header is corrupted" ); - block_Release( *pp_block ); - return NULL; - } - p_sys->i_headers++; + msg_Err( p_dec, "header data corrupted"); + return VLC_EGENERIC; + } - if( !p_sys->b_packetizer ) - { - /* Initialize the Vorbis packet->PCM decoder */ - vorbis_synthesis_init( &p_sys->vd, &p_sys->vi ); - vorbis_block_init( &p_sys->vd, &p_sys->vb ); - } + if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, &oggpacket ) < 0 ) + { + msg_Err( p_dec, "2nd Vorbis header is corrupted" ); + return VLC_EGENERIC; + } + ParseVorbisComments( p_dec ); + + /* The next packet in order is the codebooks header + * We need to watch out that this packet is not missing as a + * missing or corrupted header is fatal. */ + oggpacket.bytes = *(p_extra++) << 8; + oggpacket.bytes |= (*(p_extra++) & 0xFF); + oggpacket.packet = p_extra; + i_extra -= (oggpacket.bytes + 2); + if( i_extra < 0 ) + { + msg_Err( p_dec, "header data corrupted"); + return VLC_EGENERIC; + } - return ProcessPacket( p_dec, &oggpacket, pp_block ); + if( vorbis_synthesis_headerin( &p_sys->vi, &p_sys->vc, &oggpacket ) < 0 ) + { + msg_Err( p_dec, "3rd Vorbis header is corrupted" ); + return VLC_EGENERIC; } - return ProcessPacket( p_dec, &oggpacket, pp_block ); + if( !p_sys->b_packetizer ) + { + /* Initialize the Vorbis packet->PCM decoder */ + vorbis_synthesis_init( &p_sys->vd, &p_sys->vi ); + vorbis_block_init( &p_sys->vd, &p_sys->vb ); + } + else + { + p_dec->fmt_out.i_extra = p_dec->fmt_in.i_extra; + p_dec->fmt_out.p_extra = + realloc( p_dec->fmt_out.p_extra, p_dec->fmt_out.i_extra ); + memcpy( p_dec->fmt_out.p_extra, + p_dec->fmt_in.p_extra, p_dec->fmt_out.i_extra ); + } + + ConfigureChannelOrder(p_sys->pi_chan_table, p_sys->vi.channels, + p_dec->fmt_out.audio.i_physical_channels, VLC_TRUE); + + return VLC_SUCCESS; } /***************************************************************************** @@ -382,10 +506,7 @@ static void *ProcessPacket( decoder_t *p_dec, ogg_packet *p_oggpacket, else p_aout_buffer = NULL; - if( p_block ) - { - block_Release( p_block ); - } + if( p_block ) block_Release( p_block ); return p_aout_buffer; } } @@ -405,7 +526,11 @@ static aout_buffer_t *DecodePacket( decoder_t *p_dec, ogg_packet *p_oggpacket ) #endif if( p_oggpacket->bytes && +#ifdef MODULE_NAME_IS_tremor + vorbis_synthesis( &p_sys->vb, p_oggpacket, 1 ) == 0 ) +#else vorbis_synthesis( &p_sys->vb, p_oggpacket ) == 0 ) +#endif vorbis_synthesis_blockin( &p_sys->vd, &p_sys->vb ); /* **pp_pcm is a multichannel float vector. In stereo, for @@ -426,10 +551,10 @@ static aout_buffer_t *DecodePacket( decoder_t *p_dec, ogg_packet *p_oggpacket ) /* Interleave the samples */ #ifdef MODULE_NAME_IS_tremor Interleave( (int32_t *)p_aout_buffer->p_buffer, - (const int32_t **)pp_pcm, p_sys->vi.channels, i_samples ); + (const int32_t **)pp_pcm, p_sys->vi.channels, i_samples, p_sys->pi_chan_table); #else Interleave( (float *)p_aout_buffer->p_buffer, - (const float **)pp_pcm, p_sys->vi.channels, i_samples ); + (const float **)pp_pcm, p_sys->vi.channels, i_samples, p_sys->pi_chan_table); #endif /* Tell libvorbis how many samples we actually consumed */ @@ -479,9 +604,15 @@ static block_t *SendPacket( decoder_t *p_dec, ogg_packet *p_oggpacket, static void ParseVorbisComments( decoder_t *p_dec ) { input_thread_t *p_input = (input_thread_t *)p_dec->p_parent; - int i = 0; char *psz_name, *psz_value, *psz_comment; - while ( i < p_dec->p_sys->vc.comments ) + input_item_t *p_item; + int i = 0; + + if( p_input->i_object_type != VLC_OBJECT_INPUT ) return; + + p_item = input_GetItem( p_input ); + + while( i < p_dec->p_sys->vc.comments ) { psz_comment = strdup( p_dec->p_sys->vc.user_comments[i] ); if( !psz_comment ) @@ -496,8 +627,65 @@ static void ParseVorbisComments( decoder_t *p_dec ) *psz_value = '\0'; psz_value++; input_Control( p_input, INPUT_ADD_INFO, _("Vorbis comment"), - psz_name, psz_value ); + psz_name, "%s", psz_value ); + if( !strcasecmp( psz_name, "artist" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetArtist( p_item->p_meta, + psz_value ); + input_ItemAddInfo( p_item, + _(VLC_META_INFO_CAT), + _(VLC_META_ARTIST), + "%s", psz_value ); + } + } + else if( !strcasecmp( psz_name, "title" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetTitle( p_item->p_meta, + psz_value ); + p_item->psz_name = strdup( psz_value ); + } + } + else if( !strcasecmp( psz_name, "album" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetAlbum( p_item->p_meta, + psz_value ); + } + } + else if( !strcasecmp( psz_name, "musicbrainz_trackid" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetTrackID( p_item->p_meta, + psz_value ); + } + } +#if 0 //not used + else if( !strcasecmp( psz_name, "musicbrainz_artistid" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetArtistID( p_item->p_meta, + psz_value ); + } + } + else if( !strcasecmp( psz_name, "musicbrainz_albumid" ) ) + { + if( psz_value && ( *psz_value != '\0' ) ) + { + vlc_meta_SetAlbumID( p_item->p_meta, + psz_value ); + } + } +#endif } + /* FIXME */ + var_SetInteger( p_input, "item-change", p_item->i_id ); free( psz_comment ); i++; } @@ -506,24 +694,68 @@ static void ParseVorbisComments( decoder_t *p_dec ) /***************************************************************************** * Interleave: helper function to interleave channels *****************************************************************************/ -static void Interleave( +static void ConfigureChannelOrder(int *pi_chan_table, int i_channels, uint32_t i_channel_mask, vlc_bool_t b_decode) +{ + const uint32_t *pi_channels_in; + switch( i_channels ) + { + case 6: + case 5: + pi_channels_in = pi_6channels_in; + break; + case 4: + pi_channels_in = pi_4channels_in; + break; + case 3: + pi_channels_in = pi_3channels_in; + break; + default: + { + int i; + for( i = 0; i< i_channels; ++i ) + { + pi_chan_table[i] = i; + } + return; + } + } + + if( b_decode ) + aout_CheckChannelReorder( pi_channels_in, pi_channels_out, + i_channel_mask & AOUT_CHAN_PHYSMASK, + i_channels, + pi_chan_table ); + else + aout_CheckChannelReorder( pi_channels_out, pi_channels_in, + i_channel_mask & AOUT_CHAN_PHYSMASK, + i_channels, + pi_chan_table ); +} + +/***************************************************************************** + * Interleave: helper function to interleave channels + *****************************************************************************/ #ifdef MODULE_NAME_IS_tremor - int32_t *p_out, const int32_t **pp_in, +static void Interleave( int32_t *p_out, const int32_t **pp_in, + int i_nb_channels, int i_samples, int *pi_chan_table) +{ + int i, j; + + for ( j = 0; j < i_samples; j++ ) + for ( i = 0; i < i_nb_channels; i++ ) + p_out[j * i_nb_channels + pi_chan_table[i]] = pp_in[i][j] * (FIXED32_ONE >> 24); +} #else - float *p_out, const float **pp_in, -#endif - int i_nb_channels, int i_samples ) +static void Interleave( float *p_out, const float **pp_in, + int i_nb_channels, int i_samples, int *pi_chan_table ) { int i, j; for ( j = 0; j < i_samples; j++ ) - { for ( i = 0; i < i_nb_channels; i++ ) - { - p_out[j * i_nb_channels + i] = pp_in[i][j]; - } - } + p_out[j * i_nb_channels + pi_chan_table[i]] = pp_in[i][j]; } +#endif /***************************************************************************** * CloseDecoder: vorbis decoder destruction @@ -533,7 +765,7 @@ static void CloseDecoder( vlc_object_t *p_this ) decoder_t *p_dec = (decoder_t *)p_this; decoder_sys_t *p_sys = p_dec->p_sys; - if( !p_sys->b_packetizer && p_sys->i_headers >= 3 ) + if( !p_sys->b_packetizer && p_sys->i_headers > 3 ) { vorbis_block_clear( &p_sys->vb ); vorbis_dsp_clear( &p_sys->vd ); @@ -571,6 +803,12 @@ struct encoder_sys_t * Common properties */ mtime_t i_pts; + + /* + ** Channel reordering + */ + int pi_chan_table[AOUT_CHAN_MAX]; + }; /***************************************************************************** @@ -603,12 +841,14 @@ static int OpenEncoder( vlc_object_t *p_this ) p_enc->fmt_in.i_codec = VLC_FOURCC('f','l','3','2'); p_enc->fmt_out.i_codec = VLC_FOURCC('v','o','r','b'); - sout_CfgParse( p_enc, ENC_CFG_PREFIX, ppsz_enc_options, p_enc->p_cfg ); + config_ChainParse( p_enc, ENC_CFG_PREFIX, ppsz_enc_options, p_enc->p_cfg ); var_Get( p_enc, ENC_CFG_PREFIX "quality", &val ); i_quality = val.i_int; if( i_quality > 10 ) i_quality = 10; if( i_quality < 0 ) i_quality = 0; + var_Get( p_enc, ENC_CFG_PREFIX "cbr", &val ); + if( val.b_bool ) i_quality = 0; var_Get( p_enc, ENC_CFG_PREFIX "max-bitrate", &val ); i_max_bitrate = val.i_int; var_Get( p_enc, ENC_CFG_PREFIX "min-bitrate", &val ); @@ -677,10 +917,9 @@ static int OpenEncoder( vlc_object_t *p_this ) /* Create and store headers */ vorbis_analysis_headerout( &p_sys->vd, &p_sys->vc, &header[0], &header[1], &header[2]); - p_enc->fmt_out.i_extra = 1 + 3 * 2 + header[0].bytes + + p_enc->fmt_out.i_extra = 3 * 2 + header[0].bytes + header[1].bytes + header[2].bytes; p_extra = p_enc->fmt_out.p_extra = malloc( p_enc->fmt_out.i_extra ); - *(p_extra++) = 3; /* number of headers */ for( i = 0; i < 3; i++ ) { *(p_extra++) = header[i].bytes >> 8; @@ -694,6 +933,9 @@ static int OpenEncoder( vlc_object_t *p_this ) p_sys->i_samples_delay = 0; p_sys->i_pts = 0; + ConfigureChannelOrder(p_sys->pi_chan_table, p_sys->vi.channels, + p_enc->fmt_in.audio.i_physical_channels, VLC_TRUE); + return VLC_SUCCESS; } @@ -724,8 +966,8 @@ static block_t *Encode( encoder_t *p_enc, aout_buffer_t *p_aout_buf ) { for( j = 0 ; j < p_aout_buf->i_nb_samples ; j++ ) { - buffer[i][j]= ((float)( ((int16_t *)p_aout_buf->p_buffer ) - [j * p_sys->i_channels + i ] )) / 32768.f; + buffer[i][j]= ((float *)p_aout_buf->p_buffer) + [j * p_sys->i_channels + p_sys->pi_chan_table[i]]; } }