X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fdemux%2Fmp4%2Fmp4.c;h=f669c1cda1e7497cbafecbcc943f1cb58d46e6df;hb=811a68cde20c9c010c813fbb0ca0919764de248d;hp=dd98754240d16401a634fa4ddbec45ec38f1ba24;hpb=746ad2ae990b530ffbc245a1fb9798f4208714c5;p=vlc diff --git a/modules/demux/mp4/mp4.c b/modules/demux/mp4/mp4.c index dd98754240..f669c1cda1 100644 --- a/modules/demux/mp4/mp4.c +++ b/modules/demux/mp4/mp4.c @@ -17,20 +17,27 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ /***************************************************************************** * Preamble *****************************************************************************/ -#include /* malloc(), free() */ -#include -#include -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include +#include + + +#include #include -#include "iso_lang.h" -#include "vlc_meta.h" +#include +#include +#include +#include #include "libmp4.h" #include "drms.h" @@ -48,8 +55,8 @@ static void Close( vlc_object_t * ); vlc_module_begin(); set_category( CAT_INPUT ); set_subcategory( SUBCAT_INPUT_DEMUX ); - set_description( _("MP4 stream demuxer") ); - set_capability( "demux2", 242 ); + set_description( N_("MP4 stream demuxer") ); + set_capability( "demux", 242 ); set_callbacks( Open, Close ); vlc_module_end(); @@ -57,7 +64,7 @@ vlc_module_end(); * Local prototypes *****************************************************************************/ static int Demux ( demux_t * ); -static int DemuxRef( demux_t *p_demux ){ return 0;} +static int DemuxRef( demux_t *p_demux ){ (void)p_demux; return 0;} static int Seek ( demux_t *, mtime_t ); static int Control ( demux_t *, int, va_list ); @@ -88,11 +95,12 @@ typedef struct /* Contain all needed information for read all track with vlc */ typedef struct { - int i_track_ID; /* this should be unique */ + unsigned int i_track_ID;/* this should be unique */ - int b_ok; /* The track is usable */ - int b_enable; /* is the trak enable by default */ - vlc_bool_t b_selected; /* is the trak being played */ + int b_ok; /* The track is usable */ + int b_enable; /* is the trak enable by default */ + bool b_selected; /* is the trak being played */ + bool b_chapter; /* True when used for chapter only */ es_format_t fmt; es_out_id_t *p_es; @@ -129,7 +137,7 @@ typedef struct MP4_Box_t *p_stsd; /* will contain all data to initialize decoder */ MP4_Box_t *p_sample;/* point on actual sdsd */ - vlc_bool_t b_drms; + bool b_drms; void *p_drms; } mp4_track_t; @@ -141,19 +149,25 @@ struct demux_sys_t mtime_t i_pcr; - uint64_t i_time; /* time position of the presentation - * in movie timescale */ - uint64_t i_timescale; /* movie time scale */ - uint64_t i_duration; /* movie duration */ - unsigned int i_tracks; /* number of tracks */ - mp4_track_t *track; /* array of track */ + uint64_t i_time; /* time position of the presentation + * in movie timescale */ + uint64_t i_timescale; /* movie time scale */ + uint64_t i_duration; /* movie duration */ + unsigned int i_tracks; /* number of tracks */ + mp4_track_t *track; /* array of track */ + + /* */ + MP4_Box_t *p_tref_chap; + + /* */ + input_title_t *p_title; }; /***************************************************************************** * Declaration of local function *****************************************************************************/ static void MP4_TrackCreate ( demux_t *, mp4_track_t *, MP4_Box_t *); -static void MP4_TrackDestroy( demux_t *, mp4_track_t * ); +static void MP4_TrackDestroy( mp4_track_t * ); static int MP4_TrackSelect ( demux_t *, mp4_track_t *, mtime_t ); static void MP4_TrackUnselect(demux_t *, mp4_track_t * ); @@ -165,6 +179,8 @@ static int MP4_TrackSampleSize( mp4_track_t * ); static int MP4_TrackNextSample( demux_t *, mp4_track_t * ); static void MP4_TrackSetELST( demux_t *, mp4_track_t *, int64_t ); +static void MP4_UpdateSeekpoint( demux_t * ); + /* Return time in s of a track */ static inline int64_t MP4_TrackGetDTS( demux_t *p_demux, mp4_track_t *p_track ) { @@ -214,10 +230,10 @@ static inline int64_t MP4_TrackGetDTS( demux_t *p_demux, mp4_track_t *p_track ) if( i_dts < 0 ) i_dts = 0; } - return I64C(1000000) * i_dts / p_track->i_timescale; + return INT64_C(1000000) * i_dts / p_track->i_timescale; } -static inline int64_t MP4_TrackGetPTSDelta( demux_t *p_demux, mp4_track_t *p_track ) +static inline int64_t MP4_TrackGetPTSDelta( mp4_track_t *p_track ) { mp4_chunk_t *ck = &p_track->chunk[p_track->i_chunk]; unsigned int i_index = 0; @@ -229,7 +245,7 @@ static inline int64_t MP4_TrackGetPTSDelta( demux_t *p_demux, mp4_track_t *p_tra for( i_index = 0;; i_index++ ) { if( i_sample < ck->p_sample_count_pts[i_index] ) - return ck->p_sample_offset_pts[i_index] * I64C(1000000) / + return ck->p_sample_offset_pts[i_index] * INT64_C(1000000) / (int64_t)p_track->i_timescale; i_sample -= ck->p_sample_count_pts[i_index]; @@ -238,10 +254,10 @@ static inline int64_t MP4_TrackGetPTSDelta( demux_t *p_demux, mp4_track_t *p_tra static inline int64_t MP4_GetMoviePTS(demux_sys_t *p_sys ) { - return I64C(1000000) * p_sys->i_time / p_sys->i_timescale; + return INT64_C(1000000) * p_sys->i_time / p_sys->i_timescale; } -#define FREE( p ) if( p ) { free( p ); (p) = NULL;} +static void LoadChapter( demux_t *p_demux ); /***************************************************************************** * Open: check file and initializes MP4 structures @@ -251,7 +267,7 @@ static int Open( vlc_object_t * p_this ) demux_t *p_demux = (demux_t *)p_this; demux_sys_t *p_sys; - uint8_t *p_peek; + const uint8_t *p_peek; MP4_Box_t *p_ftyp; MP4_Box_t *p_rmra; @@ -259,7 +275,7 @@ static int Open( vlc_object_t * p_this ) MP4_Box_t *p_trak; unsigned int i; - vlc_bool_t b_seekable; + bool b_seekable; /* A little test to see if it could be a mp4 */ if( stream_Peek( p_demux->s, &p_peek, 8 ) < 8 ) return VLC_EGENERIC; @@ -343,122 +359,74 @@ static int Open( vlc_object_t * p_this ) if( ( p_rmra = MP4_BoxGet( p_sys->p_root, "/moov/rmra" ) ) ) { - playlist_t *p_playlist; - playlist_item_t *p_item; int i_count = MP4_BoxCount( p_rmra, "rmda" ); int i; - vlc_bool_t b_play = VLC_FALSE; msg_Dbg( p_demux, "detected playlist mov file (%d ref)", i_count ); - p_playlist = - (playlist_t *)vlc_object_find( p_demux, - VLC_OBJECT_PLAYLIST, - FIND_ANYWHERE ); - if( p_playlist ) + input_thread_t * p_input = vlc_object_find( p_demux, VLC_OBJECT_INPUT, FIND_PARENT ); + input_item_t * p_current = input_GetItem( p_input ); + p_current->i_type = ITEM_TYPE_PLAYLIST; + + for( i = 0; i < i_count; i++ ) { - p_item = playlist_LockItemGetByInput( p_playlist, - ((input_thread_t *)p_demux->p_parent)->input.p_item ); - playlist_ItemToNode( p_playlist, p_item ); + MP4_Box_t *p_rdrf = MP4_BoxGet( p_rmra, "rmda[%d]/rdrf", i ); + char *psz_ref; + uint32_t i_ref_type; - for( i = 0; i < i_count; i++ ) + if( !p_rdrf || !( psz_ref = strdup( p_rdrf->data.p_rdrf->psz_ref ) ) ) { - MP4_Box_t *p_rdrf = MP4_BoxGet( p_rmra, "rmda[%d]/rdrf", i ); - char *psz_ref; - uint32_t i_ref_type; + continue; + } + i_ref_type = p_rdrf->data.p_rdrf->i_ref_type; + + msg_Dbg( p_demux, "new ref=`%s' type=%4.4s", + psz_ref, (char*)&i_ref_type ); - if( !p_rdrf || !( psz_ref = p_rdrf->data.p_rdrf->psz_ref ) ) + if( i_ref_type == VLC_FOURCC( 'u', 'r', 'l', ' ' ) ) + { + if( strstr( psz_ref, "qt5gateQT" ) ) { + msg_Dbg( p_demux, "ignoring pseudo ref =`%s'", psz_ref ); continue; } - i_ref_type = p_rdrf->data.p_rdrf->i_ref_type; - - msg_Dbg( p_demux, "new ref=`%s' type=%4.4s", - psz_ref, (char*)&i_ref_type ); - - if( i_ref_type == VLC_FOURCC( 'u', 'r', 'l', ' ' ) ) + if( !strncmp( psz_ref, "http://", 7 ) || + !strncmp( psz_ref, "rtsp://", 7 ) ) { - if( strstr( psz_ref, "qt5gateQT" ) ) - { - msg_Dbg( p_demux, "ignoring pseudo ref =`%s'", psz_ref ); - continue; - } - if( !strncmp( psz_ref, "http://", 7 ) || - !strncmp( psz_ref, "rtsp://", 7 ) ) - { - msg_Dbg( p_demux, "adding ref = `%s'", psz_ref ); - if( p_item ) - { - playlist_item_t *p_child = - playlist_ItemNew( p_playlist, - psz_ref, psz_ref ); - if( p_child ) - { - playlist_NodeAddItem( p_playlist, p_child, - p_item->pp_parents[0]->i_view, - p_item, PLAYLIST_APPEND, - PLAYLIST_END ); - playlist_CopyParents( p_item, p_child ); - b_play = VLC_TRUE; - } - } - } - else - { - /* msg dbg relative ? */ - char *psz_absolute = alloca( strlen( p_demux->psz_access ) + 3 + strlen( p_demux->psz_path ) + strlen( psz_ref ) + 1); - char *end = strrchr( p_demux->psz_path, '/' ); - - if( end ) - { - int i_len = end + 1 - p_demux->psz_path; - - strcpy( psz_absolute, p_demux->psz_access ); - strcat( psz_absolute, "://" ); - strncat( psz_absolute, p_demux->psz_path, i_len); - } - else - { - strcpy( psz_absolute, "" ); - } - strcat( psz_absolute, psz_ref ); - msg_Dbg( p_demux, "adding ref = `%s'", psz_absolute ); - if( p_item ) - { - playlist_item_t *p_child = - playlist_ItemNew( p_playlist, - psz_absolute, - psz_absolute ); - if( p_child ) - { - playlist_NodeAddItem( p_playlist, p_child, - p_item->pp_parents[0]->i_view, - p_item, PLAYLIST_APPEND, - PLAYLIST_END ); - playlist_CopyParents( p_item, p_child ); - b_play = VLC_TRUE; - } - } - } + ; } else { - msg_Err( p_demux, "unknown ref type=%4.4s FIXME (send a bug report)", - (char*)&p_rdrf->data.p_rdrf->i_ref_type ); + char *psz_absolute; + char *psz_path = strdup( p_demux->psz_path ); + char *end = strrchr( psz_path, '/' ); + if( end ) end[1] = '\0'; + else *psz_path = '\0'; + + if( asprintf( &psz_absolute, "%s://%s%s", + p_demux->psz_access, psz_path, psz_ref ) < 0 ) + return VLC_ENOMEM; + + free( psz_ref ); + psz_ref = psz_absolute; + free( psz_path ); } + input_item_t *p_input; + msg_Dbg( p_demux, "adding ref = `%s'", psz_ref ); + p_input = input_ItemNewExt( p_demux, psz_ref, NULL, + 0, NULL, -1 ); + input_ItemCopyOptions( p_current, p_input ); + input_ItemAddSubItem( p_current, p_input ); + vlc_gc_decref( p_input ); } - if( b_play == VLC_TRUE ) + else { - playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, - p_playlist->status.i_view, - p_playlist->status.p_item, NULL ); + msg_Err( p_demux, "unknown ref type=%4.4s FIXME (send a bug report)", + (char*)&p_rdrf->data.p_rdrf->i_ref_type ); } - vlc_object_release( p_playlist ); - } - else - { - msg_Err( p_demux, "can't find playlist" ); + free( psz_ref ); } + vlc_object_release( p_input ); } if( !(p_mvhd = MP4_BoxGet( p_sys->p_root, "/moov/mvhd" ) ) ) @@ -478,6 +446,11 @@ static int Open( vlc_object_t * p_this ) else { p_sys->i_timescale = p_mvhd->data.p_mvhd->i_timescale; + if( p_sys->i_timescale == 0 ) + { + msg_Err( p_this, "bad timescale" ); + goto error; + } p_sys->i_duration = p_mvhd->data.p_mvhd->i_duration; } @@ -486,23 +459,38 @@ static int Open( vlc_object_t * p_this ) msg_Err( p_demux, "cannot find any /moov/trak" ); goto error; } - msg_Dbg( p_demux, "find %d track%c", + msg_Dbg( p_demux, "found %d track%c", p_sys->i_tracks, p_sys->i_tracks ? 's':' ' ); /* allocate memory */ p_sys->track = calloc( p_sys->i_tracks, sizeof( mp4_track_t ) ); + if( p_sys->track == NULL ) + goto error; memset( p_sys->track, 0, p_sys->i_tracks * sizeof( mp4_track_t ) ); + /* Search the first chap reference (like quicktime) */ + p_sys->p_tref_chap = NULL; + for( i = 0; i < p_sys->i_tracks; i++ ) + { + MP4_Box_t *p_trak = MP4_BoxGet( p_sys->p_root, "/moov/trak[%d]", i ); + MP4_Box_t *p_chap = MP4_BoxGet( p_trak, "tref/chap", i ); + if( !p_chap || p_chap->data.p_tref_generic->i_entry_count <= 0 ) + continue; + + p_sys->p_tref_chap = p_chap; + break; + } + /* now process each track and extract all usefull information */ for( i = 0; i < p_sys->i_tracks; i++ ) { p_trak = MP4_BoxGet( p_sys->p_root, "/moov/trak[%d]", i ); MP4_TrackCreate( p_demux, &p_sys->track[i], p_trak ); - if( p_sys->track[i].b_ok ) + if( p_sys->track[i].b_ok && !p_sys->track[i].b_chapter ) { - char *psz_cat; + const char *psz_cat; switch( p_sys->track[i].fmt.i_cat ) { case( VIDEO_ES ): @@ -526,13 +514,23 @@ static int Open( vlc_object_t * p_this ) p_sys->track[i].fmt.psz_language ? p_sys->track[i].fmt.psz_language : "undef" ); } + else if( p_sys->track[i].b_ok && p_sys->track[i].b_chapter ) + { + msg_Dbg( p_demux, "using track[Id 0x%x] for chapter language %s", + p_sys->track[i].i_track_ID, + p_sys->track[i].fmt.psz_language ? + p_sys->track[i].fmt.psz_language : "undef" ); + } else { msg_Dbg( p_demux, "ignoring track[Id 0x%x]", p_sys->track[i].i_track_ID ); } - } + + /* */ + LoadChapter( p_demux ); + return VLC_SUCCESS; error: @@ -562,9 +560,9 @@ static int Demux( demux_t *p_demux ) i_track++ ) { mp4_track_t *tk = &p_sys->track[i_track]; - vlc_bool_t b; + bool b; - if( !tk->b_ok || + if( !tk->b_ok || tk->b_chapter || ( tk->b_selected && tk->i_sample >= tk->i_sample_count ) ) { continue; @@ -604,6 +602,9 @@ static int Demux( demux_t *p_demux ) return 0; } + /* */ + MP4_UpdateSeekpoint( p_demux ); + /* first wait for the good time to read a packet */ es_out_Control( p_demux->out, ES_OUT_SET_PCR, p_sys->i_pcr + 1 ); @@ -616,10 +617,8 @@ static int Demux( demux_t *p_demux ) { mp4_track_t *tk = &p_sys->track[i_track]; - if( !tk->b_ok || !tk->b_selected || tk->i_sample >= tk->i_sample_count ) - { + if( !tk->b_ok || tk->b_chapter || !tk->b_selected || tk->i_sample >= tk->i_sample_count ) continue; - } while( MP4_TrackGetDTS( p_demux, tk ) < MP4_GetMoviePTS( p_sys ) ) { @@ -675,7 +674,7 @@ static int Demux( demux_t *p_demux ) p_block->i_buffer = i_size + 1; /* convert \r -> \n */ - while( ( p = strchr( p_block->p_buffer, '\r' ) ) ) + while( ( p = strchr((char *) p_block->p_buffer, '\r' ) ) ) { *p = '\n'; } @@ -690,7 +689,7 @@ static int Demux( demux_t *p_demux ) /* dts */ p_block->i_dts = MP4_TrackGetDTS( p_demux, tk ) + 1; /* pts */ - i_delta = MP4_TrackGetPTSDelta( p_demux, tk ); + i_delta = MP4_TrackGetPTSDelta( tk ); if( i_delta != -1 ) p_block->i_pts = p_block->i_dts + i_delta; else if( tk->fmt.i_cat != VIDEO_ES ) @@ -704,14 +703,34 @@ static int Demux( demux_t *p_demux ) /* Next sample */ if( MP4_TrackNextSample( p_demux, tk ) ) - { break; - } } } return 1; } + +static void MP4_UpdateSeekpoint( demux_t *p_demux ) +{ + demux_sys_t *p_sys = p_demux->p_sys; + int64_t i_time; + int i; + if( !p_sys->p_title ) + return; + i_time = MP4_GetMoviePTS( p_sys ); + for( i = 0; i < p_sys->p_title->i_seekpoint; i++ ) + { + if( i_time < p_sys->p_title->seekpoint[i]->i_time_offset ) + break; + } + i--; + + if( i != p_demux->info.i_seekpoint && i >= 0 ) + { + p_demux->info.i_seekpoint = i; + p_demux->info.i_update |= INPUT_UPDATE_SEEKPOINT; + } +} /***************************************************************************** * Seek: Got to i_date ******************************************************************************/ @@ -730,6 +749,7 @@ static int Seek( demux_t *p_demux, mtime_t i_date ) mp4_track_t *tk = &p_sys->track[i_track]; MP4_TrackSeek( p_demux, tk, i_date ); } + MP4_UpdateSeekpoint( p_demux ); return VLC_SUCCESS; } @@ -800,58 +820,81 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) case DEMUX_GET_META: { - vlc_meta_t **pp_meta = (vlc_meta_t**)va_arg( args, vlc_meta_t** ); - vlc_meta_t *meta; - MP4_Box_t *p_udta = MP4_BoxGet( p_sys->p_root, "/moov/udta" ); + vlc_meta_t *p_meta = (vlc_meta_t *)va_arg( args, vlc_meta_t*); MP4_Box_t *p_0xa9xxx; + + MP4_Box_t *p_udta = MP4_BoxGet( p_sys->p_root, "/moov/udta/meta/ilst" ); if( p_udta == NULL ) { - return VLC_EGENERIC; + p_udta = MP4_BoxGet( p_sys->p_root, "/moov/udta" ); + if( p_udta == NULL ) + { + return VLC_EGENERIC; + } } - *pp_meta = meta = vlc_meta_New(); + for( p_0xa9xxx = p_udta->p_first; p_0xa9xxx != NULL; p_0xa9xxx = p_0xa9xxx->p_next ) { + + if( !p_0xa9xxx || !p_0xa9xxx->data.p_0xa9xxx ) + continue; + + /* FIXME FIXME: should convert from whatever the character + * encoding of MP4 meta data is to UTF-8. */ +#define SET(fct) do { char *psz_utf = strdup( p_0xa9xxx->data.p_0xa9xxx->psz_text ? p_0xa9xxx->data.p_0xa9xxx->psz_text : "" ); \ + if( psz_utf ) { EnsureUTF8( psz_utf ); \ + fct( p_meta, psz_utf ); free( psz_utf ); } } while(0) + + /* XXX Becarefull p_udta can have box that are not 0xa9xx */ switch( p_0xa9xxx->i_type ) { case FOURCC_0xa9nam: /* Full name */ - vlc_meta_Add( meta, VLC_META_TITLE, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetTitle ); break; case FOURCC_0xa9aut: - vlc_meta_Add( meta, VLC_META_AUTHOR, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetArtist ); break; case FOURCC_0xa9ART: - vlc_meta_Add( meta, VLC_META_ARTIST, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetArtist ); break; case FOURCC_0xa9cpy: - vlc_meta_Add( meta, VLC_META_COPYRIGHT, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetCopyright ); break; case FOURCC_0xa9day: /* Creation Date */ - vlc_meta_Add( meta, VLC_META_DATE, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetDate ); break; case FOURCC_0xa9des: /* Description */ - vlc_meta_Add( meta, VLC_META_DESCRIPTION, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetDescription ); break; case FOURCC_0xa9gen: /* Genre */ - vlc_meta_Add( meta, VLC_META_GENRE, - p_0xa9xxx->data.p_0xa9xxx->psz_text ); + SET( vlc_meta_SetGenre ); break; - case FOURCC_0xa9swr: - case FOURCC_0xa9inf: /* Information */ case FOURCC_0xa9alb: /* Album */ - case FOURCC_0xa9dir: /* Director */ - case FOURCC_0xa9dis: /* Disclaimer */ - case FOURCC_0xa9enc: /* Encoded By */ + SET( vlc_meta_SetAlbum ); + break; + case FOURCC_0xa9trk: /* Track */ + SET( vlc_meta_SetTracknum ); + break; + case FOURCC_0xa9cmt: /* Commment */ + SET( vlc_meta_SetDescription ); + break; + case FOURCC_0xa9url: /* URL */ + SET( vlc_meta_SetURL ); + break; + + case FOURCC_0xa9enc: /* Encoded By */ + SET( vlc_meta_SetEncodedBy ); + break; + + case FOURCC_0xa9swr: + case FOURCC_0xa9inf: /* Information */ + case FOURCC_0xa9dir: /* Director */ + case FOURCC_0xa9dis: /* Disclaimer */ case FOURCC_0xa9req: /* Requirements */ case FOURCC_0xa9fmt: /* Original Format */ case FOURCC_0xa9dsa: /* Display Source As */ @@ -865,6 +908,7 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) case FOURCC_WLOC: /* Window Location */ /* TODO one day, but they aren't really meaningfull */ break; +#undef SET default: break; @@ -874,12 +918,45 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) } case DEMUX_GET_TITLE_INFO: + { + input_title_t ***ppp_title = (input_title_t***)va_arg( args, input_title_t*** ); + int *pi_int = (int*)va_arg( args, int* ); + int *pi_title_offset = (int*)va_arg( args, int* ); + int *pi_seekpoint_offset = (int*)va_arg( args, int* ); + + if( !p_sys->p_title ) + return VLC_EGENERIC; + + *pi_int = 1; + *ppp_title = malloc( sizeof( input_title_t**) ); + (*ppp_title)[0] = vlc_input_title_Duplicate( p_sys->p_title ); + *pi_title_offset = 0; + *pi_seekpoint_offset = 0; + return VLC_SUCCESS; + } + case DEMUX_SET_TITLE: + { + const int i_title = (int)va_arg( args, int ); + if( !p_sys->p_title || i_title != 0 ) + return VLC_EGENERIC; + return VLC_SUCCESS; + } + case DEMUX_SET_SEEKPOINT: + { + const int i_seekpoint = (int)va_arg( args, int ); + if( !p_sys->p_title ) + return VLC_EGENERIC; + return Seek( p_demux, p_sys->p_title->seekpoint[i_seekpoint]->i_time_offset ); + } + case DEMUX_SET_NEXT_DEMUX_TIME: case DEMUX_SET_GROUP: + case DEMUX_HAS_UNSUPPORTED_META: + case DEMUX_GET_ATTACHMENTS: return VLC_EGENERIC; default: - msg_Warn( p_demux, "control query unimplemented !!!" ); + msg_Warn( p_demux, "control query %u unimplemented", i_query ); return VLC_EGENERIC; } } @@ -889,18 +966,21 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) *****************************************************************************/ static void Close ( vlc_object_t * p_this ) { - unsigned int i_track; demux_t * p_demux = (demux_t *)p_this; demux_sys_t *p_sys = p_demux->p_sys; + unsigned int i_track; msg_Dbg( p_demux, "freeing all memory" ); MP4_BoxFree( p_demux->s, p_sys->p_root ); for( i_track = 0; i_track < p_sys->i_tracks; i_track++ ) { - MP4_TrackDestroy( p_demux, &p_sys->track[i_track] ); + MP4_TrackDestroy( &p_sys->track[i_track] ); } - FREE( p_sys->track ); + FREENULL( p_sys->track ); + + if( p_sys->p_title ) + vlc_input_title_Delete( p_sys->p_title ); free( p_sys ); } @@ -910,6 +990,90 @@ static void Close ( vlc_object_t * p_this ) /**************************************************************************** * Local functions, specific to vlc ****************************************************************************/ +/* Chapters */ +static void LoadChapterGpac( demux_t *p_demux, MP4_Box_t *p_chpl ) +{ + demux_sys_t *p_sys = p_demux->p_sys; + int i; + + p_sys->p_title = vlc_input_title_New(); + for( i = 0; i < p_chpl->data.p_chpl->i_chapter; i++ ) + { + seekpoint_t *s = vlc_seekpoint_New(); + + s->psz_name = strdup( p_chpl->data.p_chpl->chapter[i].psz_name ); + EnsureUTF8( s->psz_name ); + s->i_time_offset = p_chpl->data.p_chpl->chapter[i].i_start / 10; + TAB_APPEND( p_sys->p_title->i_seekpoint, p_sys->p_title->seekpoint, s ); + } +} +static void LoadChapterApple( demux_t *p_demux, mp4_track_t *tk ) +{ + demux_sys_t *p_sys = p_demux->p_sys; + + for( tk->i_sample = 0; tk->i_sample < tk->i_sample_count; tk->i_sample++ ) + { + const int64_t i_dts = MP4_TrackGetDTS( p_demux, tk ); + const int64_t i_pts_delta = MP4_TrackGetPTSDelta( tk ); + const unsigned int i_size = MP4_TrackSampleSize( tk ); + + if( i_size > 0 && !stream_Seek( p_demux->s, MP4_TrackGetPos( tk ) ) ) + { + char p_buffer[256]; + const int i_read = stream_Read( p_demux->s, p_buffer, __MIN( sizeof(p_buffer), i_size ) ); + const int i_len = __MIN( GetWBE(p_buffer), i_read-2 ); + + if( i_len > 0 ) + { + seekpoint_t *s = vlc_seekpoint_New(); + + s->psz_name = strndup( &p_buffer[2], i_len ); + EnsureUTF8( s->psz_name ); + + s->i_time_offset = i_dts + __MAX( i_pts_delta, 0 ); + + if( !p_sys->p_title ) + p_sys->p_title = vlc_input_title_New(); + TAB_APPEND( p_sys->p_title->i_seekpoint, p_sys->p_title->seekpoint, s ); + } + } + if( tk->i_sample+1 >= tk->chunk[tk->i_chunk].i_sample_first + + tk->chunk[tk->i_chunk].i_sample_count ) + tk->i_chunk++; + } +} +static void LoadChapter( demux_t *p_demux ) +{ + demux_sys_t *p_sys = p_demux->p_sys; + MP4_Box_t *p_chpl; + + if( ( p_chpl = MP4_BoxGet( p_sys->p_root, "/moov/udta/chpl" ) ) && p_chpl->data.p_chpl->i_chapter > 0 ) + { + LoadChapterGpac( p_demux, p_chpl ); + } + else if( p_sys->p_tref_chap ) + { + MP4_Box_data_tref_generic_t *p_chap = p_sys->p_tref_chap->data.p_tref_generic; + unsigned int i, j; + + /* Load the first subtitle track like quicktime */ + for( i = 0; i < p_chap->i_entry_count; i++ ) + { + for( j = 0; j < p_sys->i_tracks; j++ ) + { + mp4_track_t *tk = &p_sys->track[j]; + if( tk->b_ok && tk->i_track_ID == p_chap->i_track_ID[i] && + tk->fmt.i_cat == SPU_ES && tk->fmt.i_codec == VLC_FOURCC( 's', 'u', 'b', 't' ) ) + break; + } + if( j < p_sys->i_tracks ) + { + LoadChapterApple( p_demux, &p_sys->track[i] ); + break; + } + } + } +} /* now create basic chunk data, the rest will be filled by MP4_CreateSamplesIndex */ static int TrackCreateChunksIndex( demux_t *p_demux, @@ -936,6 +1100,10 @@ static int TrackCreateChunksIndex( demux_t *p_demux, } p_demux_track->chunk = calloc( p_demux_track->i_chunk_count, sizeof( mp4_chunk_t ) ); + if( p_demux_track->chunk == NULL ) + { + return VLC_ENOMEM; + } /* first we read chunk offset */ for( i_chunk = 0; i_chunk < p_demux_track->i_chunk_count; i_chunk++ ) @@ -967,6 +1135,12 @@ static int TrackCreateChunksIndex( demux_t *p_demux, for( i_chunk = p_stsc->data.p_stsc->i_first_chunk[i_index] - 1; i_chunk < i_last; i_chunk++ ) { + if( i_chunk >= p_demux_track->i_chunk_count ) + { + msg_Warn( p_demux, "corrupted chunk table" ); + return VLC_EGENERIC; + } + p_demux_track->chunk[i_chunk].i_sample_description_index = p_stsc->data.p_stsc->i_sample_description_index[i_index]; p_demux_track->chunk[i_chunk].i_sample_count = @@ -1042,6 +1216,8 @@ static int TrackCreateSamplesIndex( demux_t *p_demux, p_demux_track->i_sample_size = 0; p_demux_track->p_sample_size = calloc( p_demux_track->i_sample_count, sizeof( uint32_t ) ); + if( p_demux_track->p_sample_size == NULL ) + return VLC_ENOMEM; for( i_sample = 0; i_sample < p_demux_track->i_sample_count; i_sample++ ) { @@ -1176,7 +1352,7 @@ static int TrackCreateSamplesIndex( demux_t *p_demux, } } - msg_Dbg( p_demux, "track[Id 0x%x] read %d samples length:"I64Fd"s", + msg_Dbg( p_demux, "track[Id 0x%x] read %d samples length:%"PRId64"s", p_demux_track->i_track_ID, p_demux_track->i_sample_count, i_last_dts / p_demux_track->i_timescale ); @@ -1194,7 +1370,8 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, MP4_Box_t *p_esds; MP4_Box_t *p_box; - *pp_es = NULL; + if( pp_es ) + *pp_es = NULL; if( !p_track->chunk[i_chunk].i_sample_description_index ) { @@ -1216,7 +1393,7 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, p_track->p_sample = p_sample; - if( p_track->fmt.i_cat == AUDIO_ES && p_track->i_sample_size == 1 ) + if( p_track->fmt.i_cat == AUDIO_ES && ( p_track->i_sample_size == 1 || p_track->i_sample_size == 2 ) ) { MP4_Box_data_sample_soun_t *p_soun; @@ -1251,6 +1428,13 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, case VLC_FOURCC( 'u', 'l', 'a', 'w' ): p_soun->i_samplesize = 8; break; + case VLC_FOURCC( 'N', 'O', 'N', 'E' ): + case VLC_FOURCC( 'r', 'a', 'w', ' ' ): + case VLC_FOURCC( 't', 'w', 'o', 's' ): + case VLC_FOURCC( 's', 'o', 'w', 't' ): + /* What would be the fun if you could trust the .mov */ + p_track->i_sample_size = ((p_soun->i_samplesize+7)/8) * p_soun->i_channelcount; + break; default: break; } @@ -1262,7 +1446,6 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, } } - /* It's a little ugly but .. there are special cases */ switch( p_sample->i_type ) { @@ -1272,7 +1455,14 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, break; case( VLC_FOURCC( 'r', 'a', 'w', ' ' ) ): - p_track->fmt.i_codec = VLC_FOURCC( 'a', 'r', 'a', 'w' ); + case( VLC_FOURCC( 'N', 'O', 'N', 'E' ) ): + { + MP4_Box_data_sample_soun_t *p_soun = p_sample->data.p_sample_soun; + + if(p_soun && (p_soun->i_samplesize+7)/8 == 1 ) + p_track->fmt.i_codec = VLC_FOURCC( 'u', '8', ' ', ' ' ); + else + p_track->fmt.i_codec = VLC_FOURCC( 't', 'w', 'o', 's' ); /* Buggy files workaround */ if( p_sample->data.p_sample_soun && (p_track->i_timescale != @@ -1281,7 +1471,7 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, MP4_Box_data_sample_soun_t *p_soun = p_sample->data.p_sample_soun; - msg_Warn( p_demux, "i_timescale ("I64Fu") != i_sampleratehi " + msg_Warn( p_demux, "i_timescale (%"PRIu64") != i_sampleratehi " "(%u), making both equal (report any problem).", p_track->i_timescale, p_soun->i_sampleratehi ); @@ -1291,6 +1481,7 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, p_soun->i_sampleratehi = p_track->i_timescale; } break; + } case( VLC_FOURCC( 's', '2', '6', '3' ) ): p_track->fmt.i_codec = VLC_FOURCC( 'h', '2', '6', '3' ); @@ -1301,7 +1492,25 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, p_track->fmt.i_codec = VLC_FOURCC( 's', 'u', 'b', 't' ); /* FIXME: Not true, could be UTF-16 with a Byte Order Mark (0xfeff) */ /* FIXME UTF-8 doesn't work here ? */ - /* p_track->fmt.subs.psz_encoding = strdup( "UTF-8" ); */ + p_track->fmt.subs.psz_encoding = strdup( "UTF-8" ); + break; + + case VLC_FOURCC('y','v','1','2'): + p_track->fmt.i_codec = VLC_FOURCC('Y','V','1','2'); + break; + case VLC_FOURCC('y','u','v','2'): + p_track->fmt.i_codec = VLC_FOURCC('Y','U','Y','2'); + break; + + case VLC_FOURCC('i','n','2','4'): + /* in in24/in32 there's enda-atom to tell it's little-endian (if present) */ + if( ( MP4_BoxGet( p_sample, "wave/enda" ) ) || + ( MP4_BoxGet( p_sample, "enda" ) ) ) + { + p_track->fmt.i_codec = VLC_FOURCC('4','2','n','i'); + } else { + p_track->fmt.i_codec = p_sample->i_type; + } break; default: @@ -1387,6 +1596,21 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, switch( p_sample->i_type ) { /* qt decoder, send the complete chunk */ + case VLC_FOURCC ('h', 'd', 'v', '1'): // HDV 720p30 + case VLC_FOURCC ('h', 'd', 'v', '2'): // HDV 1080i60 + case VLC_FOURCC ('h', 'd', 'v', '3'): // HDV 1080i50 + case VLC_FOURCC ('h', 'd', 'v', '5'): // HDV 720p25 + case VLC_FOURCC ('m', 'x', '5', 'n'): // MPEG2 IMX NTSC 525/60 50mb/s produced by FCP + case VLC_FOURCC ('m', 'x', '5', 'p'): // MPEG2 IMX PAL 625/60 50mb/s produced by FCP + case VLC_FOURCC ('m', 'x', '4', 'n'): // MPEG2 IMX NTSC 525/60 40mb/s produced by FCP + case VLC_FOURCC ('m', 'x', '4', 'p'): // MPEG2 IMX PAL 625/60 40mb/s produced by FCP + case VLC_FOURCC ('m', 'x', '3', 'n'): // MPEG2 IMX NTSC 525/60 30mb/s produced by FCP + case VLC_FOURCC ('m', 'x', '3', 'p'): // MPEG2 IMX PAL 625/50 30mb/s produced by FCP + case VLC_FOURCC ('x', 'd', 'v', '2'): // XDCAM HD 1080i60 + case VLC_FOURCC ('A', 'V', 'm', 'p'): // AVID IMX PAL + p_track->fmt.i_codec = VLC_FOURCC( 'm','p','g','v' ); + break; + /* qt decoder, send the complete chunk */ case VLC_FOURCC( 'S', 'V', 'Q', '3' ): case VLC_FOURCC( 'S', 'V', 'Q', '1' ): case VLC_FOURCC( 'V', 'P', '3', '1' ): @@ -1437,6 +1661,11 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, break; } + case VLC_FOURCC('m','s',0x00,0x02): + case VLC_FOURCC('m','s',0x00,0x11): + p_track->fmt.audio.i_blockalign = p_sample->data.p_sample_soun->i_bytes_per_frame; + break; + default: break; } @@ -1466,6 +1695,10 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, p_track->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * p_track->i_width / p_track->i_height; + /* Support for cropping (eg. in H263 files) */ + p_track->fmt.video.i_visible_width = p_track->fmt.video.i_width; + p_track->fmt.video.i_visible_height = p_track->fmt.video.i_height; + /* Frame rate */ p_track->fmt.video.i_frame_rate = p_track->i_timescale; p_track->fmt.video.i_frame_rate_base = 1; @@ -1496,7 +1729,8 @@ static int TrackCreateES( demux_t *p_demux, mp4_track_t *p_track, break; } - *pp_es = es_out_Add( p_demux->out, &p_track->fmt ); + if( pp_es ) + *pp_es = es_out_Add( p_demux->out, &p_track->fmt ); return VLC_SUCCESS; } @@ -1516,10 +1750,8 @@ static int TrackTimeToSampleChunk( demux_t *p_demux, mp4_track_t *p_track, int i_index; /* FIXME see if it's needed to check p_track->i_chunk_count */ - if( !p_track->b_ok || p_track->i_chunk_count == 0 ) - { + if( p_track->i_chunk_count == 0 ) return( VLC_EGENERIC ); - } /* handle elst (find the correct one) */ MP4_TrackSetELST( p_demux, p_track, i_start ); @@ -1530,7 +1762,7 @@ static int TrackTimeToSampleChunk( demux_t *p_demux, mp4_track_t *p_track, /* now calculate i_start for this elst */ /* offset */ - i_start -= p_track->i_elst_time * I64C(1000000) / p_sys->i_timescale; + i_start -= p_track->i_elst_time * INT64_C(1000000) / p_sys->i_timescale; if( i_start < 0 ) { *pi_chunk = 0; @@ -1548,7 +1780,7 @@ static int TrackTimeToSampleChunk( demux_t *p_demux, mp4_track_t *p_track, i_start += elst->i_media_time[p_track->i_elst]; } - msg_Dbg( p_demux, "elst (%d) gives "I64Fd"ms (movie)-> "I64Fd + msg_Dbg( p_demux, "elst (%d) gives %"PRId64"ms (movie)-> %"PRId64 "ms (track)", p_track->i_elst, i_mvt * 1000 / p_sys->i_timescale, i_start * 1000 / p_track->i_timescale ); @@ -1672,13 +1904,12 @@ static int TrackTimeToSampleChunk( demux_t *p_demux, mp4_track_t *p_track, static int TrackGotoChunkSample( demux_t *p_demux, mp4_track_t *p_track, unsigned int i_chunk, unsigned int i_sample ) { - vlc_bool_t b_reselect = VLC_FALSE; + bool b_reselect = false; /* now see if actual es is ok */ - if( p_track->i_chunk < 0 || - p_track->i_chunk >= p_track->i_chunk_count - 1 || - p_track->chunk[p_track->i_chunk].i_sample_description_index != - p_track->chunk[i_chunk].i_sample_description_index ) + if( (p_track->i_chunk >= p_track->i_chunk_count - 1) || + (p_track->chunk[p_track->i_chunk].i_sample_description_index != + p_track->chunk[i_chunk].i_sample_description_index) ) { msg_Warn( p_demux, "recreate ES for track[Id 0x%x]", p_track->i_track_ID ); @@ -1695,8 +1926,8 @@ static int TrackGotoChunkSample( demux_t *p_demux, mp4_track_t *p_track, msg_Err( p_demux, "cannot create es for track[Id 0x%x]", p_track->i_track_ID ); - p_track->b_ok = VLC_FALSE; - p_track->b_selected = VLC_FALSE; + p_track->b_ok = false; + p_track->b_selected = false; return VLC_EGENERIC; } } @@ -1743,9 +1974,10 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, /* hint track unsupported */ /* set default value (-> track unusable) */ - p_track->b_ok = VLC_FALSE; - p_track->b_enable = VLC_FALSE; - p_track->b_selected = VLC_FALSE; + p_track->b_ok = false; + p_track->b_enable = false; + p_track->b_selected = false; + p_track->b_chapter = false; es_format_Init( &p_track->fmt, UNKNOWN_ES, 0 ); @@ -1757,6 +1989,8 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, /* do we launch this track by default ? */ p_track->b_enable = ( ( p_tkhd->data.p_tkhd->i_flags&MP4_TRACK_ENABLED ) != 0 ); + if( !p_track->b_enable ) + p_track->fmt.i_priority = -1; p_track->i_track_ID = p_tkhd->data.p_tkhd->i_track_ID; p_track->i_width = p_tkhd->data.p_tkhd->i_width / 65536; @@ -1776,6 +2010,8 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, } p_track->i_timescale = p_mdhd->data.p_mdhd->i_timescale; + if( !p_track->i_timescale ) + return; for( i = 0; i < 3; i++ ) { @@ -1821,12 +2057,12 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, msg_Warn( p_demux, "elst box found" ); for( i = 0; i < elst->i_entry_count; i++ ) { - msg_Dbg( p_demux, " - [%d] duration="I64Fd"ms media time="I64Fd + msg_Dbg( p_demux, " - [%d] duration=%"PRId64"ms media time=%"PRId64 "ms) rate=%d.%d", i, elst->i_segment_duration[i] * 1000 / p_sys->i_timescale, elst->i_media_time[i] >= 0 ? (int64_t)(elst->i_media_time[i] * 1000 / p_track->i_timescale) : - I64C(-1), + INT64_C(-1), elst->i_media_rate_integer[i], elst->i_media_rate_fraction[i] ); } @@ -1881,16 +2117,33 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, p_track->i_chunk = 0; p_track->i_sample = 0; + /* Mark chapter only track */ + if( !p_track->b_enable && p_sys->p_tref_chap ) + { + MP4_Box_data_tref_generic_t *p_chap = p_sys->p_tref_chap->data.p_tref_generic; + unsigned int i; + + for( i = 0; i < p_chap->i_entry_count; i++ ) + { + if( p_track->i_track_ID == p_chap->i_track_ID[i] ) + { + p_track->b_chapter = true; + break; + } + } + } + /* now create es */ + p_track->p_es = NULL; if( TrackCreateES( p_demux, p_track, p_track->i_chunk, - &p_track->p_es ) ) + p_track->b_chapter ? NULL : &p_track->p_es ) ) { msg_Err( p_demux, "cannot create es for track[Id 0x%x]", p_track->i_track_ID ); return; } - + p_track->b_ok = true; #if 0 { int i; @@ -1903,7 +2156,6 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, } } #endif - p_track->b_ok = VLC_TRUE; } /**************************************************************************** @@ -1911,13 +2163,13 @@ static void MP4_TrackCreate( demux_t *p_demux, mp4_track_t *p_track, **************************************************************************** * Destroy a track created by MP4_TrackCreate. ****************************************************************************/ -static void MP4_TrackDestroy( demux_t *p_demux, mp4_track_t *p_track ) +static void MP4_TrackDestroy( mp4_track_t *p_track ) { unsigned int i_chunk; - p_track->b_ok = VLC_FALSE; - p_track->b_enable = VLC_FALSE; - p_track->b_selected = VLC_FALSE; + p_track->b_ok = false; + p_track->b_enable = false; + p_track->b_selected = false; es_format_Clean( &p_track->fmt ); @@ -1925,25 +2177,25 @@ static void MP4_TrackDestroy( demux_t *p_demux, mp4_track_t *p_track ) { if( p_track->chunk ) { - FREE(p_track->chunk[i_chunk].p_sample_count_dts); - FREE(p_track->chunk[i_chunk].p_sample_delta_dts ); + FREENULL(p_track->chunk[i_chunk].p_sample_count_dts); + FREENULL(p_track->chunk[i_chunk].p_sample_delta_dts ); - FREE(p_track->chunk[i_chunk].p_sample_count_pts); - FREE(p_track->chunk[i_chunk].p_sample_offset_pts ); + FREENULL(p_track->chunk[i_chunk].p_sample_count_pts); + FREENULL(p_track->chunk[i_chunk].p_sample_offset_pts ); } } - FREE( p_track->chunk ); + FREENULL( p_track->chunk ); if( !p_track->i_sample_size ) { - FREE( p_track->p_sample_size ); + FREENULL( p_track->p_sample_size ); } } static int MP4_TrackSelect( demux_t *p_demux, mp4_track_t *p_track, mtime_t i_start ) { - if( !p_track->b_ok ) + if( !p_track->b_ok || p_track->b_chapter ) { return VLC_EGENERIC; } @@ -1960,7 +2212,7 @@ static int MP4_TrackSelect( demux_t *p_demux, mp4_track_t *p_track, static void MP4_TrackUnselect( demux_t *p_demux, mp4_track_t *p_track ) { - if( !p_track->b_ok ) + if( !p_track->b_ok || p_track->b_chapter ) { return; } @@ -1974,10 +2226,10 @@ static void MP4_TrackUnselect( demux_t *p_demux, mp4_track_t *p_track ) if( p_track->p_es ) { es_out_Control( p_demux->out, ES_OUT_SET_ES_STATE, - p_track->p_es, VLC_FALSE ); + p_track->p_es, false ); } - p_track->b_selected = VLC_FALSE; + p_track->b_selected = false; } static int MP4_TrackSeek( demux_t *p_demux, mp4_track_t *p_track, @@ -1986,39 +2238,37 @@ static int MP4_TrackSeek( demux_t *p_demux, mp4_track_t *p_track, uint32_t i_chunk; uint32_t i_sample; - if( !p_track->b_ok ) - { - return( VLC_EGENERIC ); - } + if( !p_track->b_ok || p_track->b_chapter ) + return VLC_EGENERIC; - p_track->b_selected = VLC_FALSE; + p_track->b_selected = false; if( TrackTimeToSampleChunk( p_demux, p_track, i_start, &i_chunk, &i_sample ) ) { msg_Warn( p_demux, "cannot select track[Id 0x%x]", p_track->i_track_ID ); - return( VLC_EGENERIC ); + return VLC_EGENERIC; } - p_track->b_selected = VLC_TRUE; + p_track->b_selected = true; if( TrackGotoChunkSample( p_demux, p_track, i_chunk, i_sample ) == VLC_SUCCESS ) { - p_track->b_selected = VLC_TRUE; + p_track->b_selected = true; es_out_Control( p_demux->out, ES_OUT_SET_NEXT_DISPLAY_TIME, p_track->p_es, i_start ); } - return( p_track->b_selected ? VLC_SUCCESS : VLC_EGENERIC ); + return p_track->b_selected ? VLC_SUCCESS : VLC_EGENERIC; } /* * 3 types: for audio - * + * */ #define QT_V0_MAX_SAMPLES 1024 static int MP4_TrackSampleSize( mp4_track_t *p_track )