X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fdemux%2Fogg.c;h=b5750c3d1f536686101685945efadcc013901118;hb=6d5336200143e6d1ad70ef653c72265d25f67640;hp=6b044fc3269e6cb36750c4c831342f67344842f8;hpb=2de4c9faad5c03b4b3d9a87b51ab14e24eb7e380;p=vlc diff --git a/modules/demux/ogg.c b/modules/demux/ogg.c index 6b044fc326..b5750c3d1f 100644 --- a/modules/demux/ogg.c +++ b/modules/demux/ogg.c @@ -1,25 +1,25 @@ /***************************************************************************** * ogg.c : ogg stream demux module for vlc ***************************************************************************** - * Copyright (C) 2001-2007 the VideoLAN team + * Copyright (C) 2001-2007 VLC authors and VideoLAN * $Id$ * * Authors: Gildas Bazin * Andre Pang (Annodex support) * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 2.1 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ /***************************************************************************** @@ -40,8 +40,7 @@ #include #include #include "xiph.h" -#include "vorbis.h" -#include "kate_categories.h" +#include "xiph_metadata.h" #include "ogg.h" #include "oggseek.h" @@ -123,6 +122,7 @@ static int Control( demux_t *, int, va_list ); static int Ogg_ReadPage ( demux_t *, ogg_page * ); static void Ogg_UpdatePCR ( logical_stream_t *, ogg_packet * ); static void Ogg_DecodePacket ( demux_t *, logical_stream_t *, ogg_packet * ); +static int Ogg_OpusPacketDuration( logical_stream_t *, ogg_packet * ); static int Ogg_BeginningOfStream( demux_t *p_demux ); static int Ogg_FindLogicalStreams( demux_t *p_demux ); @@ -134,14 +134,16 @@ static bool Ogg_LogicalStreamResetEsFormat( demux_t *p_demux, logical_stream_t * /* */ static void Ogg_ExtractMeta( demux_t *p_demux, vlc_fourcc_t i_codec, const uint8_t *p_headers, int i_headers ); +static int64_t Ogg_GetLastPacket( demux_t *p_demux, logical_stream_t *p_stream, double f_rate ); /* Logical bitstream headers */ -static void Ogg_ReadTheoraHeader( logical_stream_t *, ogg_packet * ); -static void Ogg_ReadVorbisHeader( logical_stream_t *, ogg_packet * ); +static void Ogg_ReadTheoraHeader( demux_t *, logical_stream_t *, ogg_packet * ); +static void Ogg_ReadVorbisHeader( demux_t *, logical_stream_t *, ogg_packet * ); static void Ogg_ReadSpeexHeader( logical_stream_t *, ogg_packet * ); +static void Ogg_ReadOpusHeader( demux_t *, logical_stream_t *, ogg_packet * ); static void Ogg_ReadKateHeader( logical_stream_t *, ogg_packet * ); static void Ogg_ReadFlacHeader( demux_t *, logical_stream_t *, ogg_packet * ); -static void Ogg_ReadAnnodexHeader( vlc_object_t *, logical_stream_t *, ogg_packet * ); +static void Ogg_ReadAnnodexHeader( demux_t *, logical_stream_t *, ogg_packet * ); static bool Ogg_ReadDiracHeader( logical_stream_t *, ogg_packet * ); /***************************************************************************** @@ -153,7 +155,6 @@ static int Open( vlc_object_t * p_this ) demux_sys_t *p_sys; const uint8_t *p_peek; - /* Check if we are dealing with an ogg stream */ if( stream_Peek( p_demux->s, &p_peek, 4 ) < 4 ) return VLC_EGENERIC; if( !p_demux->b_force && memcmp( p_peek, "OggS", 4 ) ) @@ -161,28 +162,22 @@ static int Open( vlc_object_t * p_this ) return VLC_EGENERIC; } - /* Set exported functions */ - p_demux->pf_demux = Demux; - p_demux->pf_control = Control; - p_demux->p_sys = p_sys = malloc( sizeof( demux_sys_t ) ); + /* */ + p_demux->p_sys = p_sys = calloc( 1, sizeof( demux_sys_t ) ); if( !p_sys ) return VLC_ENOMEM; - memset( p_sys, 0, sizeof( demux_sys_t ) ); - p_sys->i_bitrate = 0; - p_sys->pp_stream = NULL; - p_sys->p_old_stream = NULL; + p_sys->i_length = -1; - /* Begnning of stream, tell the demux to look for elementary streams. */ - p_sys->i_bos = 0; - p_sys->i_eos = 0; + /* Set exported functions */ + p_demux->pf_demux = Demux; + p_demux->pf_control = Control; /* Initialize the Ogg physical bitstream parser */ ogg_sync_init( &p_sys->oy ); - p_sys->b_page_waiting = false; /* */ - p_sys->p_meta = NULL; + TAB_INIT( p_sys->i_seekpoints, p_sys->pp_seekpoints ); return VLC_SUCCESS; } @@ -203,6 +198,8 @@ static void Close( vlc_object_t *p_this ) if( p_sys->p_old_stream ) Ogg_LogicalStreamDelete( p_demux, p_sys->p_old_stream ); + TAB_CLEAN( p_sys->i_seekpoints, p_sys->pp_seekpoints ); + free( p_sys ); } @@ -239,7 +236,7 @@ static int Demux( demux_t * p_demux ) return 0; msg_Dbg( p_demux, "beginning of a group of logical streams" ); - es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); + es_out_Control( p_demux->out, ES_OUT_SET_PCR, VLC_TS_0 ); } /* @@ -284,9 +281,10 @@ static int Demux( demux_t * p_demux ) ogg_stream_reset_serialno( &p_stream->os, ogg_page_serialno( &p_sys->current_page ) ); p_stream->b_reinit = true; - p_stream->i_pcr = -1; - p_stream->i_interpolated_pcr = -1; - es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); + p_stream->i_pcr = VLC_TS_0; + p_stream->i_interpolated_pcr = VLC_TS_0; + p_stream->i_previous_granulepos = -1; + es_out_Control( p_demux->out, ES_OUT_SET_PCR, VLC_TS_0); } if( ogg_stream_pagein( &p_stream->os, &p_sys->current_page ) != 0 ) @@ -305,14 +303,14 @@ static int Demux( demux_t * p_demux ) oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "\x80theora", 7 ) ) { - Ogg_ReadTheoraHeader( p_stream, &oggpacket ); + Ogg_ReadTheoraHeader( p_demux, p_stream, &oggpacket ); p_stream->i_secondary_header_packets = 0; } else if( p_stream->fmt.i_codec == VLC_CODEC_VORBIS && oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "\x01vorbis", 7 ) ) { - Ogg_ReadVorbisHeader( p_stream, &oggpacket ); + Ogg_ReadVorbisHeader( p_demux, p_stream, &oggpacket ); p_stream->i_secondary_header_packets = 0; } else if( p_stream->fmt.i_codec == VLC_CODEC_CMML ) @@ -339,16 +337,44 @@ static int Demux( demux_t * p_demux ) if( p_stream->i_pcr >= 0 ) { p_stream->b_reinit = false; + /* For Opus, trash the first 80 ms of decoded output as + well, to avoid blowing out speakers if we get unlucky. + Opus predicts content from prior frames, which can go + badly if we seek right where the stream goes from very + quiet to very loud. It will converge after a bit. */ + if( p_stream->fmt.i_codec == VLC_CODEC_OPUS ) + { + ogg_int64_t start_time; + int duration; + p_stream->i_skip_frames = 80*48; + /* Make sure we never play audio from within the + pre-skip at the beginning of the stream. */ + duration = + Ogg_OpusPacketDuration( p_stream, &oggpacket ); + start_time = p_stream->i_previous_granulepos; + if( duration > 0 ) + { + start_time = start_time > duration ? + start_time - duration : 0; + } + if( p_stream->i_pre_skip > start_time ) + { + p_stream->i_skip_frames += + p_stream->i_pre_skip - start_time; + } + } } else { p_stream->i_interpolated_pcr = -1; + p_stream->i_previous_granulepos = -1; continue; } /* An Ogg/vorbis packet contains an end date granulepos */ if( p_stream->fmt.i_codec == VLC_CODEC_VORBIS || p_stream->fmt.i_codec == VLC_CODEC_SPEEX || + p_stream->fmt.i_codec == VLC_CODEC_OPUS || p_stream->fmt.i_codec == VLC_CODEC_FLAC ) { if( ogg_stream_packetout( &p_stream->os, &oggpacket ) > 0 ) @@ -394,6 +420,22 @@ static int Demux( demux_t * p_demux ) return 1; } +static void Ogg_ResetStreamHelper( demux_sys_t *p_sys ) +{ + for( int i = 0; i < p_sys->i_streams; i++ ) + { + logical_stream_t *p_stream = p_sys->pp_stream[i]; + + /* we'll trash all the data until we find the next pcr */ + p_stream->b_reinit = true; + p_stream->i_pcr = -1; + p_stream->i_interpolated_pcr = -1; + p_stream->i_previous_granulepos = -1; + ogg_stream_reset( &p_stream->os ); + } + ogg_sync_reset( &p_sys->oy ); +} + /***************************************************************************** * Control: *****************************************************************************/ @@ -403,7 +445,6 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) vlc_meta_t *p_meta; int64_t *pi64; bool *pb_bool; - int i; switch( i_query ) { @@ -426,6 +467,22 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) case DEMUX_SET_TIME: return VLC_EGENERIC; + case DEMUX_GET_ATTACHMENTS: + { + input_attachment_t ***ppp_attach = + (input_attachment_t***)va_arg( args, input_attachment_t*** ); + int *pi_int = (int*)va_arg( args, int * ); + + if( p_sys->i_attachments <= 0 ) + return VLC_EGENERIC; + + *pi_int = p_sys->i_attachments; + *ppp_attach = xmalloc( sizeof(input_attachment_t**) * p_sys->i_attachments ); + for( int i = 0; i < p_sys->i_attachments; i++ ) + (*ppp_attach)[i] = vlc_input_attachment_Duplicate( p_sys->attachments[i] ); + return VLC_SUCCESS; + } + case DEMUX_SET_POSITION: /* forbid seeking if we haven't initialized all logical bitstreams yet; if we allowed, some headers would not get backed up and decoder init @@ -435,19 +492,61 @@ static int Control( demux_t *p_demux, int i_query, va_list args ) return VLC_EGENERIC; } - for( i = 0; i < p_sys->i_streams; i++ ) - { - logical_stream_t *p_stream = p_sys->pp_stream[i]; + Ogg_ResetStreamHelper( p_sys ); + return demux_vaControlHelper( p_demux->s, 0, -1, p_sys->i_bitrate, + 1, i_query, args ); + case DEMUX_GET_LENGTH: + if ( p_sys->i_length < 0 ) + return demux_vaControlHelper( p_demux->s, 0, -1, p_sys->i_bitrate, + 1, i_query, args ); + pi64 = (int64_t*)va_arg( args, int64_t * ); + *pi64 = p_sys->i_length * 1000000; + return VLC_SUCCESS; - /* we'll trash all the data until we find the next pcr */ - p_stream->b_reinit = true; - p_stream->i_pcr = -1; - p_stream->i_interpolated_pcr = -1; - ogg_stream_reset( &p_stream->os ); + case DEMUX_GET_TITLE_INFO: + { + input_title_t ***ppp_title = (input_title_t***)va_arg( args, input_title_t*** ); + int *pi_int = (int*)va_arg( args, int* ); + int *pi_title_offset = (int*)va_arg( args, int* ); + int *pi_seekpoint_offset = (int*)va_arg( args, int* ); + + if( p_sys->i_seekpoints > 0 ) + { + *pi_int = 1; + *ppp_title = malloc( sizeof( input_title_t**) ); + input_title_t *p_title = (*ppp_title)[0] = vlc_input_title_New(); + for( int i = 0; i < p_sys->i_seekpoints; i++ ) + { + TAB_APPEND( p_title->i_seekpoint, p_title->seekpoint, p_sys->pp_seekpoints[i] ); + } + *pi_title_offset = 0; + *pi_seekpoint_offset = 0; } - ogg_sync_reset( &p_sys->oy ); - /* XXX The break/return is missing on purpose as - * demux_vaControlHelper will do the last part of the job */ + return VLC_SUCCESS; + } + case DEMUX_SET_TITLE: + { + const int i_title = (int)va_arg( args, int ); + if( i_title > 1 ) + return VLC_EGENERIC; + return VLC_SUCCESS; + } + case DEMUX_SET_SEEKPOINT: + { + const int i_seekpoint = (int)va_arg( args, int ); + if( i_seekpoint > p_sys->i_seekpoints ) + return VLC_EGENERIC; + if( p_sys->i_bos > 0 ) + { + return VLC_EGENERIC; + } + + Ogg_ResetStreamHelper( p_sys ); + int64_t i_block = p_sys->pp_seekpoints[i_seekpoint]->i_time_offset * p_sys->i_bitrate / INT64_C(8000000); + if( stream_Seek( p_demux->s, i_block ) ) + return VLC_EGENERIC; + return VLC_SUCCESS; + } default: return demux_vaControlHelper( p_demux->s, 0, -1, p_sys->i_bitrate, @@ -488,6 +587,7 @@ static int Ogg_ReadPage( demux_t *p_demux, ogg_page *p_oggpage ) static void Ogg_UpdatePCR( logical_stream_t *p_stream, ogg_packet *p_oggpacket ) { + p_stream->i_end_trim = 0; /* Convert the granulepos into a pcr */ if( p_oggpacket->granulepos >= 0 ) { @@ -510,15 +610,35 @@ static void Ogg_UpdatePCR( logical_stream_t *p_stream, } else { - p_stream->i_pcr = p_oggpacket->granulepos * INT64_C(1000000) - / p_stream->f_rate; + ogg_int64_t sample; + sample = p_oggpacket->granulepos; + if( p_oggpacket->e_o_s && + p_stream->fmt.i_codec == VLC_CODEC_OPUS && + p_stream->i_previous_granulepos >= 0 ) + { + int duration; + duration = Ogg_OpusPacketDuration( p_stream, p_oggpacket ); + if( duration > 0 ) + { + ogg_int64_t end_sample; + end_sample = p_stream->i_previous_granulepos + duration; + if( end_sample > sample ) + p_stream->i_end_trim = (int)(end_sample - sample); + } + } + if (sample >= p_stream->i_pre_skip) + sample -= p_stream->i_pre_skip; + else + sample = 0; + p_stream->i_pcr = sample * INT64_C(1000000) / p_stream->f_rate; } - p_stream->i_pcr += 1; + p_stream->i_pcr += VLC_TS_0; p_stream->i_interpolated_pcr = p_stream->i_pcr; } else { + int duration; p_stream->i_pcr = -1; /* no granulepos available, try to interpolate the pcr. @@ -526,11 +646,30 @@ static void Ogg_UpdatePCR( logical_stream_t *p_stream, if( p_stream->fmt.i_cat == VIDEO_ES ) /* 1 frame per packet */ p_stream->i_interpolated_pcr += (INT64_C(1000000) / p_stream->f_rate); + else if( p_stream->fmt.i_codec == VLC_CODEC_OPUS && + p_stream->i_previous_granulepos >= 0 && + ( duration = + Ogg_OpusPacketDuration( p_stream, p_oggpacket ) ) > 0 ) + { + ogg_int64_t sample; + p_oggpacket->granulepos = + p_stream->i_previous_granulepos + duration; + sample = p_oggpacket->granulepos; + if (sample >= p_stream->i_pre_skip) + sample -= p_stream->i_pre_skip; + else + sample = 0; + p_stream->i_interpolated_pcr = + VLC_TS_0 + sample * INT64_C(1000000) / p_stream->f_rate; + } else if( p_stream->fmt.i_bitrate ) + { p_stream->i_interpolated_pcr += ( p_oggpacket->bytes * INT64_C(1000000) / p_stream->fmt.i_bitrate / 8 ); + } } + p_stream->i_previous_granulepos = p_oggpacket->granulepos; } /**************************************************************************** @@ -546,13 +685,6 @@ static void Ogg_DecodePacket( demux_t *p_demux, mtime_t i_pts = -1, i_interpolated_pts; demux_sys_t *p_ogg = p_demux->p_sys; - /* Sanity check */ - if( !p_oggpacket->bytes ) - { - msg_Dbg( p_demux, "discarding 0 sized packet" ); - return; - } - if( p_oggpacket->bytes >= 7 && ! memcmp ( p_oggpacket->packet, "Annodex", 7 ) ) { @@ -566,7 +698,7 @@ static void Ogg_DecodePacket( demux_t *p_demux, return; } - if( p_stream->fmt.i_codec == VLC_CODEC_SUBT && + if( p_stream->fmt.i_codec == VLC_CODEC_SUBT && p_oggpacket->bytes > 0 && p_oggpacket->packet[0] & PACKET_TYPE_BITS ) return; /* Check the ES is selected */ @@ -582,7 +714,14 @@ static void Ogg_DecodePacket( demux_t *p_demux, case VLC_CODEC_VORBIS: case VLC_CODEC_SPEEX: case VLC_CODEC_THEORA: - if( p_stream->i_packets_backup == 3 ) p_stream->b_force_backup = 0; + if( p_stream->i_packets_backup == 3 ) + p_stream->b_force_backup = false; + b_xiph = true; + break; + + case VLC_CODEC_OPUS: + if( p_stream->i_packets_backup == 2 ) + p_stream->b_force_backup = false; b_xiph = true; break; @@ -590,11 +729,11 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( !p_stream->fmt.audio.i_rate && p_stream->i_packets_backup == 2 ) { Ogg_ReadFlacHeader( p_demux, p_stream, p_oggpacket ); - p_stream->b_force_backup = 0; + p_stream->b_force_backup = false; } else if( p_stream->fmt.audio.i_rate ) { - p_stream->b_force_backup = 0; + p_stream->b_force_backup = false; if( p_oggpacket->bytes >= 9 ) { p_oggpacket->packet += 9; @@ -605,12 +744,13 @@ static void Ogg_DecodePacket( demux_t *p_demux, break; case VLC_CODEC_KATE: - if( p_stream->i_packets_backup == p_stream->i_kate_num_headers ) p_stream->b_force_backup = 0; + if( p_stream->i_packets_backup == p_stream->i_kate_num_headers ) + p_stream->b_force_backup = false; b_xiph = true; break; default: - p_stream->b_force_backup = 0; + p_stream->b_force_backup = false; b_xiph = false; break; } @@ -624,10 +764,11 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( p_stream->p_headers ) { memcpy( (unsigned char *)p_stream->p_headers + p_stream->i_headers - p_oggpacket->bytes, - p_oggpacket->packet, p_stream->i_headers ); + p_oggpacket->packet, p_oggpacket->bytes ); } else { +#warning Memory leak p_stream->i_headers = 0; p_stream->p_headers = NULL; free( p_org ); @@ -673,6 +814,7 @@ static void Ogg_DecodePacket( demux_t *p_demux, /* Convert the pcr into a pts */ if( p_stream->fmt.i_codec == VLC_CODEC_VORBIS || p_stream->fmt.i_codec == VLC_CODEC_SPEEX || + p_stream->fmt.i_codec == VLC_CODEC_OPUS || p_stream->fmt.i_codec == VLC_CODEC_FLAC ) { if( p_stream->i_pcr >= 0 ) @@ -682,7 +824,6 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( p_stream->i_previous_pcr == 0 && p_stream->i_pcr > 3 * DEFAULT_PTS_DELAY ) { - es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); /* Call the pace control */ es_out_Control( p_demux->out, ES_OUT_SET_PCR, @@ -692,7 +833,7 @@ static void Ogg_DecodePacket( demux_t *p_demux, p_stream->i_previous_pcr = p_stream->i_pcr; /* The granulepos is the end date of the sample */ - i_pts = p_stream->i_pcr; + i_pts = p_stream->i_pcr; } } @@ -710,7 +851,6 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( p_stream->i_previous_pcr == 0 && p_stream->i_pcr > 3 * DEFAULT_PTS_DELAY ) { - es_out_Control( p_demux->out, ES_OUT_RESET_PCR ); /* Call the pace control */ es_out_Control( p_demux->out, ES_OUT_SET_PCR, VLC_TS_0 + p_stream->i_pcr ); @@ -720,6 +860,7 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( p_stream->fmt.i_codec != VLC_CODEC_VORBIS && p_stream->fmt.i_codec != VLC_CODEC_SPEEX && + p_stream->fmt.i_codec != VLC_CODEC_OPUS && p_stream->fmt.i_codec != VLC_CODEC_FLAC && p_stream->i_pcr >= 0 ) { @@ -736,27 +877,59 @@ static void Ogg_DecodePacket( demux_t *p_demux, return; } - if( p_oggpacket->bytes <= 0 ) - return; - - if( !( p_block = block_New( p_demux, p_oggpacket->bytes ) ) ) return; + if( !( p_block = block_Alloc( p_oggpacket->bytes ) ) ) return; - /* may need to preroll video frames after a seek */ + /* may need to preroll after a seek */ if ( p_stream->i_skip_frames > 0 ) { - p_block->i_flags |= BLOCK_FLAG_PREROLL; - p_stream->i_skip_frames--; + if( p_stream->fmt.i_codec == VLC_CODEC_OPUS ) + { + int duration; + duration = Ogg_OpusPacketDuration( p_stream, p_oggpacket ); + if( p_stream->i_skip_frames > duration ) + { + p_block->i_flags |= BLOCK_FLAG_PREROLL; + p_block->i_nb_samples = 0; + p_stream->i_skip_frames -= duration; + } + else + { + p_block->i_nb_samples = duration - p_stream->i_skip_frames; + if( p_stream->i_previous_granulepos >= + p_block->i_nb_samples + p_stream->i_pre_skip ) + { + i_pts = VLC_TS_0 + (p_stream->i_previous_granulepos + - p_block->i_nb_samples - p_stream->i_pre_skip) * + INT64_C(1000000) / p_stream->f_rate; + } + p_stream->i_skip_frames = 0; + } + } + else + { + p_block->i_flags |= BLOCK_FLAG_PREROLL; + p_stream->i_skip_frames--; + } } + else if( p_stream->fmt.i_codec == VLC_CODEC_OPUS ) + p_block->i_nb_samples = Ogg_OpusPacketDuration( p_stream, p_oggpacket ); /* Normalize PTS */ - if( i_pts == 0 ) i_pts = VLC_TS_0; - else if( i_pts == -1 && i_interpolated_pts == 0 ) i_pts = VLC_TS_0; + if( i_pts == VLC_TS_INVALID ) i_pts = VLC_TS_0; + else if( i_pts == -1 && i_interpolated_pts == VLC_TS_INVALID ) + i_pts = VLC_TS_0; + else if( i_pts == -1 && p_stream->fmt.i_cat == VIDEO_ES ) + i_pts = i_interpolated_pts; else if( i_pts == -1 ) i_pts = VLC_TS_INVALID; if( p_stream->fmt.i_cat == AUDIO_ES ) + { p_block->i_dts = p_block->i_pts = i_pts; + /* Blatant abuse of the i_length field. */ + p_block->i_length = p_stream->i_end_trim; + } else if( p_stream->fmt.i_cat == SPU_ES ) { p_block->i_dts = p_block->i_pts = i_pts; @@ -793,6 +966,7 @@ static void Ogg_DecodePacket( demux_t *p_demux, if( p_stream->fmt.i_codec != VLC_CODEC_VORBIS && p_stream->fmt.i_codec != VLC_CODEC_SPEEX && + p_stream->fmt.i_codec != VLC_CODEC_OPUS && p_stream->fmt.i_codec != VLC_CODEC_FLAC && p_stream->fmt.i_codec != VLC_CODEC_TARKIN && p_stream->fmt.i_codec != VLC_CODEC_THEORA && @@ -800,6 +974,12 @@ static void Ogg_DecodePacket( demux_t *p_demux, p_stream->fmt.i_codec != VLC_CODEC_DIRAC && p_stream->fmt.i_codec != VLC_CODEC_KATE ) { + if( p_oggpacket->bytes <= 0 ) + { + msg_Dbg( p_demux, "discarding 0 sized packet" ); + block_Release( p_block ); + return; + } /* We remove the header from the packet */ i_header_len = (*p_oggpacket->packet & PACKET_LEN_BITS01) >> 6; i_header_len |= (*p_oggpacket->packet & PACKET_LEN_BITS2) << 1; @@ -848,6 +1028,47 @@ static void Ogg_DecodePacket( demux_t *p_demux, es_out_Send( p_demux->out, p_stream->p_es, p_block ); } +/* Re-implemented to avoid linking against libopus from the demuxer. */ +static int Ogg_OpusPacketDuration( logical_stream_t *p_stream, + ogg_packet *p_oggpacket ) +{ + static const int silk_fs_div[4] = { 6000, 3000, 1500, 1000 }; + int toc; + int nframes; + int frame_size; + int nsamples; + int i_rate; + if( p_oggpacket->bytes < 1 ) + return VLC_EGENERIC; + toc = p_oggpacket->packet[0]; + switch( toc&3 ) + { + case 0: + nframes = 1; + break; + case 1: + case 2: + nframes = 2; + break; + default: + if( p_oggpacket->bytes < 2 ) + return VLC_EGENERIC; + nframes = p_oggpacket->packet[1]&0x3F; + break; + } + i_rate = (int)p_stream->fmt.audio.i_rate; + if( toc&0x80 ) + frame_size = (i_rate << (toc >> 3 & 3)) / 400; + else if( ( toc&0x60 ) == 0x60 ) + frame_size = i_rate/(100 >> (toc >> 3 & 1)); + else + frame_size = i_rate*60 / silk_fs_div[toc >> 3 & 3]; + nsamples = nframes*frame_size; + if( nsamples*25 > i_rate*3 ) + return VLC_EGENERIC; + return nsamples; +} + /**************************************************************************** * Ogg_FindLogicalStreams: Find the logical streams embedded in the physical * stream and fill p_ogg. @@ -881,7 +1102,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) logical_stream_t *p_stream; p_stream = malloc( sizeof(logical_stream_t) ); - if( !p_stream ) + if( unlikely( !p_stream ) ) return VLC_ENOMEM; TAB_APPEND( p_ogg->i_streams, p_ogg->pp_stream, p_stream ); @@ -919,7 +1140,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) if( oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "\x01vorbis", 7 ) ) { - Ogg_ReadVorbisHeader( p_stream, &oggpacket ); + Ogg_ReadVorbisHeader( p_demux, p_stream, &oggpacket ); msg_Dbg( p_demux, "found vorbis header" ); } /* Check for Speex header */ @@ -932,6 +1153,17 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) p_stream->fmt.audio.i_channels, (int)p_stream->f_rate, p_stream->fmt.i_bitrate ); } + /* Check for Opus header */ + else if( oggpacket.bytes >= 8 && + ! memcmp( oggpacket.packet, "OpusHead", 8 ) ) + { + Ogg_ReadOpusHeader( p_demux, p_stream, &oggpacket ); + msg_Dbg( p_demux, "found opus header, channels: %i, " + "pre-skip: %i", + p_stream->fmt.audio.i_channels, + (int)p_stream->i_pre_skip); + p_stream->i_skip_frames = p_stream->i_pre_skip; + } /* Check for Flac header (< version 1.1.1) */ else if( oggpacket.bytes >= 4 && ! memcmp( oggpacket.packet, "fLaC", 4 ) ) @@ -941,7 +1173,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) /* Grrrr!!!! Did they really have to put all the * important info in the second header packet!!! * (STREAMINFO metadata is in the following packet) */ - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; p_stream->fmt.i_cat = AUDIO_ES; p_stream->fmt.i_codec = VLC_CODEC_FLAC; @@ -958,7 +1190,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) oggpacket.packet[5], oggpacket.packet[6], i_packets ); - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; p_stream->fmt.i_cat = AUDIO_ES; p_stream->fmt.i_codec = VLC_CODEC_FLAC; @@ -969,7 +1201,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) else if( oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "\x80theora", 7 ) ) { - Ogg_ReadTheoraHeader( p_stream, &oggpacket ); + Ogg_ReadTheoraHeader( p_demux, p_stream, &oggpacket ); msg_Dbg( p_demux, "found theora header, bitrate: %i, rate: %f", @@ -1014,8 +1246,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) else if( oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "Annodex", 7 ) ) { - Ogg_ReadAnnodexHeader( VLC_OBJECT(p_demux), p_stream, - &oggpacket ); + Ogg_ReadAnnodexHeader( p_demux, p_stream, &oggpacket ); /* kill annodex track */ free( p_stream ); p_ogg->i_streams--; @@ -1024,8 +1255,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) else if( oggpacket.bytes >= 7 && ! memcmp( oggpacket.packet, "AnxData", 7 ) ) { - Ogg_ReadAnnodexHeader( VLC_OBJECT(p_demux), p_stream, - &oggpacket ); + Ogg_ReadAnnodexHeader( p_demux, p_stream, &oggpacket ); } /* Check for Kate header */ else if( oggpacket.bytes >= 8 && @@ -1138,8 +1368,8 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) p_ogg->i_streams--; } } - else if( (*oggpacket.packet & PACKET_TYPE_BITS ) == PACKET_TYPE_HEADER && - oggpacket.bytes >= 56+1 ) + else if( oggpacket.bytes >= 44+1 && + (*oggpacket.packet & PACKET_TYPE_BITS ) == PACKET_TYPE_HEADER ) { stream_header_t tmp; stream_header_t *st = &tmp; @@ -1154,7 +1384,8 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) st->bits_per_sample = GetWLE( &oggpacket.packet[1+40] ); // (padding 2) /* Check for video header (new format) */ - if( !strncmp( st->streamtype, "video", 5 ) ) + if( !strncmp( st->streamtype, "video", 5 ) && + oggpacket.bytes >= 52+1 ) { st->sh.video.width = GetDWLE( &oggpacket.packet[1+44] ); st->sh.video.height = GetDWLE( &oggpacket.packet[1+48] ); @@ -1187,7 +1418,8 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) p_stream->fmt.video.i_bits_per_pixel ); } /* Check for audio header (new format) */ - else if( !strncmp( st->streamtype, "audio", 5 ) ) + else if( !strncmp( st->streamtype, "audio", 5 ) && + oggpacket.bytes >= 56+1 ) { char p_buffer[5]; int i_extra_size; @@ -1254,7 +1486,7 @@ static int Ogg_FindLogicalStreams( demux_t *p_demux ) /* We need to get rid of the header packet */ ogg_stream_packetout( &p_stream->os, &oggpacket ); - msg_Dbg( p_demux, "found text subtitles header" ); + msg_Dbg( p_demux, "found text subtitle header" ); p_stream->fmt.i_cat = SPU_ES; p_stream->fmt.i_codec = VLC_CODEC_SUBT; p_stream->f_rate = 1000; /* granulepos is in millisec */ @@ -1479,15 +1711,102 @@ static bool Ogg_IsVorbisFormatCompatible( const es_format_t *p_new, const es_for free( pp_old_data[i] ); return b_match; } + +static bool Ogg_IsOpusFormatCompatible( const es_format_t *p_new, + const es_format_t *p_old ) +{ + unsigned pi_new_size[XIPH_MAX_HEADER_COUNT]; + void *pp_new_data[XIPH_MAX_HEADER_COUNT]; + unsigned i_new_count; + if( xiph_SplitHeaders(pi_new_size, pp_new_data, &i_new_count, p_new->i_extra, p_new->p_extra ) ) + i_new_count = 0; + unsigned pi_old_size[XIPH_MAX_HEADER_COUNT]; + void *pp_old_data[XIPH_MAX_HEADER_COUNT]; + unsigned i_old_count; + if( xiph_SplitHeaders(pi_old_size, pp_old_data, &i_old_count, p_old->i_extra, p_old->p_extra ) ) + i_old_count = 0; + bool b_match = false; + if( i_new_count == i_old_count && i_new_count > 0 ) + { + static const unsigned char default_map[2] = { 0, 1 }; + unsigned char *p_old_head; + unsigned char *p_new_head; + const unsigned char *p_old_map; + const unsigned char *p_new_map; + int i_old_channel_count; + int i_new_channel_count; + int i_old_stream_count; + int i_new_stream_count; + int i_old_coupled_count; + int i_new_coupled_count; + p_old_head = (unsigned char *)pp_old_data[0]; + i_old_channel_count = i_old_stream_count = i_old_coupled_count = 0; + p_old_map = default_map; + if( pi_old_size[0] >= 19 && p_old_head[8] <= 15 ) + { + i_old_channel_count = p_old_head[9]; + switch( p_old_head[18] ) + { + case 0: + i_old_stream_count = 1; + i_old_coupled_count = i_old_channel_count - 1; + break; + case 1: + if( pi_old_size[0] >= 21U + i_old_channel_count ) + { + i_old_stream_count = p_old_head[19]; + i_old_coupled_count = p_old_head[20]; + p_old_map = p_old_head + 21; + } + break; + } + } + p_new_head = (unsigned char *)pp_new_data[0]; + i_new_channel_count = i_new_stream_count = i_new_coupled_count = 0; + p_new_map = default_map; + if( pi_new_size[0] >= 19 && p_new_head[8] <= 15 ) + { + i_new_channel_count = p_new_head[9]; + switch( p_new_head[18] ) + { + case 0: + i_new_stream_count = 1; + i_new_coupled_count = i_new_channel_count - 1; + break; + case 1: + if( pi_new_size[0] >= 21U + i_new_channel_count ) + { + i_new_stream_count = p_new_head[19]; + i_new_coupled_count = p_new_head[20]; + p_new_map = p_new_head+21; + } + break; + } + } + b_match = i_old_channel_count == i_new_channel_count && + i_old_stream_count == i_new_stream_count && + i_old_coupled_count == i_new_coupled_count && + memcmp(p_old_map, p_new_map, + i_new_channel_count*sizeof(*p_new_map)) == 0; + } + for( unsigned i = 0; i < i_new_count; i++ ) + free( pp_new_data[i] ); + for( unsigned i = 0; i < i_old_count; i++ ) + free( pp_old_data[i] ); + return b_match; +} + static bool Ogg_LogicalStreamResetEsFormat( demux_t *p_demux, logical_stream_t *p_stream ) { bool b_compatible = false; if( !p_stream->fmt_old.i_cat || !p_stream->fmt_old.i_codec ) return true; - /* Only vorbis is supported */ + /* Only Vorbis and Opus are supported. */ if( p_stream->fmt.i_codec == VLC_CODEC_VORBIS ) b_compatible = Ogg_IsVorbisFormatCompatible( &p_stream->fmt, &p_stream->fmt_old ); + else if( p_stream->fmt.i_codec == VLC_CODEC_OPUS ) + b_compatible = Ogg_IsOpusFormatCompatible( &p_stream->fmt, &p_stream->fmt_old ); if( !b_compatible ) msg_Warn( p_demux, "cannot reuse old stream, resetting the decoder" ); @@ -1506,7 +1825,26 @@ static void Ogg_ExtractXiphMeta( demux_t *p_demux, const void *p_headers, unsign /* TODO how to handle multiple comments properly ? */ if( i_count >= 2 && pi_size[1] > i_skip ) - vorbis_ParseComment( &p_ogg->p_meta, (uint8_t*)pp_data[1] + i_skip, pi_size[1] - i_skip ); + { + int i_cover_score = 0; + int i_cover_idx = 0; + vorbis_ParseComment( &p_ogg->p_meta, (uint8_t*)pp_data[1] + i_skip, pi_size[1] - i_skip, + &p_ogg->i_attachments, &p_ogg->attachments, + &i_cover_score, &i_cover_idx, + &p_ogg->i_seekpoints, &p_ogg->pp_seekpoints ); + if( p_ogg->p_meta != NULL && i_cover_idx < p_ogg->i_attachments ) + { + char psz_url[128]; + snprintf( psz_url, sizeof(psz_url), "attachment://%s", + p_ogg->attachments[i_cover_idx]->psz_name ); + vlc_meta_Set( p_ogg->p_meta, vlc_meta_ArtworkURL, psz_url ); + } + } + + if( p_ogg->i_seekpoints > 1 ) + { + p_demux->info.i_update |= INPUT_UPDATE_TITLE_LIST; + } for( unsigned i = 0; i < i_count; i++ ) free( pp_data[i] ); @@ -1519,11 +1857,12 @@ static void Ogg_ExtractMeta( demux_t *p_demux, vlc_fourcc_t i_codec, const uint8 { /* 3 headers with the 2° one being the comments */ case VLC_CODEC_VORBIS: - Ogg_ExtractXiphMeta( p_demux, p_headers, i_headers, 1+6 ); - break; case VLC_CODEC_THEORA: Ogg_ExtractXiphMeta( p_demux, p_headers, i_headers, 1+6 ); break; + case VLC_CODEC_OPUS: + Ogg_ExtractXiphMeta( p_demux, p_headers, i_headers, 8 ); + break; case VLC_CODEC_SPEEX: Ogg_ExtractXiphMeta( p_demux, p_headers, i_headers, 0 ); break; @@ -1549,7 +1888,14 @@ static void Ogg_ExtractMeta( demux_t *p_demux, vlc_fourcc_t i_codec, const uint8 p_demux->info.i_update |= INPUT_UPDATE_META; } -static void Ogg_ReadTheoraHeader( logical_stream_t *p_stream, +static int64_t Ogg_GetLastPacket( demux_t *p_demux, logical_stream_t *p_stream, + double f_rate ) +{ + int64_t last_packet = oggseek_get_last_frame( p_demux, p_stream ); + return ( last_packet >= 0 ) ? last_packet / f_rate : -1; +} + +static void Ogg_ReadTheoraHeader( demux_t *p_demux, logical_stream_t *p_stream, ogg_packet *p_oggpacket ) { bs_t bitstream; @@ -1567,7 +1913,7 @@ static void Ogg_ReadTheoraHeader( logical_stream_t *p_stream, /* Signal that we want to keep a backup of the theora * stream headers. They will be used when switching between * audio streams. */ - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; /* Cheat and get additionnal info ;) */ bs_init( &bitstream, p_oggpacket->packet, p_oggpacket->bytes ); @@ -1609,16 +1955,22 @@ static void Ogg_ReadTheoraHeader( logical_stream_t *p_stream, i_version = i_major * 1000000 + i_minor * 1000 + i_subminor; p_stream->i_keyframe_offset = 0; + p_stream->f_rate = ((float)i_fps_numerator) / i_fps_denominator; if ( i_version >= 3002001 ) { p_stream->i_keyframe_offset = 1; } + if ( p_demux->p_sys->i_length < 0 ) + { + int64_t last_packet = Ogg_GetLastPacket( p_demux, p_stream, p_stream->f_rate ); + if ( last_packet >= 0 ) + p_demux->p_sys->i_length = last_packet; + } - p_stream->f_rate = ((float)i_fps_numerator) / i_fps_denominator; } -static void Ogg_ReadVorbisHeader( logical_stream_t *p_stream, +static void Ogg_ReadVorbisHeader( demux_t *p_demux, logical_stream_t *p_stream, ogg_packet *p_oggpacket ) { oggpack_buffer opb; @@ -1629,7 +1981,7 @@ static void Ogg_ReadVorbisHeader( logical_stream_t *p_stream, /* Signal that we want to keep a backup of the vorbis * stream headers. They will be used when switching between * audio streams. */ - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; /* Cheat and get additionnal info ;) */ oggpack_readinit( &opb, p_oggpacket->packet, p_oggpacket->bytes); @@ -1639,6 +1991,13 @@ static void Ogg_ReadVorbisHeader( logical_stream_t *p_stream, oggpack_read( &opb, 32 ); oggpack_adv( &opb, 32 ); p_stream->fmt.i_bitrate = oggpack_read( &opb, 32 ); + + if ( p_demux->p_sys->i_length < 0 ) + { + int64_t last_packet = Ogg_GetLastPacket( p_demux, p_stream, p_stream->f_rate ); + if ( last_packet >= 0 ) + p_demux->p_sys->i_length = last_packet; + } } static void Ogg_ReadSpeexHeader( logical_stream_t *p_stream, @@ -1652,7 +2011,7 @@ static void Ogg_ReadSpeexHeader( logical_stream_t *p_stream, /* Signal that we want to keep a backup of the speex * stream headers. They will be used when switching between * audio streams. */ - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; /* Cheat and get additionnal info ;) */ oggpack_readinit( &opb, p_oggpacket->packet, p_oggpacket->bytes); @@ -1666,6 +2025,40 @@ static void Ogg_ReadSpeexHeader( logical_stream_t *p_stream, p_stream->fmt.i_bitrate = oggpack_read( &opb, 32 ); } +static void Ogg_ReadOpusHeader( demux_t *p_demux, + logical_stream_t *p_stream, + ogg_packet *p_oggpacket ) +{ + oggpack_buffer opb; + + p_stream->fmt.i_cat = AUDIO_ES; + p_stream->fmt.i_codec = VLC_CODEC_OPUS; + + /* Signal that we want to keep a backup of the opus + * stream headers. They will be used when switching between + * audio streams. */ + p_stream->b_force_backup = true; + + /* All OggOpus streams are timestamped at 48kHz and + * can be played at 48kHz. */ + p_stream->f_rate = p_stream->fmt.audio.i_rate = 48000; + p_stream->fmt.i_bitrate = 0; + + /* Cheat and get additional info ;) */ + oggpack_readinit( &opb, p_oggpacket->packet, p_oggpacket->bytes); + oggpack_adv( &opb, 64 ); + oggpack_adv( &opb, 8 ); /* version_id */ + p_stream->fmt.audio.i_channels = oggpack_read( &opb, 8 ); + p_stream->i_pre_skip = oggpack_read( &opb, 16 ); + + if ( p_demux->p_sys->i_length < 0 ) + { + int64_t last_packet = Ogg_GetLastPacket( p_demux, p_stream, p_stream->f_rate ); + if ( last_packet >= 0 ) + p_demux->p_sys->i_length = last_packet; + } +} + static void Ogg_ReadFlacHeader( demux_t *p_demux, logical_stream_t *p_stream, ogg_packet *p_oggpacket ) { @@ -1675,7 +2068,7 @@ static void Ogg_ReadFlacHeader( demux_t *p_demux, logical_stream_t *p_stream, bs_init( &s, p_oggpacket->packet, p_oggpacket->bytes ); bs_read( &s, 1 ); - if( bs_read( &s, 7 ) == 0 ) + if( p_oggpacket->bytes > 0 && bs_read( &s, 7 ) == 0 ) { if( bs_read( &s, 24 ) >= 34 /*size STREAMINFO*/ ) { @@ -1716,7 +2109,7 @@ static void Ogg_ReadKateHeader( logical_stream_t *p_stream, /* Signal that we want to keep a backup of the kate * stream headers. They will be used when switching between * kate streams. */ - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; /* Cheat and get additionnal info ;) */ oggpack_readinit( &opb, p_oggpacket->packet, p_oggpacket->bytes); @@ -1763,7 +2156,7 @@ static void Ogg_ReadKateHeader( logical_stream_t *p_stream, } } -static void Ogg_ReadAnnodexHeader( vlc_object_t *p_this, +static void Ogg_ReadAnnodexHeader( demux_t *p_demux, logical_stream_t *p_stream, ogg_packet *p_oggpacket ) { @@ -1777,7 +2170,7 @@ static void Ogg_ReadAnnodexHeader( vlc_object_t *p_this, uint64_t timebase_numerator; uint64_t timebase_denominator; - Ogg_ReadTheoraHeader( p_stream, p_oggpacket ); + Ogg_ReadTheoraHeader( p_demux, p_stream, p_oggpacket ); oggpack_readinit( &opb, p_oggpacket->packet, p_oggpacket->bytes); oggpack_adv( &opb, 8*8 ); /* "Annodex\0" header */ @@ -1785,6 +2178,11 @@ static void Ogg_ReadAnnodexHeader( vlc_object_t *p_this, minor_version = oggpack_read( &opb, 2*8 ); /* minor version */ timebase_numerator = GetQWLE( &p_oggpacket->packet[16] ); timebase_denominator = GetQWLE( &p_oggpacket->packet[24] ); + + msg_Dbg( p_demux, "Annodex info: version %"PRIu16".%"PRIu16" " + "Timebase %"PRId64" / %"PRId64, + major_version, minor_version, + timebase_numerator, timebase_denominator ); } else if( p_oggpacket->bytes >= 42 && !memcmp( p_oggpacket->packet, "AnxData", 7 ) ) @@ -1812,7 +2210,7 @@ static void Ogg_ReadAnnodexHeader( vlc_object_t *p_this, content_type_string ); } - msg_Dbg( p_this, "AnxData packet info: %"PRId64" / %"PRId64", %d, ``%s''", + msg_Dbg( p_demux, "AnxData packet info: %"PRId64" / %"PRId64", %d, ``%s''", granule_rate_numerator, granule_rate_denominator, p_stream->i_secondary_header_packets, content_type_string ); @@ -1832,28 +2230,28 @@ static void Ogg_ReadAnnodexHeader( vlc_object_t *p_this, p_stream->fmt.i_cat = AUDIO_ES; p_stream->fmt.i_codec = VLC_CODEC_VORBIS; - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; } else if( !strncmp(content_type_string, "audio/x-speex", 13) ) { p_stream->fmt.i_cat = AUDIO_ES; p_stream->fmt.i_codec = VLC_CODEC_SPEEX; - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; } else if( !strncmp(content_type_string, "video/x-theora", 14) ) { p_stream->fmt.i_cat = VIDEO_ES; p_stream->fmt.i_codec = VLC_CODEC_THEORA; - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; } else if( !strncmp(content_type_string, "video/x-xvid", 12) ) { p_stream->fmt.i_cat = VIDEO_ES; p_stream->fmt.i_codec = VLC_FOURCC( 'x','v','i','d' ); - p_stream->b_force_backup = 1; + p_stream->b_force_backup = true; } else if( !strncmp(content_type_string, "video/mpeg", 10) ) { @@ -1912,7 +2310,7 @@ static bool Ogg_ReadDiracHeader( logical_stream_t *p_stream, /* Backing up stream headers is not required -- seqhdrs are repeated * thoughout the stream at suitable decoding start points */ - p_stream->b_force_backup = 0; + p_stream->b_force_backup = false; /* read in useful bits from sequence header */ bs_init( &bs, p_oggpacket->packet, p_oggpacket->bytes );