X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fgui%2Ffbosd.c;h=2ac42b6d2607acfa4390182c1310e51029b0ae36;hb=d228fdd28ef03b992c97af16cb842acd7c879831;hp=933b5231c2d2e8ca089e880ffa663d9814a55510;hpb=09b646affc8be98f194ce09d59484423423b696c;p=vlc diff --git a/modules/gui/fbosd.c b/modules/gui/fbosd.c index 933b5231c2..2ac42b6d26 100644 --- a/modules/gui/fbosd.c +++ b/modules/gui/fbosd.c @@ -29,7 +29,8 @@ # include "config.h" #endif -#include +#include +#include #include #include /* free() */ @@ -50,7 +51,8 @@ #include #include -// #define FBOSD_BLENDING +#undef FBOSD_BLENDING +#undef FBOSD_DEBUG /***************************************************************************** * Local prototypes @@ -73,19 +75,12 @@ static void CloseBlending ( intf_thread_t * ); static int OpenTextRenderer ( intf_thread_t * ); static void CloseTextRenderer( intf_thread_t * ); -#if 0 -static int OpenScaling ( intf_thread_t * ); -static int CloseScaling ( intf_thread_t * ); -#endif - /* Manipulate the overlay buffer */ static int OverlayCallback( vlc_object_t *, char const *, vlc_value_t, vlc_value_t, void * ); -static picture_t *AllocatePicture( vlc_object_t *, - video_format_t * ); -static void DeAllocatePicture( vlc_object_t *, picture_t *, - video_format_t * ); +static picture_t *AllocatePicture( video_format_t * ); +static void DeAllocatePicture( picture_t *, video_format_t * ); static void SetOverlayTransparency( intf_thread_t *, bool ); static picture_t *LoadImage( intf_thread_t *, video_format_t *, @@ -162,16 +157,18 @@ static picture_t *RenderText( intf_thread_t *, const char *, #define DISPLAY_LONGTEXT N_( "All rendered images and text will be " \ "displayed on the overlay framebuffer." ) -static int pi_pos_values[] = { 0, 1, 2, 4, 8, 5, 6, 9, 10 }; -static const char *ppsz_pos_descriptions[] = +static const int pi_pos_values[] = { 0, 1, 2, 4, 8, 5, 6, 9, 10 }; +static const char *const ppsz_pos_descriptions[] = { N_("Center"), N_("Left"), N_("Right"), N_("Top"), N_("Bottom"), N_("Top-Left"), N_("Top-Right"), N_("Bottom-Left"), N_("Bottom-Right") }; -static int pi_color_values[] = { 0xf0000000, 0x00000000, 0x00808080, 0x00C0C0C0, +static const int pi_color_values[] = { + 0xf0000000, 0x00000000, 0x00808080, 0x00C0C0C0, 0x00FFFFFF, 0x00800000, 0x00FF0000, 0x00FF00FF, 0x00FFFF00, 0x00808000, 0x00008000, 0x00008080, 0x0000FF00, 0x00800080, 0x00000080, 0x000000FF, 0x0000FFFF}; -static const char *ppsz_color_descriptions[] = { N_("Default"), N_("Black"), +static const char *const ppsz_color_descriptions[] = { + N_("Default"), N_("Black"), N_("Gray"), N_("Silver"), N_("White"), N_("Maroon"), N_("Red"), N_("Fuchsia"), N_("Yellow"), N_("Olive"), N_("Green"), N_("Teal"), N_("Lime"), N_("Purple"), N_("Navy"), N_("Blue"), @@ -192,26 +189,23 @@ vlc_module_begin(); add_string( "fbosd-text", NULL, NULL, FBOSD_TEXT, FBOSD_LONGTEXT, true ); -#if defined(FBOSD_BLENDING) add_integer_with_range( "fbosd-alpha", 255, 0, 255, NULL, ALPHA_TEXT, ALPHA_LONGTEXT, true ); -#endif - set_section( N_("Position"), NULL ); add_integer( "fbosd-x", 0, NULL, POSX_TEXT, POSX_LONGTEXT, false ); add_integer( "fbosd-y", 0, NULL, POSY_TEXT, POSY_LONGTEXT, false ); add_integer( "fbosd-position", 8, NULL, POS_TEXT, POS_LONGTEXT, true ); - change_integer_list( pi_pos_values, ppsz_pos_descriptions, 0 ); + change_integer_list( pi_pos_values, ppsz_pos_descriptions, NULL ); set_section( N_("Font"), NULL ); add_integer_with_range( "fbosd-font-opacity", 255, 0, 255, NULL, OPACITY_TEXT, OPACITY_LONGTEXT, false ); add_integer( "fbosd-font-color", 0x00FFFFFF, NULL, COLOR_TEXT, COLOR_LONGTEXT, false ); - change_integer_list( pi_color_values, ppsz_color_descriptions, 0 ); + change_integer_list( pi_color_values, ppsz_color_descriptions, NULL ); add_integer( "fbosd-font-size", -1, NULL, SIZE_TEXT, SIZE_LONGTEXT, false ); @@ -220,7 +214,7 @@ vlc_module_begin(); add_bool( "fbosd-render", false, NULL, RENDER_TEXT, RENDER_LONGTEXT, true ); add_bool( "fbosd-display", false, NULL, DISPLAY_TEXT, DISPLAY_LONGTEXT, true ); - set_description( _("GNU/Linux osd/overlay framebuffer interface") ); + set_description( N_("GNU/Linux osd/overlay framebuffer interface") ); set_capability( "interface", 10 ); set_callbacks( Create, Destroy ); vlc_module_end(); @@ -244,7 +238,7 @@ struct fbosd_render_t char *psz_string; /* Position */ - bool b_absolute; + bool b_absolute; int i_x; int i_y; int i_pos; @@ -279,9 +273,6 @@ struct intf_sys_t filter_t *p_blend; /* alpha blending module */ #endif filter_t *p_text; /* text renderer module */ -#if 0 - filter_t *p_scale; /* scaling module */ -#endif /* Render */ struct fbosd_render_t render[FBOSD_RENDER_MAX]; @@ -291,11 +282,11 @@ struct intf_sys_t /* Position */ bool b_absolute; - int i_x; - int i_y; - int i_pos; + int i_x; + int i_y; + int i_pos; - int i_alpha; /* transparency for images */ + int i_alpha; /* transparency for images */ /* commands control */ bool b_need_update; /* update display with \overlay buffer */ @@ -314,21 +305,16 @@ static int Create( vlc_object_t *p_this ) char *psz_tmp; int i; - /* Allocate instance and initialize some members */ p_intf->p_sys = p_sys = malloc( sizeof( intf_sys_t ) ); if( !p_intf->p_sys ) - { - msg_Err( p_intf, "out of memory" ); return VLC_ENOMEM; - }; memset( p_sys, 0, sizeof(intf_sys_t) ); p_sys->p_style = malloc( sizeof( text_style_t ) ); if( !p_sys->p_style ) { free( p_intf->p_sys ); - msg_Err( p_intf, "out of memory" ); return VLC_ENOMEM; } vlc_memcpy( p_sys->p_style, &default_text_style, sizeof( text_style_t ) ); @@ -340,16 +326,12 @@ static int Create( vlc_object_t *p_this ) { free( p_intf->p_sys->p_style ); free( p_intf->p_sys ); - msg_Err( p_intf, "out of memory" ); return VLC_ENOMEM; } -#if defined(FBOSD_BLENDING) p_sys->i_alpha = var_CreateGetIntegerCommand( p_intf, "fbosd-alpha" ); var_AddCallback( p_intf, "fbosd-alpha", OverlayCallback, NULL ); -#else - p_sys->i_alpha = 255; -#endif + p_sys->i_aspect = -1; psz_aspect = var_CreateGetNonEmptyString( p_intf, "fbosd-aspect-ratio" ); @@ -470,15 +452,7 @@ static int Create( vlc_object_t *p_this ) Destroy( VLC_OBJECT(p_intf) ); return VLC_EGENERIC; } -#if 0 - /* Load scaling module */ - if( OpenScaling( p_intf ) ) - { - msg_Err( p_intf, "Unable to load image scaling module" ); - Destroy( VLC_OBJECT(p_intf) ); - return VLC_EGENERIC; - } -#endif + p_sys->b_render = true; p_sys->b_need_update = true; @@ -500,10 +474,8 @@ static void Destroy( vlc_object_t *p_this ) p_sys->b_render = false; p_sys->b_clear = false; -#if defined(FBOSD_BLENDING) var_DelCallback( p_intf, "fbosd-alpha", OverlayCallback, NULL ); var_Destroy( p_intf, "fbosd-alpha" ); -#endif var_DelCallback( p_intf, "fbosd-x", OverlayCallback, NULL ); var_DelCallback( p_intf, "fbosd-y", OverlayCallback, NULL ); @@ -543,13 +515,11 @@ static void Destroy( vlc_object_t *p_this ) if( p_sys->p_blend ) CloseBlending( p_intf ); #endif if( p_sys->p_text ) CloseTextRenderer( p_intf ); -#if 0 - if( p_sys->p_scale ) CloseScaling( p_intf ); -#endif + if( p_sys->p_image ) image_HandlerDelete( p_sys->p_image ); if( p_sys->p_overlay ) - p_sys->p_overlay->pf_release( p_sys->p_overlay ); + picture_Release( p_sys->p_overlay ); free( p_sys->p_style ); free( p_sys ); @@ -561,7 +531,7 @@ static int OpenBlending( intf_thread_t *p_intf ) if( p_intf->p_sys->p_blend ) return VLC_EGENERIC; p_intf->p_sys->p_blend = - vlc_object_create( p_intf, VLC_OBJECT_FILTER ); + vlc_object_create( p_intf, sizeof(filter_t) ); vlc_object_attach( p_intf->p_sys->p_blend, p_intf ); p_intf->p_sys->p_blend->fmt_out.video.i_x_offset = p_intf->p_sys->p_blend->fmt_out.video.i_y_offset = 0; @@ -577,7 +547,7 @@ static int OpenBlending( intf_thread_t *p_intf ) VLC_FOURCC('Y','U','V','A'); p_intf->p_sys->p_blend->p_module = - module_Need( p_intf->p_sys->p_blend, "video blending", 0, 0 ); + module_need( p_intf->p_sys->p_blend, "video blending", 0, 0 ); if( !p_intf->p_sys->p_blend->p_module ) return VLC_EGENERIC; @@ -590,7 +560,7 @@ static void CloseBlending( intf_thread_t *p_intf ) if( p_intf->p_sys->p_blend ) { if( p_intf->p_sys->p_blend->p_module ) - module_Unneed( p_intf->p_sys->p_blend, + module_unneed( p_intf->p_sys->p_blend, p_intf->p_sys->p_blend->p_module ); vlc_object_detach( p_intf->p_sys->p_blend ); @@ -606,7 +576,7 @@ static int OpenTextRenderer( intf_thread_t *p_intf ) if( p_intf->p_sys->p_text ) return VLC_EGENERIC; p_intf->p_sys->p_text = - vlc_object_create( p_intf, VLC_OBJECT_FILTER ); + vlc_object_create( p_intf, sizeof(filter_t) ); vlc_object_attach( p_intf->p_sys->p_text, p_intf ); p_intf->p_sys->p_text->fmt_out.video.i_width = @@ -620,13 +590,13 @@ static int OpenTextRenderer( intf_thread_t *p_intf ) if( psz_modulename && *psz_modulename ) { p_intf->p_sys->p_text->p_module = - module_Need( p_intf->p_sys->p_text, "text renderer", + module_need( p_intf->p_sys->p_text, "text renderer", psz_modulename, true ); } if( !p_intf->p_sys->p_text->p_module ) { p_intf->p_sys->p_text->p_module = - module_Need( p_intf->p_sys->p_text, "text renderer", 0, 0 ); + module_need( p_intf->p_sys->p_text, "text renderer", 0, 0 ); } free( psz_modulename ); @@ -641,63 +611,25 @@ static void CloseTextRenderer( intf_thread_t *p_intf ) if( p_intf->p_sys->p_text ) { if( p_intf->p_sys->p_text->p_module ) - module_Unneed( p_intf->p_sys->p_text, + module_unneed( p_intf->p_sys->p_text, p_intf->p_sys->p_text->p_module ); vlc_object_detach( p_intf->p_sys->p_text ); vlc_object_release( p_intf->p_sys->p_text ); } } -#if 0 -static int OpenScaling( intf_thread_t *p_intf ) -{ - if( p_intf->p_sys->p_scale ) return VLC_EGENERIC; - - p_intf->p_sys->p_scale = - vlc_object_create( p_intf, VLC_OBJECT_FILTER ); - vlc_object_attach( p_intf->p_sys->p_scale, p_intf ); - p_intf->p_sys->p_scale->fmt_out.video.i_chroma = - p_intf->p_sys->p_scale->fmt_in.video.i_chroma = - p_intf->p_sys->fmt_out.i_chroma; - - /* XXX: We'll also be using it for YUVA and RGBA blending ... */ - p_intf->p_sys->p_scale->fmt_in.video.i_width = - p_intf->p_sys->p_scale->fmt_in.video.i_height = 32; - p_intf->p_sys->p_scale->fmt_out.video.i_width = - p_intf->p_sys->p_scale->fmt_out.video.i_height = 16; - - p_intf->p_sys->p_scale->p_module = - module_Need( p_intf->p_sys->p_scale, "video filter2", 0, 0 ); - - if( !p_intf->p_sys->p_scale->p_module ) - return VLC_EGENERIC; - - return VLC_SUCCESS; -} - -static int CloseScaling( intf_thread_t *p_intf ) -{ - if( p_intf->p_sys->p_scale ) - { - if( p_intf->p_sys->p_scale->p_module ) - module_Unneed( p_intf->p_sys->p_scale, - p_intf->p_sys->p_scale->p_module ); - - vlc_object_detach( p_intf->p_sys->p_scale ); - vlc_object_release( p_intf->p_sys->p_scale ); - } -} -#endif /***************************************************************************** * AllocatePicture: * allocate a picture buffer for use with the overlay fb. *****************************************************************************/ -static picture_t *AllocatePicture( vlc_object_t *p_this, - video_format_t *p_fmt ) +static picture_t *AllocatePicture( video_format_t *p_fmt ) { - picture_t *p_pic = malloc( sizeof( picture_t ) ); - if( !p_pic ) return NULL; + picture_t *p_picture = picture_New( p_fmt->i_chroma, + p_fmt->i_width, p_fmt->i_height, + p_fmt->i_aspect ); + if( !p_picture ) + return NULL; if( !p_fmt->p_palette && ( p_fmt->i_chroma == VLC_FOURCC('Y','U','V','P') ) ) @@ -705,45 +637,32 @@ static picture_t *AllocatePicture( vlc_object_t *p_this, p_fmt->p_palette = malloc( sizeof(video_palette_t) ); if( !p_fmt->p_palette ) { - free( p_pic ); + picture_Release( p_picture ); return NULL; } } - else p_fmt->p_palette = NULL; - - p_pic->p_data_orig = NULL; - - vout_AllocatePicture( p_this, p_pic, p_fmt->i_chroma, - p_fmt->i_width, p_fmt->i_height, p_fmt->i_aspect ); - - if( !p_pic->i_planes ) + else { - free( p_pic ); - free( p_fmt->p_palette ); - return NULL; + p_fmt->p_palette = NULL; } - return p_pic; + + return p_picture; } /***************************************************************************** * DeAllocatePicture: * Deallocate a picture buffer and free all associated memory. *****************************************************************************/ -static void DeAllocatePicture( vlc_object_t *p_this, picture_t *p_pic, - video_format_t *p_fmt ) +static void DeAllocatePicture( picture_t *p_pic, video_format_t *p_fmt ) { - VLC_UNUSED(p_this); - if( p_pic ) - { - free( p_pic->p_data_orig ); - if( p_pic->pf_release ) p_pic->pf_release( p_pic ); - } if( p_fmt ) { free( p_fmt->p_palette ); p_fmt->p_palette = NULL; } - p_pic = NULL; + + if( p_pic ) + picture_Release( p_pic ); } /***************************************************************************** @@ -764,9 +683,10 @@ static void SetOverlayTransparency( intf_thread_t *p_intf, { msg_Dbg( p_intf, "Make overlay %s", b_transparent ? "transparent" : "opaque" ); - memset( p_sys->p_overlay->p[0].p_pixels, 0x00, i_page_size ); if( b_transparent ) memset( p_sys->p_overlay->p[0].p_pixels, 0xFF, i_page_size ); + else + memset( p_sys->p_overlay->p[0].p_pixels, 0x00, i_page_size ); } } @@ -785,22 +705,7 @@ static int BlendPicture( intf_thread_t *p_intf, video_format_t *p_fmt_src, int i_y_offset = p_sys->i_y; memcpy( &p_sys->p_blend->fmt_in.video, p_fmt_src, sizeof( video_format_t ) ); -#if 0 - msg_Dbg( p_intf, "Blending pictures %p %4.4s (%dx%d) %d bits %d planes: 0=%p 1=%p 2=%p 3=%p", - p_pic_src, (char*)&p_fmt_src->i_chroma, - p_sys->p_blend->fmt_in.video.i_width, p_sys->p_blend->fmt_in.video.i_height, - p_fmt_src->i_bits_per_pixel, - p_pic_src->i_planes, - p_pic_src->p[0].p_pixels, p_pic_src->p[1].p_pixels, - p_pic_src->p[2].p_pixels, p_pic_src->p[3].p_pixels ); - msg_Dbg( p_intf, "Blending pictures %p %4.4s (%dx%d) %d bits %d planes: 0=%p 1=%p 2=%p 3=%p", - p_pic_dst, (char*)&p_fmt_dst->i_chroma, - p_fmt_dst->i_width, p_fmt_dst->i_height, - p_fmt_dst->i_bits_per_pixel, - p_pic_dst->i_planes, - p_pic_dst->p[0].p_pixels, p_pic_dst->p[1].p_pixels, - p_pic_dst->p[2].p_pixels, p_pic_dst->p[3].p_pixels ); -#endif + /* Update the output picture size */ p_sys->p_blend->fmt_out.video.i_width = p_sys->p_blend->fmt_out.video.i_visible_width = @@ -820,7 +725,6 @@ static int BlendPicture( intf_thread_t *p_intf, video_format_t *p_fmt_src, } return VLC_EGENERIC; } -#endif static int InvertAlpha( intf_thread_t *p_intf, picture_t **p_pic, video_format_t fmt ) { @@ -857,15 +761,16 @@ static int InvertAlpha( intf_thread_t *p_intf, picture_t **p_pic, video_format_t for( ; p_begin < p_end; p_begin += i_skip ) { - uint8_t i_opacity; + uint8_t i_opacity = 0; - if( i_opacity != 0xFF ) + if( *p_begin != 0xFF ) i_opacity = 255 - *p_begin; *p_begin = i_opacity; } /* end of kludge */ return VLC_SUCCESS; } +#endif /***************************************************************************** * RenderPicture: Render the picture into the p_dest buffer. @@ -876,6 +781,7 @@ static int RenderPicture( intf_thread_t *p_intf, int i_x_offset, int i_y_offset, picture_t *p_src, picture_t *p_dest ) { int i; + VLC_UNUSED( p_intf ); if( !p_dest && !p_src ) return VLC_EGENERIC; @@ -902,7 +808,7 @@ static int RenderPicture( intf_thread_t *p_intf, int i_x_offset, int i_y_offset, i_y_clip = ( i_y_offset + p_src->p[i].i_visible_lines ) - p_dest->p[i].i_visible_lines; i_y_clip = ( i_y_clip > 0 ) ? i_y_clip : 0; -#if 0 +#if defined(FBOSD_DEBUG) msg_Dbg( p_intf, "i_pitch (%d,%d), (%d,%d)/(%d,%d)", p_dest->p[i].i_visible_pitch, p_src->p[i].i_visible_pitch, i_x_offset, i_y_offset, i_x, i_x_clip ); @@ -940,22 +846,27 @@ static picture_t *RenderText( intf_thread_t *p_intf, const char *psz_string, if( p_sys->p_text && p_sys->p_text->p_module ) { - p_region = (subpicture_region_t *) malloc( sizeof(subpicture_region_t) ); + video_format_t fmt; + + memset( &fmt, 0, sizeof(fmt) ); + fmt.i_chroma = VLC_FOURCC('T','E','X','T'); + fmt.i_aspect = 0; + fmt.i_width = fmt.i_visible_width = 0; + fmt.i_height = fmt.i_visible_height = 0; + fmt.i_x_offset = 0; + fmt.i_y_offset = 0; + + p_region = subpicture_region_New( &fmt ); if( !p_region ) return p_dest; - memset( p_region, 0, sizeof(subpicture_region_t) ); - p_region->psz_text = strdup( psz_string ); + if( !p_region->psz_text ) + { + subpicture_region_Delete( p_region ); + return NULL; + } p_region->p_style = p_style; - - p_region->fmt.i_chroma = VLC_FOURCC('T','E','X','T'); - p_region->fmt.i_aspect = 0; - p_region->fmt.i_width = p_region->fmt.i_visible_width = 0; - p_region->fmt.i_height = p_region->fmt.i_visible_height = 0; - p_region->fmt.i_x_offset = 0; - p_region->fmt.i_y_offset = 0; - p_region->i_align = OSD_ALIGN_LEFT | OSD_ALIGN_TOP; if( p_sys->p_text->pf_render_text ) @@ -972,29 +883,23 @@ static picture_t *RenderText( intf_thread_t *p_intf, const char *psz_string, fmt_out.i_bits_per_pixel = 32; vlc_memcpy( p_fmt, &fmt_out, sizeof(video_format_t) ); + /* FIXME not needed to copy the picture anymore no ? */ p_dest = AllocatePicture( VLC_OBJECT(p_intf), &fmt_out ); if( !p_dest ) { - if( p_region->picture.pf_release ) - p_region->picture.pf_release( &p_region->picture ); - free( p_region->psz_text ); - free( p_region ); + subpicture_region_Delete( p_region ); return NULL; } - vout_CopyPicture( VLC_OBJECT(p_intf), p_dest, &p_region->picture ); + picture_Copy( p_dest, p_region->p_picture ); #else fmt_out.i_chroma = p_fmt->i_chroma; - p_dest = ConvertImage( p_intf, &p_region->picture, + p_dest = ConvertImage( p_intf, &p_region->p_picture, &p_region->fmt, &fmt_out ); #endif - if( p_region->picture.pf_release ) - p_region->picture.pf_release( &p_region->picture ); - free( p_region->psz_text ); - free( p_region ); + subpicture_region_Delete( p_region ); return p_dest; } - free( p_region->psz_text ); - free( p_region ); + subpicture_region_Delete( p_region ); } return p_dest; } @@ -1089,8 +994,7 @@ static int Init( intf_thread_t *p_intf ) p_sys->fmt_out.i_sar_num = p_sys->fmt_out.i_sar_den = 1; /* Allocate overlay buffer */ - p_sys->p_overlay = AllocatePicture( VLC_OBJECT(p_intf), - &p_sys->fmt_out ); + p_sys->p_overlay = AllocatePicture( &p_sys->fmt_out ); if( !p_sys->p_overlay ) return VLC_EGENERIC; SetOverlayTransparency( p_intf, true ); @@ -1132,12 +1036,13 @@ static void End( intf_thread_t *p_intf ) if( p_sys->p_overlay ) { int ret; - ret = write( p_sys->i_fd, p_sys->p_overlay->p[0].p_pixels, p_sys->i_page_size ); + ret = write( p_sys->i_fd, p_sys->p_overlay->p[0].p_pixels, + p_sys->i_page_size ); if( ret < 0 ) msg_Err( p_intf, "unable to clear overlay" ); } - DeAllocatePicture( VLC_OBJECT(p_intf), p_intf->p_sys->p_overlay, + DeAllocatePicture( p_intf->p_sys->p_overlay, &p_intf->p_sys->fmt_out ); p_intf->p_sys->p_overlay = NULL; } @@ -1201,7 +1106,6 @@ static int OpenDisplay( intf_thread_t *p_intf ) p_sys->p_palette = malloc( 8 * 256 * sizeof( uint16_t ) ); if( !p_sys->p_palette ) { - msg_Err( p_intf, "out of memory" ); close( p_sys->i_fd ); return VLC_ENOMEM; } @@ -1282,7 +1186,7 @@ static void Render( intf_thread_t *p_intf, struct fbosd_render_t *render ) { RenderPicture( p_intf, render->i_x, render->i_y, p_pic, p_sys->p_overlay ); - p_pic->pf_release( p_pic ); + picture_Release( p_pic ); } } else if( render->i_type == FBOSD_RENDER_TEXT ) @@ -1298,7 +1202,7 @@ static void Render( intf_thread_t *p_intf, struct fbosd_render_t *render ) BlendPicture( p_intf, &fmt_in, &p_sys->fmt_out, p_text, p_sys->p_overlay ); msg_Dbg( p_intf, "releasing picture" ); - DeAllocatePicture( VLC_OBJECT( p_intf ), p_text, &fmt_in ); + DeAllocatePicture( p_text, &fmt_in ); } #else p_text = RenderText( p_intf, render->psz_string, &render->text_style, @@ -1307,7 +1211,7 @@ static void Render( intf_thread_t *p_intf, struct fbosd_render_t *render ) { RenderPicture( p_intf, render->i_x, render->i_y, p_text, p_sys->p_overlay ); - p_text->pf_release( p_text ); + picture_Release( p_text ); } #endif } @@ -1345,7 +1249,7 @@ static bool isRendererReady( intf_thread_t *p_intf ) } /***************************************************************************** - * Run: rc thread + * Run: thread ***************************************************************************** * This part of the interface is in a separate thread so that we can call * exec() from within it without annoying the rest of the program. @@ -1353,8 +1257,9 @@ static bool isRendererReady( intf_thread_t *p_intf ) static void Run( intf_thread_t *p_intf ) { intf_sys_t *p_sys = (intf_sys_t*) p_intf->p_sys; + int canc = vlc_savecancel(); - while( !intf_ShouldDie( p_intf ) ) + while( vlc_object_alive( p_intf ) ) { int i; @@ -1365,8 +1270,8 @@ static void Run( intf_thread_t *p_intf ) { Render( p_intf, &p_sys->render[i] ); RenderClear( p_intf, &p_sys->render[i] ); - } - } + } + } if( p_sys->b_clear ) { @@ -1398,13 +1303,11 @@ static void Run( intf_thread_t *p_intf ) p_sys->b_need_update = false; } - if( vlc_CPU() & CPU_CAPABILITY_FPU ) - msleep( INTF_IDLE_SLEEP ); - else - msleep( 500 ); + msleep( INTF_IDLE_SLEEP ); } End( p_intf ); + vlc_restorecancel( canc ); } static int OverlayCallback( vlc_object_t *p_this, char const *psz_cmd, @@ -1507,12 +1410,10 @@ static int OverlayCallback( vlc_object_t *p_this, char const *psz_cmd, { p_sys->render[i].text_style.i_font_alpha = 255 - newval.i_int; } -#if defined(FBOSD_BLENDING) else if( !strncmp( psz_cmd, "fbosd-alpha", 11 ) ) { p_sys->render[i].i_alpha = newval.i_int; } -#endif } return VLC_SUCCESS; }