X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fgui%2Fmacosx%2Fplaylist.m;h=ba929645f33025bbca4b9edeebc42d7f899c9c2b;hb=2a2dd55119a03f4e410fca67cc07c7a4e990ed95;hp=393fabea0c161c0b44f096effa5e5937414d8132;hpb=12dd5ea5617f78ad80764d9aef2fffd870a318cb;p=vlc diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m index 393fabea0c..ba929645f3 100644 --- a/modules/gui/macosx/playlist.m +++ b/modules/gui/macosx/playlist.m @@ -1,7 +1,7 @@ /***************************************************************************** * playlist.m: MacOS X interface module ***************************************************************************** -* Copyright (C) 2002-2008 the VideoLAN team +* Copyright (C) 2002-2009 the VideoLAN team * $Id$ * * Authors: Jon Lech Johansen @@ -39,7 +39,6 @@ #include #include #include -#include #import "intf.h" #import "wizard.h" @@ -47,10 +46,14 @@ #import "playlistinfo.h" #import "playlist.h" #import "controls.h" -#import "vlc_osd.h" #import "misc.h" -#import +#import "sidebarview.h" + +#include #import +#import +#import + /***************************************************************************** * VLCPlaylistView implementation @@ -82,7 +85,7 @@ case NSEnterCharacter: case NSCarriageReturnCharacter: - [(VLCPlaylist *)[[VLCMain sharedInstance] getPlaylist] playItem:self]; + [(VLCPlaylist *)[[VLCMain sharedInstance] playlist] playItem:self]; break; default: @@ -112,14 +115,18 @@ } - (void)awakeFromNib { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); [o_outline_view setTarget: self]; [o_outline_view setDelegate: self]; [o_outline_view setDataSource: self]; [o_outline_view setAllowsEmptySelection: NO]; [o_outline_view expandItem: [o_outline_view itemAtRow:0]]; - vlc_object_release( p_playlist ); + [o_outline_view_other setTarget: self]; + [o_outline_view_other setDelegate: self]; + [o_outline_view_other setDataSource: self]; + [o_outline_view_other setAllowsEmptySelection: NO]; + [self initStrings]; } @@ -128,6 +135,29 @@ [[o_tc_name headerCell] setStringValue:_NS("Name")]; [[o_tc_author headerCell] setStringValue:_NS("Author")]; [[o_tc_duration headerCell] setStringValue:_NS("Duration")]; + + [[o_tc_name_other headerCell] setStringValue:_NS("Name")]; + [[o_tc_author_other headerCell] setStringValue:_NS("Author")]; + [[o_tc_duration_other headerCell] setStringValue:_NS("Duration")]; +} + +- (void)swapPlaylists:(id)newList +{ + if(newList != o_outline_view) + { + id o_outline_view_temp = o_outline_view; + id o_tc_author_temp = o_tc_author; + id o_tc_duration_temp = o_tc_duration; + id o_tc_name_temp = o_tc_name; + o_outline_view = o_outline_view_other; + o_tc_author = o_tc_author_other; + o_tc_duration = o_tc_duration_other; + o_tc_name = o_tc_name_other; + o_outline_view_other = o_outline_view_temp; + o_tc_author_other = o_tc_author_temp; + o_tc_duration_other = o_tc_duration_temp; + o_tc_name_other = o_tc_name_temp; + } } - (NSOutlineView *)outlineView @@ -150,8 +180,8 @@ { int i_return = 0; playlist_item_t *p_item = NULL; - playlist_t * p_playlist = pl_Hold( VLCIntf ); - assert( outlineView == o_outline_view ); + playlist_t * p_playlist = pl_Get( VLCIntf ); + //assert( outlineView == o_outline_view ); if( !item ) p_item = p_playlist->p_root_category; @@ -161,8 +191,6 @@ if( p_item ) i_return = p_item->i_children; - pl_Release( VLCIntf ); - return i_return > 0 ? i_return : 0; } @@ -171,7 +199,7 @@ { playlist_item_t *p_return = NULL, *p_item = NULL; NSValue *o_value; - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); PL_LOCK; if( item == nil ) @@ -187,13 +215,11 @@ p_return = p_item->pp_children[index]; PL_UNLOCK; - vlc_object_release( p_playlist ); - o_value = [o_outline_dict objectForKey:[NSString stringWithFormat: @"%p", p_return]]; if( o_value == nil ) { - /* Why is there a warning if that happens all the time and seems + /* FIXME: Why is there a warning if that happens all the time and seems * to be normal? Add an assert and fix it. * msg_Warn( VLCIntf, "playlist item misses pointer value, adding one" ); */ o_value = [[NSValue valueWithPointer: p_return] retain]; @@ -205,8 +231,9 @@ - (BOOL)outlineView:(NSOutlineView *)outlineView isItemExpandable:(id)item { int i_return = 0; - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); + PL_LOCK; if( item == nil ) { /* root object */ @@ -221,7 +248,7 @@ if( p_item ) i_return = p_item->i_children; } - pl_Release( VLCIntf ); + PL_UNLOCK; return (i_return >= 0); } @@ -265,19 +292,12 @@ if( [[o_tc identifier] isEqualToString:@"name"] ) { /* sanity check to prevent the NSString class from crashing */ - char *psz_title = input_item_GetTitle( p_item->p_input ); - if( !EMPTY_STR( psz_title ) ) + char *psz_title = input_item_GetTitleFbName( p_item->p_input ); + if( psz_title ) { o_value = [NSString stringWithUTF8String: psz_title]; + free( psz_title ); } - else - { - char *psz_name = input_item_GetName( p_item->p_input ); - if( psz_name ) - o_value = [NSString stringWithUTF8String: psz_name]; - free( psz_name ); - } - free( psz_title ); } else if( [[o_tc identifier] isEqualToString:@"artist"] ) { @@ -365,19 +385,25 @@ - (void)awakeFromNib { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); int i; [super awakeFromNib]; [o_outline_view setDoubleAction: @selector(playItem:)]; + [o_outline_view_other setDoubleAction: @selector(playItem:)]; [o_outline_view registerForDraggedTypes: [NSArray arrayWithObjects: NSFilenamesPboardType, @"VLCPlaylistItemPboardType", nil]]; [o_outline_view setIntercellSpacing: NSMakeSize (0.0, 1.0)]; + [o_outline_view_other registerForDraggedTypes: + [NSArray arrayWithObjects: NSFilenamesPboardType, + @"VLCPlaylistItemPboardType", nil]]; + [o_outline_view_other setIntercellSpacing: NSMakeSize (0.0, 1.0)]; + /* This uses private Apple API which works fine until 10.5. * We need to keep checking in the future! * These methods are being added artificially to NSOutlineView's interface above */ @@ -387,12 +413,9 @@ o_tc_sortColumn = nil; char ** ppsz_name; - char ** ppsz_services = vlc_sd_GetNames( &ppsz_name ); + char ** ppsz_services = vlc_sd_GetNames( VLCIntf, &ppsz_name, NULL ); if( !ppsz_services ) - { - vlc_object_release( p_playlist ); return; - } for( i = 0; ppsz_services[i]; i++ ) { @@ -426,8 +449,6 @@ } free( ppsz_services ); free( ppsz_name ); - - vlc_object_release( p_playlist ); } - (void)searchfieldChanged:(NSNotification *)o_notification @@ -455,13 +476,28 @@ [o_mi_services setTitle: _NS("Services discovery")]; [o_mm_mi_services setTitle: _NS("Services discovery")]; [o_status_field setStringValue: _NS("No items in the playlist")]; + [o_status_field_embed setStringValue: _NS("No items in the playlist")]; [o_search_field setToolTip: _NS("Search in Playlist")]; + [o_search_field_other setToolTip: _NS("Search in Playlist")]; [o_mi_addNode setTitle: _NS("Add Folder to Playlist")]; [o_save_accessory_text setStringValue: _NS("File Format:")]; [[o_save_accessory_popup itemAtIndex:0] setTitle: _NS("Extended M3U")]; [[o_save_accessory_popup itemAtIndex:1] setTitle: _NS("XML Shareable Playlist Format (XSPF)")]; + [[o_save_accessory_popup itemAtIndex:2] setTitle: _NS("HTML Playlist")]; +} + +- (void)swapPlaylists:(id)newList +{ + if(newList != o_outline_view) + { + id o_search_field_temp = o_search_field; + o_search_field = o_search_field_other; + o_search_field_other = o_search_field_temp; + [super swapPlaylists:newList]; + [self playlistUpdated]; + } } - (void)playlistUpdated @@ -478,10 +514,11 @@ // TODO Find a way to keep the dict size to a minimum //[o_outline_dict removeAllObjects]; [o_outline_view reloadData]; - [[[[VLCMain sharedInstance] getWizard] getPlaylistWizard] reloadOutlineView]; - [[[[VLCMain sharedInstance] getBookmarks] getDataTable] reloadData]; + [o_sidebar updateSidebar:[self playingItem]]; + [[[[VLCMain sharedInstance] wizard] playlistWizard] reloadOutlineView]; + [[[[VLCMain sharedInstance] bookmarks] dataTable] reloadData]; - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); PL_LOCK; if( playlist_CurrentSize( p_playlist ) >= 2 ) @@ -489,36 +526,42 @@ [o_status_field setStringValue: [NSString stringWithFormat: _NS("%i items"), playlist_CurrentSize( p_playlist )]]; + [o_status_field_embed setStringValue: [NSString stringWithFormat: + _NS("%i items"), + playlist_CurrentSize( p_playlist )]]; } else { if( playlist_IsEmpty( p_playlist ) ) + { [o_status_field setStringValue: _NS("No items in the playlist")]; + [o_status_field_embed setStringValue: _NS("No items in the playlist")]; + } else + { [o_status_field setStringValue: _NS("1 item")]; + [o_status_field_embed setStringValue: _NS("1 item")]; + } } PL_UNLOCK; - vlc_object_release( p_playlist ); [self outlineViewSelectionDidChange: nil]; } - (void)playModeUpdated { - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); bool loop = var_GetBool( p_playlist, "loop" ); bool repeat = var_GetBool( p_playlist, "repeat" ); if( repeat ) - [[[VLCMain sharedInstance] getControls] repeatOne]; + [[[VLCMain sharedInstance] controls] repeatOne]; else if( loop ) - [[[VLCMain sharedInstance] getControls] repeatAll]; + [[[VLCMain sharedInstance] controls] repeatAll]; else - [[[VLCMain sharedInstance] getControls] repeatOff]; + [[[VLCMain sharedInstance] controls] repeatOff]; - [[[VLCMain sharedInstance] getControls] shuffle]; - - vlc_object_release( p_playlist ); + [[[VLCMain sharedInstance] controls] shuffle]; } - (void)outlineViewSelectionDidChange:(NSNotification *)notification @@ -531,29 +574,30 @@ /* update the state of our Reveal-in-Finder menu items */ NSMutableString *o_mrl; char *psz_uri = input_item_GetURI( p_item->p_input ); + + [o_mi_revealInFinder setEnabled: NO]; + [o_mm_mi_revealInFinder setEnabled: NO]; if( psz_uri ) { o_mrl = [NSMutableString stringWithUTF8String: psz_uri]; - + /* perform some checks whether it is a file and if it is local at all... */ NSRange prefix_range = [o_mrl rangeOfString: @"file:"]; if( prefix_range.location != NSNotFound ) [o_mrl deleteCharactersInRange: prefix_range]; - + if( [o_mrl characterAtIndex:0] == '/' ) { [o_mi_revealInFinder setEnabled: YES]; [o_mm_mi_revealInFinder setEnabled: YES]; - return; } + free( psz_uri ); } - [o_mi_revealInFinder setEnabled: NO]; - [o_mm_mi_revealInFinder setEnabled: NO]; if( [[VLCMain sharedInstance] isPlaylistCollapsed] == NO ) { /* update our info-panel to reflect the new item, if we aren't collapsed */ - [[[VLCMain sharedInstance] getInfo] updatePanelWithItem:p_item->p_input]; + [[[VLCMain sharedInstance] info] updatePanelWithItem:p_item->p_input]; } } } @@ -569,7 +613,7 @@ unsigned int j; // FIXME: unsafe - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); playlist_item_t *p_item, *p_temp_item; NSMutableArray *o_array = [NSMutableArray array]; @@ -578,7 +622,6 @@ if( p_item == NULL ) { PL_UNLOCK; - pl_Release( VLCIntf ); return; } @@ -588,6 +631,7 @@ [o_array insertObject: [NSValue valueWithPointer: p_temp_item] atIndex: 0]; p_temp_item = p_temp_item->p_parent; } + PL_UNLOCK; for( j = 0; j < [o_array count] - 1; j++ ) { @@ -598,11 +642,7 @@ { [o_outline_view expandItem: o_item]; } - } - - PL_UNLOCK; - pl_Release( VLCIntf ); } /* Check if p_item is a child of p_node recursively. We need to check the item @@ -616,20 +656,14 @@ locked:(BOOL)b_locked { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); playlist_item_t *p_temp_item = p_item; if( p_node == p_item ) - { - vlc_object_release(p_playlist); return YES; - } if( p_node->i_children < 1) - { - vlc_object_release(p_playlist); return NO; - } if ( p_temp_item ) { @@ -647,7 +681,6 @@ else if ( i == p_playlist->all_items.i_size - 1 ) { if(!b_locked) PL_UNLOCK; - vlc_object_release( p_playlist ); return NO; } } @@ -659,14 +692,11 @@ if( p_temp_item == p_node ) { if(!b_locked) PL_UNLOCK; - vlc_object_release( p_playlist ); return YES; } } if(!b_locked) PL_UNLOCK; } - - vlc_object_release( p_playlist ); return NO; } @@ -706,12 +736,11 @@ - (IBAction)savePlaylist:(id)sender { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); NSSavePanel *o_save_panel = [NSSavePanel savePanel]; NSString * o_name = [NSString stringWithFormat: @"%@", _NS("Untitled")]; - //[o_save_panel setAllowedFileTypes: [NSArray arrayWithObjects: @"m3u", @"xpf", nil] ]; [o_save_panel setTitle: _NS("Save Playlist")]; [o_save_panel setPrompt: _NS("Save")]; [o_save_panel setAccessoryView: o_save_accessory_view]; @@ -721,7 +750,27 @@ { NSString *o_filename = [o_save_panel filename]; - if( [o_save_accessory_popup indexOfSelectedItem] == 1 ) + if( [o_save_accessory_popup indexOfSelectedItem] == 0 ) + { + NSString * o_real_filename; + NSRange range; + range.location = [o_filename length] - [@".m3u" length]; + range.length = [@".m3u" length]; + + if( [o_filename compare:@".m3u" options: NSCaseInsensitiveSearch + range: range] != NSOrderedSame ) + { + o_real_filename = [NSString stringWithFormat: @"%@.m3u", o_filename]; + } + else + { + o_real_filename = o_filename; + } + playlist_Export( p_playlist, + [o_real_filename fileSystemRepresentation], + p_playlist->p_local_category, "export-m3u" ); + } + else if( [o_save_accessory_popup indexOfSelectedItem] == 1 ) { NSString * o_real_filename; NSRange range; @@ -745,13 +794,13 @@ { NSString * o_real_filename; NSRange range; - range.location = [o_filename length] - [@".m3u" length]; - range.length = [@".m3u" length]; + range.location = [o_filename length] - [@".html" length]; + range.length = [@".html" length]; - if( [o_filename compare:@".m3u" options: NSCaseInsensitiveSearch + if( [o_filename compare:@".html" options: NSCaseInsensitiveSearch range: range] != NSOrderedSame ) { - o_real_filename = [NSString stringWithFormat: @"%@.m3u", o_filename]; + o_real_filename = [NSString stringWithFormat: @"%@.html", o_filename]; } else { @@ -759,29 +808,62 @@ } playlist_Export( p_playlist, [o_real_filename fileSystemRepresentation], - p_playlist->p_local_category, "export-m3u" ); + p_playlist->p_local_category, "export-html" ); } } - vlc_object_release( p_playlist ); } /* When called retrieves the selected outlineview row and plays that node or item */ - (IBAction)playItem:(id)sender { intf_thread_t * p_intf = VLCIntf; - playlist_t * p_playlist = pl_Hold( p_intf ); + playlist_t * p_playlist = pl_Get( p_intf ); playlist_item_t *p_item; playlist_item_t *p_node = NULL; p_item = [[o_outline_view itemAtRow:[o_outline_view selectedRow]] pointerValue]; + PL_LOCK; if( p_item ) { if( p_item->i_children == -1 ) { p_node = p_item->p_parent; + } + else + { + p_node = p_item; + if( p_node->i_children > 0 && p_node->pp_children[0]->i_children == -1 ) + { + p_item = p_node->pp_children[0]; + } + else + { + p_item = NULL; + } + } + playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_node, p_item ); + } + PL_UNLOCK; +} +- (void)playSidebarItem:(id)item +{ + intf_thread_t * p_intf = VLCIntf; + playlist_t * p_playlist = pl_Get( p_intf ); + + playlist_item_t *p_item; + playlist_item_t *p_node = NULL; + + p_item = [item pointerValue]; + + if( p_item ) + { + if( p_item->i_children == -1 ) + { + p_node = p_item->p_parent; + } else { @@ -797,7 +879,6 @@ } playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Unlocked, p_node, p_item ); } - vlc_object_release( p_playlist ); } - (IBAction)revealItemInFinder:(id)sender @@ -827,7 +908,7 @@ int i_count; NSMutableArray *o_to_preparse; intf_thread_t * p_intf = VLCIntf; - playlist_t * p_playlist = pl_Hold( p_intf ); + playlist_t * p_playlist = pl_Get( p_intf ); o_to_preparse = [NSMutableArray arrayWithArray:[[o_outline_view selectedRowEnumerator] allObjects]]; i_count = [o_to_preparse count]; @@ -848,7 +929,7 @@ { if( p_item->i_children == -1 ) { - playlist_PreparseEnqueue( p_playlist, p_item->p_input, pl_Unlocked ); + playlist_PreparseEnqueue( p_playlist, p_item->p_input ); } else { @@ -856,7 +937,6 @@ } } } - vlc_object_release( p_playlist ); [self playlistUpdated]; } @@ -865,7 +945,7 @@ int i_count; NSMutableArray *o_to_preparse; intf_thread_t * p_intf = VLCIntf; - playlist_t * p_playlist = pl_Hold( p_intf ); + playlist_t * p_playlist = pl_Get( p_intf ); o_to_preparse = [NSMutableArray arrayWithArray:[[o_outline_view selectedRowEnumerator] allObjects]]; i_count = [o_to_preparse count]; @@ -884,10 +964,9 @@ if( p_item && p_item->i_children == -1 ) { - playlist_AskForArtEnqueue( p_playlist, p_item->p_input, pl_Unlocked ); + playlist_AskForArtEnqueue( p_playlist, p_item->p_input ); } } - vlc_object_release( p_playlist ); [self playlistUpdated]; } @@ -895,7 +974,7 @@ { NSMenuItem *o_mi = (NSMenuItem *)sender; NSString *o_string = [o_mi representedObject]; - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); if( !playlist_IsServicesDiscoveryLoaded( p_playlist, [o_string UTF8String] ) ) playlist_ServicesDiscoveryAdd( p_playlist, [o_string UTF8String] ); else @@ -904,7 +983,6 @@ [o_mi setState: playlist_IsServicesDiscoveryLoaded( p_playlist, [o_string UTF8String] ) ? YES : NO]; - vlc_object_release( p_playlist ); [self playlistUpdated]; return; } @@ -926,21 +1004,22 @@ o_to_delete = [NSMutableArray arrayWithArray:[[o_outline_view selectedRowEnumerator] allObjects]]; i_count = [o_to_delete count]; - p_playlist = pl_Hold( p_intf ); + p_playlist = pl_Get( p_intf ); - PL_LOCK; for( int i = 0; i < i_count; i++ ) { o_number = [o_to_delete lastObject]; i_row = [o_number intValue]; id o_item = [o_outline_view itemAtRow: i_row]; + [o_outline_view deselectRow: i_row]; + + PL_LOCK; playlist_item_t *p_item = [o_item pointerValue]; #ifndef NDEBUG msg_Dbg( p_intf, "deleting item %i (of %i) with id \"%i\", pointerValue \"%p\" and %i children", i+1, i_count, p_item->p_input->i_id, [o_item pointerValue], p_item->i_children +1 ); #endif [o_to_delete removeObject: o_number]; - [o_outline_view deselectRow: i_row]; if( p_item->i_children != -1 ) //is a node and not an item @@ -955,12 +1034,15 @@ playlist_NodeDelete( p_playlist, p_item, true, false ); } else - playlist_DeleteFromInput( p_playlist, p_item->p_input->i_id, pl_Locked ); + playlist_DeleteFromInput( p_playlist, p_item->p_input, pl_Locked ); + + PL_UNLOCK; + [o_outline_dict removeObjectForKey:[NSString stringWithFormat:@"%p", + [o_item pointerValue]]]; + [o_item release]; } - PL_UNLOCK; [self playlistUpdated]; - vlc_object_release( p_playlist ); } - (IBAction)sortNodeByName:(id)sender @@ -975,7 +1057,7 @@ - (void)sortNode:(int)i_mode { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); playlist_item_t * p_item; if( [o_outline_view selectedRow] > -1 ) @@ -988,27 +1070,24 @@ p_item = p_playlist->p_root_category; } + PL_LOCK; if( p_item->i_children > -1 ) // the item is a node { - PL_LOCK; playlist_RecursiveNodeSort( p_playlist, p_item, i_mode, ORDER_NORMAL ); - PL_UNLOCK; } else { - PL_LOCK; playlist_RecursiveNodeSort( p_playlist, p_item->p_parent, i_mode, ORDER_NORMAL ); - PL_UNLOCK; } - vlc_object_release( p_playlist ); + PL_UNLOCK; [self playlistUpdated]; } - (input_item_t *)createItem:(NSDictionary *)o_one_item { intf_thread_t * p_intf = VLCIntf; - playlist_t * p_playlist = pl_Hold( p_intf ); + playlist_t * p_playlist = pl_Get( p_intf ); input_item_t *p_input; int i; @@ -1045,8 +1124,6 @@ } } } - /* If no name, then make a guess */ - if( !o_name) o_name = [[NSFileManager defaultManager] displayNameAtPath: o_uri]; if( [[NSFileManager defaultManager] fileExistsAtPath:o_uri isDirectory:&b_dir] && b_dir && [[NSWorkspace sharedWorkspace] getFileSystemInfoForPath: o_uri isRemovable: &b_rem @@ -1068,15 +1145,15 @@ o_uri = o_temp; } - p_input = input_item_New( p_playlist, [o_uri fileSystemRepresentation], [o_name UTF8String] ); + p_input = input_item_New( p_playlist, [o_uri fileSystemRepresentation], o_name ? [o_name UTF8String] : NULL ); if( !p_input ) - return NULL; + return NULL; if( o_options ) { for( i = 0; i < (int)[o_options count]; i++ ) { - input_item_AddOption( p_input, strdup( [[o_options objectAtIndex:i] UTF8String] ), + input_item_AddOption( p_input, [[o_options objectAtIndex:i] UTF8String], VLC_INPUT_OPTION_TRUSTED ); } } @@ -1088,15 +1165,13 @@ [[NSDocumentController sharedDocumentController] noteNewRecentDocumentURL: o_true_file]; } - - vlc_object_release( p_playlist ); return p_input; } - (void)appendArray:(NSArray*)o_array atPos:(int)i_position enqueue:(BOOL)b_enqueue { int i_item; - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); PL_LOCK; for( i_item = 0; i_item < (int)[o_array count]; i_item++ ) @@ -1144,13 +1219,12 @@ PL_UNLOCK; [self playlistUpdated]; - vlc_object_release( p_playlist ); } - (void)appendNodeArray:(NSArray*)o_array inNode:(playlist_item_t *)p_node atPos:(int)i_position enqueue:(BOOL)b_enqueue { int i_item; - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); for( i_item = 0; i_item < (int)[o_array count]; i_item++ ) { @@ -1164,13 +1238,12 @@ if( !p_input ) continue; /* Add the item */ - /* FIXME: playlist_BothAddInput() can fail */ PL_LOCK; - playlist_BothAddInput( p_playlist, p_input, p_node, + playlist_NodeAddInput( p_playlist, p_input, p_node, PLAYLIST_INSERT, i_position == -1 ? PLAYLIST_END : i_position + i_item, - NULL, NULL, pl_Locked ); + pl_Locked ); if( i_item == 0 && !b_enqueue ) @@ -1183,12 +1256,11 @@ vlc_gc_decref( p_input ); } [self playlistUpdated]; - vlc_object_release( p_playlist ); } - (NSMutableArray *)subSearchItem:(playlist_item_t *)p_item { - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); playlist_item_t *p_selected_item; int i_current, i_selected_row; @@ -1221,7 +1293,6 @@ else if( p_selected_item == p_item->pp_children[i_current] && b_selected_item_met == YES ) { - vlc_object_release( p_playlist ); return NULL; } else if( b_selected_item_met == YES && @@ -1230,7 +1301,6 @@ [o_current_author rangeOfString:[o_search_field stringValue] options:NSCaseInsensitiveSearch].length ) ) { - vlc_object_release( p_playlist ); /*Adds the parent items in the result array as well, so that we can expand the tree*/ return [NSMutableArray arrayWithObject: [NSValue @@ -1242,20 +1312,18 @@ p_item->pp_children[i_current]]; if( o_result != NULL ) { - vlc_object_release( p_playlist ); [o_result insertObject: [NSValue valueWithPointer: p_item->pp_children[i_current]] atIndex:0]; return o_result; } } } - vlc_object_release( p_playlist ); return NULL; } - (IBAction)searchItem:(id)sender { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); id o_result; unsigned int i; @@ -1293,10 +1361,9 @@ } if( i_row > -1 ) { - [o_outline_view selectRow:i_row byExtendingSelection: NO]; + [o_outline_view selectRowIndexes:[NSIndexSet indexSetWithIndex:i_row] byExtendingSelection:NO]; [o_outline_view scrollRowToVisible: i_row]; } - vlc_object_release( p_playlist ); } - (IBAction)recursiveExpandNode:(id)sender @@ -1350,13 +1417,12 @@ int i_mode, i_type = 0; intf_thread_t *p_intf = VLCIntf; - playlist_t *p_playlist = pl_Hold( p_intf ); + playlist_t *p_playlist = pl_Get( p_intf ); /* Check whether the selected table column header corresponds to a sortable table column*/ if( !( o_tc == o_tc_name || o_tc == o_tc_author ) ) { - vlc_object_release( p_playlist ); return; } @@ -1391,7 +1457,6 @@ playlist_RecursiveNodeSort( p_playlist, p_playlist->p_root_category, i_mode, i_type ); PL_UNLOCK; - vlc_object_release( p_playlist ); [self playlistUpdated]; o_tc_sortColumn = o_tc; @@ -1415,7 +1480,7 @@ forTableColumn:(NSTableColumn *)tableColumn item:(id)item { - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); id o_playing_item; @@ -1434,51 +1499,34 @@ { [cell setFont: [[NSFontManager sharedFontManager] convertFont:[cell font] toNotHaveTrait:NSBoldFontMask]]; } - vlc_object_release( p_playlist ); } -- (IBAction)addNode:(id)sender +- (id)playingItem { - /* we have to create a new thread here because otherwise we would block the - * interface since the interaction-stuff and this code would run in the same - * thread */ - [NSThread detachNewThreadSelector: @selector(addNodeThreadedly) - toTarget: self withObject:nil]; - [self playlistUpdated]; + playlist_t *p_playlist = pl_Get( VLCIntf ); + + id o_playing_item; + + PL_LOCK; + o_playing_item = [o_outline_dict objectForKey: + [NSString stringWithFormat:@"%p", playlist_CurrentPlayingItem( p_playlist )]]; + PL_UNLOCK; + + return o_playing_item; } -- (void)addNodeThreadedly +- (IBAction)addNode:(id)sender { - NSAutoreleasePool * ourPool = [[NSAutoreleasePool alloc] init]; - - /* simply adds a new node to the end of the playlist */ - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); vlc_thread_set_priority( p_playlist, VLC_THREAD_PRIORITY_LOW ); - int ret_v; - char *psz_name = NULL; - ret_v = intf_UserStringInput( p_playlist, _("New Node"), - _("Please enter a name for the new node."), &psz_name ); - PL_LOCK; - if( ret_v != DIALOG_CANCELLED && psz_name ) - { - playlist_NodeCreate( p_playlist, psz_name, - p_playlist->p_local_category, 0, NULL ); - } - else if(! config_GetInt( p_playlist, "interact" ) ) - { - /* in case that the interaction is disabled, just give it a bogus name */ - playlist_NodeCreate( p_playlist, _("Empty Folder"), + playlist_NodeCreate( p_playlist, _("Empty Folder"), p_playlist->p_local_category, 0, NULL ); - } PL_UNLOCK; - free( psz_name ); - pl_Release( VLCIntf ); - [ourPool release]; + [self playlistUpdated]; } - @end @implementation VLCPlaylist (NSOutlineViewDataSource) @@ -1486,7 +1534,7 @@ - (id)outlineView:(NSOutlineView *)outlineView child:(NSInteger)index ofItem:(id)item { id o_value = [super outlineView: outlineView child: index ofItem: item]; - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); PL_LOCK; if( playlist_CurrentSize( p_playlist ) >= 2 ) @@ -1494,22 +1542,25 @@ [o_status_field setStringValue: [NSString stringWithFormat: _NS("%i items"), playlist_CurrentSize( p_playlist )]]; + [o_status_field_embed setStringValue: [NSString stringWithFormat: + _NS("%i items"), + playlist_CurrentSize( p_playlist )]]; } else { if( playlist_IsEmpty( p_playlist ) ) { [o_status_field setStringValue: _NS("No items in the playlist")]; + [o_status_field_embed setStringValue: _NS("No items in the playlist")]; } else { [o_status_field setStringValue: _NS("1 item")]; + [o_status_field_embed setStringValue: _NS("1 item")]; } } PL_UNLOCK; - vlc_object_release( p_playlist ); - [o_outline_dict setObject:o_value forKey:[NSString stringWithFormat:@"%p", [o_value pointerValue]]]; return o_value; @@ -1520,7 +1571,7 @@ - (BOOL)outlineView:(NSOutlineView *)outlineView writeItems:(NSArray *)items toPasteboard:(NSPasteboard *)pboard { unsigned int i; - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); /* First remove the items that were moved during the last drag & drop operation */ @@ -1541,7 +1592,6 @@ [o_item pointerValue] == p_playlist->p_local_category || [o_item pointerValue] == p_playlist->p_ml_category ) { - vlc_object_release(p_playlist); return NO; } /* Fill the items and nodes to move in 2 different arrays */ @@ -1563,13 +1613,12 @@ @"VLCPlaylistItemPboardType", nil] owner: self]; [pboard setData:[NSData data] forType:@"VLCPlaylistItemPboardType"]; - vlc_object_release(p_playlist); return YES; } - (NSDragOperation)outlineView:(NSOutlineView *)outlineView validateDrop:(id )info proposedItem:(id)item proposedChildIndex:(NSInteger)index { - playlist_t *p_playlist = pl_Hold( VLCIntf ); + playlist_t *p_playlist = pl_Get( VLCIntf ); NSPasteboard *o_pasteboard = [info draggingPasteboard]; if( !p_playlist ) return NSDragOperationNone; @@ -1580,7 +1629,6 @@ if( index == NSOutlineViewDropOnItemIndex && ((playlist_item_t *)[item pointerValue])->i_children == -1 ) { - vlc_object_release( p_playlist ); return NSDragOperationNone; } } @@ -1588,7 +1636,6 @@ /* Don't allow on drop on playlist root element's child */ if( !item && index != NSOutlineViewDropOnItemIndex) { - vlc_object_release( p_playlist ); return NSDragOperationNone; } @@ -1598,7 +1645,6 @@ if( !( ([self isItem: [item pointerValue] inNode: p_playlist->p_local_category checkItemExistence: NO] || ( var_CreateGetBool( p_playlist, "media-library" ) && [self isItem: [item pointerValue] inNode: p_playlist->p_ml_category checkItemExistence: NO] ) ) || item == nil ) ) { - vlc_object_release( p_playlist ); return NSDragOperationNone; } @@ -1613,27 +1659,23 @@ [[o_nodes_array objectAtIndex: i] pointerValue] checkItemExistence: NO] ) { - vlc_object_release( p_playlist ); return NSDragOperationNone; } } - vlc_object_release( p_playlist ); return NSDragOperationMove; } /* Drop from the Finder */ else if( [[o_pasteboard types] containsObject: NSFilenamesPboardType] ) { - vlc_object_release( p_playlist ); return NSDragOperationGeneric; } - vlc_object_release( p_playlist ); return NSDragOperationNone; } - (BOOL)outlineView:(NSOutlineView *)outlineView acceptDrop:(id )info item:(id)item childIndex:(NSInteger)index { - playlist_t * p_playlist = pl_Hold( VLCIntf ); + playlist_t * p_playlist = pl_Get( VLCIntf ); NSPasteboard *o_pasteboard = [info draggingPasteboard]; /* Drag & Drop inside the playlist */ @@ -1654,7 +1696,6 @@ (This should never be true) */ if( p_new_parent->i_children < 0 ) { - vlc_object_release( p_playlist ); return NO; } @@ -1718,10 +1759,9 @@ } [o_outline_view deselectAll: self]; - [o_outline_view selectRow: i_row byExtendingSelection: NO]; + [o_outline_view selectRowIndexes:[NSIndexSet indexSetWithIndex:i_row] byExtendingSelection:NO]; [o_outline_view scrollRowToVisible: i_row]; - vlc_object_release( p_playlist ); return YES; } @@ -1754,10 +1794,8 @@ [self appendNodeArray:o_array inNode: p_node atPos:index enqueue:YES]; } - vlc_object_release( p_playlist ); return YES; } - vlc_object_release( p_playlist ); return NO; } @end