X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fgui%2Fskins2%2Fsrc%2Fskin_main.cpp;h=a78cc6abcf8842ade68e09a16fbf52d653beb6a7;hb=fd964450e1eba43b68adbb82a2f684c460f93700;hp=f6511d14305ce367e577ff516c83057a7f383e4d;hpb=a05b23aac0c27884c03852e3217febae76470919;p=vlc diff --git a/modules/gui/skins2/src/skin_main.cpp b/modules/gui/skins2/src/skin_main.cpp index f6511d1430..a78cc6abcf 100644 --- a/modules/gui/skins2/src/skin_main.cpp +++ b/modules/gui/skins2/src/skin_main.cpp @@ -22,8 +22,17 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ -#include -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include +#include +#include +#include +#include +#include + #include "dialogs.hpp" #include "os_factory.hpp" #include "os_loop.hpp" @@ -38,7 +47,6 @@ #include "../commands/cmd_dialogs.hpp" #include "../commands/cmd_minimize.hpp" - //--------------------------------------------------------------------------- // Exported interface functions. //--------------------------------------------------------------------------- @@ -65,6 +73,9 @@ static int DemuxControl( demux_t *, int, va_list ); static int onSystrayChange( vlc_object_t *pObj, const char *pVariable, vlc_value_t oldVal, vlc_value_t newVal, void *pParam ); +static int onTaskBarChange( vlc_object_t *pObj, const char *pVariable, + vlc_value_t oldVal, vlc_value_t newVal, + void *pParam ); //--------------------------------------------------------------------------- @@ -85,17 +96,10 @@ static int Open( vlc_object_t *p_this ) p_intf->pf_run = Run; // Suscribe to messages bank - p_intf->p_sys->p_sub = msg_Subscribe( p_intf, MSG_QUEUE_NORMAL ); + p_intf->p_sys->p_sub = msg_Subscribe( p_intf ); p_intf->p_sys->p_input = NULL; - p_intf->p_sys->p_playlist = (playlist_t *)vlc_object_find( p_intf, - VLC_OBJECT_PLAYLIST, FIND_ANYWHERE ); - if( p_intf->p_sys->p_playlist == NULL ) - { - msg_Err( p_intf, "No playlist object found" ); - msg_Unsubscribe( p_intf, p_intf->p_sys->p_sub ); - return VLC_EGENERIC; - } + p_intf->p_sys->p_playlist = pl_Yield( p_intf ); // Initialize "singleton" objects p_intf->p_sys->p_logger = NULL; @@ -153,9 +157,6 @@ static int Open( vlc_object_t *p_this ) Dialogs::instance( p_intf ); ThemeRepository::instance( p_intf ); - // We support play on start - p_intf->b_play = VLC_TRUE; - return( VLC_SUCCESS ); } @@ -237,27 +238,11 @@ static void Run( intf_thread_t *p_intf ) } delete pLoader; - if( skin_last ) - { - free( skin_last ); - } + free( skin_last ); // Get the instance of OSLoop OSLoop *loop = OSFactory::instance( p_intf )->getOSLoop(); - // Check if we need to start playing - if( p_intf->b_play ) - { - playlist_t *p_playlist = - (playlist_t *)vlc_object_find( p_intf, VLC_OBJECT_PLAYLIST, - FIND_ANYWHERE ); - if( p_playlist ) - { - playlist_LockControl( p_playlist, PLAYLIST_AUTOPLAY ); - vlc_object_release( p_playlist ); - } - } - // Enter the main event loop loop->run(); @@ -271,6 +256,35 @@ static void Run( intf_thread_t *p_intf ) } +// Callbacks for vout requests +static int WindowOpen( vlc_object_t *p_this ) +{ + vout_window_t *pWnd = (vout_window_t *)p_this; + intf_thread_t *pIntf = (intf_thread_t *) + vlc_object_find_name( p_this, "skins2", FIND_ANYWHERE ); + + if( pIntf == NULL ) + return VLC_EGENERIC; + + /* FIXME: most probably not thread-safe, + * albeit no worse than ever before */ + pWnd->handle = VlcProc::getWindow( pIntf, pWnd->vout, + &pWnd->pos_x, &pWnd->pos_y, + &pWnd->width, &pWnd->height ); + pWnd->p_private = pIntf; + pWnd->control = &VlcProc::controlWindow; + return VLC_SUCCESS; +} + + +static void WindowClose( vlc_object_t *p_this ) +{ + vout_window_t *pWnd = (vout_window_t *)p_this; + intf_thread_t *pIntf = (intf_thread_t *)p_this->p_private; + + VlcProc::releaseWindow( pIntf, pWnd->handle ); +} + //--------------------------------------------------------------------------- // DemuxOpen: initialize demux //--------------------------------------------------------------------------- @@ -299,16 +313,11 @@ static int DemuxOpen( vlc_object_t *p_this ) // Do nothing is skins2 is not the main interface if( var_Type( p_intf, "skin-to-load" ) == VLC_VAR_STRING ) { - playlist_t *p_playlist = - (playlist_t *) vlc_object_find( p_this, VLC_OBJECT_PLAYLIST, - FIND_ANYWHERE ); - if( p_playlist != NULL ) - { - // Make sure the item is deleted afterwards - p_playlist->pp_items[p_playlist->i_index]->b_autodeletion = - VLC_TRUE; - vlc_object_release( p_playlist ); - } + playlist_t *p_playlist = pl_Yield( p_this ); + // Make sure the item is deleted afterwards + /// \bug does not always work + p_playlist->status.p_item->i_flags |= PLAYLIST_REMOVE_FLAG; + vlc_object_release( p_playlist ); vlc_value_t val; val.psz_string = p_demux->psz_path; @@ -341,7 +350,7 @@ static int Demux( demux_t *p_demux ) //--------------------------------------------------------------------------- static int DemuxControl( demux_t *p_demux, int i_query, va_list args ) { - return demux2_vaControlHelper( p_demux->s, 0, 0, 0, 1, i_query, args ); + return demux_vaControlHelper( p_demux->s, 0, 0, 0, 1, i_query, args ); } @@ -362,19 +371,58 @@ static int onSystrayChange( vlc_object_t *pObj, const char *pVariable, return VLC_EGENERIC; } - AsyncQueue *pQueue = AsyncQueue::instance( pIntf ); - if( newVal.b_bool ) + // Check that we found the correct interface (same check as for the demux) + if( var_Type( pIntf, "skin-to-load" ) == VLC_VAR_STRING ) { - CmdAddInTray *pCmd = new CmdAddInTray( pIntf ); - pQueue->push( CmdGenericPtr( pCmd ) ); + AsyncQueue *pQueue = AsyncQueue::instance( pIntf ); + if( newVal.b_bool ) + { + CmdAddInTray *pCmd = new CmdAddInTray( pIntf ); + pQueue->push( CmdGenericPtr( pCmd ) ); + } + else + { + CmdRemoveFromTray *pCmd = new CmdRemoveFromTray( pIntf ); + pQueue->push( CmdGenericPtr( pCmd ) ); + } } - else + + vlc_object_release( pIntf ); + return VLC_SUCCESS; +} + + +/// Callback for the systray configuration option +static int onTaskBarChange( vlc_object_t *pObj, const char *pVariable, + vlc_value_t oldVal, vlc_value_t newVal, + void *pParam ) +{ + intf_thread_t *pIntf = + (intf_thread_t*)vlc_object_find( pObj, VLC_OBJECT_INTF, FIND_ANYWHERE ); + + if( pIntf == NULL ) + { + return VLC_EGENERIC; + } + + // Check that we found the correct interface (same check as for the demux) + if( var_Type( pIntf, "skin-to-load" ) == VLC_VAR_STRING ) { - CmdRemoveFromTray *pCmd = new CmdRemoveFromTray( pIntf ); - pQueue->push( CmdGenericPtr( pCmd ) ); + AsyncQueue *pQueue = AsyncQueue::instance( pIntf ); + if( newVal.b_bool ) + { + CmdAddInTaskBar *pCmd = new CmdAddInTaskBar( pIntf ); + pQueue->push( CmdGenericPtr( pCmd ) ); + } + else + { + CmdRemoveFromTaskBar *pCmd = new CmdRemoveFromTaskBar( pIntf ); + pQueue->push( CmdGenericPtr( pCmd ) ); + } } vlc_object_release( pIntf ); + return VLC_SUCCESS; } @@ -388,39 +436,49 @@ static int onSystrayChange( vlc_object_t *pObj, const char *pVariable, "This option is updated automatically, do not touch it." ) #define SKINS2_SYSTRAY N_("Systray icon") #define SKINS2_SYSTRAY_LONG N_("Show a systray icon for VLC") +#define SKINS2_TASKBAR N_("Show VLC on the taskbar") +#define SKINS2_TASKBAR_LONG N_("Show VLC on the taskbar") #define SKINS2_TRANSPARENCY N_("Enable transparency effects") #define SKINS2_TRANSPARENCY_LONG N_("You can disable all transparency effects"\ " if you want. This is mainly useful when moving windows does not behave" \ " correctly.") +#define SKINS2_PLAYLIST N_("Use a skinned playlist") +#define SKINS2_PLAYLIST_LONG N_("Use a skinned playlist") vlc_module_begin(); set_category( CAT_INTERFACE ); set_subcategory( SUBCAT_INTERFACE_MAIN ); - add_string( "skins2-last", "", NULL, SKINS2_LAST, SKINS2_LAST_LONG, - VLC_TRUE ); + add_file( "skins2-last", "", NULL, SKINS2_LAST, SKINS2_LAST_LONG, + true ); change_autosave(); add_string( "skins2-config", "", NULL, SKINS2_CONFIG, SKINS2_CONFIG_LONG, - VLC_TRUE ); + true ); change_autosave(); + change_internal(); #ifdef WIN32 - add_bool( "skins2-systray", VLC_FALSE, onSystrayChange, SKINS2_SYSTRAY, - SKINS2_SYSTRAY_LONG, VLC_FALSE ); - add_bool( "skins2-transparency", VLC_FALSE, NULL, SKINS2_TRANSPARENCY, - SKINS2_TRANSPARENCY_LONG, VLC_FALSE ); + add_bool( "skins2-systray", false, onSystrayChange, SKINS2_SYSTRAY, + SKINS2_SYSTRAY_LONG, false ); + add_bool( "skins2-taskbar", true, onTaskBarChange, SKINS2_TASKBAR, + SKINS2_TASKBAR_LONG, false ); + add_bool( "skins2-transparency", false, NULL, SKINS2_TRANSPARENCY, + SKINS2_TRANSPARENCY_LONG, false ); #endif - add_bool( "skinned-playlist", VLC_TRUE, NULL, SKINS2_TRANSPARENCY, - SKINS2_TRANSPARENCY_LONG, VLC_FALSE ); - set_shortname( _("Skins")); - set_description( _("Skinnable Interface") ); + add_bool( "skinned-playlist", true, NULL, SKINS2_PLAYLIST, + SKINS2_PLAYLIST_LONG, false ); + set_shortname( N_("Skins")); + set_description( N_("Skinnable Interface") ); set_capability( "interface", 30 ); set_callbacks( Open, Close ); add_shortcut( "skins" ); - set_program( "svlc" ); add_submodule(); - set_description( _("Skins loader demux") ); - set_capability( "demux2", 5 ); + set_capability( "vout window", 51 ); + set_callbacks( WindowOpen, WindowClose ); + + add_submodule(); + set_description( N_("Skins loader demux") ); + set_capability( "demux", 5 ); set_callbacks( DemuxOpen, NULL ); vlc_module_end();