X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fmeta_engine%2Ftaglib.cpp;h=4ededfdab235a1fa28a574a5c3342178e53044a7;hb=b028610a03184c78490fb5dc3637a11450eaa05f;hp=df2a7bb1c6d0364e1025634dc89c4203c045f50f;hpb=5fa18d5627809fe65fdcf47aec00711c0b852688;p=vlc diff --git a/modules/meta_engine/taglib.cpp b/modules/meta_engine/taglib.cpp index df2a7bb1c6..4ededfdab2 100644 --- a/modules/meta_engine/taglib.cpp +++ b/modules/meta_engine/taglib.cpp @@ -1,7 +1,7 @@ /***************************************************************************** * taglib.cpp: Taglib tag parser/writer ***************************************************************************** - * Copyright (C) 2003-2008 the VideoLAN team + * Copyright (C) 2003-2009 the VideoLAN team * $Id$ * * Authors: Clément Stenac @@ -29,11 +29,13 @@ #include #include -#include #include #include #include #include +#include +#include +#include /* for attachment_new */ #ifdef WIN32 # include @@ -56,6 +58,16 @@ #include #include #include + +#ifdef TAGLIB_WITH_ASF +# include +# include +#endif + +#ifdef TAGLIB_WITH_MP4 +# include +#endif + #include #include #include @@ -68,15 +80,11 @@ // Local functions static int ReadMeta ( vlc_object_t * ); -static int DownloadArt ( vlc_object_t * ); static int WriteMeta ( vlc_object_t * ); vlc_module_begin () set_capability( "meta reader", 1000 ) set_callbacks( ReadMeta, NULL ) - add_submodule () - set_capability( "art downloader", 50 ) - set_callbacks( DownloadArt, NULL ) add_submodule () set_capability( "meta writer", 50 ) set_callbacks( WriteMeta, NULL ) @@ -131,12 +139,9 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t* * but in our case it will be a '\0' * terminated string */ char psz_ufid[64]; - int j = 0; - int max_size = p_ufid->identifier().size() < 63 ? - p_ufid->identifier().size() : 63; - while( j < max_size ) - psz_ufid[j] = p_ufid->identifier()[j++]; - psz_ufid[j] = '\0'; + int max_size = __MIN( p_ufid->identifier().size(), 63); + strncpy( psz_ufid, p_ufid->identifier().data(), max_size ); + psz_ufid[max_size] = '\0'; vlc_meta_SetTrackID( p_meta, psz_ufid ); } } @@ -197,19 +202,31 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t* list = tag->frameListMap()[ "APIC" ]; if( list.isEmpty() ) return; + TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments ); - for( ID3v2::FrameList::Iterator iter = list.begin(); - iter != list.end(); iter++ ) + for( iter = list.begin(); iter != list.end(); iter++ ) { ID3v2::AttachedPictureFrame* p_apic = dynamic_cast(*iter); input_attachment_t *p_attachment; - const char *psz_name, *psz_mime, *psz_description; - const char *p_data; int i_data; + const char *psz_mime; + char *psz_name, *psz_description; + // Get the mime and description of the image. + // If the description is empty, take the type as a description psz_mime = p_apic->mimeType().toCString( true ); - psz_description = psz_name = p_apic->description().toCString( true ); + if( p_apic->description().size() > 0 ) + psz_description = strdup( p_apic->description().toCString( true ) ); + else + { + if( asprintf( &psz_description, "%i", p_apic->type() ) == -1 ) + psz_description = NULL; + } + + if( !psz_description ) + continue; + psz_name = psz_description; /* some old iTunes version not only sets incorrectly the mime type * or the description of the image, @@ -218,21 +235,25 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t* if( !strncmp( psz_mime, "PNG", 3 ) || !strncmp( psz_name, "\xC2\x89PNG", 5 ) ) { - msg_Warn( p_demux, "Invalid picture embedded by broken iTunes version" ); - break; + msg_Warn( p_demux_meta, "Invalid picture embedded by broken iTunes version" ); + free( psz_description ); + continue; } - p_data = p_apic->picture().data(); - i_data = p_apic->picture().size(); + const ByteVector picture = p_apic->picture(); + const char *p_data = picture.data(); + const unsigned i_data = picture.size(); - msg_Dbg( p_demux, "Found embedded art: %s (%s) is %i bytes", + msg_Dbg( p_demux_meta, "Found embedded art: %s (%s) is %u bytes", psz_name, psz_mime, i_data ); p_attachment = vlc_input_attachment_New( psz_name, psz_mime, psz_description, p_data, i_data ); - TAB_APPEND_CAST( (input_attachment_t**), - p_demux_meta->i_attachments, p_demux_meta->attachments, - p_attachment ); + if( p_attachment ) + TAB_APPEND_CAST( (input_attachment_t**), + p_demux_meta->i_attachments, p_demux_meta->attachments, + p_attachment ); + free( psz_description ); if( pi_cover_score[p_apic->type()] > i_score ) { @@ -240,7 +261,7 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t* char *psz_url; if( asprintf( &psz_url, "attachment://%s", p_attachment->psz_name ) == -1 ) - break; + continue; vlc_meta_SetArtURL( p_meta, psz_url ); free( psz_url ); } @@ -270,23 +291,23 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_t* p_demux, demux_met StringList mime_list = tag->fieldListMap()[ "COVERARTMIME" ]; StringList art_list = tag->fieldListMap()[ "COVERART" ]; - /* we support only one cover in ogg/vorbis */ - if( mime_list.size() != 1 || art_list.size() != 1 ) + // We get only the first covert art + if( mime_list.size() > 1 || art_list.size() > 1 ) + msg_Warn( p_demux_meta, "Found %i embedded arts, so using only the first one", + art_list.size() ); + else if( mime_list.size() == 0 || art_list.size() == 0 ) return; input_attachment_t *p_attachment; - const char *psz_name, *psz_mime, *psz_description; - uint8_t *p_data; - int i_data; - - psz_name = "cover"; - psz_mime = mime_list[0].toCString(true); - psz_description = "cover"; + const char* psz_name = "cover"; + const char* psz_mime = mime_list[0].toCString(true); + const char* psz_description = "cover"; - i_data = vlc_b64_decode_binary( &p_data, art_list[0].toCString(true) ); + uint8_t *p_data; + int i_data = vlc_b64_decode_binary( &p_data, art_list[0].toCString(true) ); - msg_Dbg( p_demux, "Found embedded art: %s (%s) is %i bytes", + msg_Dbg( p_demux_meta, "Found embedded art: %s (%s) is %i bytes", psz_name, psz_mime, i_data ); TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments ); @@ -301,7 +322,28 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_t* p_demux, demux_met vlc_meta_SetArtURL( p_meta, "attachment://cover" ); } +#ifdef TAGLIB_WITH_MP4 +static void ReadMetaFromMP4( MP4::Tag* tag, demux_t *p_demux, demux_meta_t *p_demux_meta, vlc_meta_t* p_meta ) +{ + if( tag->itemListMap().contains("covr") ) + { + MP4::CoverArtList list = tag->itemListMap()["covr"].toCoverArtList(); + const char *psz_format = list[0].format() == MP4::CoverArt::PNG ? "image/png" : "image/jpeg"; + msg_Dbg( p_demux_meta, "Found embedded art (%s) is %i bytes", + psz_format, list[0].data().size() ); + + TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments ); + input_attachment_t *p_attachment = + vlc_input_attachment_New( "cover", psz_format, "cover", + list[0].data().data(), list[0].data().size() ); + TAB_APPEND_CAST( (input_attachment_t**), + p_demux_meta->i_attachments, p_demux_meta->attachments, + p_attachment ); + vlc_meta_SetArtURL( p_meta, "attachment://cover" ); + } +} +#endif /** * Get the tags from the file using TagLib @@ -310,17 +352,33 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_t* p_demux, demux_met */ static int ReadMeta( vlc_object_t* p_this) { - demux_t* p_demux = (demux_t*)p_this; - demux_meta_t* p_demux_meta = (demux_meta_t*)p_demux->p_private; + demux_meta_t* p_demux_meta = (demux_meta_t *)p_this; + demux_t* p_demux = p_demux_meta->p_demux; vlc_meta_t* p_meta; - TagLib::FileRef f; + FileRef f; + char *psz_path = decode_URI_duplicate( p_demux->psz_path ); p_demux_meta->p_meta = NULL; - const char* local_name = ToLocale( p_demux->psz_path ); + if( !psz_path ) + return VLC_ENOMEM; + if( strncmp( p_demux->psz_access, "file", strlen("file") ) ) + return VLC_EGENERIC; + + +#if defined(WIN32) || defined (UNDER_CE) + wchar_t wpath[MAX_PATH + 1]; + if( !MultiByteToWideChar( CP_UTF8, 0, psz_path, -1, wpath, MAX_PATH) ) + return VLC_EGENERIC; + wpath[MAX_PATH] = L'\0'; + f = FileRef( wpath ); +#else + const char* local_name = ToLocale( psz_path ); if( !local_name ) return VLC_EGENERIC; f = FileRef( local_name ); LocaleFree( local_name ); +#endif + free( psz_path ); if( f.isNull() ) return VLC_EGENERIC; @@ -352,7 +410,7 @@ static int ReadMeta( vlc_object_t* p_this) SET( comment, Description ); SET( genre, Genre ); SETINT( year, Date ); - SETINT( track, Tracknum ); + SETINT( track, TrackNum ); #undef SETINT #undef SET @@ -366,6 +424,13 @@ static int ReadMeta( vlc_object_t* p_this) else if( flac->xiphComment() ) ReadMetaFromXiph( flac->xiphComment(), p_demux, p_demux_meta, p_meta ); } +#ifdef TAGLIB_WITH_MP4 + else if( MP4::File *mp4 = dynamic_cast(f.file()) ) + { + if( mp4->tag() ) + ReadMetaFromMP4( mp4->tag(), p_demux, p_demux_meta, p_meta ); + } +#endif else if( MPC::File* mpc = dynamic_cast(f.file()) ) { if( mpc->APETag() ) @@ -387,6 +452,15 @@ static int ReadMeta( vlc_object_t* p_this) else if( Ogg::Vorbis::File* ogg_vorbis = dynamic_cast(f.file()) ) ReadMetaFromXiph( ogg_vorbis->tag(), p_demux, p_demux_meta, p_meta ); } +#ifdef TAGLIB_WITH_ASF + else if( RIFF::File* riff = dynamic_cast(f.file()) ) + { + if( RIFF::AIFF::File* riff_aiff = dynamic_cast(f.file()) ) + ReadMetaFromId3v2( riff_aiff->tag(), p_demux, p_demux_meta, p_meta ); + else if( RIFF::WAV::File* riff_wav = dynamic_cast(f.file()) ) + ReadMetaFromId3v2( riff_wav->tag(), p_demux, p_demux_meta, p_meta ); + } +#endif else if( TrueAudio::File* trueaudio = dynamic_cast(f.file()) ) { if( trueaudio->ID3v2Tag() ) @@ -494,9 +568,9 @@ static void WriteMetaToXiph( Ogg::XiphComment* tag, input_item_t* p_item ) static int WriteMeta( vlc_object_t *p_this ) { - playlist_t *p_playlist = (playlist_t *)p_this; - meta_export_t *p_export = (meta_export_t *)p_playlist->p_private; + meta_export_t *p_export = (meta_export_t *)p_this; input_item_t *p_item = p_export->p_item; + FileRef f; if( !p_item ) { @@ -504,11 +578,24 @@ static int WriteMeta( vlc_object_t *p_this ) return VLC_EGENERIC; } - FileRef f( p_export->psz_file ); +#if defined(WIN32) || defined (UNDER_CE) + wchar_t wpath[MAX_PATH + 1]; + if( !MultiByteToWideChar( CP_UTF8, 0, p_export->psz_file, -1, wpath, MAX_PATH) ) + return VLC_EGENERIC; + wpath[MAX_PATH] = L'\0'; + f = FileRef( wpath ); +#else + const char* local_name = ToLocale( p_export->psz_file ); + if( !local_name ) + return VLC_EGENERIC; + f = FileRef( local_name ); + LocaleFree( local_name ); +#endif + if( f.isNull() || !f.tag() || f.file()->readOnly() ) { - msg_Err( p_this, "File %s can't be opened for tag writing\n", - p_export->psz_file ); + msg_Err( p_this, "File %s can't be opened for tag writing", + p_export->psz_file ); return VLC_EGENERIC; } @@ -518,36 +605,22 @@ static int WriteMeta( vlc_object_t *p_this ) char *psz_meta; -#define SET( a, b ) \ - if( b ) \ - { \ - String* psz_tmp = new String( b, String::UTF8 ); \ - p_tag->set##a( *psz_tmp ); \ - delete psz_tmp; \ - } +#define SET( a, b ) \ + psz_meta = input_item_Get ## a( p_item ); \ + if( psz_meta ) \ + { \ + String tmp( psz_meta, String::UTF8 ); \ + p_tag->set##b( tmp ); \ + } \ + free( psz_meta ); // Saving all common fields // If the title is empty, use the name - psz_meta = input_item_GetTitle( p_item ); - if( !psz_meta ) psz_meta = input_item_GetName( p_item ); - SET( Title, psz_meta ); - free( psz_meta ); - - psz_meta = input_item_GetArtist( p_item ); - SET( Artist, psz_meta ); - free( psz_meta ); - - psz_meta = input_item_GetAlbum( p_item ); - SET( Album, psz_meta ); - free( psz_meta ); - - psz_meta = input_item_GetDescription( p_item ); - SET( Comment, psz_meta ); - free( psz_meta ); - - psz_meta = input_item_GetGenre( p_item ); - SET( Genre, psz_meta ); - free( psz_meta ); + SET( TitleFbName, Title ); + SET( Artist, Artist ); + SET( Album, Album ); + SET( Description, Comment ); + SET( Genre, Genre ); #undef SET @@ -589,6 +662,15 @@ static int WriteMeta( vlc_object_t *p_this ) else if( Ogg::Vorbis::File* ogg_vorbis = dynamic_cast(f.file()) ) WriteMetaToXiph( ogg_vorbis->tag(), p_item ); } +#ifdef TAGLIB_WITH_ASF + else if( RIFF::File* riff = dynamic_cast(f.file()) ) + { + if( RIFF::AIFF::File* riff_aiff = dynamic_cast(f.file()) ) + WriteMetaToId3v2( riff_aiff->tag(), p_item ); + else if( RIFF::WAV::File* riff_wav = dynamic_cast(f.file()) ) + WriteMetaToId3v2( riff_wav->tag(), p_item ); + } +#endif else if( TrueAudio::File* trueaudio = dynamic_cast(f.file()) ) { if( trueaudio->ID3v2Tag() ) @@ -606,13 +688,3 @@ static int WriteMeta( vlc_object_t *p_this ) return VLC_SUCCESS; } - - -static int DownloadArt( vlc_object_t *p_this ) -{ - /* We need to be passed the file name - * Fetch the thing from the file, save it to the cache folder - */ - return VLC_EGENERIC; -} -