X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fmisc%2Fgnutls.c;h=622807bdfd7e7d640359497dff78b67a7a9a7ff6;hb=de587c237065de4696d9d035d0504cdf34990d87;hp=f20e5934805812491b4a01abcca9f08f9d3c2fb8;hpb=aaaea383ca9188d7b138f7bb81d26859b7196234;p=vlc diff --git a/modules/misc/gnutls.c b/modules/misc/gnutls.c index f20e593480..622807bdfd 100644 --- a/modules/misc/gnutls.c +++ b/modules/misc/gnutls.c @@ -25,8 +25,12 @@ * Preamble *****************************************************************************/ -#include -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include +#include #include #include @@ -37,37 +41,42 @@ #endif #ifdef HAVE_SYS_STAT_H # include -# ifdef HAVE_UNISTD_H -# include -# endif #endif +#ifdef WIN32 +# include +#else +# include +#endif +# include -#include "vlc_tls.h" +#include #include +#include #include #include #include -#define DH_BITS 1024 -#define CACHE_EXPIRATION 3600 +#include + +#define CACHE_TIMEOUT 3600 #define CACHE_SIZE 64 +#include "dhparams.h" + +#include + /***************************************************************************** * Module descriptor *****************************************************************************/ -static int Open ( vlc_object_t * ); -static void Close( vlc_object_t * ); +static int OpenClient (vlc_object_t *); +static void CloseClient (vlc_object_t *); +static int OpenServer (vlc_object_t *); +static void CloseServer (vlc_object_t *); -#define DH_BITS_TEXT N_("Diffie-Hellman prime bits") -#define DH_BITS_LONGTEXT N_( \ - "This allows you to modify the Diffie-Hellman prime's number of bits, " \ - "used for TLS or SSL-based server-side encryption. This is generally " \ - "not needed." ) - -#define CACHE_EXPIRATION_TEXT N_("Expiration time for resumed TLS sessions") -#define CACHE_EXPIRATION_LONGTEXT N_( \ +#define CACHE_TIMEOUT_TEXT N_("Expiration time for resumed TLS sessions") +#define CACHE_TIMEOUT_LONGTEXT N_( \ "It is possible to cache the resumed TLS sessions. This is the expiration "\ "time of the sessions stored in this cache, in seconds." ) @@ -76,78 +85,76 @@ static void Close( vlc_object_t * ); "This is the maximum number of resumed TLS sessions that " \ "the cache will hold." ) -#define CHECK_CERT_TEXT N_("Check TLS/SSL server certificate validity") -#define CHECK_CERT_LONGTEXT N_( \ - "This ensures that the server certificate is valid " \ - "(i.e. signed by an approved Certification Authority)." ) - -#define CHECK_HOSTNAME_TEXT N_("Check TLS/SSL server hostname in certificate") -#define CHECK_HOSTNAME_LONGTEXT N_( \ - "This ensures that the server hostname in certificate matches the " \ - "requested host name." ) - vlc_module_begin(); set_shortname( "GnuTLS" ); - set_description( _("GnuTLS TLS encryption layer") ); - set_capability( "tls", 1 ); - set_callbacks( Open, Close ); + set_description( N_("GnuTLS transport layer security") ); + set_capability( "tls client", 1 ); + set_callbacks( OpenClient, CloseClient ); set_category( CAT_ADVANCED ); set_subcategory( SUBCAT_ADVANCED_MISC ); - add_bool( "tls-check-cert", VLC_TRUE, NULL, CHECK_CERT_TEXT, - CHECK_CERT_LONGTEXT, VLC_FALSE ); - add_bool( "tls-check-hostname", VLC_TRUE, NULL, CHECK_HOSTNAME_TEXT, - CHECK_HOSTNAME_LONGTEXT, VLC_FALSE ); - - add_integer( "gnutls-dh-bits", DH_BITS, NULL, DH_BITS_TEXT, - DH_BITS_LONGTEXT, VLC_TRUE ); - add_integer( "gnutls-cache-expiration", CACHE_EXPIRATION, NULL, - CACHE_EXPIRATION_TEXT, CACHE_EXPIRATION_LONGTEXT, VLC_TRUE ); - add_integer( "gnutls-cache-size", CACHE_SIZE, NULL, CACHE_SIZE_TEXT, - CACHE_SIZE_LONGTEXT, VLC_TRUE ); + add_obsolete_bool( "tls-check-cert" ); + add_obsolete_bool( "tls-check-hostname" ); + + add_submodule(); + set_description( N_("GnuTLS server") ); + set_capability( "tls server", 1 ); + set_category( CAT_ADVANCED ); + set_subcategory( SUBCAT_ADVANCED_MISC ); + set_callbacks( OpenServer, CloseServer ); + + add_obsolete_integer( "gnutls-dh-bits" ); + add_integer( "gnutls-cache-timeout", CACHE_TIMEOUT, NULL, + CACHE_TIMEOUT_TEXT, CACHE_TIMEOUT_LONGTEXT, true ); + add_integer( "gnutls-cache-size", CACHE_SIZE, NULL, CACHE_SIZE_TEXT, + CACHE_SIZE_LONGTEXT, true ); vlc_module_end(); - -#define MAX_SESSION_ID 32 -#define MAX_SESSION_DATA 1024 - -typedef struct saved_session_t +/** + * Initializes GnuTLS with proper locking. + * @return VLC_SUCCESS on success, a VLC error code otherwise. + */ +static int gnutls_Init (vlc_object_t *p_this) { - char id[MAX_SESSION_ID]; - char data[MAX_SESSION_DATA]; + int ret = VLC_EGENERIC; - unsigned i_idlen; - unsigned i_datalen; -} saved_session_t; + vlc_gcrypt_init (); /* GnuTLS depends on gcrypt */ + vlc_mutex_t *lock = var_AcquireMutex ("gnutls_mutex"); + if (gnutls_global_init ()) + { + msg_Err (p_this, "cannot initialize GnuTLS"); + goto error; + } -typedef struct tls_server_sys_t -{ - gnutls_certificate_credentials x509_cred; - gnutls_dh_params dh_params; + const char *psz_version = gnutls_check_version ("1.3.3"); + if (psz_version == NULL) + { + msg_Err (p_this, "unsupported GnuTLS version"); + gnutls_global_deinit (); + goto error; + } - struct saved_session_t *p_cache; - struct saved_session_t *p_store; - int i_cache_size; - vlc_mutex_t cache_lock; + msg_Dbg (p_this, "GnuTLS v%s initialized", psz_version); + ret = VLC_SUCCESS; - int (*pf_handshake2)( tls_session_t * ); -} tls_server_sys_t; +error: + vlc_mutex_unlock (lock); + return ret; +} -typedef struct tls_session_sys_t +/** + * Deinitializes GnuTLS. + */ +static void gnutls_Deinit (vlc_object_t *p_this) { - gnutls_session session; - char *psz_hostname; - vlc_bool_t b_handshaked; -} tls_session_sys_t; - + vlc_mutex_t *lock = var_AcquireMutex( "gnutls_mutex" ); -typedef struct tls_client_sys_t -{ - struct tls_session_sys_t session; - gnutls_certificate_credentials x509_cred; -} tls_client_sys_t; + gnutls_global_deinit (); + msg_Dbg (p_this, "GnuTLS deinitialized"); + vlc_mutex_unlock (lock); +} static int gnutls_Error (vlc_object_t *obj, int val) @@ -155,25 +162,44 @@ static int gnutls_Error (vlc_object_t *obj, int val) switch (val) { case GNUTLS_E_AGAIN: +#ifndef WIN32 errno = EAGAIN; break; +#endif + /* WinSock does not return EAGAIN, return EINTR instead */ case GNUTLS_E_INTERRUPTED: +#ifdef WIN32 + WSASetLastError (WSAEINTR); +#else errno = EINTR; +#endif break; default: msg_Err (obj, "%s", gnutls_strerror (val)); -#ifdef DEBUG +#ifndef NDEBUG if (!gnutls_error_is_fatal (val)) msg_Err (obj, "Error above should be handled"); #endif +#ifdef WIN32 + WSASetLastError (WSAECONNRESET); +#else errno = ECONNRESET; +#endif } return -1; } +struct tls_session_sys_t +{ + gnutls_session_t session; + char *psz_hostname; + bool b_handshaked; +}; + + /** * Sends data through a TLS session. */ @@ -206,23 +232,19 @@ gnutls_Recv( void *p_session, void *buf, int i_length ) } -/***************************************************************************** - * tls_Session(Continue)?Handshake: - ***************************************************************************** - * Establishes TLS session with a peer through socket . - * Returns -1 on error (you need not and must not call tls_SessionClose) - * 0 on succesful handshake completion, 1 if more would-be blocking recv is - * needed, 2 if more would-be blocking send is required. - *****************************************************************************/ +/** + * Starts or continues the TLS handshake. + * + * @return -1 on fatal error, 0 on succesful handshake completion, + * 1 if more would-be blocking recv is needed, + * 2 if more would-be blocking send is required. + */ static int -gnutls_ContinueHandshake( tls_session_t *p_session) +gnutls_ContinueHandshake (tls_session_t *p_session) { - tls_session_sys_t *p_sys; + tls_session_sys_t *p_sys = p_session->p_sys; int val; - p_sys = (tls_session_sys_t *)(p_session->p_sys); - - /* TODO: handle fatal error */ #ifdef WIN32 WSASetLastError( 0 ); #endif @@ -237,11 +259,10 @@ gnutls_ContinueHandshake( tls_session_t *p_session) #endif msg_Err( p_session, "TLS handshake error: %s", gnutls_strerror( val ) ); - p_session->pf_close( p_session ); return -1; } - p_sys->b_handshaked = VLC_TRUE; + p_sys->b_handshaked = true; return 0; } @@ -285,7 +306,7 @@ gnutls_HandshakeAndValidate( tls_session_t *session ) { msg_Err( session, "Certificate verification failed: %s", gnutls_strerror( val ) ); - goto error; + return -1; } if( status ) @@ -295,7 +316,7 @@ gnutls_HandshakeAndValidate( tls_session_t *session ) { if( status & e->flag ) { - msg_Err( session, e->msg ); + msg_Err( session, "%s", e->msg ); status &= ~e->flag; } } @@ -304,24 +325,24 @@ gnutls_HandshakeAndValidate( tls_session_t *session ) msg_Err( session, "unknown certificate error (you found a bug in VLC)" ); - goto error; + return -1; } /* certificate (host)name verification */ - const gnutls_datum *data = gnutls_certificate_get_peers( p_sys->session, - &(size_t){ 0 } ); + const gnutls_datum_t *data; + data = gnutls_certificate_get_peers (p_sys->session, &(unsigned){0}); if( data == NULL ) { msg_Err( session, "Peer certificate not available" ); - goto error; + return -1; } - gnutls_x509_crt cert; + gnutls_x509_crt_t cert; val = gnutls_x509_crt_init( &cert ); if( val ) { msg_Err( session, "x509 fatal error: %s", gnutls_strerror( val ) ); - goto error; + return -1; } val = gnutls_x509_crt_import( cert, data, GNUTLS_X509_FMT_DER ); @@ -329,108 +350,50 @@ gnutls_HandshakeAndValidate( tls_session_t *session ) { msg_Err( session, "Certificate import error: %s", gnutls_strerror( val ) ); - gnutls_x509_crt_deinit( cert ); - goto crt_error; + goto error; } - if( p_sys->psz_hostname != NULL ) + assert( p_sys->psz_hostname != NULL ); + if ( !gnutls_x509_crt_check_hostname( cert, p_sys->psz_hostname ) ) { - if ( !gnutls_x509_crt_check_hostname( cert, p_sys->psz_hostname ) ) - { - msg_Err( session, "Certificate does not match \"%s\"", - p_sys->psz_hostname ); - goto crt_error; - } + msg_Err( session, "Certificate does not match \"%s\"", + p_sys->psz_hostname ); + goto error; } - else - msg_Warn( session, "Certificate and hostname were not verified" ); if( gnutls_x509_crt_get_expiration_time( cert ) < time( NULL ) ) { msg_Err( session, "Certificate expired" ); - goto crt_error; + goto error; } if( gnutls_x509_crt_get_activation_time( cert ) > time ( NULL ) ) { msg_Err( session, "Certificate not yet valid" ); - goto crt_error; + goto error; } gnutls_x509_crt_deinit( cert ); msg_Dbg( session, "TLS/x509 certificate verified" ); return 0; -crt_error: - gnutls_x509_crt_deinit( cert ); error: - session->pf_close( session ); + gnutls_x509_crt_deinit( cert ); return -1; } /** - * Starts negociation of a TLS session. + * Sets the operating system file descriptor backend for the TLS sesison. * * @param fd stream socket already connected with the peer. - * @param psz_hostname if not NULL, hostname to mention as a Server Name. - * - * @return -1 on error (you need not and must not call tls_SessionClose), - * 0 on succesful handshake completion, 1 if more would-be blocking recv is - * needed, 2 if more would-be blocking send is required. - */ -static int -gnutls_BeginHandshake( tls_session_t *p_session, int fd, - const char *psz_hostname ) -{ - tls_session_sys_t *p_sys; - - p_sys = (tls_session_sys_t *)(p_session->p_sys); - - gnutls_transport_set_ptr (p_sys->session, (gnutls_transport_ptr)(intptr_t)fd); - - if( psz_hostname != NULL ) - { - gnutls_server_name_set( p_sys->session, GNUTLS_NAME_DNS, psz_hostname, - strlen( psz_hostname ) ); - if (var_CreateGetBool (p_session, "tls-check-hostname")) - { - p_sys->psz_hostname = strdup( psz_hostname ); - if( p_sys->psz_hostname == NULL ) - { - p_session->pf_close( p_session ); - return -1; - } - } - } - - return p_session->pf_handshake2( p_session ); -} - -/** - * Terminates TLS session and releases session data. - * You still have to close the socket yourself. */ static void -gnutls_SessionClose( tls_session_t *p_session ) +gnutls_SetFD (tls_session_t *p_session, int fd) { - tls_session_sys_t *p_sys; - - p_sys = (tls_session_sys_t *)(p_session->p_sys); - - if( p_sys->b_handshaked == VLC_TRUE ) - gnutls_bye( p_sys->session, GNUTLS_SHUT_WR ); - gnutls_deinit( p_sys->session ); - - if( p_sys->psz_hostname != NULL ) - free( p_sys->psz_hostname ); - - vlc_object_detach( p_session ); - vlc_object_destroy( p_session ); - - free( p_sys ); + gnutls_transport_set_ptr (p_session->p_sys->session, + (gnutls_transport_ptr_t)(intptr_t)fd); } - typedef int (*tls_prio_func) (gnutls_session_t, const int *); static int @@ -535,30 +498,16 @@ gnutls_SessionPrioritize (vlc_object_t *obj, gnutls_session_t session) } -static void -gnutls_ClientDelete( tls_session_t *p_session ) -{ - /* On the client-side, credentials are re-allocated per session */ - gnutls_certificate_credentials x509_cred = - ((tls_client_sys_t *)(p_session->p_sys))->x509_cred; - - gnutls_SessionClose( p_session ); - - /* credentials must be free'd *after* gnutls_deinit() */ - gnutls_certificate_free_credentials( x509_cred ); -} - - static int gnutls_Addx509File( vlc_object_t *p_this, - gnutls_certificate_credentials cred, - const char *psz_path, vlc_bool_t b_priv ); + gnutls_certificate_credentials_t cred, + const char *psz_path, bool b_priv ); static int gnutls_Addx509Directory( vlc_object_t *p_this, - gnutls_certificate_credentials cred, + gnutls_certificate_credentials_t cred, const char *psz_dirname, - vlc_bool_t b_priv ) + bool b_priv ) { DIR* dir; @@ -568,9 +517,16 @@ gnutls_Addx509Directory( vlc_object_t *p_this, dir = utf8_opendir( psz_dirname ); if( dir == NULL ) { - msg_Warn( p_this, "cannot open directory (%s): %s", psz_dirname, - strerror( errno ) ); - return VLC_EGENERIC; + if (errno != ENOENT) + { + msg_Err (p_this, "cannot open directory (%s): %m", psz_dirname); + return VLC_EGENERIC; + } + + msg_Dbg (p_this, "creating empty certificate directory: %s", + psz_dirname); + utf8_mkdir (psz_dirname, b_priv ? 0700 : 0755); + return VLC_SUCCESS; } #ifdef S_ISLNK else @@ -617,122 +573,131 @@ gnutls_Addx509Directory( vlc_object_t *p_this, static int gnutls_Addx509File( vlc_object_t *p_this, gnutls_certificate_credentials cred, - const char *psz_path, vlc_bool_t b_priv ) + const char *psz_path, bool b_priv ) { struct stat st; - if( utf8_stat( psz_path, &st ) == 0 ) + int fd = utf8_open (psz_path, O_RDONLY, 0); + if (fd == -1) + goto error; + + block_t *block = block_File (fd); + if (block != NULL) { - if( S_ISREG( st.st_mode ) ) - { - char *psz_localname = ToLocale( psz_path ); - int i = b_priv - ? gnutls_certificate_set_x509_key_file( cred, - psz_localname, psz_localname, GNUTLS_X509_FMT_PEM ) - : gnutls_certificate_set_x509_trust_file( cred, - psz_localname, GNUTLS_X509_FMT_PEM ); - LocaleFree( psz_localname ); - - if( i < 0 ) - { - msg_Warn( p_this, "cannot add x509 credentials (%s): %s", - psz_path, gnutls_strerror( i ) ); - return VLC_EGENERIC; - } - else - { - msg_Dbg( p_this, "added x509 credentials (%s)", - psz_path ); - return VLC_SUCCESS; - } - } - else if( S_ISDIR( st.st_mode ) ) + close (fd); + + gnutls_datum data = { + .data = block->p_buffer, + .size = block->i_buffer, + }; + int res = b_priv + ? gnutls_certificate_set_x509_key_mem (cred, &data, &data, + GNUTLS_X509_FMT_PEM) + : gnutls_certificate_set_x509_trust_mem (cred, &data, + GNUTLS_X509_FMT_PEM); + block_Release (block); + + if (res < 0) { - msg_Dbg( p_this, - "looking recursively for x509 credentials in %s", - psz_path ); - return gnutls_Addx509Directory( p_this, cred, psz_path, b_priv); + msg_Warn (p_this, "cannot add x509 credentials (%s): %s", + psz_path, gnutls_strerror (res)); + return VLC_EGENERIC; } + msg_Dbg (p_this, "added x509 credentials (%s)", psz_path); + return VLC_SUCCESS; } - else - msg_Warn( p_this, "cannot add x509 credentials (%s): %s", - psz_path, strerror( errno ) ); + + if (!fstat (fd, &st) && S_ISDIR (st.st_mode)) + { + close (fd); + msg_Dbg (p_this, "looking recursively for x509 credentials in %s", + psz_path); + return gnutls_Addx509Directory (p_this, cred, psz_path, b_priv); + } + +error: + msg_Warn (p_this, "cannot add x509 credentials (%s): %m", psz_path); + if (fd != -1) + close (fd); return VLC_EGENERIC; } +/** TLS client session data */ +typedef struct tls_client_sys_t +{ + struct tls_session_sys_t session; + gnutls_certificate_credentials_t x509_cred; +} tls_client_sys_t; + + /** * Initializes a client-side TLS session. */ -static tls_session_t * -gnutls_ClientCreate( tls_t *p_tls ) +static int OpenClient (vlc_object_t *obj) { - tls_session_t *p_session = NULL; - tls_client_sys_t *p_sys = NULL; + tls_session_t *p_session = (tls_session_t *)obj; int i_val; - p_sys = (tls_client_sys_t *)malloc( sizeof(struct tls_client_sys_t) ); - if( p_sys == NULL ) - return NULL; + if (gnutls_Init (obj)) + return VLC_EGENERIC; - p_session = (struct tls_session_t *)vlc_object_create ( p_tls, sizeof(struct tls_session_t) ); - if( p_session == NULL ) + tls_client_sys_t *p_sys = malloc (sizeof (*p_sys)); + if (p_sys == NULL) { - free( p_sys ); - return NULL; + gnutls_Deinit (obj); + return VLC_ENOMEM; } - p_session->p_sys = p_sys; + p_session->p_sys = &p_sys->session; p_session->sock.p_sys = p_session; p_session->sock.pf_send = gnutls_Send; p_session->sock.pf_recv = gnutls_Recv; - p_session->pf_handshake = gnutls_BeginHandshake; - p_session->pf_close = gnutls_ClientDelete; + p_session->pf_set_fd = gnutls_SetFD; - p_sys->session.b_handshaked = VLC_FALSE; - p_sys->session.psz_hostname = NULL; + p_sys->session.b_handshaked = false; - vlc_object_attach( p_session, p_tls ); - - const char *homedir = p_tls->p_libvlc->psz_homedir, - *datadir = config_GetDataDir ((vlc_object_t *)p_session); - size_t l1 = strlen (homedir), l2 = strlen (datadir); - char path[((l1 > l2) ? l1 : l2) + sizeof ("/"CONFIG_DIR"/ssl/private")]; - // > sizeof ("/"CONFIG_DIR"/ssl/certs") - // > sizeof ("/ca-certificates.crt") - - i_val = gnutls_certificate_allocate_credentials( &p_sys->x509_cred ); - if( i_val != 0 ) + i_val = gnutls_certificate_allocate_credentials (&p_sys->x509_cred); + if (i_val != 0) { - msg_Err( p_tls, "cannot allocate X509 credentials: %s", - gnutls_strerror( i_val ) ); + msg_Err (obj, "cannot allocate X509 credentials: %s", + gnutls_strerror (i_val)); goto error; } - if (var_CreateGetBool (p_tls, "tls-check-cert")) + char *userdir = config_GetUserDataDir (); + if (userdir != NULL) { - sprintf (path, "%s/"CONFIG_DIR"/ssl/certs", homedir); - gnutls_Addx509Directory ((vlc_object_t *)p_session, - p_sys->x509_cred, path, VLC_FALSE); - - sprintf (path, "%s/ca-certificates.crt", datadir); - gnutls_Addx509File ((vlc_object_t *)p_session, - p_sys->x509_cred, path, VLC_FALSE); - p_session->pf_handshake2 = gnutls_HandshakeAndValidate; + char path[strlen (userdir) + sizeof ("/ssl/private")]; + sprintf (path, "%s/ssl", userdir); + utf8_mkdir (path, 0755); + + sprintf (path, "%s/ssl/certs", userdir); + gnutls_Addx509Directory (VLC_OBJECT (p_session), + p_sys->x509_cred, path, false); + sprintf (path, "%s/ssl/private", userdir); + gnutls_Addx509Directory (VLC_OBJECT (p_session), p_sys->x509_cred, + path, true); + free (userdir); } - else - p_session->pf_handshake2 = gnutls_ContinueHandshake; - sprintf (path, "%s/"CONFIG_DIR"/ssl/private", homedir); - gnutls_Addx509Directory ((vlc_object_t *)p_session, p_sys->x509_cred, - path, VLC_TRUE); + const char *confdir = config_GetConfDir (); + { + char path[strlen (confdir) + + sizeof ("/ssl/certs/ca-certificates.crt")]; + sprintf (path, "%s/ssl/certs/ca-certificates.crt", confdir); + gnutls_Addx509File (VLC_OBJECT (p_session), + p_sys->x509_cred, path, false); + } + p_session->pf_handshake = gnutls_HandshakeAndValidate; + /*p_session->pf_handshake = gnutls_ContinueHandshake;*/ - i_val = gnutls_init( &p_sys->session.session, GNUTLS_CLIENT ); - if( i_val != 0 ) + i_val = gnutls_init (&p_sys->session.session, GNUTLS_CLIENT); + if (i_val != 0) { - msg_Err( p_tls, "cannot initialize TLS session: %s", - gnutls_strerror( i_val ) ); - gnutls_certificate_free_credentials( p_sys->x509_cred ); + msg_Err (obj, "cannot initialize TLS session: %s", + gnutls_strerror (i_val)); + gnutls_certificate_free_credentials (p_sys->x509_cred); goto error; } @@ -740,34 +705,89 @@ gnutls_ClientCreate( tls_t *p_tls ) p_sys->session.session)) goto s_error; - i_val = gnutls_credentials_set( p_sys->session.session, + /* minimum DH prime bits */ + gnutls_dh_set_prime_bits (p_sys->session.session, 1024); + + i_val = gnutls_credentials_set (p_sys->session.session, GNUTLS_CRD_CERTIFICATE, - p_sys->x509_cred ); - if( i_val < 0 ) + p_sys->x509_cred); + if (i_val < 0) { - msg_Err( p_tls, "cannot set TLS session credentials: %s", - gnutls_strerror( i_val ) ); + msg_Err (obj, "cannot set TLS session credentials: %s", + gnutls_strerror (i_val)); goto s_error; } - return p_session; + char *servername = var_GetNonEmptyString (p_session, "tls-server-name"); + if (servername == NULL ) + msg_Err (p_session, "server name missing for TLS session"); -s_error: - gnutls_deinit( p_sys->session.session ); - gnutls_certificate_free_credentials( p_sys->x509_cred ); + p_sys->session.psz_hostname = servername; + gnutls_server_name_set (p_sys->session.session, GNUTLS_NAME_DNS, + servername, strlen (servername)); + return VLC_SUCCESS; + +s_error: + gnutls_deinit (p_sys->session.session); + gnutls_certificate_free_credentials (p_sys->x509_cred); error: - vlc_object_detach( p_session ); - vlc_object_destroy( p_session ); - free( p_sys ); + gnutls_Deinit (obj); + free (p_sys); + return VLC_EGENERIC; +} - return NULL; + +static void CloseClient (vlc_object_t *obj) +{ + tls_session_t *client = (tls_session_t *)obj; + tls_client_sys_t *p_sys = (tls_client_sys_t *)(client->p_sys); + + if (p_sys->session.b_handshaked == true) + gnutls_bye (p_sys->session.session, GNUTLS_SHUT_WR); + gnutls_deinit (p_sys->session.session); + /* credentials must be free'd *after* gnutls_deinit() */ + gnutls_certificate_free_credentials (p_sys->x509_cred); + + gnutls_Deinit (obj); + free (p_sys->session.psz_hostname); + free (p_sys); } +/** + * Server-side TLS + */ +struct tls_server_sys_t +{ + gnutls_certificate_credentials_t x509_cred; + gnutls_dh_params_t dh_params; + + struct saved_session_t *p_cache; + struct saved_session_t *p_store; + int i_cache_size; + vlc_mutex_t cache_lock; + + int (*pf_handshake) (tls_session_t *); +}; + + /** * TLS session resumption callbacks (server-side) */ +#define MAX_SESSION_ID 32 +#define MAX_SESSION_DATA 1024 + +typedef struct saved_session_t +{ + char id[MAX_SESSION_ID]; + char data[MAX_SESSION_DATA]; + + unsigned i_idlen; + unsigned i_datalen; +} saved_session_t; + + static int cb_store( void *p_server, gnutls_datum key, gnutls_datum data ) { tls_server_sys_t *p_sys = ((tls_server_t *)p_server)->p_sys; @@ -794,10 +814,9 @@ static int cb_store( void *p_server, gnutls_datum key, gnutls_datum data ) } -static const gnutls_datum err_datum = { NULL, 0 }; - static gnutls_datum cb_fetch( void *p_server, gnutls_datum key ) { + static const gnutls_datum_t err_datum = { NULL, 0 }; tls_server_sys_t *p_sys = ((tls_server_t *)p_server)->p_sys; saved_session_t *p_session, *p_end; @@ -811,7 +830,7 @@ static gnutls_datum cb_fetch( void *p_server, gnutls_datum key ) if( ( p_session->i_idlen == key.size ) && !memcmp( p_session->id, key.data, key.size ) ) { - gnutls_datum data; + gnutls_datum_t data; data.size = p_session->i_datalen; @@ -863,6 +882,27 @@ static int cb_delete( void *p_server, gnutls_datum key ) } +/** + * Terminates TLS session and releases session data. + * You still have to close the socket yourself. + */ +static void +gnutls_SessionClose (tls_server_t *p_server, tls_session_t *p_session) +{ + tls_session_sys_t *p_sys = p_session->p_sys; + (void)p_server; + + if( p_sys->b_handshaked == true ) + gnutls_bye( p_sys->session, GNUTLS_SHUT_WR ); + gnutls_deinit( p_sys->session ); + + vlc_object_detach( p_session ); + vlc_object_release( p_session ); + + free( p_sys ); +} + + /** * Initializes a server-side TLS session. */ @@ -871,7 +911,7 @@ gnutls_ServerSessionPrepare( tls_server_t *p_server ) { tls_session_t *p_session; tls_server_sys_t *p_server_sys; - gnutls_session session; + gnutls_session_t session; int i_val; p_session = vlc_object_create( p_server, sizeof (struct tls_session_t) ); @@ -881,22 +921,19 @@ gnutls_ServerSessionPrepare( tls_server_t *p_server ) p_session->p_sys = malloc( sizeof(struct tls_session_sys_t) ); if( p_session->p_sys == NULL ) { - vlc_object_destroy( p_session ); + vlc_object_release( p_session ); return NULL; } - vlc_object_attach( p_session, p_server ); - - p_server_sys = (tls_server_sys_t *)p_server->p_sys; + p_server_sys = p_server->p_sys; p_session->sock.p_sys = p_session; p_session->sock.pf_send = gnutls_Send; p_session->sock.pf_recv = gnutls_Recv; - p_session->pf_handshake = gnutls_BeginHandshake; - p_session->pf_handshake2 = p_server_sys->pf_handshake2; - p_session->pf_close = gnutls_SessionClose; + p_session->pf_set_fd = gnutls_SetFD; + p_session->pf_handshake = p_server_sys->pf_handshake; - ((tls_session_sys_t *)p_session->p_sys)->b_handshaked = VLC_FALSE; - ((tls_session_sys_t *)p_session->p_sys)->psz_hostname = NULL; + p_session->p_sys->b_handshaked = false; + p_session->p_sys->psz_hostname = NULL; i_val = gnutls_init( &session, GNUTLS_SERVER ); if( i_val != 0 ) @@ -906,9 +943,8 @@ gnutls_ServerSessionPrepare( tls_server_t *p_server ) goto error; } - ((tls_session_sys_t *)p_session->p_sys)->session = session; + p_session->p_sys->session = session; - i_val = gnutls_set_default_priority( session ); if (gnutls_SessionPrioritize (VLC_OBJECT (p_session), session)) { gnutls_deinit( session ); @@ -925,14 +961,11 @@ gnutls_ServerSessionPrepare( tls_server_t *p_server ) goto error; } - if( p_session->pf_handshake2 == gnutls_HandshakeAndValidate ) - gnutls_certificate_server_set_request( session, GNUTLS_CERT_REQUIRE ); - - i_val = config_GetInt (p_server, "gnutls-dh-bits"); - gnutls_dh_set_prime_bits (session, i_val); + if (p_session->pf_handshake == gnutls_HandshakeAndValidate) + gnutls_certificate_server_set_request (session, GNUTLS_CERT_REQUIRE); /* Session resumption support */ - i_val = config_GetInt (p_server, "gnutls-cache-expiration"); + i_val = config_GetInt (p_server, "gnutls-cache-timeout"); gnutls_db_set_cache_expiration (session, i_val); gnutls_db_set_retrieve_function( session, cb_fetch ); gnutls_db_set_remove_function( session, cb_delete ); @@ -944,40 +977,18 @@ gnutls_ServerSessionPrepare( tls_server_t *p_server ) error: free( p_session->p_sys ); vlc_object_detach( p_session ); - vlc_object_destroy( p_session ); + vlc_object_release( p_session ); return NULL; } -/** - * Releases data allocated with tls_ServerCreate(). - */ -static void -gnutls_ServerDelete( tls_server_t *p_server ) -{ - tls_server_sys_t *p_sys; - p_sys = (tls_server_sys_t *)p_server->p_sys; - - vlc_mutex_destroy( &p_sys->cache_lock ); - free( p_sys->p_cache ); - - vlc_object_detach( p_server ); - vlc_object_destroy( p_server ); - - /* all sessions depending on the server are now deinitialized */ - gnutls_certificate_free_credentials( p_sys->x509_cred ); - gnutls_dh_params_deinit( p_sys->dh_params ); - free( p_sys ); -} - - /** * Adds one or more certificate authorities. * * @param psz_ca_path (Unicode) path to an x509 certificates list. * * @return -1 on error, 0 on success. - *****************************************************************************/ + */ static int gnutls_ServerAddCA( tls_server_t *p_server, const char *psz_ca_path ) { @@ -1001,7 +1012,7 @@ gnutls_ServerAddCA( tls_server_t *p_server, const char *psz_ca_path ) msg_Dbg( p_server, " %d trusted CA added (%s)", val, psz_ca_path ); /* enables peer's certificate verification */ - p_sys->pf_handshake2 = gnutls_HandshakeAndValidate; + p_sys->pf_handshake = gnutls_HandshakeAndValidate; return VLC_SUCCESS; } @@ -1038,54 +1049,42 @@ gnutls_ServerAddCRL( tls_server_t *p_server, const char *psz_crl_path ) /** * Allocates a whole server's TLS credentials. - * - * @return NULL on error. */ -static tls_server_t * -gnutls_ServerCreate( tls_t *p_tls, const char *psz_cert_path, - const char *psz_key_path ) +static int OpenServer (vlc_object_t *obj) { - tls_server_t *p_server; + tls_server_t *p_server = (tls_server_t *)obj; tls_server_sys_t *p_sys; - char *psz_local_key, *psz_local_cert; int val; - msg_Dbg( p_tls, "creating TLS server" ); + if (gnutls_Init (obj)) + return VLC_EGENERIC; + + msg_Dbg (obj, "creating TLS server"); p_sys = (tls_server_sys_t *)malloc( sizeof(struct tls_server_sys_t) ); if( p_sys == NULL ) - return NULL; - - p_sys->i_cache_size = config_GetInt (p_tls, "gnutls-cache-size"); - p_sys->p_cache = (struct saved_session_t *)calloc( p_sys->i_cache_size, - sizeof( struct saved_session_t ) ); - if( p_sys->p_cache == NULL ) - { - free( p_sys ); - return NULL; - } - p_sys->p_store = p_sys->p_cache; + return VLC_ENOMEM; - p_server = vlc_object_create( p_tls, sizeof(struct tls_server_t) ); - if( p_server == NULL ) + p_sys->i_cache_size = config_GetInt (obj, "gnutls-cache-size"); + p_sys->p_cache = calloc (p_sys->i_cache_size, + sizeof (struct saved_session_t)); + if (p_sys->p_cache == NULL) { - free( p_sys->p_cache ); - free( p_sys ); - return NULL; + free (p_sys); + return VLC_ENOMEM; } - vlc_object_attach( p_server, p_tls ); - + p_sys->p_store = p_sys->p_cache; p_server->p_sys = p_sys; - p_server->pf_delete = gnutls_ServerDelete; - p_server->pf_add_CA = gnutls_ServerAddCA; + p_server->pf_add_CA = gnutls_ServerAddCA; p_server->pf_add_CRL = gnutls_ServerAddCRL; - p_server->pf_session_prepare = gnutls_ServerSessionPrepare; + p_server->pf_open = gnutls_ServerSessionPrepare; + p_server->pf_close = gnutls_SessionClose; /* No certificate validation by default */ - p_sys->pf_handshake2 = gnutls_ContinueHandshake; + p_sys->pf_handshake = gnutls_ContinueHandshake; - vlc_mutex_init( p_server, &p_sys->cache_lock ); + vlc_mutex_init( &p_sys->cache_lock ); /* Sets server's credentials */ val = gnutls_certificate_allocate_credentials( &p_sys->x509_cred ); @@ -1096,13 +1095,18 @@ gnutls_ServerCreate( tls_t *p_tls, const char *psz_cert_path, goto error; } - psz_local_cert = ToLocale( psz_cert_path ); - psz_local_key = ToLocale( psz_key_path ); - val = gnutls_certificate_set_x509_key_file( p_sys->x509_cred, + char *psz_cert_path = var_GetNonEmptyString (obj, "tls-x509-cert"); + char *psz_key_path = var_GetNonEmptyString (obj, "tls-x509-key"); + const char *psz_local_cert = ToLocale (psz_cert_path); + const char *psz_local_key = ToLocale (psz_key_path); + val = gnutls_certificate_set_x509_key_file (p_sys->x509_cred, psz_local_cert, psz_local_key, GNUTLS_X509_FMT_PEM ); - LocaleFree( psz_cert_path ); - LocaleFree( psz_key_path ); + LocaleFree (psz_local_key); + free (psz_key_path); + LocaleFree (psz_local_cert); + free (psz_cert_path); + if( val < 0 ) { msg_Err( p_server, "cannot set certificate chain or private key: %s", @@ -1112,175 +1116,51 @@ gnutls_ServerCreate( tls_t *p_tls, const char *psz_cert_path, } /* FIXME: - * - regenerate these regularly * - support other ciper suites */ - val = gnutls_dh_params_init( &p_sys->dh_params ); - if( val >= 0 ) + val = gnutls_dh_params_init (&p_sys->dh_params); + if (val >= 0) { - msg_Dbg( p_server, "computing Diffie Hellman ciphers parameters" ); - val = gnutls_dh_params_generate2( p_sys->dh_params, - config_GetInt( p_tls, "gnutls-dh-bits" ) ); + const gnutls_datum_t data = { + .data = (unsigned char *)dh_params, + .size = sizeof (dh_params) - 1, + }; + + val = gnutls_dh_params_import_pkcs3 (p_sys->dh_params, &data, + GNUTLS_X509_FMT_PEM); + if (val == 0) + gnutls_certificate_set_dh_params (p_sys->x509_cred, + p_sys->dh_params); } - if( val < 0 ) + if (val < 0) { - msg_Err( p_server, "cannot initialize DH cipher suites: %s", - gnutls_strerror( val ) ); - gnutls_certificate_free_credentials( p_sys->x509_cred ); - goto error; + msg_Err (p_server, "cannot initialize DHE cipher suites: %s", + gnutls_strerror (val)); } - msg_Dbg( p_server, "ciphers parameters computed" ); - - gnutls_certificate_set_dh_params( p_sys->x509_cred, p_sys->dh_params); - return p_server; + return VLC_SUCCESS; error: - vlc_mutex_destroy( &p_sys->cache_lock ); - vlc_object_detach( p_server ); - vlc_object_destroy( p_server ); - free( p_sys ); - return NULL; + vlc_mutex_destroy (&p_sys->cache_lock); + free (p_sys->p_cache); + free (p_sys); + return VLC_EGENERIC; } - -#ifdef LIBVLC_USE_PTHREAD -GCRY_THREAD_OPTION_PTHREAD_IMPL; -# define gcry_threads_vlc gcry_threads_pthread -#else /** - * gcrypt thread option VLC implementation + * Destroys a TLS server object. */ - -# define NEED_THREAD_CONTEXT 1 -static vlc_object_t *__p_gcry_data; - -static int gcry_vlc_mutex_init( void **p_sys ) -{ - int i_val; - vlc_mutex_t *p_lock = (vlc_mutex_t *)malloc( sizeof( vlc_mutex_t ) ); - - if( p_lock == NULL) - return ENOMEM; - - i_val = vlc_mutex_init( __p_gcry_data, p_lock ); - if( i_val ) - free( p_lock ); - else - *p_sys = p_lock; - return i_val; -} - -static int gcry_vlc_mutex_destroy( void **p_sys ) -{ - int i_val; - vlc_mutex_t *p_lock = (vlc_mutex_t *)*p_sys; - - i_val = vlc_mutex_destroy( p_lock ); - free( p_lock ); - return i_val; -} - -static int gcry_vlc_mutex_lock( void **p_sys ) -{ - return vlc_mutex_lock( (vlc_mutex_t *)*p_sys ); -} - -static int gcry_vlc_mutex_unlock( void **lock ) -{ - return vlc_mutex_unlock( (vlc_mutex_t *)*lock ); -} - -static struct gcry_thread_cbs gcry_threads_vlc = -{ - GCRY_THREAD_OPTION_USER, - NULL, - gcry_vlc_mutex_init, - gcry_vlc_mutex_destroy, - gcry_vlc_mutex_lock, - gcry_vlc_mutex_unlock -}; -#endif - - -/***************************************************************************** - * Module initialization - *****************************************************************************/ -static int -Open( vlc_object_t *p_this ) -{ - tls_t *p_tls = (tls_t *)p_this; - - vlc_value_t lock, count; - - var_Create( p_this->p_libvlc_global, "gnutls_mutex", VLC_VAR_MUTEX ); - var_Get( p_this->p_libvlc_global, "gnutls_mutex", &lock ); - vlc_mutex_lock( lock.p_address ); - - /* Initialize GnuTLS only once */ - var_Create( p_this->p_libvlc_global, "gnutls_count", VLC_VAR_INTEGER ); - var_Get( p_this->p_libvlc_global, "gnutls_count", &count); - - if( count.i_int == 0) - { -#ifdef NEED_THREAD_CONTEXT - __p_gcry_data = VLC_OBJECT( p_this->p_libvlc ); -#endif - - gcry_control (GCRYCTL_SET_THREAD_CBS, &gcry_threads_vlc); - if( gnutls_global_init( ) ) - { - msg_Warn( p_this, "cannot initialize GnuTLS" ); - vlc_mutex_unlock( lock.p_address ); - return VLC_EGENERIC; - } - - const char *psz_version = gnutls_check_version( "1.2.9" ); - if( psz_version == NULL ) - { - gnutls_global_deinit( ); - vlc_mutex_unlock( lock.p_address ); - msg_Err( p_this, "unsupported GnuTLS version" ); - return VLC_EGENERIC; - } - msg_Dbg( p_this, "GnuTLS v%s initialized", psz_version ); - } - - count.i_int++; - var_Set( p_this->p_libvlc_global, "gnutls_count", count); - vlc_mutex_unlock( lock.p_address ); - - p_tls->pf_server_create = gnutls_ServerCreate; - p_tls->pf_client_create = gnutls_ClientCreate; - return VLC_SUCCESS; -} - - -/***************************************************************************** - * Module deinitialization - *****************************************************************************/ -static void -Close( vlc_object_t *p_this ) +static void CloseServer (vlc_object_t *p_server) { - /*tls_t *p_tls = (tls_t *)p_this; - tls_sys_t *p_sys = (tls_sys_t *)(p_this->p_sys);*/ - - vlc_value_t lock, count; - - var_Create( p_this->p_libvlc_global, "gnutls_mutex", VLC_VAR_MUTEX ); - var_Get( p_this->p_libvlc_global, "gnutls_mutex", &lock ); - vlc_mutex_lock( lock.p_address ); + tls_server_sys_t *p_sys = ((tls_server_t *)p_server)->p_sys; - var_Create( p_this->p_libvlc_global, "gnutls_count", VLC_VAR_INTEGER ); - var_Get( p_this->p_libvlc_global, "gnutls_count", &count); - count.i_int--; - var_Set( p_this->p_libvlc_global, "gnutls_count", count); + vlc_mutex_destroy (&p_sys->cache_lock); + free (p_sys->p_cache); - if( count.i_int == 0 ) - { - gnutls_global_deinit( ); - msg_Dbg( p_this, "GnuTLS deinitialized" ); - } + /* all sessions depending on the server are now deinitialized */ + gnutls_certificate_free_credentials (p_sys->x509_cred); + gnutls_dh_params_deinit (p_sys->dh_params); + free (p_sys); - vlc_mutex_unlock( lock.p_address ); + gnutls_Deinit (p_server); }