X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fmux%2Fmp4.c;h=13e72fa290e2a111d82f88732defe0dd4734f7e2;hb=15643af12d9eb61eff8a8e89d8170f3d2b73d7e1;hp=53054613d5b882e1066bb3df04e1712ae5ef0f50;hpb=7dd2f1548a90c339f7e91ff469a6ad3ec9eecdd4;p=vlc diff --git a/modules/mux/mp4.c b/modules/mux/mp4.c index 53054613d5..13e72fa290 100644 --- a/modules/mux/mp4.c +++ b/modules/mux/mp4.c @@ -26,17 +26,22 @@ * Preamble *****************************************************************************/ -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include + +#include +#include #include #include -#include +#include -#ifdef HAVE_TIME_H #include -#endif -#include "iso_lang.h" -#include "vlc_meta.h" +#include +#include /***************************************************************************** * Module descriptor @@ -52,26 +57,26 @@ static void Close ( vlc_object_t * ); #define SOUT_CFG_PREFIX "sout-mp4-" -vlc_module_begin(); - set_description( _("MP4/MOV muxer") ); - set_category( CAT_SOUT ); - set_subcategory( SUBCAT_SOUT_MUX ); - set_shortname( "MP4" ); +vlc_module_begin () + set_description( N_("MP4/MOV muxer") ) + set_category( CAT_SOUT ) + set_subcategory( SUBCAT_SOUT_MUX ) + set_shortname( "MP4" ) - add_bool( SOUT_CFG_PREFIX "faststart", 1, NULL, + add_bool( SOUT_CFG_PREFIX "faststart", true, NULL, FASTSTART_TEXT, FASTSTART_LONGTEXT, - VLC_TRUE ); - set_capability( "sout mux", 5 ); - add_shortcut( "mp4" ); - add_shortcut( "mov" ); - add_shortcut( "3gp" ); - set_callbacks( Open, Close ); -vlc_module_end(); + true ) + set_capability( "sout mux", 5 ) + add_shortcut( "mp4" ) + add_shortcut( "mov" ) + add_shortcut( "3gp" ) + set_callbacks( Open, Close ) +vlc_module_end () /***************************************************************************** * Exported prototypes *****************************************************************************/ -static const char *ppsz_sout_options[] = { +static const char *const ppsz_sout_options[] = { "faststart", NULL }; @@ -111,7 +116,7 @@ typedef struct /* for later stco fix-up (fast start files) */ uint64_t i_stco_pos; - vlc_bool_t b_stco64; + bool b_stco64; /* for spu */ int64_t i_last_dts; @@ -120,10 +125,10 @@ typedef struct struct sout_mux_sys_t { - vlc_bool_t b_mov; - vlc_bool_t b_3gp; - vlc_bool_t b_64_ext; - vlc_bool_t b_fast_start; + bool b_mov; + bool b_3gp; + bool b_64_ext; + bool b_fast_start; uint64_t i_mdat_pos; uint64_t i_pos; @@ -136,7 +141,7 @@ struct sout_mux_sys_t typedef struct bo_t { - vlc_bool_t b_grow; + bool b_grow; int i_buffer_size; int i_buffer; @@ -144,7 +149,7 @@ typedef struct bo_t } bo_t; -static void bo_init ( bo_t *, int , uint8_t *, vlc_bool_t ); +static void bo_init ( bo_t *, int , uint8_t *, bool ); static void bo_add_8 ( bo_t *, uint8_t ); static void bo_add_16be ( bo_t *, uint16_t ); static void bo_add_24be ( bo_t *, uint32_t ); @@ -169,8 +174,8 @@ static block_t *bo_to_sout( sout_instance_t *p_sout, bo_t *box ); static bo_t *GetMoovBox( sout_mux_t *p_mux ); -static block_t *ConvertSUBT( sout_mux_t *, mp4_stream_t *, block_t *); -static block_t *ConvertAVC1( sout_mux_t *, mp4_stream_t *, block_t * ); +static block_t *ConvertSUBT( block_t *); +static block_t *ConvertAVC1( block_t * ); /***************************************************************************** * Open: @@ -181,7 +186,7 @@ static int Open( vlc_object_t *p_this ) sout_mux_sys_t *p_sys; bo_t *box; - msg_Dbg( p_mux, "Mp4 muxer opend" ); + msg_Dbg( p_mux, "Mp4 muxer opened" ); config_ChainParse( p_mux, SOUT_CFG_PREFIX, ppsz_sout_options, p_mux->p_cfg ); p_mux->pf_control = Control; @@ -189,6 +194,8 @@ static int Open( vlc_object_t *p_this ) p_mux->pf_delstream = DelStream; p_mux->pf_mux = Mux; p_mux->p_sys = p_sys = malloc( sizeof( sout_mux_sys_t ) ); + if( !p_sys ) + return VLC_ENOMEM; p_sys->i_pos = 0; p_sys->i_nb_streams = 0; p_sys->pp_streams = NULL; @@ -217,7 +224,7 @@ static int Open( vlc_object_t *p_this ) /* FIXME FIXME * Quicktime actually doesn't like the 64 bits extensions !!! */ - p_sys->b_64_ext = VLC_FALSE; + p_sys->b_64_ext = false; /* Now add mdat header */ box = box_new( "mdat" ); @@ -247,7 +254,7 @@ static void Close( vlc_object_t * p_this ) msg_Dbg( p_mux, "Close" ); /* Update mdat size */ - bo_init( &bo, 0, NULL, VLC_TRUE ); + bo_init( &bo, 0, NULL, true ); if( p_sys->i_pos - p_sys->i_mdat_pos >= (((uint64_t)1)<<32) ) { /* Extended size */ @@ -293,7 +300,7 @@ static void Close( vlc_object_t * p_this ) { msg_Warn( p_this, "read() not supported by access output, " "won't create a fast start file" ); - p_sys->b_fast_start = VLC_FALSE; + p_sys->b_fast_start = false; block_Release( p_buf ); break; } @@ -337,7 +344,7 @@ static void Close( vlc_object_t * p_this ) moov->i_buffer = i_moov_size; i_moov_pos = p_sys->i_mdat_pos; - p_sys->b_fast_start = VLC_FALSE; + p_sys->b_fast_start = false; } /* Write MOOV header */ @@ -362,24 +369,25 @@ static void Close( vlc_object_t * p_this ) *****************************************************************************/ static int Control( sout_mux_t *p_mux, int i_query, va_list args ) { - vlc_bool_t *pb_bool; + VLC_UNUSED(p_mux); + bool *pb_bool; - switch( i_query ) - { - case MUX_CAN_ADD_STREAM_WHILE_MUXING: - pb_bool = (vlc_bool_t*)va_arg( args, vlc_bool_t * ); - *pb_bool = VLC_FALSE; - return VLC_SUCCESS; + switch( i_query ) + { + case MUX_CAN_ADD_STREAM_WHILE_MUXING: + pb_bool = (bool*)va_arg( args, bool * ); + *pb_bool = false; + return VLC_SUCCESS; - case MUX_GET_ADD_STREAM_WAIT: - pb_bool = (vlc_bool_t*)va_arg( args, vlc_bool_t * ); - *pb_bool = VLC_TRUE; - return VLC_SUCCESS; + case MUX_GET_ADD_STREAM_WAIT: + pb_bool = (bool*)va_arg( args, bool * ); + *pb_bool = true; + return VLC_SUCCESS; - case MUX_GET_MIME: /* Not needed, as not streamable */ + case MUX_GET_MIME: /* Not needed, as not streamable */ default: return VLC_EGENERIC; - } + } } /***************************************************************************** @@ -392,22 +400,22 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input ) switch( p_input->p_fmt->i_codec ) { - case VLC_FOURCC( 'm', 'p', '4', 'a' ): - case VLC_FOURCC( 'm', 'p', '4', 'v' ): - case VLC_FOURCC( 'm', 'p', 'g', 'a' ): - case VLC_FOURCC( 'm', 'p', 'g', 'v' ): - case VLC_FOURCC( 'M', 'J', 'P', 'G' ): - case VLC_FOURCC( 'm', 'j', 'p', 'b' ): - case VLC_FOURCC( 'S', 'V', 'Q', '1' ): - case VLC_FOURCC( 'S', 'V', 'Q', '3' ): - case VLC_FOURCC( 'H', '2', '6', '3' ): - case VLC_FOURCC( 'h', '2', '6', '4' ): - case VLC_FOURCC( 's', 'a', 'm', 'r' ): - case VLC_FOURCC( 's', 'a', 'w', 'b' ): - case VLC_FOURCC( 'Y', 'V', '1', '2' ): - case VLC_FOURCC( 'Y', 'U', 'Y', '2' ): + case VLC_CODEC_MP4A: + case VLC_CODEC_MP4V: + case VLC_CODEC_MPGA: + case VLC_CODEC_MPGV: + case VLC_CODEC_MJPG: + case VLC_CODEC_MJPGB: + case VLC_CODEC_SVQ1: + case VLC_CODEC_SVQ3: + case VLC_CODEC_H263: + case VLC_CODEC_H264: + case VLC_CODEC_AMR_NB: + case VLC_CODEC_AMR_WB: + case VLC_CODEC_YV12: + case VLC_CODEC_YUYV: break; - case VLC_FOURCC( 's', 'u', 'b', 't' ): + case VLC_CODEC_SUBT: msg_Warn( p_mux, "subtitle track added like in .mov (even when creating .mp4)" ); break; default: @@ -417,6 +425,8 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input ) } p_stream = malloc( sizeof( mp4_stream_t ) ); + if( !p_stream ) + return VLC_ENOMEM; es_format_Copy( &p_stream->fmt, p_input->p_fmt ); p_stream->i_track_id = p_sys->i_nb_streams + 1; p_stream->i_length_neg = 0; @@ -440,6 +450,7 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input ) *****************************************************************************/ static int DelStream( sout_mux_t *p_mux, sout_input_t *p_input ) { + VLC_UNUSED(p_input); msg_Dbg( p_mux, "removing input" ); return VLC_SUCCESS; } @@ -447,15 +458,14 @@ static int DelStream( sout_mux_t *p_mux, sout_input_t *p_input ) static int MuxGetStream( sout_mux_t *p_mux, int *pi_stream, mtime_t *pi_dts ) { mtime_t i_dts; - int i_stream; - int i; + int i_stream, i; for( i = 0, i_dts = 0, i_stream = -1; i < p_mux->i_nb_inputs; i++ ) { block_fifo_t *p_fifo = p_mux->pp_inputs[i]->p_fifo; block_t *p_buf; - if( Block_FifoCount( p_fifo ) <= 1 ) + if( block_FifoCount( p_fifo ) <= 1 ) { if( p_mux->pp_inputs[i]->p_fmt->i_cat != SPU_ES ) { @@ -508,13 +518,13 @@ static int Mux( sout_mux_t *p_mux ) again: p_data = block_FifoGet( p_input->p_fifo ); - if( p_stream->fmt.i_codec == VLC_FOURCC( 'h', '2', '6', '4' ) ) + if( p_stream->fmt.i_codec == VLC_CODEC_H264 ) { - p_data = ConvertAVC1( p_mux, p_stream, p_data ); + p_data = ConvertAVC1( p_data ); } - else if( p_stream->fmt.i_codec == VLC_FOURCC( 's', 'u', 'b', 't' ) ) + else if( p_stream->fmt.i_codec == VLC_CODEC_SUBT ) { - p_data = ConvertSUBT( p_mux, p_stream, p_data ); + p_data = ConvertSUBT( p_data ); } if( p_data == NULL ) goto again; @@ -526,7 +536,7 @@ again: block_t *p_next = block_FifoShow( p_input->p_fifo ); int64_t i_diff = p_next->i_dts - p_data->i_dts; - if( i_diff < I64C(1000000 ) ) /* protection */ + if( i_diff < INT64_C(1000000 ) ) /* protection */ { p_data->i_length = i_diff; } @@ -590,9 +600,9 @@ again: if( p_stream->i_entry_count >= p_stream->i_entry_max - 1 ) { p_stream->i_entry_max += 1000; - p_stream->entry = - realloc( p_stream->entry, + p_stream->entry = realloc_or_free( p_stream->entry, p_stream->i_entry_max * sizeof( mp4_entry_t ) ); + assert( p_stream->entry ); } /* update */ @@ -649,7 +659,7 @@ again: /***************************************************************************** * *****************************************************************************/ -static block_t *ConvertSUBT( sout_mux_t *p_mux, mp4_stream_t *tk, block_t *p_block ) +static block_t *ConvertSUBT( block_t *p_block ) { p_block = block_Realloc( p_block, 2, p_block->i_buffer ); @@ -663,7 +673,7 @@ static block_t *ConvertSUBT( sout_mux_t *p_mux, mp4_stream_t *tk, block_t *p_blo return p_block; } -static block_t *ConvertAVC1( sout_mux_t *p_mux, mp4_stream_t *tk, block_t *p_block ) +static block_t *ConvertAVC1( block_t *p_block ) { uint8_t *last = p_block->p_buffer; /* Assume it starts with 0x00000001 */ uint8_t *dat = &p_block->p_buffer[4]; @@ -736,14 +746,14 @@ static bo_t *GetESDS( mp4_stream_t *p_stream ) i_bitrate_avg += p_stream->entry[i].i_size; if( p_stream->entry[i].i_length > 0) { - int64_t i_bitrate = I64C(8000000) * p_stream->entry[i].i_size / p_stream->entry[i].i_length; + int64_t i_bitrate = INT64_C(8000000) * p_stream->entry[i].i_size / p_stream->entry[i].i_length; if( i_bitrate > i_bitrate_max ) i_bitrate_max = i_bitrate; } } if( p_stream->i_duration > 0 ) - i_bitrate_avg = I64C(8000000) * i_bitrate_avg / p_stream->i_duration; + i_bitrate_avg = INT64_C(8000000) * i_bitrate_avg / p_stream->i_duration; else i_bitrate_avg = 0; if( i_bitrate_max <= 1 ) @@ -774,18 +784,18 @@ static bo_t *GetESDS( mp4_stream_t *p_stream ) switch( p_stream->fmt.i_codec ) { - case VLC_FOURCC( 'm', 'p', '4', 'v' ): + case VLC_CODEC_MP4V: i_object_type_indication = 0x20; break; - case VLC_FOURCC( 'm', 'p', 'g', 'v' ): + case VLC_CODEC_MPGV: /* FIXME MPEG-I=0x6b, MPEG-II = 0x60 -> 0x65 */ i_object_type_indication = 0x60; break; - case VLC_FOURCC( 'm', 'p', '4', 'a' ): + case VLC_CODEC_MP4A: /* FIXME for mpeg2-aac == 0x66->0x68 */ i_object_type_indication = 0x40; break; - case VLC_FOURCC( 'm', 'p', 'g', 'a' ): + case VLC_CODEC_MPGA: i_object_type_indication = p_stream->fmt.audio.i_rate < 32000 ? 0x69 : 0x6b; break; @@ -867,7 +877,7 @@ static bo_t *GetDamrTag( mp4_stream_t *p_stream ) bo_add_fourcc( damr, "REFC" ); bo_add_8( damr, 0 ); - if( p_stream->fmt.i_codec == VLC_FOURCC( 's', 'a', 'm', 'r' ) ) + if( p_stream->fmt.i_codec == VLC_CODEC_AMR_NB ) bo_add_16be( damr, 0x81ff ); /* Mode set (all modes for AMR_NB) */ else bo_add_16be( damr, 0x83ff ); /* Mode set (all modes for AMR_WB) */ @@ -878,7 +888,7 @@ static bo_t *GetDamrTag( mp4_stream_t *p_stream ) return damr; } -static bo_t *GetD263Tag( mp4_stream_t *p_stream ) +static bo_t *GetD263Tag( void ) { bo_t *d263; @@ -1019,8 +1029,8 @@ static bo_t *GetUdtaTag( sout_mux_t *p_mux ) { mp4_stream_t *p_stream = p_sys->pp_streams[i_track]; - if( p_stream->fmt.i_codec == VLC_FOURCC('m','p','4','v') || - p_stream->fmt.i_codec == VLC_FOURCC('m','p','4','a') ) + if( p_stream->fmt.i_codec == VLC_CODEC_MP4V || + p_stream->fmt.i_codec == VLC_CODEC_MP4A ) { bo_t *box = box_new( "\251req" ); /* String length */ @@ -1079,31 +1089,31 @@ static bo_t *GetUdtaTag( sout_mux_t *p_mux ) static bo_t *GetSounBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) { sout_mux_sys_t *p_sys = p_mux->p_sys; - vlc_bool_t b_descr = VLC_FALSE; + bool b_descr = false; bo_t *soun; char fcc[4] = " "; int i; switch( p_stream->fmt.i_codec ) { - case VLC_FOURCC('m','p','4','a'): + case VLC_CODEC_MP4A: memcpy( fcc, "mp4a", 4 ); - b_descr = VLC_TRUE; + b_descr = true; break; - case VLC_FOURCC('s','a','m','r'): - case VLC_FOURCC('s','a','w','b'): + case VLC_CODEC_AMR_NB: + case VLC_CODEC_AMR_WB: memcpy( fcc, (char*)&p_stream->fmt.i_codec, 4 ); - b_descr = VLC_TRUE; + b_descr = true; break; - case VLC_FOURCC('m','p','g','a'): + case VLC_CODEC_MPGA: if( p_sys->b_mov ) memcpy( fcc, ".mp3", 4 ); else { memcpy( fcc, "mp4a", 4 ); - b_descr = VLC_TRUE; + b_descr = true; } break; @@ -1121,7 +1131,7 @@ static bo_t *GetSounBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) /* SoundDescription */ if( p_sys->b_mov && - p_stream->fmt.i_codec == VLC_FOURCC('m','p','4','a') ) + p_stream->fmt.i_codec == VLC_CODEC_MP4A ) { bo_add_16be( soun, 1 ); // version 1; } @@ -1143,7 +1153,7 @@ static bo_t *GetSounBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) /* Extended data for SoundDescription V1 */ if( p_sys->b_mov && - p_stream->fmt.i_codec == VLC_FOURCC('m','p','4','a') ) + p_stream->fmt.i_codec == VLC_CODEC_MP4A ) { /* samples per packet */ bo_add_32be( soun, p_stream->fmt.audio.i_frame_length ); @@ -1159,11 +1169,11 @@ static bo_t *GetSounBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) bo_t *box; if( p_sys->b_mov && - p_stream->fmt.i_codec == VLC_FOURCC('m','p','4','a') ) + p_stream->fmt.i_codec == VLC_CODEC_MP4A ) { box = GetWaveTag( p_stream ); } - else if( p_stream->fmt.i_codec == VLC_FOURCC('s','a','m','r') ) + else if( p_stream->fmt.i_codec == VLC_CODEC_AMR_NB ) { box = GetDamrTag( p_stream ); } @@ -1180,7 +1190,7 @@ static bo_t *GetSounBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) return soun; } -static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) +static bo_t *GetVideBox( mp4_stream_t *p_stream ) { bo_t *vide; @@ -1189,36 +1199,36 @@ static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) switch( p_stream->fmt.i_codec ) { - case VLC_FOURCC('m','p','4','v'): - case VLC_FOURCC('m','p','g','v'): + case VLC_CODEC_MP4V: + case VLC_CODEC_MPGV: memcpy( fcc, "mp4v", 4 ); break; - case VLC_FOURCC('M','J','P','G'): + case VLC_CODEC_MJPG: memcpy( fcc, "mjpa", 4 ); break; - case VLC_FOURCC('S','V','Q','1'): + case VLC_CODEC_SVQ1: memcpy( fcc, "SVQ1", 4 ); break; - case VLC_FOURCC('S','V','Q','3'): + case VLC_CODEC_SVQ3: memcpy( fcc, "SVQ3", 4 ); break; - case VLC_FOURCC('H','2','6','3'): + case VLC_CODEC_H263: memcpy( fcc, "s263", 4 ); break; - case VLC_FOURCC('h','2','6','4'): + case VLC_CODEC_H264: memcpy( fcc, "avc1", 4 ); break; - case VLC_FOURCC('Y','V','1','2'): + case VLC_CODEC_YV12: memcpy( fcc, "yv12", 4 ); break; - case VLC_FOURCC('Y','U','Y','2'): + case VLC_CODEC_YUYV: memcpy( fcc, "yuy2", 4 ); break; @@ -1262,8 +1272,8 @@ static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) /* add an ES Descriptor */ switch( p_stream->fmt.i_codec ) { - case VLC_FOURCC('m','p','4','v'): - case VLC_FOURCC('m','p','g','v'): + case VLC_CODEC_MP4V: + case VLC_CODEC_MPGV: { bo_t *esds = GetESDS( p_stream ); @@ -1272,16 +1282,16 @@ static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) } break; - case VLC_FOURCC('H','2','6','3'): + case VLC_CODEC_H263: { - bo_t *d263 = GetD263Tag( p_stream ); + bo_t *d263 = GetD263Tag(); box_fix( d263 ); box_gather( vide, d263 ); } break; - case VLC_FOURCC('S','V','Q','3'): + case VLC_CODEC_SVQ3: { bo_t *esds = GetSVQ3Tag( p_stream ); @@ -1290,7 +1300,7 @@ static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) } break; - case VLC_FOURCC('h','2','6','4'): + case VLC_CODEC_H264: box_gather( vide, GetAvcCTag( p_stream ) ); break; @@ -1303,7 +1313,7 @@ static bo_t *GetVideBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) return vide; } -static bo_t *GetTextBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) +static bo_t *GetTextBox( void ) { bo_t *text = box_new( "text" ); @@ -1361,12 +1371,12 @@ static bo_t *GetStblBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) } else if( p_stream->fmt.i_cat == VIDEO_ES ) { - bo_t *vide = GetVideBox( p_mux, p_stream ); + bo_t *vide = GetVideBox( p_stream ); box_gather( stsd, vide ); } else if( p_stream->fmt.i_cat == SPU_ES ) { - box_gather( stsd, GetTextBox( p_mux, p_stream ) ); + box_gather( stsd, GetTextBox() ); } box_fix( stsd ); @@ -1374,13 +1384,13 @@ static bo_t *GetStblBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) if( p_sys->i_pos >= (((uint64_t)0x1) << 32) ) { /* 64 bits version */ - p_stream->b_stco64 = VLC_TRUE; + p_stream->b_stco64 = true; stco = box_full_new( "co64", 0, 0 ); } else { /* 32 bits version */ - p_stream->b_stco64 = VLC_FALSE; + p_stream->b_stco64 = false; stco = box_full_new( "stco", 0, 0 ); } bo_add_32be( stco, 0 ); // entry-count (fixed latter) @@ -1444,13 +1454,13 @@ static bo_t *GetStblBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) /* first, create quantified length */ for( i = 0, i_dts = 0, i_dts_q = 0; i < p_stream->i_entry_count; i++ ) { - int64_t i_dts_deq = i_dts_q * I64C(1000000) / (int64_t)i_timescale; + int64_t i_dts_deq = i_dts_q * INT64_C(1000000) / (int64_t)i_timescale; int64_t i_delta = p_stream->entry[i].i_length + i_dts - i_dts_deq; i_dts += p_stream->entry[i].i_length; p_stream->entry[i].i_length = - i_delta * (int64_t)i_timescale / I64C(1000000); + i_delta * (int64_t)i_timescale / INT64_C(1000000); i_dts_q += p_stream->entry[i].i_length; } @@ -1528,7 +1538,7 @@ static bo_t *GetStblBox( sout_mux_t *p_mux, mp4_stream_t *p_stream ) static int64_t get_timestamp(void); -static uint32_t mvhd_matrix[9] = +static const uint32_t mvhd_matrix[9] = { 0x10000, 0, 0, 0, 0x10000, 0, 0, 0, 0x40000000 }; static bo_t *GetMoovBox( sout_mux_t *p_mux ) @@ -1711,13 +1721,13 @@ static bo_t *GetMoovBox( sout_mux_t *p_mux ) if( p_sys->b_64_ext ) { bo_add_64be( elst, (p_stream->i_dts_start-p_sys->i_dts_start) * - i_movie_timescale / I64C(1000000) ); + i_movie_timescale / INT64_C(1000000) ); bo_add_64be( elst, -1 ); } else { bo_add_32be( elst, (p_stream->i_dts_start-p_sys->i_dts_start) * - i_movie_timescale / I64C(1000000) ); + i_movie_timescale / INT64_C(1000000) ); bo_add_32be( elst, -1 ); } bo_add_16be( elst, 1 ); @@ -1730,13 +1740,13 @@ static bo_t *GetMoovBox( sout_mux_t *p_mux ) if( p_sys->b_64_ext ) { bo_add_64be( elst, p_stream->i_duration * - i_movie_timescale / I64C(1000000) ); + i_movie_timescale / INT64_C(1000000) ); bo_add_64be( elst, 0 ); } else { bo_add_32be( elst, p_stream->i_duration * - i_movie_timescale / I64C(1000000) ); + i_movie_timescale / INT64_C(1000000) ); bo_add_32be( elst, 0 ); } bo_add_16be( elst, 1 ); @@ -1935,12 +1945,13 @@ static bo_t *GetMoovBox( sout_mux_t *p_mux ) /****************************************************************************/ static void bo_init( bo_t *p_bo, int i_size, uint8_t *p_buffer, - vlc_bool_t b_grow ) + bool b_grow ) { if( !p_buffer ) { p_bo->i_buffer_size = __MAX( i_size, 1024 ); p_bo->p_buffer = malloc( p_bo->i_buffer_size ); + assert( p_bo->p_buffer ); } else { @@ -1961,8 +1972,8 @@ static void bo_add_8( bo_t *p_bo, uint8_t i ) else if( p_bo->b_grow ) { p_bo->i_buffer_size += 1024; - p_bo->p_buffer = realloc( p_bo->p_buffer, p_bo->i_buffer_size ); - + p_bo->p_buffer = realloc_or_free( p_bo->p_buffer, p_bo->i_buffer_size ); + assert( p_bo->p_buffer ); p_bo->p_buffer[p_bo->i_buffer] = i; } @@ -2075,7 +2086,7 @@ static bo_t * box_new( const char *fcc ) if( ( box = malloc( sizeof( bo_t ) ) ) ) { - bo_init( box, 0, NULL, VLC_TRUE ); + bo_init( box, 0, NULL, true ); bo_add_32be ( box, 0 ); bo_add_fourcc( box, fcc ); @@ -2090,7 +2101,7 @@ static bo_t * box_full_new( const char *fcc, uint8_t v, uint32_t f ) if( ( box = malloc( sizeof( bo_t ) ) ) ) { - bo_init( box, 0, NULL, VLC_TRUE ); + bo_init( box, 0, NULL, true ); bo_add_32be ( box, 0 ); bo_add_fourcc( box, fcc ); @@ -2113,11 +2124,7 @@ static void box_fix( bo_t *box ) static void box_free( bo_t *box ) { - if( box->p_buffer ) - { - free( box->p_buffer ); - } - + free( box->p_buffer ); free( box ); } @@ -2129,6 +2136,7 @@ static void box_gather ( bo_t *box, bo_t *box2 ) static block_t * bo_to_sout( sout_instance_t *p_sout, bo_t *box ) { + (void)p_sout; block_t *p_buf; p_buf = block_New( p_sout, box->i_buffer ); @@ -2152,13 +2160,10 @@ static void box_send( sout_mux_t *p_mux, bo_t *box ) static int64_t get_timestamp(void) { - int64_t i_timestamp = 0; + int64_t i_timestamp = time(NULL); -#ifdef HAVE_TIME_H - i_timestamp = time(NULL); i_timestamp += 2082844800; // MOV/MP4 start date is 1/1/1904 // 208284480 is (((1970 - 1904) * 365) + 17) * 24 * 60 * 60 -#endif return i_timestamp; }