X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fvideo_filter%2Fgrain.c;h=8aff4cddf3383decdcd42f5758a91b89d4df4e29;hb=5d51dfe0711b6c1539e39fe43995875a4eff3f78;hp=f5ba969b93e29dc5ce52b1f5876fd871bff56c91;hpb=5b55ee1bb0a0212b967f8f4a33824ffc6b7c7f09;p=vlc

diff --git a/modules/video_filter/grain.c b/modules/video_filter/grain.c
index f5ba969b93..8aff4cddf3 100644
--- a/modules/video_filter/grain.c
+++ b/modules/video_filter/grain.c
@@ -29,10 +29,12 @@
 # include "config.h"
 #endif
 
-#include <vlc/vlc.h>
-#include <vlc_vout.h>
+#include <vlc_common.h>
+#include <vlc_plugin.h>
+#include <vlc_rand.h>
 
-#include "vlc_filter.h"
+#include <vlc_filter.h>
+#include "filter_picture.h"
 
 /*****************************************************************************
  * Local prototypes
@@ -44,22 +46,20 @@ static picture_t *Filter( filter_t *, picture_t * );
 
 #define FILTER_PREFIX "grain-"
 
+#define NOISE_HELP N_("add grain to image")
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
-vlc_module_begin();
-    set_description( _("Grain video filter") );
-    set_shortname( _( "Grain" ));
-    set_capability( "video filter2", 0 );
-    set_category( CAT_VIDEO );
-    set_subcategory( SUBCAT_VIDEO_VFILTER );
-
-    set_callbacks( Create, Destroy );
-vlc_module_end();
-
-static const char *ppsz_filter_options[] = {
-    NULL
-};
+vlc_module_begin ()
+    set_description( N_("Grain video filter") )
+    set_shortname( N_( "Grain" ))
+    set_help(NOISE_HELP)
+    set_capability( "video filter2", 0 )
+    set_category( CAT_VIDEO )
+    set_subcategory( SUBCAT_VIDEO_VFILTER )
+
+    set_callbacks( Create, Destroy )
+vlc_module_end ()
 
 struct filter_sys_t
 {
@@ -70,18 +70,21 @@ static int Create( vlc_object_t *p_this )
 {
     filter_t *p_filter = (filter_t *)p_this;
 
-    /* FIXME: check that chroma is YUV based */
+    switch( p_filter->fmt_in.video.i_chroma )
+    {
+        CASE_PLANAR_YUV
+            break;
+
+        default:
+            msg_Err( p_filter, "Unsupported input chroma (%4.4s)",
+                     (char*)&(p_filter->fmt_in.video.i_chroma) );
+            return VLC_EGENERIC;
+    }
 
     /* Allocate structure */
     p_filter->p_sys = malloc( sizeof( filter_sys_t ) );
     if( p_filter->p_sys == NULL )
-    {
-        msg_Err( p_filter, "out of memory" );
         return VLC_ENOMEM;
-    }
-
-    config_ChainParse( p_filter, FILTER_PREFIX, ppsz_filter_options,
-                       p_filter->p_cfg );
 
     p_filter->pf_video_filter = Filter;
 
@@ -105,12 +108,10 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
 
     if( !p_pic ) return NULL;
 
-    p_outpic = p_filter->pf_vout_buffer_new( p_filter );
+    p_outpic = filter_NewPicture( p_filter );
     if( !p_outpic )
     {
-        msg_Warn( p_filter, "can't get output picture" );
-        if( p_pic->pf_release )
-            p_pic->pf_release( p_pic );
+        picture_Release( p_pic );
         return NULL;
     }
 
@@ -135,7 +136,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
         {
             for( i_col = 0; i_col < i_num_cols; i_col++ )
             {
-                p_noise[i_line*i_pitch+i_col] = ((rand()&0x1f)-0x0f);
+                p_noise[i_line*i_pitch+i_col] = ((vlc_mrand48()&0x1f)-0x0f);
             }
         }
 
@@ -199,14 +200,5 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
 
     }
 
-    p_outpic->date = p_pic->date;
-    p_outpic->b_force = p_pic->b_force;
-    p_outpic->i_nb_fields = p_pic->i_nb_fields;
-    p_outpic->b_progressive = p_pic->b_progressive;
-    p_outpic->b_top_field_first = p_pic->b_top_field_first;
-
-    if( p_pic->pf_release )
-        p_pic->pf_release( p_pic );
-
-    return p_outpic;
+    return CopyInfoAndRelease( p_outpic, p_pic );
 }