X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fvideo_output%2Fsdl.c;h=0bc7de17d5a14157aef0ac80fd7f454adaded16d;hb=4e9597b800d1140dfab1cf33c3df8c608d58878f;hp=3ed1de7168dc37347e0deb763a40d4461d8b0032;hpb=b321beb4ac88fb3d032b0f0132a8ce7348b52f89;p=vlc diff --git a/modules/video_output/sdl.c b/modules/video_output/sdl.c index 3ed1de7168..0bc7de17d5 100644 --- a/modules/video_output/sdl.c +++ b/modules/video_output/sdl.c @@ -32,7 +32,8 @@ # include "config.h" #endif -#include +#include +#include #include #include #include @@ -74,9 +75,10 @@ struct vout_sys_t /* For RGB output */ int i_surfaces; - vlc_bool_t b_cursor; - vlc_bool_t b_cursor_autohidden; + bool b_cursor; + bool b_cursor_autohidden; mtime_t i_lastmoved; + mtime_t i_mouse_hide_timeout; mtime_t i_lastpressed; /* to track dbl-clicks */ }; @@ -122,10 +124,10 @@ vlc_module_begin(); set_shortname( "SDL" ); set_category( CAT_VIDEO ); set_subcategory( SUBCAT_VIDEO_VOUT ); - set_description( _("Simple DirectMedia Layer video output") ); + set_description( N_("Simple DirectMedia Layer video output") ); set_capability( "video output", 60 ); add_shortcut( "sdl" ); - add_string( "sdl-chroma", NULL, NULL, CHROMA_TEXT, CHROMA_LONGTEXT, VLC_TRUE ); + add_string( "sdl-chroma", NULL, NULL, CHROMA_TEXT, CHROMA_LONGTEXT, true ); set_callbacks( Open, Close ); #if defined( __i386__ ) || defined( __x86_64__ ) /* On i386, SDL is linked against svgalib */ @@ -160,6 +162,8 @@ static int Open ( vlc_object_t *p_this ) return VLC_ENOMEM; } + memset( p_vout->p_sys, 0, sizeof( vout_sys_t ) ); + /* Check if SDL video module has been initialized */ if( SDL_WasInit( SDL_INIT_VIDEO ) != 0 ) { @@ -177,7 +181,7 @@ static int Open ( vlc_object_t *p_this ) p_vout->pf_control = NULL; #ifdef HAVE_SETENV - psz_method = config_GetPsz( p_vout, "vout" ); + char* psz = psz_method = config_GetPsz( p_vout, "vout" ); if( psz_method ) { while( *psz_method && *psz_method != ':' ) @@ -190,6 +194,7 @@ static int Open ( vlc_object_t *p_this ) setenv( "SDL_VIDEODRIVER", psz_method + 1, 1 ); } } + free( psz ); #endif /* Initialize library */ @@ -227,6 +232,8 @@ static int Open ( vlc_object_t *p_this ) p_vout->p_sys->b_cursor = 1; p_vout->p_sys->b_cursor_autohidden = 0; p_vout->p_sys->i_lastmoved = p_vout->p_sys->i_lastpressed = mdate(); + p_vout->p_sys->i_mouse_hide_timeout = + var_GetInteger(p_vout, "mouse-hide-timeout") * 1000; if( OpenDisplay( p_vout ) ) { @@ -403,7 +410,7 @@ static int Manage( vout_thread_t *p_vout ) var_Set( p_vout, "mouse-y", val ); - val.b_bool = VLC_TRUE; + val.b_bool = true; var_Set( p_vout, "mouse-moved", val ); if( p_vout->p_sys->b_cursor ) @@ -425,39 +432,35 @@ static int Manage( vout_thread_t *p_vout ) switch( event.button.button ) { case SDL_BUTTON_LEFT: - var_Get( p_vout, "mouse-button-down", &val ); - val.i_int &= ~1; - var_Set( p_vout, "mouse-button-down", val ); + { + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int &= ~1; + var_Set( p_vout, "mouse-button-down", val ); + + val.b_bool = true; + var_Set( p_vout, "mouse-clicked", val ); - val.b_bool = VLC_TRUE; - var_Set( p_vout, "mouse-clicked", val ); + val.b_bool = false; + var_Set( p_vout->p_libvlc, "intf-popupmenu", val ); + } break; case SDL_BUTTON_MIDDLE: { - playlist_t *p_playlist; - var_Get( p_vout, "mouse-button-down", &val ); val.i_int &= ~2; var_Set( p_vout, "mouse-button-down", val ); - p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST, - FIND_ANYWHERE ); - if( p_playlist != NULL ) - { - vlc_value_t val; - var_Get( p_playlist, "intf-show", &val ); - val.b_bool = !val.b_bool; - var_Set( p_playlist, "intf-show", val ); - vlc_object_release( p_playlist ); - } + vlc_value_t val; + var_Get( p_vout->p_libvlc, "intf-show", &val ); + val.b_bool = !val.b_bool; + var_Set( p_vout->p_libvlc, "intf-show", val ); } break; case SDL_BUTTON_RIGHT: { intf_thread_t *p_intf; - playlist_t *p_playlist; var_Get( p_vout, "mouse-button-down", &val ); val.i_int &= ~4; @@ -470,16 +473,8 @@ static int Manage( vout_thread_t *p_vout ) vlc_object_release( p_intf ); } - p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST, - FIND_ANYWHERE ); - - if( p_playlist != NULL ) - { - vlc_value_t val; - val.b_bool = VLC_TRUE; - var_Set( p_playlist, "intf-popupmenu", val ); - vlc_object_release( p_playlist ); - } + val.b_bool = true; + var_Set( p_vout->p_libvlc, "intf-popupmenu", val ); } break; } @@ -518,12 +513,16 @@ static int Manage( vout_thread_t *p_vout ) /* Quit event (close the window) */ case SDL_QUIT: { - playlist_t *p_playlist = (playlist_t *)vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE ); +#if 0 + playlist_t *p_playlist = pl_Yield( p_vout ); if( p_playlist != NULL ) { playlist_Stop( p_playlist ); - vlc_object_release( p_playlist ); + pl_Release( p_vout ); } +#else +#warning FIXME FIXME ? +#endif } break; @@ -625,7 +624,8 @@ static int Manage( vout_thread_t *p_vout ) /* Pointer change */ if( ! p_vout->p_sys->b_cursor_autohidden && - ( mdate() - p_vout->p_sys->i_lastmoved > 2000000 ) ) + ( mdate() - p_vout->p_sys->i_lastmoved > + p_vout->p_sys->i_mouse_hide_timeout ) ) { /* Hide the mouse automatically */ p_vout->p_sys->b_cursor_autohidden = 1; @@ -750,6 +750,8 @@ static int OpenDisplay( vout_thread_t *p_vout ) char *psz_chroma = NULL; uint32_t i_chroma = 0; + bool b_overlay = config_GetInt( p_vout, "overlay" ); + /* Set main window's size */ #if SDL_VERSION_ATLEAST(1,2,10) p_vout->p_sys->i_width = p_vout->b_fullscreen ? p_vout->p_sys->i_desktop_width : @@ -801,75 +803,82 @@ static int OpenDisplay( vout_thread_t *p_vout ) } } - /* Choose the chroma we will try first. */ - do + if( b_overlay ) { - if( !psz_chroma ) i_chroma = 0; - switch( i_chroma ? i_chroma : p_vout->render.i_chroma ) + /* Choose the chroma we will try first. */ + do { - case VLC_FOURCC('Y','U','Y','2'): - case VLC_FOURCC('Y','U','N','V'): - p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); - i_sdl_chroma = SDL_YUY2_OVERLAY; - break; - case VLC_FOURCC('U','Y','V','Y'): - case VLC_FOURCC('U','Y','N','V'): - case VLC_FOURCC('Y','4','2','2'): - p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y'); - i_sdl_chroma = SDL_UYVY_OVERLAY; - break; - case VLC_FOURCC('Y','V','Y','U'): - p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U'); - i_sdl_chroma = SDL_YVYU_OVERLAY; - break; - case VLC_FOURCC('Y','V','1','2'): - case VLC_FOURCC('I','4','2','0'): - case VLC_FOURCC('I','Y','U','V'): - default: - p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); - i_sdl_chroma = SDL_YV12_OVERLAY; - break; - } - free( psz_chroma ); psz_chroma = NULL; + if( !psz_chroma ) i_chroma = 0; + switch( i_chroma ? i_chroma : p_vout->render.i_chroma ) + { + case VLC_FOURCC('Y','U','Y','2'): + case VLC_FOURCC('Y','U','N','V'): + p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); + i_sdl_chroma = SDL_YUY2_OVERLAY; + break; + case VLC_FOURCC('U','Y','V','Y'): + case VLC_FOURCC('U','Y','N','V'): + case VLC_FOURCC('Y','4','2','2'): + p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y'); + i_sdl_chroma = SDL_UYVY_OVERLAY; + break; + case VLC_FOURCC('Y','V','Y','U'): + p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U'); + i_sdl_chroma = SDL_YVYU_OVERLAY; + break; + case VLC_FOURCC('Y','V','1','2'): + case VLC_FOURCC('I','4','2','0'): + case VLC_FOURCC('I','Y','U','V'): + default: + p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); + i_sdl_chroma = SDL_YV12_OVERLAY; + break; + } + free( psz_chroma ); psz_chroma = NULL; - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma, - p_vout->p_sys->p_display ); - /* FIXME: if the first overlay we find is software, don't stop, - * because we may find a hardware one later ... */ - } - while( i_chroma && !p_vout->p_sys->p_overlay ); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma, + p_vout->p_sys->p_display ); + /* FIXME: if the first overlay we find is software, don't stop, + * because we may find a hardware one later ... */ + } + while( i_chroma && !p_vout->p_sys->p_overlay ); - /* If this best choice failed, fall back to other chromas */ - if( p_vout->p_sys->p_overlay == NULL ) - { - p_vout->output.i_chroma = VLC_FOURCC('I','Y','U','V'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_IYUV_OVERLAY, - p_vout->p_sys->p_display ); - } + /* If this best choice failed, fall back to other chromas */ + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('I','Y','U','V'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_IYUV_OVERLAY, + p_vout->p_sys->p_display ); + } - if( p_vout->p_sys->p_overlay == NULL ) - { - p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_YV12_OVERLAY, - p_vout->p_sys->p_display ); - } + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_YV12_OVERLAY, + p_vout->p_sys->p_display ); + } - if( p_vout->p_sys->p_overlay == NULL ) - { - p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_YUY2_OVERLAY, - p_vout->p_sys->p_display ); + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_YUY2_OVERLAY, + p_vout->p_sys->p_display ); + } } if( p_vout->p_sys->p_overlay == NULL ) { - msg_Warn( p_vout, "no SDL overlay for 0x%.8x (%4.4s)", - p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma ); + if( b_overlay ) + msg_Warn( p_vout, "no SDL overlay for 0x%.8x (%4.4s)", + p_vout->render.i_chroma, + (char*)&p_vout->render.i_chroma ); + else + msg_Warn( p_vout, "SDL overlay disabled by the user" ); switch( p_vout->p_sys->p_display->format->BitsPerPixel ) {