X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=modules%2Fvideo_output%2Fsdl.c;h=0bc7de17d5a14157aef0ac80fd7f454adaded16d;hb=d253749f68a85d8c720e66e4a0f7ad9693ba84e3;hp=9daa2d4f6d4acc91c01055396cfd9815a0cd46c8;hpb=f485214f09dd284cbb85674e937fbbb0a6032a2e;p=vlc diff --git a/modules/video_output/sdl.c b/modules/video_output/sdl.c index 9daa2d4f6d..0bc7de17d5 100644 --- a/modules/video_output/sdl.c +++ b/modules/video_output/sdl.c @@ -27,13 +27,18 @@ * Preamble *****************************************************************************/ #include /* ENOMEM */ -#include /* free() */ -#include /* strerror() */ -#include -#include -#include -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include +#include +#include +#include +#include +#include +//#include #include #ifndef WIN32 @@ -59,15 +64,21 @@ struct vout_sys_t int i_width; int i_height; +#if SDL_VERSION_ATLEAST(1,2,10) + unsigned int i_desktop_width; + unsigned int i_desktop_height; +#endif + /* For YUV output */ SDL_Overlay * p_overlay; /* An overlay we keep to grab the XVideo port */ /* For RGB output */ int i_surfaces; - vlc_bool_t b_cursor; - vlc_bool_t b_cursor_autohidden; + bool b_cursor; + bool b_cursor_autohidden; mtime_t i_lastmoved; + mtime_t i_mouse_hide_timeout; mtime_t i_lastpressed; /* to track dbl-clicks */ }; @@ -98,6 +109,14 @@ static int NewPicture ( vout_thread_t *, picture_t * ); static void SetPalette ( vout_thread_t *, uint16_t *, uint16_t *, uint16_t * ); +static int ConvertKey( SDLKey ); + + +#define CHROMA_TEXT N_("SDL chroma format") +#define CHROMA_LONGTEXT N_( \ + "Force the SDL renderer to use a specific chroma format instead of " \ + "trying to improve performances by using the most efficient one.") + /***************************************************************************** * Module descriptor *****************************************************************************/ @@ -105,12 +124,11 @@ vlc_module_begin(); set_shortname( "SDL" ); set_category( CAT_VIDEO ); set_subcategory( SUBCAT_VIDEO_VOUT ); - set_description( _("Simple DirectMedia Layer video output") ); + set_description( N_("Simple DirectMedia Layer video output") ); set_capability( "video output", 60 ); add_shortcut( "sdl" ); + add_string( "sdl-chroma", NULL, NULL, CHROMA_TEXT, CHROMA_LONGTEXT, true ); set_callbacks( Open, Close ); - /* XXX: check for conflicts with the SDL audio output */ - var_Create( p_module->p_libvlc_global, "sdl", VLC_VAR_MUTEX ); #if defined( __i386__ ) || defined( __x86_64__ ) /* On i386, SDL is linked against svgalib */ linked_with_a_crap_library_which_uses_atexit(); @@ -127,38 +145,43 @@ vlc_module_end(); static int Open ( vlc_object_t *p_this ) { vout_thread_t * p_vout = (vout_thread_t *)p_this; - vlc_value_t lockval; + /* XXX: check for conflicts with the SDL audio output */ + vlc_mutex_t *lock = var_AcquireMutex( "sdl" ); #ifdef HAVE_SETENV char *psz_method; #endif - var_Get( p_this->p_libvlc_global, "sdl", &lockval ); - vlc_mutex_lock( lockval.p_address ); - - if( SDL_WasInit( SDL_INIT_VIDEO ) != 0 ) - { - vlc_mutex_unlock( lockval.p_address ); - return VLC_EGENERIC; - } + if( lock == NULL ) + return VLC_ENOMEM; - /* Allocate structure */ p_vout->p_sys = malloc( sizeof( vout_sys_t ) ); if( p_vout->p_sys == NULL ) { - msg_Err( p_vout, "out of memory" ); - vlc_mutex_unlock( lockval.p_address ); + vlc_mutex_unlock( lock ); return VLC_ENOMEM; } + memset( p_vout->p_sys, 0, sizeof( vout_sys_t ) ); + + /* Check if SDL video module has been initialized */ + if( SDL_WasInit( SDL_INIT_VIDEO ) != 0 ) + { + vlc_mutex_unlock( lock ); + free( p_vout->p_sys ); + return VLC_EGENERIC; + } + + /* Allocate structure */ p_vout->pf_init = Init; p_vout->pf_end = End; p_vout->pf_manage = Manage; p_vout->pf_render = NULL; p_vout->pf_display = Display; + p_vout->pf_control = NULL; #ifdef HAVE_SETENV - psz_method = config_GetPsz( p_vout, "vout" ); + char* psz = psz_method = config_GetPsz( p_vout, "vout" ); if( psz_method ) { while( *psz_method && *psz_method != ':' ) @@ -171,6 +194,7 @@ static int Open ( vlc_object_t *p_this ) setenv( "SDL_VIDEODRIVER", psz_method + 1, 1 ); } } + free( psz ); #endif /* Initialize library */ @@ -179,7 +203,7 @@ static int Open ( vlc_object_t *p_this ) /* Win32 SDL implementation doesn't support SDL_INIT_EVENTTHREAD yet*/ | SDL_INIT_EVENTTHREAD #endif -#ifdef DEBUG +#ifndef NDEBUG /* In debug mode you may want vlc to dump a core instead of staying * stuck */ | SDL_INIT_NOPARACHUTE @@ -188,15 +212,28 @@ static int Open ( vlc_object_t *p_this ) { msg_Err( p_vout, "cannot initialize SDL (%s)", SDL_GetError() ); free( p_vout->p_sys ); - vlc_mutex_unlock( lockval.p_address ); + vlc_mutex_unlock( lock ); return VLC_EGENERIC; } - vlc_mutex_unlock( lockval.p_address ); + vlc_mutex_unlock( lock ); + + /* Translate keys into unicode */ + SDL_EnableUNICODE(1); + + /* Get the desktop resolution */ +#if SDL_VERSION_ATLEAST(1,2,10) + /* FIXME: SDL has a problem with virtual desktop */ + p_vout->p_sys->i_desktop_width = SDL_GetVideoInfo()->current_w; + p_vout->p_sys->i_desktop_height = SDL_GetVideoInfo()->current_h; +#endif + /* Create the cursor */ p_vout->p_sys->b_cursor = 1; p_vout->p_sys->b_cursor_autohidden = 0; - p_vout->p_sys->i_lastmoved = mdate(); + p_vout->p_sys->i_lastmoved = p_vout->p_sys->i_lastpressed = mdate(); + p_vout->p_sys->i_mouse_hide_timeout = + var_GetInteger(p_vout, "mouse-hide-timeout") * 1000; if( OpenDisplay( p_vout ) ) { @@ -327,37 +364,56 @@ static int Manage( vout_thread_t *p_vout ) { SDL_Event event; /* SDL event */ vlc_value_t val; - int i_width, i_height, i_x, i_y; + unsigned int i_width, i_height, i_x, i_y; /* Process events */ - while( SDL_PollEvent(&event) ) + while( SDL_PollEvent( &event ) ) { switch( event.type ) { - case SDL_VIDEORESIZE: /* Resizing of window */ - /* Update dimensions */ + /* Resizing of window */ + case SDL_VIDEORESIZE: p_vout->i_changes |= VOUT_SIZE_CHANGE; p_vout->i_window_width = p_vout->p_sys->i_width = event.resize.w; p_vout->i_window_height = p_vout->p_sys->i_height = event.resize.h; break; + /* Mouse move */ case SDL_MOUSEMOTION: vout_PlacePicture( p_vout, p_vout->p_sys->i_width, p_vout->p_sys->i_height, &i_x, &i_y, &i_width, &i_height ); - val.i_int = ( event.motion.x - i_x ) - * p_vout->render.i_width / i_width; + /* Compute the x coordinate and check if the value is + in [0,p_vout->fmt_in.i_visible_width] */ + val.i_int = ( event.motion.x - i_x ) * + p_vout->fmt_in.i_visible_width / i_width + + p_vout->fmt_in.i_x_offset; + + if( (int)(event.motion.x - i_x) < 0 ) + val.i_int = 0; + else if( (unsigned int)val.i_int > p_vout->fmt_in.i_visible_width ) + val.i_int = p_vout->fmt_in.i_visible_width; + var_Set( p_vout, "mouse-x", val ); - val.i_int = ( event.motion.y - i_y ) - * p_vout->render.i_height / i_height; + + /* compute the y coordinate and check if the value is + in [0,p_vout->fmt_in.i_visible_height] */ + val.i_int = ( event.motion.y - i_y ) * + p_vout->fmt_in.i_visible_height / i_height + + p_vout->fmt_in.i_y_offset; + + if( (int)(event.motion.y - i_y) < 0 ) + val.i_int = 0; + else if( (unsigned int)val.i_int > p_vout->fmt_in.i_visible_height ) + val.i_int = p_vout->fmt_in.i_visible_height; + var_Set( p_vout, "mouse-y", val ); - val.b_bool = VLC_TRUE; + val.b_bool = true; var_Set( p_vout, "mouse-moved", val ); - if( p_vout->p_sys->b_cursor && - (abs(event.motion.xrel) > 2 || abs(event.motion.yrel) > 2) ) + if( p_vout->p_sys->b_cursor ) { if( p_vout->p_sys->b_cursor_autohidden ) { @@ -371,17 +427,44 @@ static int Manage( vout_thread_t *p_vout ) } break; + /* Mouse button released */ case SDL_MOUSEBUTTONUP: switch( event.button.button ) { case SDL_BUTTON_LEFT: - val.b_bool = VLC_TRUE; - var_Set( p_vout, "mouse-clicked", val ); + { + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int &= ~1; + var_Set( p_vout, "mouse-button-down", val ); + + val.b_bool = true; + var_Set( p_vout, "mouse-clicked", val ); + + val.b_bool = false; + var_Set( p_vout->p_libvlc, "intf-popupmenu", val ); + } + break; + + case SDL_BUTTON_MIDDLE: + { + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int &= ~2; + var_Set( p_vout, "mouse-button-down", val ); + + vlc_value_t val; + var_Get( p_vout->p_libvlc, "intf-show", &val ); + val.b_bool = !val.b_bool; + var_Set( p_vout->p_libvlc, "intf-show", val ); + } break; case SDL_BUTTON_RIGHT: { intf_thread_t *p_intf; + + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int &= ~4; + var_Set( p_vout, "mous-button-down", val ); p_intf = vlc_object_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE ); if( p_intf ) @@ -389,17 +472,22 @@ static int Manage( vout_thread_t *p_vout ) p_intf->b_menu_change = 1; vlc_object_release( p_intf ); } + + val.b_bool = true; + var_Set( p_vout->p_libvlc, "intf-popupmenu", val ); } break; } break; + /* Mouse button pressed */ case SDL_MOUSEBUTTONDOWN: switch( event.button.button ) { case SDL_BUTTON_LEFT: - /* In this part we will eventually manage - * clicks for DVD navigation for instance. */ + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int |= 1; + var_Set( p_vout, "mouse-button-down", val ); /* detect double-clicks */ if( ( mdate() - p_vout->p_sys->i_lastpressed ) < 300000 ) @@ -408,118 +496,72 @@ static int Manage( vout_thread_t *p_vout ) p_vout->p_sys->i_lastpressed = mdate(); break; - case 4: + case SDL_BUTTON_MIDDLE: + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int |= 2; + var_Set( p_vout, "mouse-button-down", val ); break; - case 5: + case SDL_BUTTON_RIGHT: + var_Get( p_vout, "mouse-button-down", &val ); + val.i_int |= 4; + var_Set( p_vout, "mouse-button-down", val ); break; } break; + /* Quit event (close the window) */ case SDL_QUIT: - p_vout->p_libvlc->b_die = 1; + { +#if 0 + playlist_t *p_playlist = pl_Yield( p_vout ); + if( p_playlist != NULL ) + { + playlist_Stop( p_playlist ); + pl_Release( p_vout ); + } +#else +#warning FIXME FIXME ? +#endif + } break; - case SDL_KEYDOWN: /* if a key is pressed */ + /* Key pressed */ + case SDL_KEYDOWN: + /* convert the key if possible */ + val.i_int = ConvertKey( event.key.keysym.sym ); - switch( event.key.keysym.sym ) + if( !val.i_int ) { - case SDLK_ESCAPE: - if( p_vout->b_fullscreen ) + /* Find the right caracter */ + if( ( event.key.keysym.unicode & 0xff80 ) == 0 ) { - p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE; + val.i_int = event.key.keysym.unicode & 0x7f; + /* FIXME: find a better solution than this + hack to find the right caracter */ + if( val.i_int >= 1 && val.i_int <= 26 ) + val.i_int += 96; + else if( val.i_int >= 65 && val.i_int <= 90 ) + val.i_int += 32; } - else - { - p_vout->p_libvlc->b_die = 1; - } - break; - - case SDLK_q: /* quit */ - p_vout->p_libvlc->b_die = 1; - break; - - case SDLK_f: /* switch to fullscreen */ - p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE; - break; - - case SDLK_c: /* toggle grayscale */ - p_vout->b_grayscale = ! p_vout->b_grayscale; - p_vout->i_changes |= VOUT_GRAYSCALE_CHANGE; - break; - - case SDLK_i: /* toggle info */ - p_vout->b_info = ! p_vout->b_info; - p_vout->i_changes |= VOUT_INFO_CHANGE; - break; - - case SDLK_s: /* toggle scaling */ - p_vout->b_scale = ! p_vout->b_scale; - p_vout->i_changes |= VOUT_SCALE_CHANGE; - break; - - case SDLK_SPACE: /* toggle interface */ - p_vout->b_interface = ! p_vout->b_interface; - p_vout->i_changes |= VOUT_INTF_CHANGE; - break; + } - case SDLK_MENU: + if( val.i_int ) + { + if( ( event.key.keysym.mod & KMOD_SHIFT ) ) { - intf_thread_t *p_intf; - p_intf = vlc_object_find( p_vout, VLC_OBJECT_INTF, - FIND_ANYWHERE ); - if( p_intf != NULL ) - { - p_intf->b_menu_change = 1; - vlc_object_release( p_intf ); - } + val.i_int |= KEY_MODIFIER_SHIFT; } - break; - - case SDLK_LEFT: - break; - - case SDLK_RIGHT: - break; - - case SDLK_UP: - break; - - case SDLK_DOWN: - break; - - case SDLK_b: + if( ( event.key.keysym.mod & KMOD_CTRL ) ) { - audio_volume_t i_volume; - if ( !aout_VolumeDown( p_vout, 1, &i_volume ) ) - { - msg_Dbg( p_vout, "audio volume is now %d", i_volume ); - } - else - { - msg_Dbg( p_vout, "audio volume: operation not supported" ); - } + val.i_int |= KEY_MODIFIER_CTRL; } - break; - - case SDLK_n: + if( ( event.key.keysym.mod & KMOD_ALT ) ) { - audio_volume_t i_volume; - if ( !aout_VolumeUp( p_vout, 1, &i_volume ) ) - { - msg_Dbg( p_vout, "audio volume is now %d", i_volume ); - } - else - { - msg_Dbg( p_vout, "audio volume: operation not supported" ); - } + val.i_int |= KEY_MODIFIER_ALT; } - break; - - default: - break; + var_Set( p_vout->p_libvlc, "key-pressed", val ); } - break; default: break; @@ -529,7 +571,14 @@ static int Manage( vout_thread_t *p_vout ) /* Fullscreen change */ if( p_vout->i_changes & VOUT_FULLSCREEN_CHANGE ) { - p_vout->b_fullscreen = ! p_vout->b_fullscreen; + vlc_value_t val_fs; + + /* Update the object variable and trigger callback */ + val_fs.b_bool = !p_vout->b_fullscreen; + p_vout->b_fullscreen = !p_vout->b_fullscreen; + var_Set( p_vout, "fullscreen", val_fs ); + + /*TODO: add the "always on top" code here !*/ p_vout->p_sys->b_cursor_autohidden = 0; SDL_ShowCursor( p_vout->p_sys->b_cursor && @@ -539,9 +588,26 @@ static int Manage( vout_thread_t *p_vout ) p_vout->i_changes |= VOUT_SIZE_CHANGE; } - /* - * Size change - */ + /* Crop or Aspect Ratio Changes */ + if( p_vout->i_changes & VOUT_CROP_CHANGE || + p_vout->i_changes & VOUT_ASPECT_CHANGE ) + { + p_vout->i_changes &= ~VOUT_CROP_CHANGE; + p_vout->i_changes &= ~VOUT_ASPECT_CHANGE; + + p_vout->fmt_out.i_x_offset = p_vout->fmt_in.i_x_offset; + p_vout->fmt_out.i_y_offset = p_vout->fmt_in.i_y_offset; + p_vout->fmt_out.i_visible_width = p_vout->fmt_in.i_visible_width; + p_vout->fmt_out.i_visible_height = p_vout->fmt_in.i_visible_height; + p_vout->fmt_out.i_aspect = p_vout->fmt_in.i_aspect; + p_vout->fmt_out.i_sar_num = p_vout->fmt_in.i_sar_num; + p_vout->fmt_out.i_sar_den = p_vout->fmt_in.i_sar_den; + p_vout->output.i_aspect = p_vout->fmt_in.i_aspect; + + p_vout->i_changes |= VOUT_SIZE_CHANGE; + } + + /* Size change */ if( p_vout->i_changes & VOUT_SIZE_CHANGE ) { msg_Dbg( p_vout, "video display resized (%dx%d)", @@ -554,12 +620,12 @@ static int Manage( vout_thread_t *p_vout ) * we can handle rescaling ourselves */ if( p_vout->p_sys->p_overlay != NULL ) p_vout->i_changes &= ~VOUT_SIZE_CHANGE; - } /* Pointer change */ if( ! p_vout->p_sys->b_cursor_autohidden && - ( mdate() - p_vout->p_sys->i_lastmoved > 2000000 ) ) + ( mdate() - p_vout->p_sys->i_lastmoved > + p_vout->p_sys->i_mouse_hide_timeout ) ) { /* Hide the mouse automatically */ p_vout->p_sys->b_cursor_autohidden = 1; @@ -569,6 +635,72 @@ static int Manage( vout_thread_t *p_vout ) return VLC_SUCCESS; } +/***************************************************************************** + * Key events handling + *****************************************************************************/ +static struct +{ + SDLKey sdl_key; + int i_vlckey; +} sdlkeys_to_vlckeys[] = +{ + { SDLK_F1, KEY_F1 }, + { SDLK_F2, KEY_F2 }, + { SDLK_F3, KEY_F3 }, + { SDLK_F4, KEY_F4 }, + { SDLK_F5, KEY_F5 }, + { SDLK_F6, KEY_F6 }, + { SDLK_F7, KEY_F7 }, + { SDLK_F8, KEY_F8 }, + { SDLK_F9, KEY_F9 }, + { SDLK_F10, KEY_F10 }, + { SDLK_F11, KEY_F11 }, + { SDLK_F12, KEY_F12 }, + + { SDLK_RETURN, KEY_ENTER }, + { SDLK_KP_ENTER, KEY_ENTER }, + { SDLK_SPACE, KEY_SPACE }, + { SDLK_ESCAPE, KEY_ESC }, + + { SDLK_MENU, KEY_MENU }, + { SDLK_LEFT, KEY_LEFT }, + { SDLK_RIGHT, KEY_RIGHT }, + { SDLK_UP, KEY_UP }, + { SDLK_DOWN, KEY_DOWN }, + + { SDLK_HOME, KEY_HOME }, + { SDLK_END, KEY_END }, + { SDLK_PAGEUP, KEY_PAGEUP }, + { SDLK_PAGEDOWN, KEY_PAGEDOWN }, + + { SDLK_INSERT, KEY_INSERT }, + { SDLK_DELETE, KEY_DELETE }, + /*TODO: find a equivalent for SDL + { , KEY_MEDIA_NEXT_TRACK } + { , KEY_MEDIA_PREV_TRACK } + { , KEY_VOLUME_MUTE } + { , KEY_VOLUME_DOWN } + { , KEY_VOLUME_UP } + { , KEY_MEDIA_PLAY_PAUSE } + { , KEY_MEDIA_PLAY_PAUSE }*/ + + { 0, 0 } +}; + +static int ConvertKey( SDLKey sdl_key ) +{ + int i; + for( i=0; sdlkeys_to_vlckeys[i].sdl_key != 0; i++ ) + { + if( sdlkeys_to_vlckeys[i].sdl_key == sdl_key ) + { + return sdlkeys_to_vlckeys[i].i_vlckey; + } + } + return 0; +} + + /***************************************************************************** * Display: displays previously rendered output ***************************************************************************** @@ -576,7 +708,7 @@ static int Manage( vout_thread_t *p_vout ) *****************************************************************************/ static void Display( vout_thread_t *p_vout, picture_t *p_pic ) { - int x, y, w, h; + unsigned int x, y, w, h; SDL_Rect disp; vout_PlacePicture( p_vout, p_vout->p_sys->i_width, p_vout->p_sys->i_height, @@ -615,12 +747,23 @@ static int OpenDisplay( vout_thread_t *p_vout ) /* SDL fucked up fourcc definitions on bigendian machines */ uint32_t i_sdl_chroma; + char *psz_chroma = NULL; + uint32_t i_chroma = 0; + + bool b_overlay = config_GetInt( p_vout, "overlay" ); /* Set main window's size */ +#if SDL_VERSION_ATLEAST(1,2,10) + p_vout->p_sys->i_width = p_vout->b_fullscreen ? p_vout->p_sys->i_desktop_width : + p_vout->i_window_width; + p_vout->p_sys->i_height = p_vout->b_fullscreen ? p_vout->p_sys->i_desktop_height : + p_vout->i_window_height; +#else p_vout->p_sys->i_width = p_vout->b_fullscreen ? p_vout->output.i_width : p_vout->i_window_width; p_vout->p_sys->i_height = p_vout->b_fullscreen ? p_vout->output.i_height : p_vout->i_window_height; +#endif /* Initialize flags and cursor */ i_flags = SDL_ANYFORMAT | SDL_HWPALETTE | SDL_HWSURFACE | SDL_DOUBLEBUF; @@ -646,67 +789,96 @@ static int OpenDisplay( vout_thread_t *p_vout ) SDL_LockSurface( p_vout->p_sys->p_display ); - /* Choose the chroma we will try first. */ - switch( p_vout->render.i_chroma ) + if( ( psz_chroma = config_GetPsz( p_vout, "sdl-chroma" ) ) ) { - case VLC_FOURCC('Y','U','Y','2'): - case VLC_FOURCC('Y','U','N','V'): - p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); - i_sdl_chroma = SDL_YUY2_OVERLAY; - break; - case VLC_FOURCC('U','Y','V','Y'): - case VLC_FOURCC('U','Y','N','V'): - case VLC_FOURCC('Y','4','2','2'): - p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y'); - i_sdl_chroma = SDL_UYVY_OVERLAY; - break; - case VLC_FOURCC('Y','V','Y','U'): - p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U'); - i_sdl_chroma = SDL_YVYU_OVERLAY; - break; - case VLC_FOURCC('Y','V','1','2'): - case VLC_FOURCC('I','4','2','0'): - case VLC_FOURCC('I','Y','U','V'): - default: - p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); - i_sdl_chroma = SDL_YV12_OVERLAY; - break; + if( strlen( psz_chroma ) >= 4 ) + { + memcpy(&i_chroma, psz_chroma, 4); + msg_Dbg( p_vout, "Forcing chroma to 0x%.8x (%4.4s)", i_chroma, (char*)&i_chroma ); + } + else + { + free( psz_chroma ); + psz_chroma = NULL; + } } - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma, p_vout->p_sys->p_display ); - /* FIXME: if the first overlay we find is software, don't stop, - * because we may find a hardware one later ... */ - - /* If this best choice failed, fall back to other chromas */ - if( p_vout->p_sys->p_overlay == NULL ) + if( b_overlay ) { - p_vout->output.i_chroma = VLC_FOURCC('I','Y','U','V'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_IYUV_OVERLAY, - p_vout->p_sys->p_display ); - } + /* Choose the chroma we will try first. */ + do + { + if( !psz_chroma ) i_chroma = 0; + switch( i_chroma ? i_chroma : p_vout->render.i_chroma ) + { + case VLC_FOURCC('Y','U','Y','2'): + case VLC_FOURCC('Y','U','N','V'): + p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); + i_sdl_chroma = SDL_YUY2_OVERLAY; + break; + case VLC_FOURCC('U','Y','V','Y'): + case VLC_FOURCC('U','Y','N','V'): + case VLC_FOURCC('Y','4','2','2'): + p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y'); + i_sdl_chroma = SDL_UYVY_OVERLAY; + break; + case VLC_FOURCC('Y','V','Y','U'): + p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U'); + i_sdl_chroma = SDL_YVYU_OVERLAY; + break; + case VLC_FOURCC('Y','V','1','2'): + case VLC_FOURCC('I','4','2','0'): + case VLC_FOURCC('I','Y','U','V'): + default: + p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); + i_sdl_chroma = SDL_YV12_OVERLAY; + break; + } + free( psz_chroma ); psz_chroma = NULL; - if( p_vout->p_sys->p_overlay == NULL ) - { - p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_YV12_OVERLAY, - p_vout->p_sys->p_display ); - } + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma, + p_vout->p_sys->p_display ); + /* FIXME: if the first overlay we find is software, don't stop, + * because we may find a hardware one later ... */ + } + while( i_chroma && !p_vout->p_sys->p_overlay ); - if( p_vout->p_sys->p_overlay == NULL ) - { - p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); - p_vout->p_sys->p_overlay = - SDL_CreateYUVOverlay( 32, 32, SDL_YUY2_OVERLAY, - p_vout->p_sys->p_display ); + + /* If this best choice failed, fall back to other chromas */ + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('I','Y','U','V'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_IYUV_OVERLAY, + p_vout->p_sys->p_display ); + } + + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_YV12_OVERLAY, + p_vout->p_sys->p_display ); + } + + if( p_vout->p_sys->p_overlay == NULL ) + { + p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2'); + p_vout->p_sys->p_overlay = + SDL_CreateYUVOverlay( 32, 32, SDL_YUY2_OVERLAY, + p_vout->p_sys->p_display ); + } } if( p_vout->p_sys->p_overlay == NULL ) { - msg_Warn( p_vout, "no SDL overlay for 0x%.8x (%4.4s)", - p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma ); + if( b_overlay ) + msg_Warn( p_vout, "no SDL overlay for 0x%.8x (%4.4s)", + p_vout->render.i_chroma, + (char*)&p_vout->render.i_chroma ); + else + msg_Warn( p_vout, "SDL overlay disabled by the user" ); switch( p_vout->p_sys->p_display->format->BitsPerPixel ) {