X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Faudio_output%2Fmixer.c;h=4f1f9b64899a5d0c2989ab2d2a2b14ba09e6d83b;hb=b181de412b91984d7013903fc1eb1084be489ad7;hp=e251cc29323d0dcf432a279e0e754885dcc7b32c;hpb=d1296b32da7293d0f780cdb9b4782c84e39fb1da;p=vlc diff --git a/src/audio_output/mixer.c b/src/audio_output/mixer.c index e251cc2932..4f1f9b6489 100644 --- a/src/audio_output/mixer.c +++ b/src/audio_output/mixer.c @@ -1,8 +1,8 @@ /***************************************************************************** * mixer.c : audio output mixing operations ***************************************************************************** - * Copyright (C) 2002 VideoLAN - * $Id: mixer.c,v 1.20 2002/11/13 20:51:04 sam Exp $ + * Copyright (C) 2002-2004 the VideoLAN team + * $Id$ * * Authors: Christophe Massiot * @@ -10,7 +10,7 @@ * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the @@ -18,24 +18,24 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ /***************************************************************************** * Preamble *****************************************************************************/ -#include /* calloc(), malloc(), free() */ -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif -#include +#include +#include #ifdef HAVE_ALLOCA_H -# include +# include #endif - -#include "audio_output.h" +#include #include "aout_internal.h" - /***************************************************************************** * aout_MixerNew: prepare a mixer plug-in ***************************************************************************** @@ -43,10 +43,10 @@ *****************************************************************************/ int aout_MixerNew( aout_instance_t * p_aout ) { - p_aout->mixer.p_module = module_Need( p_aout, "audio mixer", NULL ); + p_aout->mixer.p_module = module_need( p_aout, "audio mixer", NULL, false ); if ( p_aout->mixer.p_module == NULL ) { - msg_Err( p_aout, "no suitable aout mixer" ); + msg_Err( p_aout, "no suitable audio mixer" ); return -1; } p_aout->mixer.b_error = 0; @@ -58,13 +58,11 @@ int aout_MixerNew( aout_instance_t * p_aout ) ***************************************************************************** * Please note that you must hold the mixer lock. *****************************************************************************/ -int aout_MixerDelete( aout_instance_t * p_aout ) +void aout_MixerDelete( aout_instance_t * p_aout ) { - if ( p_aout->mixer.b_error ) return 0; - module_Unneed( p_aout, p_aout->mixer.p_module ); + if ( p_aout->mixer.b_error ) return; + module_unneed( p_aout, p_aout->mixer.p_module ); p_aout->mixer.b_error = 1; - - return 0; } /***************************************************************************** @@ -82,7 +80,7 @@ static int MixBuffer( aout_instance_t * p_aout ) if ( p_aout->mixer.b_error ) { /* Free all incoming buffers. */ - vlc_mutex_lock( &p_aout->input_fifos_lock ); + aout_lock_input_fifos( p_aout ); for ( i = 0; i < p_aout->i_nb_inputs; i++ ) { aout_input_t * p_input = p_aout->pp_inputs[i]; @@ -95,13 +93,13 @@ static int MixBuffer( aout_instance_t * p_aout ) p_buffer = p_next; } } - vlc_mutex_unlock( &p_aout->input_fifos_lock ); + aout_unlock_input_fifos( p_aout ); return -1; } - vlc_mutex_lock( &p_aout->output_fifo_lock ); - vlc_mutex_lock( &p_aout->input_fifos_lock ); + aout_lock_output_fifo( p_aout ); + aout_lock_input_fifos( p_aout ); /* Retrieve the date of the next buffer. */ memcpy( &exact_start_date, &p_aout->output.fifo.end_date, @@ -113,14 +111,14 @@ static int MixBuffer( aout_instance_t * p_aout ) /* The output is _very_ late. This can only happen if the user * pauses the stream (or if the decoder is buggy, which cannot * happen :). */ - msg_Warn( p_aout, "output PTS is out of range ("I64Fd"), clearing out", + msg_Warn( p_aout, "output PTS is out of range (%"PRId64"), clearing out", mdate() - start_date ); aout_FifoSet( p_aout, &p_aout->output.fifo, 0 ); aout_DateSet( &exact_start_date, 0 ); start_date = 0; - } + } - vlc_mutex_unlock( &p_aout->output_fifo_lock ); + aout_unlock_output_fifo( p_aout ); /* See if we have enough data to prepare a new buffer for the audio * output. First : start date. */ @@ -133,15 +131,18 @@ static int MixBuffer( aout_instance_t * p_aout ) aout_fifo_t * p_fifo = &p_input->fifo; aout_buffer_t * p_buffer; - if ( p_input->b_error ) continue; + if ( p_input->b_error || p_input->b_paused ) + continue; p_buffer = p_fifo->p_first; while ( p_buffer != NULL && p_buffer->start_date < mdate() ) { - msg_Warn( p_aout, "input PTS is out of range ("I64Fd"), " + msg_Warn( p_aout, "input PTS is out of range (%"PRId64"), " "trashing", mdate() - p_buffer->start_date ); - aout_BufferFree( aout_FifoPop( p_aout, p_fifo ) ); + p_buffer = aout_FifoPop( p_aout, p_fifo ); + aout_BufferFree( p_buffer ); p_buffer = p_fifo->p_first; + p_input->p_first_byte_to_mix = NULL; } if ( p_buffer == NULL ) @@ -159,7 +160,7 @@ static int MixBuffer( aout_instance_t * p_aout ) if ( i < p_aout->i_nb_inputs ) { /* Interrupted before the end... We can't run. */ - vlc_mutex_unlock( &p_aout->input_fifos_lock ); + aout_unlock_input_fifos( p_aout ); return -1; } } @@ -174,9 +175,9 @@ static int MixBuffer( aout_instance_t * p_aout ) aout_fifo_t * p_fifo = &p_input->fifo; aout_buffer_t * p_buffer; mtime_t prev_date; - vlc_bool_t b_drop_buffers; + bool b_drop_buffers; - if ( p_input->b_error ) + if ( p_input->b_error || p_input->b_paused ) { if ( i_first_input == i ) i_first_input++; continue; @@ -189,11 +190,13 @@ static int MixBuffer( aout_instance_t * p_aout ) } /* Check for the continuity of start_date */ - while ( p_buffer != NULL && p_buffer->end_date < start_date ) + while ( p_buffer != NULL && p_buffer->end_date < start_date - 1 ) { + /* We authorize a +-1 because rounding errors get compensated + * regularly. */ aout_buffer_t * p_next = p_buffer->p_next; - msg_Err( p_aout, "the mixer got a packet in the past ("I64Fd")", - start_date - p_buffer->end_date ); + msg_Warn( p_aout, "the mixer got a packet in the past (%"PRId64")", + start_date - p_buffer->end_date ); aout_BufferFree( p_buffer ); p_fifo->p_first = p_buffer = p_next; p_input->p_first_byte_to_mix = NULL; @@ -204,41 +207,6 @@ static int MixBuffer( aout_instance_t * p_aout ) break; } - if ( !AOUT_FMT_NON_LINEAR( &p_aout->mixer.mixer ) ) - { - /* Additionally check that p_first_byte_to_mix is well - * located. */ - mtime_t i_nb_bytes = (start_date - p_buffer->start_date) - * p_aout->mixer.mixer.i_bytes_per_frame - * p_aout->mixer.mixer.i_rate - / p_aout->mixer.mixer.i_frame_length - / 1000000; - ptrdiff_t mixer_nb_bytes; - - if ( p_input->p_first_byte_to_mix == NULL ) - { - p_input->p_first_byte_to_mix = p_buffer->p_buffer; - } - mixer_nb_bytes = p_input->p_first_byte_to_mix - - p_buffer->p_buffer; - - if ( !((i_nb_bytes + p_aout->mixer.mixer.i_bytes_per_frame - > mixer_nb_bytes) && - (i_nb_bytes < p_aout->mixer.mixer.i_bytes_per_frame - + mixer_nb_bytes)) ) - { - msg_Warn( p_aout, - "mixer start isn't output start (%d)", - i_nb_bytes - mixer_nb_bytes ); - - /* Round to the nearest multiple */ - i_nb_bytes /= p_aout->mixer.mixer.i_bytes_per_frame; - i_nb_bytes *= p_aout->mixer.mixer.i_bytes_per_frame; - p_input->p_first_byte_to_mix = p_buffer->p_buffer - + i_nb_bytes; - } - } - /* Check that we have enough samples. */ for ( ; ; ) { @@ -255,7 +223,7 @@ static int MixBuffer( aout_instance_t * p_aout ) if ( prev_date != p_buffer->start_date ) { msg_Warn( p_aout, - "buffer hole, dropping packets ("I64Fd")", + "buffer hole, dropping packets (%"PRId64")", p_buffer->start_date - prev_date ); b_drop_buffers = 1; break; @@ -277,18 +245,61 @@ static int MixBuffer( aout_instance_t * p_aout ) else break; } if ( p_buffer == NULL ) break; + + p_buffer = p_fifo->p_first; + if ( !AOUT_FMT_NON_LINEAR( &p_aout->mixer.mixer ) ) + { + /* Additionally check that p_first_byte_to_mix is well + * located. */ + mtime_t i_nb_bytes = (start_date - p_buffer->start_date) + * p_aout->mixer.mixer.i_bytes_per_frame + * p_aout->mixer.mixer.i_rate + / p_aout->mixer.mixer.i_frame_length + / 1000000; + ptrdiff_t mixer_nb_bytes; + + if ( p_input->p_first_byte_to_mix == NULL ) + { + p_input->p_first_byte_to_mix = p_buffer->p_buffer; + } + mixer_nb_bytes = p_input->p_first_byte_to_mix - p_buffer->p_buffer; + + if ( !((i_nb_bytes + p_aout->mixer.mixer.i_bytes_per_frame + > mixer_nb_bytes) && + (i_nb_bytes < p_aout->mixer.mixer.i_bytes_per_frame + + mixer_nb_bytes)) ) + { + msg_Warn( p_aout, "mixer start isn't output start (%"PRId64")", + i_nb_bytes - mixer_nb_bytes ); + + /* Round to the nearest multiple */ + i_nb_bytes /= p_aout->mixer.mixer.i_bytes_per_frame; + i_nb_bytes *= p_aout->mixer.mixer.i_bytes_per_frame; + if( i_nb_bytes < 0 ) + { + /* Is it really the best way to do it ? */ + aout_lock_output_fifo( p_aout ); + aout_FifoSet( p_aout, &p_aout->output.fifo, 0 ); + aout_DateSet( &exact_start_date, 0 ); + aout_unlock_output_fifo( p_aout ); + break; + } + + p_input->p_first_byte_to_mix = p_buffer->p_buffer + i_nb_bytes; + } + } } if ( i < p_aout->i_nb_inputs || i_first_input == p_aout->i_nb_inputs ) { /* Interrupted before the end... We can't run. */ - vlc_mutex_unlock( &p_aout->input_fifos_lock ); + aout_unlock_input_fifos( p_aout ); return -1; } /* Run the mixer. */ aout_BufferAlloc( &p_aout->mixer.output_alloc, - ((u64)p_aout->output.i_nb_samples * 1000000) + ((uint64_t)p_aout->output.i_nb_samples * 1000000) / p_aout->output.output.i_rate, /* This is a bit kludgy, but is actually only used * for the S/PDIF dummy mixer : */ @@ -296,8 +307,7 @@ static int MixBuffer( aout_instance_t * p_aout ) p_output_buffer ); if ( p_output_buffer == NULL ) { - msg_Err( p_aout, "out of memory" ); - vlc_mutex_unlock( &p_aout->input_fifos_lock ); + aout_unlock_input_fifos( p_aout ); return -1; } /* This is again a bit kludgy - for the S/PDIF mixer. */ @@ -313,7 +323,7 @@ static int MixBuffer( aout_instance_t * p_aout ) p_aout->mixer.pf_do_work( p_aout, p_output_buffer ); - vlc_mutex_unlock( &p_aout->input_fifos_lock ); + aout_unlock_input_fifos( p_aout ); aout_OutputPlay( p_aout, p_output_buffer ); @@ -339,7 +349,7 @@ void aout_MixerRun( aout_instance_t * p_aout ) int aout_MixerMultiplierSet( aout_instance_t * p_aout, float f_multiplier ) { float f_old = p_aout->mixer.f_multiplier; - vlc_bool_t b_new_mixer = 0; + bool b_new_mixer = 0; if ( !p_aout->mixer.b_error ) {