X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fclipitem.cpp;h=8df2212c3e73b994407be5e0c5aa041d5d3de2bf;hb=f9c0df27ed5dafb1ee72c3e6dea7340de350b542;hp=b934e217f0202108dcb63bbd12468a1fa3ba56d7;hpb=63da743a1c189608dcd4cdc2d174c898e8f961ce;p=kdenlive diff --git a/src/clipitem.cpp b/src/clipitem.cpp index b934e217..8df2212c 100644 --- a/src/clipitem.cpp +++ b/src/clipitem.cpp @@ -160,7 +160,7 @@ void ClipItem::setEffectList(const EffectsList effectList) m_effectNames = m_effectList.effectNames().join(" / "); if (!m_effectList.isEmpty()) { for (int i = 0; i < m_effectList.count(); i++) { - QDomElement effect = m_effectList.itemFromIndex(i + 1); + QDomElement effect = m_effectList.at(i); QString effectId = effect.attribute("id"); // check if it is a fade effect QDomNodeList params = effect.elementsByTagName("parameter"); @@ -188,21 +188,21 @@ void ClipItem::setEffectList(const EffectsList effectList) } } else if (effectId == "fadeout") { if (m_effectList.hasEffect(QString(), "fade_to_black") == -1) { - if (e.attribute("name") == "out") fade -= e.attribute("value").toInt(); - else if (e.attribute("name") == "in") fade += e.attribute("value").toInt(); + if (e.attribute("name") == "out") fade += e.attribute("value").toInt(); + else if (e.attribute("name") == "in") fade -= e.attribute("value").toInt(); } else { QDomElement fadeout = m_effectList.getEffectByTag(QString(), "fade_to_black"); - if (fadeout.attribute("name") == "out") fade -= fadeout.attribute("value").toInt(); - else if (fadeout.attribute("name") == "in") fade += fadeout.attribute("value").toInt(); + if (fadeout.attribute("name") == "out") fade += fadeout.attribute("value").toInt(); + else if (fadeout.attribute("name") == "in") fade -= fadeout.attribute("value").toInt(); } } else if (effectId == "fade_to_black") { if (m_effectList.hasEffect(QString(), "fadeout") == -1) { - if (e.attribute("name") == "out") fade -= e.attribute("value").toInt(); - else if (e.attribute("name") == "in") fade += e.attribute("value").toInt(); + if (e.attribute("name") == "out") fade += e.attribute("value").toInt(); + else if (e.attribute("name") == "in") fade -= e.attribute("value").toInt(); } else { QDomElement fadeout = m_effectList.getEffectByTag(QString(), "fadeout"); - if (fadeout.attribute("name") == "out") fade -= fadeout.attribute("value").toInt(); - else if (fadeout.attribute("name") == "in") fade += fadeout.attribute("value").toInt(); + if (fadeout.attribute("name") == "out") fade += fadeout.attribute("value").toInt(); + else if (fadeout.attribute("name") == "in") fade -= fadeout.attribute("value").toInt(); } } } @@ -226,12 +226,10 @@ int ClipItem::selectedEffectIndex() const return m_selectedEffect; } -void ClipItem::initEffect(QDomElement effect, int diff) +void ClipItem::initEffect(QDomElement effect, int diff, int offset) { // the kdenlive_ix int is used to identify an effect in mlt's playlist, should // not be changed - if (effect.attribute("kdenlive_ix").toInt() == 0) - effect.setAttribute("kdenlive_ix", QString::number(effectsCounter())); if (effect.attribute("id") == "freeze" && diff > 0) { EffectsList::setParameter(effect, "frame", QString::number(diff)); @@ -260,10 +258,24 @@ void ClipItem::initEffect(QDomElement effect, int diff) e.setAttribute("value", "1"); } - if ((e.attribute("type") == "keyframe" || e.attribute("type") == "simplekeyframe") && e.attribute("keyframes").isEmpty()) { - // Effect has a keyframe type parameter, we need to set the values - e.setAttribute("keyframes", QString::number(cropStart().frames(m_fps)) + ':' + e.attribute("default")); + if (e.attribute("type") == "keyframe" || e.attribute("type") == "simplekeyframe") { + if (e.attribute("keyframes").isEmpty()) { + // Effect has a keyframe type parameter, we need to set the values + e.setAttribute("keyframes", QString::number(cropStart().frames(m_fps)) + ':' + e.attribute("default")); + } + else if (offset != 0) { + // adjust keyframes to this clip + QString adjusted = adjustKeyframes(e.attribute("keyframes"), offset - cropStart().frames(m_fps)); + e.setAttribute("keyframes", adjusted); + } } + + if (e.attribute("type") == "geometry" && !e.hasAttribute("fixed")) { + // Effects with a geometry parameter need to sync in / out with parent clip + effect.setAttribute("in", QString::number(cropStart().frames(m_fps))); + effect.setAttribute("out", QString::number((cropStart() + cropDuration()).frames(m_fps) - 1)); + effect.setAttribute("_sync_in_out", "1"); + } } if (effect.attribute("tag") == "volume" || effect.attribute("tag") == "brightness") { if (effect.attribute("id") == "fadeout" || effect.attribute("id") == "fade_to_black") { @@ -271,7 +283,7 @@ void ClipItem::initEffect(QDomElement effect, int diff) int start = end; if (effect.attribute("id") == "fadeout") { if (m_effectList.hasEffect(QString(), "fade_to_black") == -1) { - int effectDuration = EffectsList::parameter(effect, "in").toInt(); + int effectDuration = EffectsList::parameter(effect, "out").toInt() - EffectsList::parameter(effect, "in").toInt(); if (effectDuration > cropDuration().frames(m_fps)) { effectDuration = cropDuration().frames(m_fps) / 2; } @@ -282,7 +294,7 @@ void ClipItem::initEffect(QDomElement effect, int diff) } } else if (effect.attribute("id") == "fade_to_black") { if (m_effectList.hasEffect(QString(), "fadeout") == -1) { - int effectDuration = EffectsList::parameter(effect, "in").toInt(); + int effectDuration = EffectsList::parameter(effect, "out").toInt() - EffectsList::parameter(effect, "in").toInt(); if (effectDuration > cropDuration().frames(m_fps)) { effectDuration = cropDuration().frames(m_fps) / 2; } @@ -300,21 +312,23 @@ void ClipItem::initEffect(QDomElement effect, int diff) if (effect.attribute("id") == "fadein") { if (m_effectList.hasEffect(QString(), "fade_from_black") == -1) { int effectDuration = EffectsList::parameter(effect, "out").toInt(); + if (offset != 0) effectDuration -= offset; if (effectDuration > cropDuration().frames(m_fps)) { effectDuration = cropDuration().frames(m_fps) / 2; } end += effectDuration; } else - end += EffectsList::parameter(m_effectList.getEffectByTag(QString(), "fade_from_black"), "out").toInt(); + end += EffectsList::parameter(m_effectList.getEffectByTag(QString(), "fade_from_black"), "out").toInt() - offset; } else if (effect.attribute("id") == "fade_from_black") { if (m_effectList.hasEffect(QString(), "fadein") == -1) { int effectDuration = EffectsList::parameter(effect, "out").toInt(); + if (offset != 0) effectDuration -= offset; if (effectDuration > cropDuration().frames(m_fps)) { effectDuration = cropDuration().frames(m_fps) / 2; } end += effectDuration; } else - end += EffectsList::parameter(m_effectList.getEffectByTag(QString(), "fadein"), "out").toInt(); + end += EffectsList::parameter(m_effectList.getEffectByTag(QString(), "fadein"), "out").toInt() - offset; } EffectsList::setParameter(effect, "in", QString::number(start)); EffectsList::setParameter(effect, "out", QString::number(end)); @@ -322,6 +336,19 @@ void ClipItem::initEffect(QDomElement effect, int diff) } } +const QString ClipItem::adjustKeyframes(QString keyframes, int offset) +{ + QStringList result; + // Simple keyframes + const QStringList list = keyframes.split(';', QString::SkipEmptyParts); + foreach(const QString &keyframe, list) { + int pos = keyframe.section(':', 0, 0).toInt() - offset; + QString newKey = QString::number(pos) + ":" + keyframe.section(':', 1); + result.append(newKey); + } + return result.join(";"); +} + bool ClipItem::checkKeyFrames() { bool clipEffectsModified = false; @@ -396,7 +423,7 @@ bool ClipItem::checkKeyFrames() void ClipItem::setKeyframes(const int ix, const QStringList keyframes) { - QDomElement effect = getEffectAt(ix); + QDomElement effect = m_effectList.at(ix); if (effect.attribute("disable") == "1") return; QLocale locale; QDomNodeList params = effect.elementsByTagName("parameter"); @@ -435,7 +462,7 @@ void ClipItem::setSelectedEffect(const int ix) { m_selectedEffect = ix; QLocale locale; - QDomElement effect = effectAt(m_selectedEffect); + QDomElement effect = effectAtIndex(m_selectedEffect); if (!effect.isNull() && effect.attribute("disable") != "1") { QDomNodeList params = effect.elementsByTagName("parameter"); for (int i = 0; i < params.count(); i++) { @@ -475,7 +502,7 @@ void ClipItem::setSelectedEffect(const int ix) QStringList ClipItem::keyframes(const int index) { QStringList result; - QDomElement effect = effectAt(index); + QDomElement effect = m_effectList.at(index); QDomNodeList params = effect.elementsByTagName("parameter"); for (int i = 0; i < params.count(); i++) { @@ -489,7 +516,7 @@ QStringList ClipItem::keyframes(const int index) void ClipItem::updateKeyframeEffect() { // regenerate xml parameter from the clip keyframes - QDomElement effect = getEffectAt(m_selectedEffect); + QDomElement effect = getEffectAtIndex(m_selectedEffect); if (effect.attribute("disable") == "1") return; QDomNodeList params = effect.elementsByTagName("parameter"); QDomElement e = params.item(m_visibleParam).toElement(); @@ -511,7 +538,7 @@ void ClipItem::updateKeyframeEffect() QDomElement ClipItem::selectedEffect() { if (m_selectedEffect == -1 || m_effectList.isEmpty()) return QDomElement(); - return effectAt(m_selectedEffect); + return effectAtIndex(m_selectedEffect); } void ClipItem::resetThumbs(bool clearExistingThumbs) @@ -796,7 +823,7 @@ void ClipItem::paint(QPainter *painter, else { #if KDE_IS_VERSION(4,5,0) if (m_clip && m_clip->thumbProducer()) { - QString path = m_clip->fileURL().path() + "_"; + QString path = m_clip->fileURL().path() + '_'; QImage img; QPen pen(Qt::white); pen.setStyle(Qt::DotLine); @@ -999,16 +1026,16 @@ OPERATIONTYPE ClipItem::operationMode(QPointF pos) } QRectF rect = sceneBoundingRect(); int addtransitionOffset = 10; - // Don't allow add transition if track height is very small - if (rect.height() < 30) addtransitionOffset = 0; + // Don't allow add transition if track height is very small. No transitions for audio only clips + if (rect.height() < 30 || isAudioOnly() || m_clipType == AUDIO) addtransitionOffset = 0; if (qAbs((int)(pos.x() - (rect.x() + m_startFade))) < maximumOffset && qAbs((int)(pos.y() - rect.y())) < 6) { return FADEIN; - } else if (pos.x() - rect.x() < maximumOffset && (rect.bottom() - pos.y() > addtransitionOffset)) { + } else if ((pos.x() <= rect.x() + rect.width() / 2) && pos.x() - rect.x() < maximumOffset && (rect.bottom() - pos.y() > addtransitionOffset)) { return RESIZESTART; } else if (qAbs((int)(pos.x() - (rect.x() + rect.width() - m_endFade))) < maximumOffset && qAbs((int)(pos.y() - rect.y())) < 6) { return FADEOUT; - } else if ((rect.right() - pos.x() < maximumOffset) && (rect.bottom() - pos.y() > addtransitionOffset)) { + } else if ((pos.x() >= rect.x() + rect.width() / 2) && (rect.right() - pos.x() < maximumOffset) && (rect.bottom() - pos.y() > addtransitionOffset)) { return RESIZEEND; } else if ((pos.x() - rect.x() < 16 / scale) && (rect.bottom() - pos.y() <= addtransitionOffset)) { return TRANSITIONSTART; @@ -1033,7 +1060,8 @@ void ClipItem::resetFrameWidth(int width) QList ClipItem::snapMarkers() const { QList < GenTime > snaps; - QList < GenTime > markers = baseClip()->snapMarkers(); + if (!m_clip) return snaps; + QList < GenTime > markers = m_clip->snapMarkers(); GenTime pos; for (int i = 0; i < markers.size(); i++) { @@ -1049,7 +1077,8 @@ QList ClipItem::snapMarkers() const QList ClipItem::commentedSnapMarkers() const { QList < CommentedTime > snaps; - QList < CommentedTime > markers = baseClip()->commentedSnapMarkers(); + if (!m_clip) return snaps; + QList < CommentedTime > markers = m_clip->commentedSnapMarkers(); GenTime pos; for (int i = 0; i < markers.size(); i++) { @@ -1274,7 +1303,9 @@ QVariant ClipItem::itemChange(GraphicsItemChange change, const QVariant &value) int xpos = projectScene()->getSnapPointForPos((int) newPos.x(), KdenliveSettings::snaptopoints()); xpos = qMax(xpos, 0); newPos.setX(xpos); - int newTrack = newPos.y() / KdenliveSettings::trackheight(); + // Warning: newPos gives a position relative to the click event, so hack to get absolute pos + int yOffset = property("y_absolute").toInt() + newPos.y(); + int newTrack = yOffset / KdenliveSettings::trackheight(); newTrack = qMin(newTrack, projectScene()->tracksCount() - 1); newTrack = qMax(newTrack, 0); newPos.setY((int)(newTrack * KdenliveSettings::trackheight() + 1)); @@ -1361,19 +1392,25 @@ QStringList ClipItem::effectNames() return m_effectList.effectNames(); } -QDomElement ClipItem::effectAt(int ix) const +QDomElement ClipItem::effect(int ix) const +{ + if (ix >= m_effectList.count() || ix < 0) return QDomElement(); + return m_effectList.at(ix).cloneNode().toElement(); +} + +QDomElement ClipItem::effectAtIndex(int ix) const { if (ix > m_effectList.count() || ix <= 0) return QDomElement(); return m_effectList.itemFromIndex(ix).cloneNode().toElement(); } -QDomElement ClipItem::getEffectAt(int ix) const +QDomElement ClipItem::getEffectAtIndex(int ix) const { - if (ix > m_effectList.count() || ix < 0) return QDomElement(); + if (ix > m_effectList.count() || ix <= 0) return QDomElement(); return m_effectList.itemFromIndex(ix); } -bool ClipItem::updateEffect(QDomElement effect) +void ClipItem::updateEffect(QDomElement effect) { //kDebug() << "CHange EFFECT AT: " << ix << ", CURR: " << m_effectList.at(ix).attribute("tag") << ", NEW: " << effect.attribute("tag"); m_effectList.updateEffect(effect); @@ -1386,12 +1423,16 @@ bool ClipItem::updateEffect(QDomElement effect) r.setHeight(20); update(r); } - return true; +} + +void ClipItem::enableEffects(QList indexes, bool disable) +{ + m_effectList.enableEffects(indexes, disable); } bool ClipItem::moveEffect(QDomElement effect, int ix) { - if (ix < 0 || ix > (m_effectList.count() - 1) || effect.isNull()) { + if (ix <= 0 || ix > (m_effectList.count()) || effect.isNull()) { kDebug() << "Invalid effect index: " << ix; return false; } @@ -1410,33 +1451,90 @@ bool ClipItem::moveEffect(QDomElement effect, int ix) return true; } -EffectsParameterList ClipItem::addEffect(const QDomElement effect, bool /*animate*/) +EffectsParameterList ClipItem::addEffect(QDomElement effect, bool /*animate*/) { bool needRepaint = false; QLocale locale; int ix; + QDomElement insertedEffect; if (!effect.hasAttribute("kdenlive_ix")) { + // effect dropped from effect list ix = effectsCounter(); } else ix = effect.attribute("kdenlive_ix").toInt(); if (!m_effectList.isEmpty() && ix <= m_effectList.count()) { needRepaint = true; - m_effectList.insert(effect); - } else m_effectList.append(effect); + insertedEffect = m_effectList.insert(effect); + } else insertedEffect = m_effectList.append(effect); + + // Update index to the real one + effect.setAttribute("kdenlive_ix", insertedEffect.attribute("kdenlive_ix")); + int effectIn; + int effectOut; + + if (effect.attribute("tag") == "affine") { + // special case: the affine effect needs in / out points + effectIn = effect.attribute("in").toInt(); + effectOut = effect.attribute("out").toInt(); + } + else { + effectIn = EffectsList::parameter(effect, "in").toInt(); + effectOut = EffectsList::parameter(effect, "out").toInt(); + } + EffectsParameterList parameters; - parameters.addParam("tag", effect.attribute("tag")); - parameters.addParam("kdenlive_ix", effect.attribute("kdenlive_ix")); - if (effect.hasAttribute("src")) parameters.addParam("src", effect.attribute("src")); - if (effect.hasAttribute("disable")) parameters.addParam("disable", effect.attribute("disable")); + parameters.addParam("tag", insertedEffect.attribute("tag")); + parameters.addParam("kdenlive_ix", insertedEffect.attribute("kdenlive_ix")); + if (insertedEffect.hasAttribute("src")) parameters.addParam("src", insertedEffect.attribute("src")); + if (insertedEffect.hasAttribute("disable")) parameters.addParam("disable", insertedEffect.attribute("disable")); - QString effectId = effect.attribute("id"); - if (effectId.isEmpty()) effectId = effect.attribute("tag"); + QString effectId = insertedEffect.attribute("id"); + if (effectId.isEmpty()) effectId = insertedEffect.attribute("tag"); parameters.addParam("id", effectId); - // special case: the affine effect needs in / out points - - QDomNodeList params = effect.elementsByTagName("parameter"); + QDomNodeList params = insertedEffect.elementsByTagName("parameter"); int fade = 0; bool needInOutSync = false; + + // check if it is a fade effect + if (effectId == "fadein") { + needRepaint = true; + if (m_effectList.hasEffect(QString(), "fade_from_black") == -1) { + fade = effectOut - effectIn; + }/* else { + QDomElement fadein = m_effectList.getEffectByTag(QString(), "fade_from_black"); + if (fadein.attribute("name") == "out") fade += fadein.attribute("value").toInt(); + else if (fadein.attribute("name") == "in") fade -= fadein.attribute("value").toInt(); + }*/ + } else if (effectId == "fade_from_black") { + kDebug()<<"// FOUND FTB:"< m_effectList.count() - 1) { - setSelectedEffect(m_effectList.count() - 1); + if (ix > m_effectList.count()) { + setSelectedEffect(m_effectList.count()); } else setSelectedEffect(ix); } if (needRepaint) update(boundingRect()); @@ -1598,8 +1654,8 @@ void ClipItem::setSpeed(const double speed, const int strobe) if (m_speed <= 0 && m_speed > -1) m_speed = -1.0; m_strobe = strobe; - if (m_speed == 1.0) m_clipName = baseClip()->name(); - else m_clipName = baseClip()->name() + " - " + QString::number(speed * 100, 'f', 0) + '%'; + if (m_speed == 1.0) m_clipName = m_clip->name(); + else m_clipName = m_clip->name() + " - " + QString::number(speed * 100, 'f', 0) + '%'; m_info.cropStart = GenTime((int)(m_speedIndependantInfo.cropStart.frames(m_fps) / qAbs(m_speed) + 0.5), m_fps); m_info.cropDuration = GenTime((int)(m_speedIndependantInfo.cropDuration.frames(m_fps) / qAbs(m_speed) + 0.5), m_fps); //update(); @@ -1626,6 +1682,20 @@ const ItemInfo ClipItem::speedIndependantInfo() const return m_speedIndependantInfo; } +int ClipItem::nextFreeEffectGroupIndex() const +{ + int freeGroupIndex = 0; + for (int i = 0; i < m_effectList.count(); i++) { + QDomElement effect = m_effectList.at(i); + EffectInfo effectInfo; + effectInfo.fromString(effect.attribute("kdenlive_info")); + if (effectInfo.groupIndex >= freeGroupIndex) { + freeGroupIndex = effectInfo.groupIndex + 1; + } + } + return freeGroupIndex; +} + //virtual void ClipItem::dropEvent(QGraphicsSceneDragDropEvent * event) { @@ -1635,7 +1705,22 @@ void ClipItem::dropEvent(QGraphicsSceneDragDropEvent * event) QDomDocument doc; doc.setContent(effects, true); QDomElement e = doc.documentElement(); - e.setAttribute("kdenlive_ix", 0); + if (e.tagName() == "effectgroup") { + // dropped an effect group + QDomNodeList effectlist = e.elementsByTagName("effect"); + int freeGroupIndex = nextFreeEffectGroupIndex(); + EffectInfo effectInfo; + for (int i = 0; i < effectlist.count(); i++) { + QDomElement effect = effectlist.at(i).toElement(); + effectInfo.fromString(effect.attribute("kdenlive_info")); + effectInfo.groupIndex = freeGroupIndex; + effect.setAttribute("kdenlive_info", effectInfo.toString()); + effect.removeAttribute("kdenlive_ix"); + } + } else { + // single effect dropped + e.removeAttribute("kdenlive_ix"); + } CustomTrackView *view = (CustomTrackView *) scene()->views()[0]; if (view) view->slotAddEffect(e, m_info.startPos, track()); } @@ -1716,18 +1801,18 @@ void ClipItem::insertKeyframe(QDomElement effect, int pos, int val) newkfr.append(str); } else if (!added) { if (i == m_visibleParam) - newkfr.append(QString::number(pos) + ":" + QString::number(val)); + newkfr.append(QString::number(pos) + ':' + QString::number(val)); else - newkfr.append(QString::number(pos) + ":" + locale.toString(newval)); + newkfr.append(QString::number(pos) + ':' + locale.toString(newval)); if (kpos > pos) newkfr.append(str); added = true; } else newkfr.append(str); } if (!added) { if (i == m_visibleParam) - newkfr.append(QString::number(pos) + ":" + QString::number(val)); + newkfr.append(QString::number(pos) + ':' + QString::number(val)); else - newkfr.append(QString::number(pos) + ":" + e.attribute("default")); + newkfr.append(QString::number(pos) + ':' + e.attribute("default")); } e.setAttribute("keyframes", newkfr.join(";")); } @@ -1755,9 +1840,9 @@ void ClipItem::movedKeyframe(QDomElement effect, int oldpos, int newpos, double newpos = qMax(newpos, start); newpos = qMin(newpos, end); if (i == m_visibleParam) - newkfr.append(QString::number(newpos) + ":" + locale.toString(value)); + newkfr.append(QString::number(newpos) + ':' + locale.toString(value)); else - newkfr.append(QString::number(newpos) + ":" + str.section(':', 1, 1)); + newkfr.append(QString::number(newpos) + ':' + str.section(':', 1, 1)); } } e.setAttribute("keyframes", newkfr.join(";")); @@ -1794,7 +1879,7 @@ Mlt::Producer *ClipItem::getProducer(int track, bool trackSpecific) if (isAudioOnly()) return m_clip->audioProducer(track); else if (isVideoOnly()) - return m_clip->videoProducer(); + return m_clip->videoProducer(track); else return m_clip->getProducer(trackSpecific ? track : -1); } @@ -1813,9 +1898,9 @@ QMap ClipItem::adjustEffectsToDuration(int width, int height, if (id == "fade_from_black" || id == "fadein") { if (in != cropStart().frames(m_fps)) { effects[i] = effect.cloneNode().toElement(); - int diff = in - cropStart().frames(m_fps); - in -= diff; - out -= diff; + int duration = out - in; + in = cropStart().frames(m_fps); + out = in + duration; EffectsList::setParameter(effect, "in", QString::number(in)); EffectsList::setParameter(effect, "out", QString::number(out)); } @@ -1850,7 +1935,10 @@ QMap ClipItem::adjustEffectsToDuration(int width, int height, int frame = EffectsList::parameter(effect, "frame").toInt(); EffectsList::setParameter(effect, "frame", QString::number(frame - diff)); continue; - } + } else if (effect.attribute("id") == "pan_zoom") { + effect.setAttribute("in", cropStart().frames(m_fps)); + effect.setAttribute("out", (cropStart() + cropDuration()).frames(m_fps) - 1); + } QDomNodeList params = effect.elementsByTagName("parameter"); for (int j = 0; j < params.count(); j++) { @@ -1864,7 +1952,7 @@ QMap ClipItem::adjustEffectsToDuration(int width, int height, } else if (type == "simplekeyframe" || type == "keyframe") { if (!effects.contains(i)) effects[i] = effect.cloneNode().toElement(); - updateNormalKeyframes(param); + updateNormalKeyframes(param, oldInfo); #ifdef USE_QJSON } else if (type == "roto-spline") { if (!effects.contains(i)) @@ -1879,16 +1967,25 @@ QMap ClipItem::adjustEffectsToDuration(int width, int height, return effects; } -bool ClipItem::updateNormalKeyframes(QDomElement parameter) +bool ClipItem::updateNormalKeyframes(QDomElement parameter, ItemInfo oldInfo) { int in = cropStart().frames(m_fps); int out = (cropStart() + cropDuration()).frames(m_fps) - 1; + int oldin = oldInfo.cropStart.frames(m_fps); QLocale locale; + bool keyFrameUpdated = false; const QStringList data = parameter.attribute("keyframes").split(';', QString::SkipEmptyParts); QMap keyframes; - foreach (QString keyframe, data) - keyframes[keyframe.section(':', 0, 0).toInt()] = locale.toDouble(keyframe.section(':', 1, 1)); + foreach (QString keyframe, data) { + int keyframepos = keyframe.section(':', 0, 0).toInt(); + // if keyframe was at clip start, update it + if (keyframepos == oldin) { + keyframepos = in; + keyFrameUpdated = true; + } + keyframes[keyframepos] = locale.toDouble(keyframe.section(':', 1, 1)); + } QMap::iterator i = keyframes.end(); @@ -1940,7 +2037,7 @@ bool ClipItem::updateNormalKeyframes(QDomElement parameter) ++i; } - if (startFound || endFound) { + if (startFound || endFound || keyFrameUpdated) { QString newkfr; QMap::const_iterator k = keyframes.constBegin(); while (k != keyframes.constEnd()) { @@ -1956,20 +2053,19 @@ bool ClipItem::updateNormalKeyframes(QDomElement parameter) void ClipItem::updateGeometryKeyframes(QDomElement effect, int paramIndex, int width, int height, ItemInfo oldInfo) { - QDomElement param = effect.elementsByTagName("parameter").item(paramIndex).toElement(); int offset = oldInfo.cropStart.frames(m_fps); QString data = param.attribute("value"); if (offset > 0) { QStringList kfrs = data.split(';'); data.clear(); - foreach (QString keyframe, kfrs) { + foreach (const QString &keyframe, kfrs) { if (keyframe.contains('=')) { int pos = keyframe.section('=', 0, 0).toInt(); pos += offset; - data.append(QString::number(pos) + "=" + keyframe.section('=', 1) + ";"); + data.append(QString::number(pos) + '=' + keyframe.section('=', 1) + ";"); } - else data.append(keyframe + ";"); + else data.append(keyframe + ';'); } } Mlt::Geometry geometry(data.toUtf8().data(), oldInfo.cropDuration.frames(m_fps), width, height);