X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fcommands%2Fmoveeffectcommand.cpp;h=a96fcc4016e1f42d40796c505b5b59f36863309f;hb=f69a24d18f8134c93e407ea485967ac31187da47;hp=c077128803d5e048199b9069d956e23eca13dc19;hpb=9b507272f9fcd3f0cdc96badcef9ba66da2a34e4;p=kdenlive

diff --git a/src/commands/moveeffectcommand.cpp b/src/commands/moveeffectcommand.cpp
index c0771288..a96fcc40 100644
--- a/src/commands/moveeffectcommand.cpp
+++ b/src/commands/moveeffectcommand.cpp
@@ -21,17 +21,18 @@
 #include "moveeffectcommand.h"
 #include "customtrackview.h"
 
-#include <KLocale>
+#include <KLocalizedString>
+#include <KDebug>
 
-MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QList<int> &oldPos, int newPos, QUndoCommand * parent) :
-        QUndoCommand(parent),
-        m_view(view),
-        m_track(track),
-        m_oldindex(oldPos),
-        m_pos(pos)
+MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, const GenTime &pos, const QList<int> &oldPos, int newPos, QUndoCommand * parent) :
+    QUndoCommand(parent),
+    m_view(view),
+    m_track(track),
+    m_oldindex(oldPos),
+    m_pos(pos)
 {
-    for (int i = 0; i < m_oldindex.count(); i++) {
-	m_newindex << newPos + i;
+    for (int i = 0; i < m_oldindex.count(); ++i) {
+        m_newindex << newPos + i;
     }
     /*    QString effectName;
         QDomElement namenode = effect.firstChildElement("name");
@@ -50,13 +51,16 @@ int MoveEffectCommand::id() const
 // virtual
 bool MoveEffectCommand::mergeWith(const QUndoCommand * other)
 {
+    Q_UNUSED(other)
     return false;
+    /* dead code (flaged by coverity), was removed to avoid crash when dropping on group
     if (other->id() != id()) return false;
     if (m_track != static_cast<const MoveEffectCommand*>(other)->m_track) return false;
     if (m_pos != static_cast<const MoveEffectCommand*>(other)->m_pos) return false;
     m_oldindex = static_cast<const MoveEffectCommand*>(other)->m_oldindex;
     m_newindex = static_cast<const MoveEffectCommand*>(other)->m_newindex;
     return true;
+    */
 }
 
 // virtual