X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fguide.cpp;h=ba05ec6aef126841aa744ae0cbe494b013b5c1d9;hb=c3302003093710ee247ad84c0fe2ef3c579d417f;hp=8c27f4dbff52eea8b9132f99a6b8f930ed8421eb;hpb=5a546f9e78723ea8d25a7794c398ac620cc5e91f;p=kdenlive diff --git a/src/guide.cpp b/src/guide.cpp index 8c27f4db..ba05ec6a 100644 --- a/src/guide.cpp +++ b/src/guide.cpp @@ -29,7 +29,7 @@ #include #include -Guide::Guide(CustomTrackView *view, GenTime pos, QString label, double height) : +Guide::Guide(CustomTrackView *view, const GenTime &pos, const QString &label, double height) : QGraphicsLineItem(), m_position(pos), m_label(label), @@ -70,7 +70,7 @@ CommentedTime Guide::info() const return CommentedTime(m_position, m_label); } -void Guide::updateGuide(const GenTime newPos, const QString &comment) +void Guide::updateGuide(const GenTime &newPos, const QString &comment) { m_position = newPos; setPos(m_position.frames(m_view->fps()), 0); @@ -129,7 +129,8 @@ QRectF Guide::boundingRect() const double width = m_pen.widthF() / scale * 2; QRectF rect(line().x1() - width / 2 , line().y1(), width, line().y2() - line().y1()); if (KdenliveSettings::showmarkers()) { - rect.setWidth(width + m_width); + // +3 to cover the arc at the end of the comment + rect.setWidth(width + m_width + 3); } return rect; } @@ -144,7 +145,7 @@ QPainterPath Guide::shape() const if (KdenliveSettings::showmarkers() && scene()->views().count()) { const QFontMetrics metric = m_view->fontMetrics(); int offset = scene()->views()[0]->verticalScrollBar()->value(); - QRectF txtBounding(line().x1(), line().y1() + 10 + offset, m_width, metric.height()); + QRectF txtBounding(line().x1(), line().y1() + offset, m_width, metric.height()); path.addRect(txtBounding); } return path; @@ -155,18 +156,17 @@ void Guide::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWi { QGraphicsLineItem::paint(painter, option); if (KdenliveSettings::showmarkers() && scene() && scene()->views().count()) { - QPointF p1 = line().p1() + QPointF(1, 0); + QPointF p1 = line().p1(); const QFontMetrics metric = m_view->fontMetrics(); - + painter->setClipRect(option->rect); // makes sure the text stays visible when scrolling vertical int offset = scene()->views()[0]->verticalScrollBar()->value(); - QRectF txtBounding = painter->boundingRect(p1.x(), p1.y() + 10 + offset, m_width, metric.height(), Qt::AlignLeft | Qt::AlignTop, ' ' + m_label + ' '); - QPainterPath path; - path.addRoundedRect(txtBounding, 3, 3); - painter->fillPath(path, m_pen.color()); + QRectF txtBounding = painter->boundingRect(p1.x(), p1.y() + offset, m_width, metric.height(), Qt::AlignLeft | Qt::AlignTop, m_label); + painter->setBrush(QBrush(m_pen.color())); + painter->drawRoundedRect(txtBounding.adjusted(-5, -5, 2, 1), 3, 3); painter->setPen(Qt::white); - painter->drawText(txtBounding, Qt::AlignCenter, m_label); + painter->drawText(txtBounding.adjusted(1, 0, 1, 0), Qt::AlignCenter, m_label); } }